86299 2012-05-12 08:31:43 -0700 Dangling node to ID maps vector uses raw pointers, but should use OwnPtr 2012-05-13 16:24:25 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin webkit.review.bot oldest_to_newest 622351 0 darin 2012-05-12 08:31:43 -0700 Dangling node to ID maps vector uses raw pointers, but should use OwnPtr 622352 1 141578 darin 2012-05-12 08:33:01 -0700 Created attachment 141578 Patch 622562 2 141578 webkit.review.bot 2012-05-13 16:24:21 -0700 Comment on attachment 141578 Patch Clearing flags on attachment: 141578 Committed r116904: <http://trac.webkit.org/changeset/116904> 622563 3 webkit.review.bot 2012-05-13 16:24:25 -0700 All reviewed patches have been landed. Closing bug. 141578 2012-05-12 08:33:01 -0700 2012-05-13 16:24:21 -0700 Patch bug-86299-20120512083259.patch text/plain 2899 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTEyICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBEYW5nbGluZyBub2RlIHRvIElEIG1h cHMgdmVjdG9yIHVzZXMgcmF3IHBvaW50ZXJzLCBidXQgc2hvdWxkIHVzZSBPd25QdHIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2Mjk5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5z cGVjdG9yRE9NQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6 OnJlbGVhc2VEYW5nbGluZ05vZGVzKTogUmVtb3ZlZCBub3ctdW5uZWVkZWQgY2FsbAorICAgICAg ICB0byBkZWxldGVBbGxWYWx1ZXMgc2luY2UgdGhlIGNsZWFyIGZ1bmN0aW9uIG5vdyB0YWtlcyBj YXJlIG9mIHRoYXQuCisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6cHVzaE5v ZGVQYXRoVG9Gcm9udGVuZCk6IEFkZGVkIGNvZGUgdGhhdCB1c2VzCisgICAgICAgIGFkb3B0UHRy IGFuZCByZWxlYXNlIGFzIG5lZWVkIHRvIGRlYWwgd2l0aCBhIFZlY3RvcjxPd25QdHI+LgorICAg ICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oOiBDaGFuZ2VkIG1fZGFuZ2xpbmdO b2RlVG9JZE1hcHMgdG8gYmUKKyAgICAgICAgVmVjdG9yPE93blB0cj4gaW5zdGVhZCBvZiBhIHZl Y3RvciBvZiByYXcgcG9pbnRlcnMuCisKIDIwMTItMDUtMTIgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IG1vdmUgcmVjb3Jk aW5nIGJ1dHRvbiBzdGF0ZSBjb250cm9sIG91dCBvZiBhZGRQcm9maWxlSGVhZGVyLgpJbmRleDog U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCShyZXZp c2lvbiAxMTYyMDYpCisrKyBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDcsNyArMzA3LDYgQEAgdm9pZCBJbnNwZWN0b3JE T01BZ2VudDo6c2V0RG9jdW1lbnQoRG9jdQogCiB2b2lkIEluc3BlY3RvckRPTUFnZW50OjpyZWxl YXNlRGFuZ2xpbmdOb2RlcygpCiB7Ci0gICAgZGVsZXRlQWxsVmFsdWVzKG1fZGFuZ2xpbmdOb2Rl VG9JZE1hcHMpOwogICAgIG1fZGFuZ2xpbmdOb2RlVG9JZE1hcHMuY2xlYXIoKTsKIH0KIApAQCAt NTMwLDggKzUyOSw5IEBAIGludCBJbnNwZWN0b3JET01BZ2VudDo6cHVzaE5vZGVQYXRoVG9Gcm8K ICAgICAgICAgTm9kZSogcGFyZW50ID0gaW5uZXJQYXJlbnROb2RlKG5vZGUpOwogICAgICAgICBp ZiAoIXBhcmVudCkgewogICAgICAgICAgICAgLy8gTm9kZSBiZWluZyBwdXNoZWQgaXMgZGV0YWNo ZWQgLT4gcHVzaCBzdWJ0cmVlIHJvb3QuCi0gICAgICAgICAgICBkYW5nbGluZ01hcCA9IG5ldyBO b2RlVG9JZE1hcCgpOwotICAgICAgICAgICAgbV9kYW5nbGluZ05vZGVUb0lkTWFwcy5hcHBlbmQo ZGFuZ2xpbmdNYXApOworICAgICAgICAgICAgT3duUHRyPE5vZGVUb0lkTWFwPiBuZXdNYXAgPSBh ZG9wdFB0cihuZXcgTm9kZVRvSWRNYXApOworICAgICAgICAgICAgZGFuZ2xpbmdNYXAgPSBuZXdN YXAuZ2V0KCk7CisgICAgICAgICAgICBtX2RhbmdsaW5nTm9kZVRvSWRNYXBzLmFwcGVuZChuZXdN YXAucmVsZWFzZSgpKTsKICAgICAgICAgICAgIFJlZlB0cjxUeXBlQnVpbGRlcjo6QXJyYXk8VHlw ZUJ1aWxkZXI6OkRPTTo6Tm9kZT4gPiBjaGlsZHJlbiA9IFR5cGVCdWlsZGVyOjpBcnJheTxUeXBl QnVpbGRlcjo6RE9NOjpOb2RlPjo6Y3JlYXRlKCk7CiAgICAgICAgICAgICBjaGlsZHJlbi0+YWRk SXRlbShidWlsZE9iamVjdEZvck5vZGUobm9kZSwgMCwgZGFuZ2xpbmdNYXApKTsKICAgICAgICAg ICAgIG1fZnJvbnRlbmQtPnNldENoaWxkTm9kZXMoMCwgY2hpbGRyZW4pOwpJbmRleDogU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmgJKHJldmlzaW9uIDExNjIw NikKKysrIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNDQsNyArMjQ0LDcgQEAgcHJpdmF0ZToKICAgICBET01MaXN0ZW5lciog bV9kb21MaXN0ZW5lcjsKICAgICBOb2RlVG9JZE1hcCBtX2RvY3VtZW50Tm9kZVRvSWRNYXA7CiAg ICAgLy8gT3ducyBub2RlIG1hcHBpbmdzIGZvciBkYW5nbGluZyBub2Rlcy4KLSAgICBWZWN0b3I8 Tm9kZVRvSWRNYXAqPiBtX2RhbmdsaW5nTm9kZVRvSWRNYXBzOworICAgIFZlY3RvcjxPd25QdHI8 Tm9kZVRvSWRNYXA+ID4gbV9kYW5nbGluZ05vZGVUb0lkTWFwczsKICAgICBIYXNoTWFwPGludCwg Tm9kZSo+IG1faWRUb05vZGU7CiAgICAgSGFzaE1hcDxpbnQsIE5vZGVUb0lkTWFwKj4gbV9pZFRv Tm9kZXNNYXA7CiAgICAgSGFzaFNldDxpbnQ+IG1fY2hpbGRyZW5SZXF1ZXN0ZWQ7Cg==