86298 2012-05-12 08:27:28 -0700 Listeners map uses raw pointers, but should use OwnPtr 2012-05-13 22:25:39 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin ggaren mitz sam webkit.review.bot oldest_to_newest 622349 0 darin 2012-05-12 08:27:28 -0700 Listeners map uses raw pointers, but should use OwnPtr 622350 1 141577 darin 2012-05-12 08:30:36 -0700 Created attachment 141577 Patch 622631 2 darin 2012-05-13 21:28:06 -0700 My other recent patches got reviewed, but this one hasn’t gotten review yet. 622653 3 141577 webkit.review.bot 2012-05-13 22:25:34 -0700 Comment on attachment 141577 Patch Clearing flags on attachment: 141577 Committed r116917: <http://trac.webkit.org/changeset/116917> 622654 4 webkit.review.bot 2012-05-13 22:25:39 -0700 All reviewed patches have been landed. Closing bug. 141577 2012-05-12 08:30:36 -0700 2012-05-13 22:25:34 -0700 Patch bug-86298-20120512083035.patch text/plain 4988 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA1LTEyICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBMaXN0ZW5lcnMgbWFwIHVzZXMgcmF3 IHBvaW50ZXJzLCBidXQgc2hvdWxkIHVzZSBPd25QdHIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2Mjk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9QYWdlU2NyaXB0RGVidWdTZXJ2 ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZVNjcmlwdERlYnVnU2VydmVyOjp+UGFnZVNj cmlwdERlYnVnU2VydmVyKTogUmVtb3ZlZCBjYWxsCisgICAgICAgIHRvIGRlbGV0ZUFsbFZhbHVl cyBzaW5jZSB0aGUgZGVzdHJ1Y3RvciBub3cgdGFrZXMgY2FyZSBvZiB0aGlzCisgICAgICAgIChX ZWJDb3JlOjpQYWdlU2NyaXB0RGVidWdTZXJ2ZXI6OmFkZExpc3RlbmVyKTogQ2hhbmdlZCBpZGlv bSBvZiB0aGUgYWRkCisgICAgICAgIGZ1bmN0aW9uIGNhbGwgaGVyZSB0byB1c2UgYWRvcHRQdHIu CisgICAgICAgIChXZWJDb3JlOjpQYWdlU2NyaXB0RGVidWdTZXJ2ZXI6OnJlbW92ZUxpc3RlbmVy KTogQWRkZWQgYSBub3ctbmVlZGVkCisgICAgICAgIGNhbGwgdG8gZ2V0IGFuZCByZW1vdmVkIGEg bm93LXVuZWVlZGVkIGNhbGwgdG8gZGVsZXRlLgorICAgICAgICAqIGJpbmRpbmdzL2pzL1BhZ2VT Y3JpcHREZWJ1Z1NlcnZlci5oOiBDaGFuZ2VkIHRoZSBrZXkgdHlwZSBvZgorICAgICAgICBQYWdl TGlzdGVuZXJzTWFwIHRvIE93blB0ci4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdERl YnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdERlYnVnU2VydmVyOjp+U2Ny aXB0RGVidWdTZXJ2ZXIpOiBSZW1vdmVkIGNvZGUgdG8gZGVsZXRlCisgICAgICAgIHRoZSB2YWx1 ZXMgaW4gbV9wYWdlTGlzdGVuZXJzTWFwLiBUaGlzIG1hcCB3YXMgbmV2ZXIgdXNlZCBhbmQgc28g SSBoYXZlCisgICAgICAgIHJlbW92ZWQgaXQuCisgICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0 RGVidWdTZXJ2ZXIuaDogUmVtb3ZlZCB0aGUgdHlwZSBQYWdlTGlzdGVuZXJzTWFwCisgICAgICAg IGFuZCB0aGUgdW51c2VkIGRhdGEgbWVtYmVyLCBtX3BhZ2VMaXN0ZW5lcnNNYXAuCisKIDIwMTIt MDUtMTIgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IG1vdmUgcmVjb3JkaW5nIGJ1dHRvbiBzdGF0ZSBjb250cm9sIG91dCBv ZiBhZGRQcm9maWxlSGVhZGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvUGFn ZVNjcmlwdERlYnVnU2VydmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9QYWdlU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCShyZXZpc2lvbiAxMTYyMDYpCisrKyBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9QYWdlU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC03NSw3ICs3NSw2IEBAIFBhZ2VTY3JpcHREZWJ1Z1NlcnZlcjo6UGFnZVNj cmlwdERlYnVnU2UKIAogUGFnZVNjcmlwdERlYnVnU2VydmVyOjp+UGFnZVNjcmlwdERlYnVnU2Vy dmVyKCkKIHsKLSAgICBkZWxldGVBbGxWYWx1ZXMobV9wYWdlTGlzdGVuZXJzTWFwKTsKIH0KIAog dm9pZCBQYWdlU2NyaXB0RGVidWdTZXJ2ZXI6OmFkZExpc3RlbmVyKFNjcmlwdERlYnVnTGlzdGVu ZXIqIGxpc3RlbmVyLCBQYWdlKiBwYWdlKQpAQCAtODMsMTEgKzgyLDkgQEAgdm9pZCBQYWdlU2Ny aXB0RGVidWdTZXJ2ZXI6OmFkZExpc3RlbmVyKAogICAgIEFTU0VSVF9BUkcobGlzdGVuZXIsIGxp c3RlbmVyKTsKICAgICBBU1NFUlRfQVJHKHBhZ2UsIHBhZ2UpOwogCi0gICAgUGFnZUxpc3RlbmVy c01hcDo6QWRkUmVzdWx0IHJlc3VsdCA9IG1fcGFnZUxpc3RlbmVyc01hcC5hZGQocGFnZSwgMCk7 Ci0gICAgaWYgKHJlc3VsdC5pc05ld0VudHJ5KQotICAgICAgICByZXN1bHQuaXRlcmF0b3ItPnNl Y29uZCA9IG5ldyBMaXN0ZW5lclNldDsKLQotICAgIExpc3RlbmVyU2V0KiBsaXN0ZW5lcnMgPSBy ZXN1bHQuaXRlcmF0b3ItPnNlY29uZDsKKyAgICBPd25QdHI8TGlzdGVuZXJTZXQ+JiBsaXN0ZW5l cnMgPSBtX3BhZ2VMaXN0ZW5lcnNNYXAuYWRkKHBhZ2UsIG51bGxwdHIpLml0ZXJhdG9yLT5zZWNv bmQ7CisgICAgaWYgKCFsaXN0ZW5lcnMpCisgICAgICAgIGxpc3RlbmVycyA9IGFkb3B0UHRyKG5l dyBMaXN0ZW5lclNldCk7CiAgICAgbGlzdGVuZXJzLT5hZGQobGlzdGVuZXIpOwogCiAgICAgcmVj b21waWxlQWxsSlNGdW5jdGlvbnNTb29uKCk7CkBAIC0xMDMsMTEgKzEwMCwxMCBAQCB2b2lkIFBh Z2VTY3JpcHREZWJ1Z1NlcnZlcjo6cmVtb3ZlTGlzdGVuCiAgICAgaWYgKGl0ID09IG1fcGFnZUxp c3RlbmVyc01hcC5lbmQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgTGlzdGVuZXJTZXQqIGxp c3RlbmVycyA9IGl0LT5zZWNvbmQ7CisgICAgTGlzdGVuZXJTZXQqIGxpc3RlbmVycyA9IGl0LT5z ZWNvbmQuZ2V0KCk7CiAgICAgbGlzdGVuZXJzLT5yZW1vdmUobGlzdGVuZXIpOwogICAgIGlmIChs aXN0ZW5lcnMtPmlzRW1wdHkoKSkgewogICAgICAgICBtX3BhZ2VMaXN0ZW5lcnNNYXAucmVtb3Zl KGl0KTsKLSAgICAgICAgZGVsZXRlIGxpc3RlbmVyczsKICAgICAgICAgZGlkUmVtb3ZlTGFzdExp c3RlbmVyKHBhZ2UpOwogICAgIH0KIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L1BhZ2VTY3JpcHREZWJ1Z1NlcnZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1BhZ2VTY3JpcHREZWJ1Z1NlcnZlci5oCShyZXZpc2lvbiAxMTYyMDYpCisrKyBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9QYWdlU2NyaXB0RGVidWdTZXJ2ZXIuaAkod29ya2lu ZyBjb3B5KQpAQCAtNTQsNyArNTQsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHJlY29t cGlsZUFsbEpTRnVuY3Rpb25zKFRpbWVyPFNjcmlwdERlYnVnU2VydmVyPiopOwogCiBwcml2YXRl OgotICAgIHR5cGVkZWYgSGFzaE1hcDxQYWdlKiwgTGlzdGVuZXJTZXQqPiBQYWdlTGlzdGVuZXJz TWFwOworICAgIHR5cGVkZWYgSGFzaE1hcDxQYWdlKiwgT3duUHRyPExpc3RlbmVyU2V0PiA+IFBh Z2VMaXN0ZW5lcnNNYXA7CiAKICAgICBQYWdlU2NyaXB0RGVidWdTZXJ2ZXIoKTsKICAgICB2aXJ0 dWFsIH5QYWdlU2NyaXB0RGVidWdTZXJ2ZXIoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1NjcmlwdERlYnVnU2VydmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5jcHAJKHJldmlzaW9uIDExNjIwNikKKysr IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdERlYnVnU2VydmVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNjUsNyArNjUsNiBAQCBTY3JpcHREZWJ1Z1NlcnZlcjo6U2NyaXB0RGVidWdT ZXJ2ZXIoKQogCiBTY3JpcHREZWJ1Z1NlcnZlcjo6flNjcmlwdERlYnVnU2VydmVyKCkKIHsKLSAg ICBkZWxldGVBbGxWYWx1ZXMobV9wYWdlTGlzdGVuZXJzTWFwKTsKIH0KIAogU3RyaW5nIFNjcmlw dERlYnVnU2VydmVyOjpzZXRCcmVha3BvaW50KGNvbnN0IFN0cmluZyYgc291cmNlSUQsIGNvbnN0 IFNjcmlwdEJyZWFrcG9pbnQmIHNjcmlwdEJyZWFrcG9pbnQsIGludCogYWN0dWFsTGluZU51bWJl ciwgaW50KiBhY3R1YWxDb2x1bW5OdW1iZXIpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdERlYnVnU2VydmVyLmgJKHJldmlzaW9uIDExNjIwNikKKysrIFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdERlYnVnU2VydmVyLmgJKHdvcmtpbmcgY29weSkK QEAgLTEzMywxMSArMTMzLDkgQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCBkaWRFeGVj dXRlUHJvZ3JhbShjb25zdCBKU0M6OkRlYnVnZ2VyQ2FsbEZyYW1lJiwgaW50cHRyX3Qgc291cmNl SUQsIGludCBsaW5lbm8pOwogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWFjaEJyZWFrcG9pbnQoY29u c3QgSlNDOjpEZWJ1Z2dlckNhbGxGcmFtZSYsIGludHB0cl90IHNvdXJjZUlELCBpbnQgbGluZW5v KTsKIAotICAgIHR5cGVkZWYgSGFzaE1hcDxQYWdlKiwgTGlzdGVuZXJTZXQqPiBQYWdlTGlzdGVu ZXJzTWFwOwogICAgIHR5cGVkZWYgSGFzaE1hcDxsb25nLCBTY3JpcHRCcmVha3BvaW50PiBMaW5l VG9CcmVha3BvaW50TWFwOwogICAgIHR5cGVkZWYgSGFzaE1hcDxpbnRwdHJfdCwgTGluZVRvQnJl YWtwb2ludE1hcD4gU291cmNlSWRUb0JyZWFrcG9pbnRzTWFwOwogCi0gICAgUGFnZUxpc3RlbmVy c01hcCBtX3BhZ2VMaXN0ZW5lcnNNYXA7CiAgICAgYm9vbCBtX2NhbGxpbmdMaXN0ZW5lcnM7CiAg ICAgUGF1c2VPbkV4Y2VwdGlvbnNTdGF0ZSBtX3BhdXNlT25FeGNlcHRpb25zU3RhdGU7CiAgICAg Ym9vbCBtX3BhdXNlT25OZXh0U3RhdGVtZW50Owo=