86294 2012-05-12 07:01:05 -0700 Web Inspector: implement tabs reordering via drag'n'drop. 2012-05-14 02:45:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 622339 0 pfeldman 2012-05-12 07:01:05 -0700 Patch to follow. 622340 1 141574 pfeldman 2012-05-12 07:02:26 -0700 Created attachment 141574 Patch 622493 2 apavlov 2012-05-13 06:45:59 -0700 (In reply to comment #1) > Created an attachment (id=141574) [details] > Patch Will this retain the tab order on the window re-opening, like Eclipse does? (Meaning, will it update the tab strip model?) 622775 3 pfeldman 2012-05-14 02:45:47 -0700 Committed r116930: <http://trac.webkit.org/changeset/116930> 141574 2012-05-12 07:02:26 -0700 2012-05-12 09:47:48 -0700 Patch bug-86294-20120512180224.patch text/plain 5080 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2ODUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWExOTc1NzE4N2RjMDli ODhjOTA2YzFhOTk3MTdmMzI5MjM3ZDVlMC4uOTJlODM2MWI3N2YwYWNmMTk5NjA1NjA1MzgzN2Yx NmUxYjA4Mzg0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTA1LTEyICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGltcGxlbWVudCB0YWJzIHJlb3JkZXJpbmcgdmlhIGRyYWcnbidkcm9wLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYyOTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvVGFiYmVkUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lVGFiLnBy b3RvdHlwZS5fY3JlYXRlVGFiRWxlbWVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiYmVk UGFuZVRhYi5wcm90b3R5cGUuX3RhYkNsaWNrZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRh YmJlZFBhbmVUYWIucHJvdG90eXBlLl90YWJNb3VzZURvd24pOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBlLl90YWJDb250ZXh0TWVudSk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuVGFiYmVkUGFuZVRhYi5wcm90b3R5cGUuX3RhYk1vdXNlTW92ZSk6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZVRhYi5wcm90b3R5cGUuX3RhYkRyYWdnaW5nKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lVGFiLnByb3RvdHlwZS5fZW5kVGFiRHJh Z2dpbmcpOgorCisyMDEyLTA1LTEyICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0u b3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFkZCB0YWIgY29udGV4dCBtZW51CiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjI5MgogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMKaW5kZXgg OTA5YjlmYTljYzA1MWE2NDM4MTE2OGM4M2Q2ZjdhZDdlZmQ0ZjM3OC4uZjliMTcyODU2MDQyNGUx ZWVhZTM1MmJlYTlmNmE4ODY2ODRlYjlhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGFiYmVkUGFuZS5qcwpAQCAtNjI4LDggKzYyOCwxMSBAQCBXZWJJbnNw ZWN0b3IuVGFiYmVkUGFuZVRhYi5wcm90b3R5cGUgPSB7CiAgICAgICAgIGVsc2UgewogICAgICAg ICAgICAgdGhpcy5fdGFiRWxlbWVudCA9IHRhYkVsZW1lbnQ7CiAgICAgICAgICAgICB0YWJFbGVt ZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fdGFiQ2xpY2tlZC5iaW5kKHRoaXMp LCBmYWxzZSk7Ci0gICAgICAgICAgICBpZiAodGhpcy5fY2xvc2VhYmxlKQorICAgICAgICAgICAg aWYgKHRoaXMuX2Nsb3NlYWJsZSkgewogICAgICAgICAgICAgICAgIHRhYkVsZW1lbnQuYWRkRXZl bnRMaXN0ZW5lcigiY29udGV4dG1lbnUiLCB0aGlzLl90YWJDb250ZXh0TWVudS5iaW5kKHRoaXMp LCBmYWxzZSk7CisgICAgICAgICAgICAgICAgdGFiRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJt b3VzZWRvd24iLCB0aGlzLl90YWJNb3VzZURvd24uYmluZCh0aGlzKSwgZmFsc2UpOworICAgICAg ICAgICAgICAgIHRhYkVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vtb3ZlIiwgdGhpcy5f dGFiTW91c2VNb3ZlLmJpbmQodGhpcyksIGZhbHNlKTsKKyAgICAgICAgICAgIH0KICAgICAgICAg fQogICAgICAgICAKICAgICAgICAgcmV0dXJuIHRhYkVsZW1lbnQ7CkBAIC02NTAsOSArNjUzLDE2 IEBAIFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lVGFiLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAg ICAgIGlmICh0aGlzLl9jbG9zZWFibGUgJiYgKGV2ZW50LmJ1dHRvbiA9PT0gMSB8fCBldmVudC50 YXJnZXQuaGFzU3R5bGVDbGFzcygidGFiYmVkLXBhbmUtaGVhZGVyLXRhYi1jbG9zZS1idXR0b24i KSkpCiAgICAgICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmNsb3NlVGFiKHRoaXMuaWQsIHRydWUp OwotICAgICAgICBlbHNlCi0gICAgICAgICAgICB0aGlzLl90YWJiZWRQYW5lLnNlbGVjdFRhYih0 aGlzLmlkLCB0cnVlKTsKLSAgICAgICAgdGhpcy5fdGFiYmVkUGFuZS5mb2N1cygpOworICAgIH0s CisKKyAgICAvKioKKyAgICAgKiBAcGFyYW0ge0V2ZW50fSBldmVudAorICAgICAqLworICAgIF90 YWJNb3VzZURvd246IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKGV2ZW50LnRh cmdldC5oYXNTdHlsZUNsYXNzKCJ0YWJiZWQtcGFuZS1oZWFkZXItdGFiLWNsb3NlLWJ1dHRvbiIp IHx8IGV2ZW50LmJ1dHRvbiA9PT0gMSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgdGhp cy5fdGFiYmVkUGFuZS5zZWxlY3RUYWIodGhpcy5pZCwgdHJ1ZSk7CiAgICAgfSwKIAogICAgIF90 YWJDb250ZXh0TWVudTogZnVuY3Rpb24oZXZlbnQpCkBAIC02NzcsNSArNjg3LDU4IEBAIFdlYklu c3BlY3Rvci5UYWJiZWRQYW5lVGFiLnByb3RvdHlwZSA9IHsKICAgICAgICAgY29udGV4dE1lbnUu YXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNsb3NlIE90aGVycyIpLCBjbG9zZU90 aGVycy5iaW5kKHRoaXMpKTsKICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNw ZWN0b3IuVUlTdHJpbmcoIkNsb3NlIEFsbCIpLCBjbG9zZUFsbC5iaW5kKHRoaXMpKTsKICAgICAg ICAgY29udGV4dE1lbnUuc2hvdyhldmVudCk7CisgICAgfSwKKworICAgIF90YWJNb3VzZU1vdmU6 IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKGV2ZW50LndoaWNoICE9PSAxKQor ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB0aGlzLl90YWJiZWRQYW5lLnNlbGVjdFRhYih0 aGlzLmlkLCB0cnVlKTsKKyAgICAgICAgV2ViSW5zcGVjdG9yLmVsZW1lbnREcmFnU3RhcnQodGhp cy5fdGFiRWxlbWVudCwgdGhpcy5fdGFiRHJhZ2dpbmcuYmluZCh0aGlzKSwgdGhpcy5fZW5kVGFi RHJhZ2dpbmcuYmluZCh0aGlzKSwgZXZlbnQsICJwb2ludGVyIik7CisgICAgICAgIHRoaXMuX2Ry YWdTdGFydFggPSBldmVudC5wYWdlWDsKKyAgICB9LAorCisgICAgLyoqCisgICAgICogQHBhcmFt IHtFdmVudH0gZXZlbnQKKyAgICAgKi8KKyAgICBfdGFiRHJhZ2dpbmc6IGZ1bmN0aW9uKGV2ZW50 KQorICAgIHsKKyAgICAgICAgdmFyIHRhYkVsZW1lbnRzID0gdGhpcy5fdGFiYmVkUGFuZS5fdGFi c0VsZW1lbnQuY2hpbGROb2RlczsKKyAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0YWJFbGVt ZW50cy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgdmFyIHRhYkVsZW1lbnQgPSB0YWJFbGVt ZW50c1tpXTsKKyAgICAgICAgICAgIGlmICh0YWJFbGVtZW50ID09PSB0aGlzLl90YWJFbGVtZW50 KQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgdmFyIG9mZnNldCA9IHRh YkVsZW1lbnQudG90YWxPZmZzZXRMZWZ0KCk7CisgICAgICAgICAgICBpZiAoZXZlbnQub2Zmc2V0 WCA8IG9mZnNldCB8fCBldmVudC5vZmZzZXRYID4gb2Zmc2V0ICsgdGFiRWxlbWVudC5jbGllbnRX aWR0aCkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgCisgICAgICAgICAgICBpZiAodGFi RWxlbWVudC5vZmZzZXRMZWZ0ID4gdGhpcy5fdGFiRWxlbWVudC5vZmZzZXRMZWZ0KQorICAgICAg ICAgICAgICAgIHRhYkVsZW1lbnQgPSB0YWJFbGVtZW50Lm5leHRTaWJsaW5nOworICAgICAgICAg ICAgdmFyIG9sZE9mZnNldExlZnQgPSB0aGlzLl90YWJFbGVtZW50Lm9mZnNldExlZnQ7CisgICAg ICAgICAgICB0aGlzLl90YWJFbGVtZW50LnBhcmVudEVsZW1lbnQuaW5zZXJ0QmVmb3JlKHRoaXMu X3RhYkVsZW1lbnQsIHRhYkVsZW1lbnQpOworICAgICAgICAgICAgdGhpcy5fZHJhZ1N0YXJ0WCAr PSB0aGlzLl90YWJFbGVtZW50Lm9mZnNldExlZnQgLSBvbGRPZmZzZXRMZWZ0OworICAgICAgICB9 CisKKyAgICAgICAgaWYgKCF0aGlzLl90YWJFbGVtZW50LnByZXZpb3VzU2libGluZyAmJiBldmVu dC5wYWdlWCAtIHRoaXMuX2RyYWdTdGFydFggPCAwKSB7CisgICAgICAgICAgICB0aGlzLl90YWJF bGVtZW50LnN0eWxlLnNldFByb3BlcnR5KCJsZWZ0IiwgIjBweCIpOworICAgICAgICAgICAgcmV0 dXJuOworICAgICAgICB9CisgICAgICAgIGlmICghdGhpcy5fdGFiRWxlbWVudC5uZXh0U2libGlu ZyAmJiBldmVudC5wYWdlWCAtIHRoaXMuX2RyYWdTdGFydFggPiAwKSB7CisgICAgICAgICAgICB0 aGlzLl90YWJFbGVtZW50LnN0eWxlLnNldFByb3BlcnR5KCJsZWZ0IiwgIjBweCIpOworICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgdGhpcy5fdGFiRWxlbWVudC5zdHls ZS5zZXRQcm9wZXJ0eSgicG9zaXRpb24iLCAicmVsYXRpdmUiKTsKKyAgICAgICAgdGhpcy5fdGFi RWxlbWVudC5zdHlsZS5zZXRQcm9wZXJ0eSgibGVmdCIsIChldmVudC5wYWdlWCAtIHRoaXMuX2Ry YWdTdGFydFgpICsgInB4Iik7CisgICAgfSwKKworICAgIC8qKgorICAgICAqIEBwYXJhbSB7RXZl bnR9IGV2ZW50CisgICAgICovCisgICAgX2VuZFRhYkRyYWdnaW5nOiBmdW5jdGlvbihldmVudCkK KyAgICB7CisgICAgICAgIHRoaXMuX3RhYkVsZW1lbnQuc3R5bGUucmVtb3ZlUHJvcGVydHkoInBv c2l0aW9uIik7CisgICAgICAgIHRoaXMuX3RhYkVsZW1lbnQuc3R5bGUucmVtb3ZlUHJvcGVydHko ImxlZnQiKTsKKyAgICAgICAgV2ViSW5zcGVjdG9yLmVsZW1lbnREcmFnRW5kKGV2ZW50KTsKICAg ICB9CiB9Cg==