86292 2000-12-31 16:04:58 -0800 Web Inspector: add tab context menu 2012-05-12 06:08:57 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 622324 0 pfeldman 2000-12-31 16:04:58 -0800 This tab context menu will have "Close", "Close Others" and "Close All". 622326 1 141570 pfeldman 2000-12-31 16:06:33 -0800 Created attachment 141570 Patch 622333 2 141570 yurys 2012-05-12 06:05:13 -0700 Comment on attachment 141570 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141570&action=review > Source/WebCore/inspector/front-end/TabbedPane.js:631 > + if (this._closeable) Can you have this field on the tab container instead of the tab? Otherwise it looks as if some tabs may be closeable while others not. 622334 3 pfeldman 2012-05-12 06:08:57 -0700 Committed r116853: <http://trac.webkit.org/changeset/116853> 141570 2000-12-31 16:06:33 -0800 2012-05-12 06:05:12 -0700 Patch bug-86292-20120512162823.patch text/plain 3871 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU2ZTkxMDlmNjBhN2Vi OTNhMTZhMTIzMGE5ZDdhMDgxYTE4N2RiMC4uYzk4ODZmZmFjY2RhZDU3ZWRkNTQ4Y2NhY2FiNDkw M2Q0YjQxMTcwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTA1LTEyICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFkZCB0YWIgY29udGV4dCBtZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NjI5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgdGFiIGNvbnRleHQgbWVudSB3aWxsIGhhdmUgIkNsb3NlIiwg IkNsb3NlIE90aGVycyIgYW5kICJDbG9zZSBBbGwiLgorCisgICAgICAgICogRW5nbGlzaC5scHJv ai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGFi YmVkUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lLnByb3RvdHlwZS5j bG9zZU90aGVyVGFicyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZVRhYi5wcm90 b3R5cGUuX2NyZWF0ZVRhYkVsZW1lbnQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYmJlZFBh bmVUYWIucHJvdG90eXBlLl90YWJDbGlja2VkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJi ZWRQYW5lVGFiLnByb3RvdHlwZS5fdGFiQ29udGV4dE1lbnUpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBlLl90YWJDb250ZXh0TWVudS5jbG9zZU90aGVycyk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZVRhYi5wcm90b3R5cGUuX3RhYkNvbnRl eHRNZW51LmNsb3NlQWxsKToKKworMjAxMi0wNS0xMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu QGNocm9taXVtLm9yZz4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtYWtlIGNhbGwgZnJhbWUg c2VsZWN0b3IgcGFuZSBmb2N1c2FibGUsIGFsbG93IFVwIC8gRG93biB0byBzZWxlY3QgY3VycmVu dCBjYWxsIGZyYW1lLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODYyOTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9s b2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6 ZWRTdHJpbmdzLmpzCmluZGV4IDc2YTczMWI3YTExNWVhOTRhNzhjNzQxOWU0MTNlNjE5MTE3YzI5 NGQuLjgyNjExOTA3NThlMmQ0MzI4NDkzZDFiMDM0NDAwNjkyOTYzNzBmOWUgMTAwNjQ0CkdJVCBi aW5hcnkgcGF0Y2gKZGVsdGEgMTA5CnpjbVpxYVZMajV6K09VT0BPP1VERUJiTW4wYlFzeSM2JlU7 KE4qRlJHS1hlcjMmdGJAQ0N9djF5ZlFqYHg4YypNKwp4IV5rMTh6fklQYDFCNk5wdXxQPiVBWFp7 PDJKKWZHQ3ZUS0JvUExqbWsjRC0yRX5DX1RKemQ2WTUmJFdmOHZGbk4KCmRlbHRhIDI3CmpjbVhA byVpN1l6K09VT0BPP1VifDdEbTQ1WTxpNFIrdSFMalVYdVUtZ3lSVlYKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMKaW5kZXggZGE2OTRlNDE0 MTJlNzg2ODQ1ODcyYjE5MGZmNTBkMTM1ZWNjNzU1Yy4uOTA5YjlmYTljYzA1MWE2NDM4MTE2OGM4 M2Q2ZjdhZDdlZmQ0ZjM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9UYWJiZWRQYW5lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvVGFiYmVkUGFuZS5qcwpAQCAtMTYwLDYgKzE2MCwyMCBAQCBXZWJJbnNwZWN0b3IuVGFi YmVkUGFuZS5wcm90b3R5cGUgPSB7CiAKICAgICAvKioKICAgICAgKiBAcGFyYW0ge3N0cmluZ30g aWQKKyAgICAgKi8KKyAgICBjbG9zZU90aGVyVGFiczogZnVuY3Rpb24oaWQpCisgICAgeworICAg ICAgICB2YXIgdGFicyA9IHRoaXMuX3RhYnMuc2xpY2UoKTsKKyAgICAgICAgZm9yICh2YXIgaSA9 IDA7IGkgPCB0YWJzLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICBpZiAodGFic1tpXS5pZCAh PT0gaWQpCisgICAgICAgICAgICAgICAgdGhpcy5faW5uZXJDbG9zZVRhYih0YWJzW2ldLmlkLCB0 cnVlKTsKKyAgICAgICAgfQorICAgICAgICB0aGlzLl91cGRhdGVUYWJFbGVtZW50cygpOworICAg ICAgICB0aGlzLnNlbGVjdFRhYihpZCwgdHJ1ZSk7CisgICAgfSwKKworICAgIC8qKgorICAgICAq IEBwYXJhbSB7c3RyaW5nfSBpZAogICAgICAqIEBwYXJhbSB7Ym9vbGVhbj19IHVzZXJHZXN0dXJl CiAgICAgICovCiAgICAgc2VsZWN0VGFiOiBmdW5jdGlvbihpZCwgdXNlckdlc3R1cmUpCkBAIC02 MTQsNiArNjI4LDggQEAgV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewog ICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIHRoaXMuX3RhYkVsZW1lbnQgPSB0YWJFbGVtZW50 OwogICAgICAgICAgICAgdGFiRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMu X3RhYkNsaWNrZWQuYmluZCh0aGlzKSwgZmFsc2UpOworICAgICAgICAgICAgaWYgKHRoaXMuX2Ns b3NlYWJsZSkKKyAgICAgICAgICAgICAgICB0YWJFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNv bnRleHRtZW51IiwgdGhpcy5fdGFiQ29udGV4dE1lbnUuYmluZCh0aGlzKSwgZmFsc2UpOwogICAg ICAgICB9CiAgICAgICAgIAogICAgICAgICByZXR1cm4gdGFiRWxlbWVudDsKQEAgLTYzNyw1ICs2 NTMsMjkgQEAgV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewogICAgICAg ICBlbHNlCiAgICAgICAgICAgICB0aGlzLl90YWJiZWRQYW5lLnNlbGVjdFRhYih0aGlzLmlkLCB0 cnVlKTsKICAgICAgICAgdGhpcy5fdGFiYmVkUGFuZS5mb2N1cygpOworICAgIH0sCisKKyAgICBf dGFiQ29udGV4dE1lbnU6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgZnVuY3Rpb24g Y2xvc2UoKQorICAgICAgICB7CisgICAgICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmNsb3NlVGFi KHRoaXMuaWQsIHRydWUpOworICAgICAgICB9CisgIAorICAgICAgICBmdW5jdGlvbiBjbG9zZU90 aGVycygpCisgICAgICAgIHsKKyAgICAgICAgICAgIHRoaXMuX3RhYmJlZFBhbmUuY2xvc2VPdGhl clRhYnModGhpcy5pZCk7CisgICAgICAgIH0KKyAgCisgICAgICAgIGZ1bmN0aW9uIGNsb3NlQWxs KCkKKyAgICAgICAgeworICAgICAgICAgICAgdGhpcy5fdGFiYmVkUGFuZS5jbG9zZUFsbFRhYnMo dHJ1ZSk7CisgICAgICAgIH0KKyAgCisgICAgICAgIHZhciBjb250ZXh0TWVudSA9IG5ldyBXZWJJ bnNwZWN0b3IuQ29udGV4dE1lbnUoKTsKKyAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNsb3NlIiksIGNsb3NlLmJpbmQodGhpcykpOworICAgICAg ICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ2xvc2UgT3Ro ZXJzIiksIGNsb3NlT3RoZXJzLmJpbmQodGhpcykpOworICAgICAgICBjb250ZXh0TWVudS5hcHBl bmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ2xvc2UgQWxsIiksIGNsb3NlQWxsLmJpbmQo dGhpcykpOworICAgICAgICBjb250ZXh0TWVudS5zaG93KGV2ZW50KTsKICAgICB9CiB9Cg==