<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>86287</bug_id>
          
          <creation_ts>2012-05-12 02:18:40 -0700</creation_ts>
          <short_desc>run-safari and co. should support --guard-malloc command line argument</short_desc>
          <delta_ts>2012-05-12 11:08:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>mitz</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>622295</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-05-12 02:18:40 -0700</bug_when>
    <thetext>run-webkit-tests supports the argument --guard-malloc on OS X to inject libgmalloc into Safari/WebProcess.

run-safari and debug-safari and friends should support this as well, for convenience.

I have a patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622296</commentid>
    <comment_count>1</comment_count>
      <attachid>141563</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-05-12 02:24:04 -0700</bug_when>
    <thetext>Created attachment 141563
patch

If need be (if whoever reviews this wants) we can make a gdb script that we call (-x) that turns gmalloc on only for the child process and not for gdb itself. It&apos;s kind of annoying that there doesn&apos;t seem to be a way to hand it commands right on the command line...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622376</commentid>
    <comment_count>2</comment_count>
      <attachid>141563</attachid>
    <who name="">mitz</who>
    <bug_when>2012-05-12 09:51:48 -0700</bug_when>
    <thetext>Comment on attachment 141563
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141563&amp;action=review

&gt; Tools/Scripts/webkitdirs.pm:1387
&gt; +sub setupGuardMallocIfNeeded

This should use the verb “set up” and therefore a capital U.

&gt; Tools/Scripts/webkitdirs.pm:1398
&gt; +        $ENV{DYLD_INSERT_LIBRARIES} = &quot;/usr/lib/libgmalloc.dylib&quot;;

This will get overwritten by
    $ENV{DYLD_INSERT_LIBRARIES} = $webProcessShimPath;
in the shouldTargetWebProcess() branch of execMacWebKitAppForDebugging(). Please change that function so that it will work with the new option.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622387</commentid>
    <comment_count>3</comment_count>
      <attachid>141583</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-05-12 10:46:05 -0700</bug_when>
    <thetext>Created attachment 141583
patch + mitzification</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622390</commentid>
    <comment_count>4</comment_count>
      <attachid>141583</attachid>
    <who name="">mitz</who>
    <bug_when>2012-05-12 10:57:18 -0700</bug_when>
    <thetext>Comment on attachment 141583
patch + mitzification

View in context: https://bugs.webkit.org/attachment.cgi?id=141583&amp;action=review

&gt; Tools/Scripts/webkitdirs.pm:2514
&gt; +  --guard-malloc        Enable malloc guard (Mac OS X only)

I’ve never seen this called “malloc guard”. Is this what it’s called in run-webkit-tests? The man pages seem to call it Guard Malloc.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622391</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-05-12 10:57:53 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 141583 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=141583&amp;action=review
&gt; 
&gt; &gt; Tools/Scripts/webkitdirs.pm:2514
&gt; &gt; +  --guard-malloc        Enable malloc guard (Mac OS X only)
&gt; 
&gt; I’ve never seen this called “malloc guard”. Is this what it’s called in run-webkit-tests? The man pages seem to call it Guard Malloc.

I stole the help message from run-webkit-tests, I agree it sounds a little weird. Maybe we should change it in both places?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622392</commentid>
    <comment_count>6</comment_count>
    <who name="">mitz</who>
    <bug_when>2012-05-12 11:06:47 -0700</bug_when>
    <thetext>&gt; I stole the help message from run-webkit-tests, I agree it sounds a little weird. Maybe we should change it in both places?

Good idea.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622394</commentid>
    <comment_count>7</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-05-12 11:08:33 -0700</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/116859

Thanks, Dan!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141563</attachid>
            <date>2012-05-12 02:24:04 -0700</date>
            <delta_ts>2012-05-12 10:46:05 -0700</delta_ts>
            <desc>patch</desc>
            <filename>gmalloc.diff</filename>
            <type>text/plain</type>
            <size>3356</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkYzY1
MDU4Li42MmVlZjFiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMDUtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5
X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgcnVuLXNhZmFyaSBhbmQgY28uIHNob3VsZCBz
dXBwb3J0IC0tZ3VhcmQtbWFsbG9jIGNvbW1hbmQgbGluZSBhcmd1bWVudAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYyODcKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc2V0dXBHdWFyZE1hbGxvY0lm
TmVlZGVkKCksIHdoaWNoIGNvbnN1bHRzIHRoZSBhcmd1bWVudCAtLWd1YXJkLW1hbGxvYyBvbiBP
UyBYLAorICAgICAgICBzZXR0aW5nIERZTERfSU5TRVJUX0xJQlJBUklFUz0iL3Vzci9saWIvbGli
Z21hbGxvYy5keWxpYiIgaWYgaXQncyBlbmFibGVkLgorCisgICAgICAgIFVzZSBzZXR1cEd1YXJk
TWFsbG9jSWZOZWVkZWQoKSBiZWZvcmUgcnVubmluZyBhIFdlYktpdCBhcHAgKHdoZXRoZXIgc3Rh
bmRhbG9uZSBvcgorICAgICAgICBpbiB0aGUgZGVidWdnZXIpLiBUaGlzIHdpbGwgY2F1c2UgZ21h
bGxvYyB0byBiZSBsb2FkZWQgZm9yIGdkYiBhcyB3ZWxsLCBidXQgdGhpcworICAgICAgICB0ZW5k
cyB0byBiZSBoYXJtbGVzcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAg
ICAgICAgKHNldHVwR3VhcmRNYWxsb2NJZk5lZWRlZCk6CisgICAgICAgIChwcmludEhlbHBBbmRF
eGl0Rm9yUnVuQW5kRGVidWdXZWJLaXRBcHBJZk5lZWRlZCk6CisgICAgICAgIChydW5NYWNXZWJL
aXRBcHApOgorICAgICAgICAoZXhlY01hY1dlYktpdEFwcEZvckRlYnVnZ2luZyk6CisgICAgICAg
IChydW5TYWZhcmkpOgorCiAyMDEyLTA1LTEwICBWYXJ1biBKYWluICA8dmFydW5qYWluQGdvb2ds
ZS5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBUcmlnZ2VyIGNvbnRleHQgbWVudSBmb3IgbG9u
ZyBwcmVzcyBnZXN0dXJlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0g
Yi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggMjAzODUzYi4uMjEyOTU5NyAxMDA3
NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMv
d2Via2l0ZGlycy5wbQpAQCAtMTAzLDYgKzEwMyw3IEBAIG15ICRmb3JjZUNocm9taXVtVXBkYXRl
OwogbXkgJGlzSW5zcGVjdG9yRnJvbnRlbmQ7CiBteSAkaXNXSzI7CiBteSAkc2hvdWxkVGFyZ2V0
V2ViUHJvY2VzczsKK215ICRzaG91bGRVc2VHdWFyZE1hbGxvYzsKIG15ICR4Y29kZVZlcnNpb247
CiAKICMgVmFyaWFibGVzIGZvciBXaW4zMiBzdXBwb3J0CkBAIC0xMzgzLDYgKzEzODQsMjEgQEAg
c3ViIGRldGVybWluZVNob3VsZFRhcmdldFdlYlByb2Nlc3MKICAgICAkc2hvdWxkVGFyZ2V0V2Vi
UHJvY2VzcyA9IGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS10YXJnZXQtd2Vi
LXByb2Nlc3MiKTsKIH0KIAorc3ViIHNldHVwR3VhcmRNYWxsb2NJZk5lZWRlZAoreworICAgIGlm
ICghaXNEYXJ3aW4oKSkgeworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgaWYgKCFkZWZp
bmVkKCRzaG91bGRVc2VHdWFyZE1hbGxvYykpIHsKKyAgICAgICAgJHNob3VsZFVzZUd1YXJkTWFs
bG9jID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLWd1YXJkLW1hbGxvYyIp
OworICAgIH0KKworICAgIGlmICgkc2hvdWxkVXNlR3VhcmRNYWxsb2MpIHsKKyAgICAgICAgJEVO
VntEWUxEX0lOU0VSVF9MSUJSQVJJRVN9ID0gIi91c3IvbGliL2xpYmdtYWxsb2MuZHlsaWIiOwor
ICAgIH0KK30KKwogc3ViIHJlbGF0aXZlU2NyaXB0c0RpcigpCiB7CiAgICAgbXkgJHNjcmlwdERp
ciA9IEZpbGU6OlNwZWMtPmNhdHBhdGgoIiIsIEZpbGU6OlNwZWMtPmFiczJyZWwoJEZpbmRCaW46
OkJpbiwgZ2V0Y3dkKCkpLCAiIik7CkBAIC0yNDg0LDYgKzI1MDAsNyBAQCBzdWIgcHJpbnRIZWxw
QW5kRXhpdEZvclJ1bkFuZERlYnVnV2ViS2l0QXBwSWZOZWVkZWQoKQogVXNhZ2U6IEB7W2Jhc2Vu
YW1lKCQwKV19IFtvcHRpb25zXSBbYXJncyAuLi5dCiAgIC0taGVscCAgICAgICAgICAgICAgICBT
aG93IHRoaXMgaGVscCBtZXNzYWdlCiAgIC0tbm8tc2F2ZWQtc3RhdGUgICAgICBEaXNhYmxlIGFw
cGxpY2F0aW9uIHJlc3VtZSBmb3IgdGhlIHNlc3Npb24gb24gTWFjIE9TIDEwLjcKKyAgLS1ndWFy
ZC1tYWxsb2MgICAgICAgIEVuYWJsZSBtYWxsb2MgZ3VhcmQgKE1hYyBPUyBYIG9ubHkpCiBFT0YK
ICAgICBleGl0KDEpOwogfQpAQCAtMjUwMiw2ICsyNTE5LDkgQEAgc3ViIHJ1bk1hY1dlYktpdEFw
cCgkOyQpCiAgICAgcHJpbnQgIlN0YXJ0aW5nIEB7W2Jhc2VuYW1lKCRhcHBQYXRoKV19IHdpdGgg
RFlMRF9GUkFNRVdPUktfUEFUSCBzZXQgdG8gcG9pbnQgdG8gYnVpbHQgV2ViS2l0IGluICRwcm9k
dWN0RGlyLlxuIjsKICAgICAkRU5We0RZTERfRlJBTUVXT1JLX1BBVEh9ID0gJHByb2R1Y3REaXI7
CiAgICAgJEVOVntXRUJLSVRfVU5TRVRfRFlMRF9GUkFNRVdPUktfUEFUSH0gPSAiWUVTIjsKKwor
ICAgIHNldHVwR3VhcmRNYWxsb2NJZk5lZWRlZCgpOworCiAgICAgaWYgKGRlZmluZWQoJHVzZU9w
ZW5Db21tYW5kKSAmJiAkdXNlT3BlbkNvbW1hbmQgPT0gVVNFX09QRU5fQ09NTUFORCkgewogICAg
ICAgICByZXR1cm4gc3lzdGVtKCJvcGVuIiwgIi1XIiwgIi1hIiwgJGFwcFBhdGgsICItLWFyZ3Mi
LCBhcmd1bWVudHNGb3JSdW5BbmREZWJ1Z01hY1dlYktpdEFwcCgpKTsKICAgICB9CkBAIC0yNTIx
LDYgKzI1NDEsOSBAQCBzdWIgZXhlY01hY1dlYktpdEFwcEZvckRlYnVnZ2luZygkKQogICAgIG15
ICRwcm9kdWN0RGlyID0gcHJvZHVjdERpcigpOwogICAgICRFTlZ7RFlMRF9GUkFNRVdPUktfUEFU
SH0gPSAkcHJvZHVjdERpcjsKICAgICAkRU5We1dFQktJVF9VTlNFVF9EWUxEX0ZSQU1FV09SS19Q
QVRIfSA9ICJZRVMiOworCisgICAgc2V0dXBHdWFyZE1hbGxvY0lmTmVlZGVkKCk7CisKICAgICBt
eSBAYXJjaGl0ZWN0dXJlRmxhZ3MgPSAoIi1hcmNoIiwgYXJjaGl0ZWN0dXJlKCkpOwogICAgIGlm
ICghc2hvdWxkVGFyZ2V0V2ViUHJvY2VzcygpKSB7CiAgICAgICAgIHByaW50ICJTdGFydGluZyBA
e1tiYXNlbmFtZSgkYXBwUGF0aCldfSB1bmRlciBnZGIgd2l0aCBEWUxEX0ZSQU1FV09SS19QQVRI
IHNldCB0byBwb2ludCB0byBidWlsdCBXZWJLaXQgaW4gJHByb2R1Y3REaXIuXG4iOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141583</attachid>
            <date>2012-05-12 10:46:05 -0700</date>
            <delta_ts>2012-05-12 10:57:18 -0700</delta_ts>
            <desc>patch + mitzification</desc>
            <filename>gmalloc.diff</filename>
            <type>text/plain</type>
            <size>4457</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNjE3
YmNmLi5lYmUwMzY1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMDUtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5
X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgcnVuLXNhZmFyaSBhbmQgY28uIHNob3VsZCBz
dXBwb3J0IC0tZ3VhcmQtbWFsbG9jIGNvbW1hbmQgbGluZSBhcmd1bWVudAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYyODcKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc2V0VXBHdWFyZE1hbGxvY0lm
TmVlZGVkKCksIHdoaWNoIGNvbnN1bHRzIHRoZSBhcmd1bWVudCAtLWd1YXJkLW1hbGxvYyBvbiBP
UyBYLAorICAgICAgICBzZXR0aW5nIERZTERfSU5TRVJUX0xJQlJBUklFUz0iL3Vzci9saWIvbGli
Z21hbGxvYy5keWxpYiIgaWYgaXQncyBlbmFibGVkLgorCisgICAgICAgIFVzZSBzZXRVcEd1YXJk
TWFsbG9jSWZOZWVkZWQoKSBiZWZvcmUgcnVubmluZyBhIFdlYktpdCBhcHAgKHdoZXRoZXIgc3Rh
bmRhbG9uZSBvcgorICAgICAgICBpbiB0aGUgZGVidWdnZXIpLiBUaGlzIHdpbGwgY2F1c2UgZ21h
bGxvYyB0byBiZSBsb2FkZWQgZm9yIGdkYiBhcyB3ZWxsLCBidXQgdGhpcworICAgICAgICB0ZW5k
cyB0byBiZSBoYXJtbGVzcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAg
ICAgICAgKGFwcGVuZFRvRW52aXJvbm1lbnRWYXJpYWJsZUxpc3QpOgorICAgICAgICAoc2V0VXBH
dWFyZE1hbGxvY0lmTmVlZGVkKToKKyAgICAgICAgKHByaW50SGVscEFuZEV4aXRGb3JSdW5BbmRE
ZWJ1Z1dlYktpdEFwcElmTmVlZGVkKToKKyAgICAgICAgKHJ1bk1hY1dlYktpdEFwcCk6CisgICAg
ICAgIChleGVjTWFjV2ViS2l0QXBwRm9yRGVidWdnaW5nKToKKwogMjAxMi0wNS0xMSAgT2phbiBW
YWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBwcmV2aW91cy9uZXh0IGJ1
dHRvbnMgdGhlIGdhcmRlbi1vLW1hdGljcyBwZXJmIHBhbmVsCmRpZmYgLS1naXQgYS9Ub29scy9T
Y3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXgg
MjAzODUzYi4uNTkxNTZiNiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt
CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTAzLDYgKzEwMyw3IEBAIG15
ICRmb3JjZUNocm9taXVtVXBkYXRlOwogbXkgJGlzSW5zcGVjdG9yRnJvbnRlbmQ7CiBteSAkaXNX
SzI7CiBteSAkc2hvdWxkVGFyZ2V0V2ViUHJvY2VzczsKK215ICRzaG91bGRVc2VHdWFyZE1hbGxv
YzsKIG15ICR4Y29kZVZlcnNpb247CiAKICMgVmFyaWFibGVzIGZvciBXaW4zMiBzdXBwb3J0CkBA
IC0xMzgzLDYgKzEzODQsMzIgQEAgc3ViIGRldGVybWluZVNob3VsZFRhcmdldFdlYlByb2Nlc3MK
ICAgICAkc2hvdWxkVGFyZ2V0V2ViUHJvY2VzcyA9IGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVG
cm9tQVJHVigiLS10YXJnZXQtd2ViLXByb2Nlc3MiKTsKIH0KIAorc3ViIGFwcGVuZFRvRW52aXJv
bm1lbnRWYXJpYWJsZUxpc3QKK3sKKyAgICBteSAoJGVudmlyb25tZW50VmFyaWFibGVOYW1lLCAk
dmFsdWUpID0gQF87CisKKyAgICBpZiAoZGVmaW5lZCgkRU5WeyRlbnZpcm9ubWVudFZhcmlhYmxl
TmFtZX0pKSB7CisgICAgICAgICRFTlZ7JGVudmlyb25tZW50VmFyaWFibGVOYW1lfSAuPSAiOiIg
LiAkdmFsdWU7CisgICAgfSBlbHNlIHsKKyAgICAgICAgJEVOVnskZW52aXJvbm1lbnRWYXJpYWJs
ZU5hbWV9ID0gJHZhbHVlOworICAgIH0KK30KKworc3ViIHNldFVwR3VhcmRNYWxsb2NJZk5lZWRl
ZAoreworICAgIGlmICghaXNEYXJ3aW4oKSkgeworICAgICAgICByZXR1cm47CisgICAgfQorCisg
ICAgaWYgKCFkZWZpbmVkKCRzaG91bGRVc2VHdWFyZE1hbGxvYykpIHsKKyAgICAgICAgJHNob3Vs
ZFVzZUd1YXJkTWFsbG9jID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLWd1
YXJkLW1hbGxvYyIpOworICAgIH0KKworICAgIGlmICgkc2hvdWxkVXNlR3VhcmRNYWxsb2MpIHsK
KyAgICAgICAgYXBwZW5kVG9FbnZpcm9ubWVudFZhcmlhYmxlTGlzdCgiRFlMRF9JTlNFUlRfTElC
UkFSSUVTIiwgIi91c3IvbGliL2xpYmdtYWxsb2MuZHlsaWIiKTsKKyAgICB9Cit9CisKIHN1YiBy
ZWxhdGl2ZVNjcmlwdHNEaXIoKQogewogICAgIG15ICRzY3JpcHREaXIgPSBGaWxlOjpTcGVjLT5j
YXRwYXRoKCIiLCBGaWxlOjpTcGVjLT5hYnMycmVsKCRGaW5kQmluOjpCaW4sIGdldGN3ZCgpKSwg
IiIpOwpAQCAtMjQ4NCw2ICsyNTExLDcgQEAgc3ViIHByaW50SGVscEFuZEV4aXRGb3JSdW5BbmRE
ZWJ1Z1dlYktpdEFwcElmTmVlZGVkKCkKIFVzYWdlOiBAe1tiYXNlbmFtZSgkMCldfSBbb3B0aW9u
c10gW2FyZ3MgLi4uXQogICAtLWhlbHAgICAgICAgICAgICAgICAgU2hvdyB0aGlzIGhlbHAgbWVz
c2FnZQogICAtLW5vLXNhdmVkLXN0YXRlICAgICAgRGlzYWJsZSBhcHBsaWNhdGlvbiByZXN1bWUg
Zm9yIHRoZSBzZXNzaW9uIG9uIE1hYyBPUyAxMC43CisgIC0tZ3VhcmQtbWFsbG9jICAgICAgICBF
bmFibGUgbWFsbG9jIGd1YXJkIChNYWMgT1MgWCBvbmx5KQogRU9GCiAgICAgZXhpdCgxKTsKIH0K
QEAgLTI1MDIsNiArMjUzMCw5IEBAIHN1YiBydW5NYWNXZWJLaXRBcHAoJDskKQogICAgIHByaW50
ICJTdGFydGluZyBAe1tiYXNlbmFtZSgkYXBwUGF0aCldfSB3aXRoIERZTERfRlJBTUVXT1JLX1BB
VEggc2V0IHRvIHBvaW50IHRvIGJ1aWx0IFdlYktpdCBpbiAkcHJvZHVjdERpci5cbiI7CiAgICAg
JEVOVntEWUxEX0ZSQU1FV09SS19QQVRIfSA9ICRwcm9kdWN0RGlyOwogICAgICRFTlZ7V0VCS0lU
X1VOU0VUX0RZTERfRlJBTUVXT1JLX1BBVEh9ID0gIllFUyI7CisKKyAgICBzZXRVcEd1YXJkTWFs
bG9jSWZOZWVkZWQoKTsKKwogICAgIGlmIChkZWZpbmVkKCR1c2VPcGVuQ29tbWFuZCkgJiYgJHVz
ZU9wZW5Db21tYW5kID09IFVTRV9PUEVOX0NPTU1BTkQpIHsKICAgICAgICAgcmV0dXJuIHN5c3Rl
bSgib3BlbiIsICItVyIsICItYSIsICRhcHBQYXRoLCAiLS1hcmdzIiwgYXJndW1lbnRzRm9yUnVu
QW5kRGVidWdNYWNXZWJLaXRBcHAoKSk7CiAgICAgfQpAQCAtMjUyMSw2ICsyNTUyLDkgQEAgc3Vi
IGV4ZWNNYWNXZWJLaXRBcHBGb3JEZWJ1Z2dpbmcoJCkKICAgICBteSAkcHJvZHVjdERpciA9IHBy
b2R1Y3REaXIoKTsKICAgICAkRU5We0RZTERfRlJBTUVXT1JLX1BBVEh9ID0gJHByb2R1Y3REaXI7
CiAgICAgJEVOVntXRUJLSVRfVU5TRVRfRFlMRF9GUkFNRVdPUktfUEFUSH0gPSAiWUVTIjsKKwor
ICAgIHNldFVwR3VhcmRNYWxsb2NJZk5lZWRlZCgpOworCiAgICAgbXkgQGFyY2hpdGVjdHVyZUZs
YWdzID0gKCItYXJjaCIsIGFyY2hpdGVjdHVyZSgpKTsKICAgICBpZiAoIXNob3VsZFRhcmdldFdl
YlByb2Nlc3MoKSkgewogICAgICAgICBwcmludCAiU3RhcnRpbmcgQHtbYmFzZW5hbWUoJGFwcFBh
dGgpXX0gdW5kZXIgZ2RiIHdpdGggRFlMRF9GUkFNRVdPUktfUEFUSCBzZXQgdG8gcG9pbnQgdG8g
YnVpbHQgV2ViS2l0IGluICRwcm9kdWN0RGlyLlxuIjsKQEAgLTI1MjksNyArMjU2Myw4IEBAIHN1
YiBleGVjTWFjV2ViS2l0QXBwRm9yRGVidWdnaW5nKCQpCiAgICAgICAgIG15ICR3ZWJQcm9jZXNz
U2hpbVBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCRwcm9kdWN0RGlyLCAiV2ViUHJvY2Vzc1No
aW0uZHlsaWIiKTsKICAgICAgICAgbXkgJHdlYlByb2Nlc3NQYXRoID0gRmlsZTo6U3BlYy0+Y2F0
ZGlyKCRwcm9kdWN0RGlyLCAiV2ViUHJvY2Vzcy5hcHAiKTsKICAgICAgICAgbXkgJHdlYktpdDJF
eGVjdXRhYmxlUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJHByb2R1Y3REaXIsICJXZWJLaXQy
LmZyYW1ld29yayIsICJXZWJLaXQyIik7Ci0gICAgICAgICRFTlZ7RFlMRF9JTlNFUlRfTElCUkFS
SUVTfSA9ICR3ZWJQcm9jZXNzU2hpbVBhdGg7CisKKyAgICAgICAgYXBwZW5kVG9FbnZpcm9ubWVu
dFZhcmlhYmxlTGlzdCgiRFlMRF9JTlNFUlRfTElCUkFSSUVTIiwgJHdlYlByb2Nlc3NTaGltUGF0
aCk7CiAKICAgICAgICAgcHJpbnQgIlN0YXJ0aW5nIFdlYlByb2Nlc3MgdW5kZXIgZ2RiIHdpdGgg
RFlMRF9GUkFNRVdPUktfUEFUSCBzZXQgdG8gcG9pbnQgdG8gYnVpbHQgV2ViS2l0IGluICRwcm9k
dWN0RGlyLlxuIjsKICAgICAgICAgZXhlYyB7ICRnZGJQYXRoIH0gJGdkYlBhdGgsIEBhcmNoaXRl
Y3R1cmVGbGFncywgIi0tYXJncyIsICR3ZWJQcm9jZXNzUGF0aCwgJHdlYktpdDJFeGVjdXRhYmxl
UGF0aCwgIi10eXBlIiwgIndlYnByb2Nlc3MiLCAiLWNsaWVudC1leGVjdXRhYmxlIiwgJGFwcFBh
dGggb3IgZGllOwo=
</data>
<flag name="review"
          id="147744"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>