86271 2012-05-11 16:15:52 -0700 [chromium] Port a WebView test from test_shell_tests to webkit_unit_tests 2012-05-11 20:06:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony abarth jamesr ojan webkit.review.bot oldest_to_newest 622089 0 tony 2012-05-11 16:15:52 -0700 [chromium] Port a WebView test from test_shell_tests to webkit_unit_tests 622090 1 141523 tony 2012-05-11 16:16:29 -0700 Created attachment 141523 Patch 622091 2 141523 jamesr 2012-05-11 16:18:13 -0700 Comment on attachment 141523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141523&action=review > Source/WebKit/chromium/ChangeLog:3 > + [chromium] Port a WebView test from test_shell_tests to webkit_unit_tests might be useful to say which test you're porting right here, so people don't have to guess 622096 3 141524 tony 2012-05-11 16:22:23 -0700 Created attachment 141524 Patch for landing 622214 4 141524 webkit.review.bot 2012-05-11 20:06:04 -0700 Comment on attachment 141524 Patch for landing Clearing flags on attachment: 141524 Committed r116836: <http://trac.webkit.org/changeset/116836> 622215 5 webkit.review.bot 2012-05-11 20:06:08 -0700 All reviewed patches have been landed. Closing bug. 141523 2012-05-11 16:16:29 -0700 2012-05-11 16:22:19 -0700 Patch bug-86271-20120511161628.patch text/plain 1930 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGIzNzNmZjFjMGI2OTRmNDdjY2FlZjE4ZjkwMjMzOTY4ZmFjZjA4NjAuLjBmNzAyYWI5Y2RhN2Rk OWRjOTI4ZGJmZjJiMGZjM2VlY2Q0OTdmZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMTEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KKworICAgICAgICBbY2hyb21pdW1dIFBvcnQgYSBXZWJWaWV3IHRlc3QgZnJvbSB0ZXN0X3No ZWxsX3Rlc3RzIHRvIHdlYmtpdF91bml0X3Rlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjI3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBvcmlnaW5hbCB0ZXN0IGlzIGluIHNyYy93ZWJraXQv Z2x1ZS93ZWJ2aWV3X3VuaXR0ZXN0LmNjLgorCisgICAgICAgICogdGVzdHMvV2ViVmlld1Rlc3Qu Y3BwOgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgorICAgICAgICAoV2ViS2l0KToKKwogMjAx Mi0wNS0xMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExNjcyNy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9XZWJWaWV3VGVzdC5jcHAKaW5kZXggNDYwYzYyYmQyOGE4NDNiNTczOGUw MWM0OWRmMzgyMzdmZDQ2MjRkNC4uYWVmNWM5NGNlYWFiYjEwNDAyYTY4MmFlMmFhYWYxZmVlNGZk YzAwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJWaWV3VGVz dC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJWaWV3VGVzdC5jcHAK QEAgLTE0Myw2ICsxNDMsMjUgQEAgVEVTVF9GKFdlYlZpZXdUZXN0LCBGb2N1c0lzSW5hY3RpdmUp CiAgICAgd2ViVmlldy0+Y2xvc2UoKTsKIH0KIAorVEVTVF9GKFdlYlZpZXdUZXN0LCBBY3RpdmVT dGF0ZSkKK3sKKyAgICBGcmFtZVRlc3RIZWxwZXJzOjpyZWdpc3Rlck1vY2tlZFVSTExvYWQobV9i YXNlVVJMLCAidmlzaWJsZV9pZnJhbWUuaHRtbCIpOworICAgIFdlYlZpZXcqIHdlYlZpZXcgPSBG cmFtZVRlc3RIZWxwZXJzOjpjcmVhdGVXZWJWaWV3QW5kTG9hZChtX2Jhc2VVUkwgKyAidmlzaWJs ZV9pZnJhbWUuaHRtbCIpOworCisgICAgQVNTRVJUX1RSVUUod2ViVmlldyk7CisKKyAgICB3ZWJW aWV3LT5zZXRJc0FjdGl2ZSh0cnVlKTsKKyAgICBFWFBFQ1RfVFJVRSh3ZWJWaWV3LT5pc0FjdGl2 ZSgpKTsKKworICAgIHdlYlZpZXctPnNldElzQWN0aXZlKGZhbHNlKTsKKyAgICBFWFBFQ1RfRkFM U0Uod2ViVmlldy0+aXNBY3RpdmUoKSk7CisKKyAgICB3ZWJWaWV3LT5zZXRJc0FjdGl2ZSh0cnVl KTsKKyAgICBFWFBFQ1RfVFJVRSh3ZWJWaWV3LT5pc0FjdGl2ZSgpKTsKKworICAgIHdlYlZpZXct PmNsb3NlKCk7Cit9CisKIHZvaWQgV2ViVmlld1Rlc3Q6OnRlc3RBdXRvUmVzaXplKGNvbnN0IFdl YlNpemUmIG1pbkF1dG9SZXNpemUsIGNvbnN0IFdlYlNpemUmIG1heEF1dG9SZXNpemUsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdGQ6OnN0cmluZyYgcGFnZVdpZHRo LCBjb25zdCBzdGQ6OnN0cmluZyYgcGFnZUhlaWdodCwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGludCBleHBlY3RlZFdpZHRoLCBpbnQgZXhwZWN0ZWRIZWlnaHQsCg== 141524 2012-05-11 16:22:23 -0700 2012-05-11 20:06:04 -0700 Patch for landing bug-86271-20120511162222.patch text/plain 1945 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGIzNzNmZjFjMGI2OTRmNDdjY2FlZjE4ZjkwMjMzOTY4ZmFjZjA4NjAuLjY2ZDEzZjgwNWZhNDcz ODQzOTU2ZWRiYTg2NzZiMDJiNWRjNmUwMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMTEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KKworICAgICAgICBbY2hyb21pdW1dIFBvcnQgZ3Rlc3QgV2ViVmlld1Rlc3QuQWN0aXZlU3Rh dGUgZnJvbSB0ZXN0X3NoZWxsX3Rlc3RzIHRvIHdlYmtpdF91bml0X3Rlc3RzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjI3MQorCisgICAgICAgIFJl dmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgorCisgICAgICAgIFRoZSBvcmlnaW5hbCB0ZXN0IGlz IGluIHNyYy93ZWJraXQvZ2x1ZS93ZWJ2aWV3X3VuaXR0ZXN0LmNjLgorCisgICAgICAgICogdGVz dHMvV2ViVmlld1Rlc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgorICAgICAgICAo V2ViS2l0KToKKwogMjAxMi0wNS0xMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExNjcyNy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJWaWV3VGVzdC5jcHAKaW5kZXggNDYwYzYy YmQyOGE4NDNiNTczOGUwMWM0OWRmMzgyMzdmZDQ2MjRkNC4uYWVmNWM5NGNlYWFiYjEwNDAyYTY4 MmFlMmFhYWYxZmVlNGZkYzAwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9XZWJWaWV3VGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9X ZWJWaWV3VGVzdC5jcHAKQEAgLTE0Myw2ICsxNDMsMjUgQEAgVEVTVF9GKFdlYlZpZXdUZXN0LCBG b2N1c0lzSW5hY3RpdmUpCiAgICAgd2ViVmlldy0+Y2xvc2UoKTsKIH0KIAorVEVTVF9GKFdlYlZp ZXdUZXN0LCBBY3RpdmVTdGF0ZSkKK3sKKyAgICBGcmFtZVRlc3RIZWxwZXJzOjpyZWdpc3Rlck1v Y2tlZFVSTExvYWQobV9iYXNlVVJMLCAidmlzaWJsZV9pZnJhbWUuaHRtbCIpOworICAgIFdlYlZp ZXcqIHdlYlZpZXcgPSBGcmFtZVRlc3RIZWxwZXJzOjpjcmVhdGVXZWJWaWV3QW5kTG9hZChtX2Jh c2VVUkwgKyAidmlzaWJsZV9pZnJhbWUuaHRtbCIpOworCisgICAgQVNTRVJUX1RSVUUod2ViVmll dyk7CisKKyAgICB3ZWJWaWV3LT5zZXRJc0FjdGl2ZSh0cnVlKTsKKyAgICBFWFBFQ1RfVFJVRSh3 ZWJWaWV3LT5pc0FjdGl2ZSgpKTsKKworICAgIHdlYlZpZXctPnNldElzQWN0aXZlKGZhbHNlKTsK KyAgICBFWFBFQ1RfRkFMU0Uod2ViVmlldy0+aXNBY3RpdmUoKSk7CisKKyAgICB3ZWJWaWV3LT5z ZXRJc0FjdGl2ZSh0cnVlKTsKKyAgICBFWFBFQ1RfVFJVRSh3ZWJWaWV3LT5pc0FjdGl2ZSgpKTsK KworICAgIHdlYlZpZXctPmNsb3NlKCk7Cit9CisKIHZvaWQgV2ViVmlld1Rlc3Q6OnRlc3RBdXRv UmVzaXplKGNvbnN0IFdlYlNpemUmIG1pbkF1dG9SZXNpemUsIGNvbnN0IFdlYlNpemUmIG1heEF1 dG9SZXNpemUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdGQ6OnN0 cmluZyYgcGFnZVdpZHRoLCBjb25zdCBzdGQ6OnN0cmluZyYgcGFnZUhlaWdodCwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGludCBleHBlY3RlZFdpZHRoLCBpbnQgZXhwZWN0ZWRI ZWlnaHQsCg==