86266 2012-05-11 15:50:33 -0700 r112643/r116697 break Webview form input fields 2012-05-21 14:10:55 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 1 mmerritt bdakin ap bdakin cmhofman eric jonlee mitz nick sam sfalken webkit.review.bot oldest_to_newest 622055 0 mmerritt 2012-05-11 15:50:33 -0700 The updates realeased by Apple on 5/9/12 - 5/10/12 for Snow Leopard (OS X 10.6.8) and Lion (OS X 10.7.4) appear to include changes to Safari/Webkit that breaks some Webview form input fields. The fields display as black on black, making them unusable. It only appears to affect input fields of type "text" and type "password". Here's a couple of similar (but not necessarily identical) bug reports: https://jamfnation.jamfsoftware.com/discussion.html?id=4423&postid=21536 http://code.google.com/p/leopard-webkit/issues/detail?id=1 https://bugs.webkit.org/show_bug.cgi?id=75860 What we've found is that this can be worked around by injecting javascript into downloaded frames that sets the opacity of the affected input fields to 90+ percent. (100 percent makes them black, which is the problem). You can also accomplish the same goal by using a user stylesheet override in WebPreferences. Finally, enabling Core Animation for the Webview seems to fix the problem as well, but last we heard that was specifically unsupported. 623378 1 ap 2012-05-14 15:24:40 -0700 Thank you for filing this bug! Does this happen for you when using WebKit nightlies from <http://nightly.webkit.org>? If it does not, this is most likely not an issue with webkit.org code, and it needs to be reported to Apple directly via <http://bugrepoer.apple.com>. 623380 2 bdakin 2012-05-14 15:26:25 -0700 Sounds like <rdar://problem/11400430> 623387 3 ap 2012-05-14 15:33:10 -0700 May be duplicate of bug 82131. 625850 4 nick 2012-05-16 14:09:03 -0700 I have seen this with the Google home page or my site with WebKit 534.57.2 (installed as part of Safari 5.1.7 on Mac OS X 10.6.8 and Mac OS X 10.7.4) and with r117340 of the WebKit source. I have reported the issue at bugreporter.apple.com as <rdar://problem/11467914> 625854 5 bdakin 2012-05-16 14:11:19 -0700 (In reply to comment #4) > I have seen this with the Google home page or my site with WebKit 534.57.2 (installed as part of Safari 5.1.7 on Mac OS X 10.6.8 and Mac OS X 10.7.4) and with r117340 of the WebKit source. > > I have reported the issue at bugreporter.apple.com as <rdar://problem/11467914> Hi Nick, if you still have the Cocoa app that you made, can you attach it to <rdar://problem/11467914>? 625860 6 nick 2012-05-16 14:16:08 -0700 (In reply to comment #5) > Hi Nick, if you still have the Cocoa app that you made, can you attach it to <rdar://problem/11467914>? @Beth: Done. Let me know if I can help in any way. 625867 7 nick 2012-05-16 14:23:26 -0700 Internal testing has also see the problem with Safari: 5.1.6 (7534.56.5) running on Mac OS X 10.7.4 625890 8 bdakin 2012-05-16 14:57:37 -0700 Thanks Nick! I have actually not been able to reproduce the bug on my machine running the same OS and the same version of Safari. I also tried on a colleague's machine and didn't see the bug. Can you think of any system or user settings that you might have that are non-standard? I'm just trying to find a common thread here of configurations that exhibit the bug. 625893 9 nick 2012-05-16 15:00:32 -0700 (In reply to comment #8) > Can you think of any system or user settings that you might have that are non-standard? Not really. As you can see with the test application it is very simple. Are there any preference files that you might find useful? Certainly I have been able to reproduce it in very minimally changes Lion VMware VMs too. If necessary I can try a clean Lion install (+ updates) in VMware to see if that reproduces the issue. 626066 10 bdakin 2012-05-16 17:37:18 -0700 I was able to find an instance in FileMaker Pro that I can reproduce on my machine. I don't know why I can't reproduce it more widely…that may have to do with different graphics cards or something. Anyway, I have a patch that fixes the FileMaker case I can reproduce. I will post it shortly. 626072 11 142380 bdakin 2012-05-16 17:45:19 -0700 Created attachment 142380 Patch 626122 12 142380 mjs 2012-05-16 18:38:16 -0700 Comment on attachment 142380 Patch Test case? 626190 13 bdakin 2012-05-16 20:20:59 -0700 (In reply to comment #12) > (From update of attachment 142380 [details]) > Test case? A DRT/WKT test case will not work since this bug does not reproduce in Safari or either of those environments either…we would see it in existing tests if it did. This also does not reproduce on my computer with a simple WebKit app. I have only been able to see the bug in FileMaker. I don't think there is a way to test thing in any of our current automated test systems. 626249 14 142380 mitz 2012-05-16 22:01:09 -0700 Comment on attachment 142380 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142380&action=review > Source/WebCore/ChangeLog:4 > + 5/10/12 update to Snow Leopard and Lion breaks Webview form input fields Please use either the subversion revision where this bug was introduced (it might be a revision committed to a branch) or at the very least the Safari version number where the bug first appeared (5.1.6). > Source/WebCore/ChangeLog:15 > + 5/10/12 update. Un-styled text fields will still use NSTextFieldCell on these Again, please just refer to revision numbers or Safari versions. > Source/WebCore/rendering/RenderThemeMac.mm:737 > - bool useNewGradient = true; > + bool useNSTextFieldCell = true; This variable is now only used in an interesting way in Lion and Snow Leopard, so it shouldn’t exist in the common code. > Source/WebCore/rendering/RenderThemeMac.mm:751 > + // We do not use NSTextFieldCell to draw styled text fields on Lion and SnowLeopard because > + // there are a number of bugs on those platforms that require NSTextFieldCell to be in charge > + // of painting its own background. We need WebCore to paint styled backgrounds, so we'll use > + // this WebCoreSystemInterface function instead. > + if (!useNSTextFieldCell) { > + wkDrawBezeledTextFieldCell(r, isEnabled(o) && !isReadOnlyControl(o)); > + return false; > + } This code is also specific to Lion and Snow Leopard, so it should be in the #if block for those platforms. > Source/WebCore/rendering/RenderThemeMac.mm:753 > + NSTextFieldCell* textField = this->textField(); Star on the wrong side of the space. 626250 15 142380 mitz 2012-05-16 22:02:02 -0700 Comment on attachment 142380 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142380&action=review > Source/WebCore/rendering/RenderThemeMac.mm:2183 > + // Post-Lion, WebCore can be in charnge of paintinng the background thanks to Typo: charnge 626703 16 142503 bdakin 2012-05-17 10:46:13 -0700 Created attachment 142503 Updated patch Thanks Dan! Here is a patch that addresses all of your comments. 626708 17 142503 bdakin 2012-05-17 10:49:01 -0700 Comment on attachment 142503 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=142503&action=review > Source/WebCore/ChangeLog:21 > + behavior for MountainLion. Oops, forgot to include the URL for this change. I have added it to my local copy. It's http://trac.webkit.org/changeset/116697 , for reference. 626967 18 nick 2012-05-17 14:15:53 -0700 (In reply to comment #11) I tried my test application with svn r117453 which from everything I can tell includes the patch and it _didn't_ fix the bug. I then started hacking on RenderThemeMac.mm and noticed: line 2167: NSTextFieldCell* RenderThemeMac::textField(bool useNewGradient) const useNewGradient is always false on my Mac and therefore line 2199 is used: [m_textField.get() setBackgroundColor:[NSColor clearColor]]; given that changing the opacity fixes this issue (as per comment #1) is it possible that the line 2197: [m_textField.get() setBackgroundColor:[NSColor whiteColor]]; should be used instead? Certainly if I hack the method and set useNewGradient to true then it works for me. I am also somewhat concerned about a line of code in RenderThemeMac::paintTextField(), line 740: useNewGradient = WebCore::deviceScaleFactor(o->frame()) != 1; isn't comparing a float (WebCore::deviceScaleFactor returns a float) against 1 (int) a bad idea? Also, after looking at Comment #10: > that may have to do with different graphics cards or something I tried my test application on both of the available graphics cards in my MacBookPro5,2. The problem occurs on both the integrated NVIDIA GeForce 9400M and the discrete NVIDIA GeForce 9600M GT. Hope this helps. 626979 19 mitz 2012-05-17 14:23:29 -0700 (In reply to comment #18) > (In reply to comment #11) > > I tried my test application with svn r117453 which from everything I can tell includes the patch and it _didn't_ fix the bug. Thanks for testing! This bug is still not in status FIXED, and there’s nothing here indicating the the patch was committed. > > I then started hacking on RenderThemeMac.mm and noticed: > > line 2167: > NSTextFieldCell* RenderThemeMac::textField(bool useNewGradient) const > > useNewGradient is always false on my Mac and therefore line 2199 is used: > > [m_textField.get() setBackgroundColor:[NSColor clearColor]]; > > given that changing the opacity fixes this issue (as per comment #1) is it possible that the line 2197: > > [m_textField.get() setBackgroundColor:[NSColor whiteColor]]; > > should be used instead? Certainly if I hack the method and set useNewGradient to true then it works for me. Using a white background color would break text fields that specify a non-default background color. > > I am also somewhat concerned about a line of code in RenderThemeMac::paintTextField(), line 740: > > useNewGradient = WebCore::deviceScaleFactor(o->frame()) != 1; > > isn't comparing a float (WebCore::deviceScaleFactor returns a float) against 1 (int) a bad idea? The compiler treats the right hand side as a floating point constant, and will compare a float to a float. The WebKit coding style guideline is to omit the unnecessary “.f” suffix in cases like this. 627002 20 nick 2012-05-17 14:45:55 -0700 (In reply to comment #19) > Thanks for testing! This bug is still not in status FIXED, and there’s nothing here indicating the the patch was committed. I apologize for not having a full understanding of how WebKit development works. I assumed (incorrectly) that the patch had been applied to /trunk. > Using a white background color would break text fields that specify a non-default background color. I manually applied the patch (which does not have useNewGradient parameter) to my local copy of WebKit and it calls [m_textField.get() setBackgroundColor:[NSColor whiteColor]]; so it does work for me. > The compiler treats the right hand side as a floating point constant, and will compare a float to a float. The WebKit coding style guideline is to omit the unnecessary “.f” suffix in cases like this. Thanks for the explanation. Given I had never looked at the WebKit source until yesterday I should have never questioned this. Hopefully, the fact that I have confirmed that the patch does work (for me) helps. If you would prefer me to back off just let me know. 627010 21 bdakin 2012-05-17 14:55:23 -0700 (In reply to comment #20) > (In reply to comment #19) > > Thanks for testing! This bug is still not in status FIXED, and there’s nothing here indicating the the patch was committed. > > I apologize for not having a full understanding of how WebKit development works. I assumed (incorrectly) that the patch had been applied to /trunk. > No worries! I am about to work on committing it now. > > Using a white background color would break text fields that specify a non-default background color. > > I manually applied the patch (which does not have useNewGradient parameter) to my local copy of WebKit and it calls > > [m_textField.get() setBackgroundColor:[NSColor whiteColor]]; > > so it does work for me. > Yay! > > The compiler treats the right hand side as a floating point constant, and will compare a float to a float. The WebKit coding style guideline is to omit the unnecessary “.f” suffix in cases like this. > > Thanks for the explanation. Given I had never looked at the WebKit source until yesterday I should have never questioned this. > > Hopefully, the fact that I have confirmed that the patch does work (for me) helps. If you would prefer me to back off just let me know. No, this is very helpful!! Thank you for confirming!! Many people who reported this bug have nvidia graphics cards, so I do suspect that for whatever reason, those cards are more likely to exhibit the bug. I have an Intel graphics card, and I have still only ever seen the bug in FileMaker, not in your test app. Anyway! Will commit shortly. Thanks for the review, Dan! 627014 22 bdakin 2012-05-17 14:58:47 -0700 Committed patch with http://trac.webkit.org/changeset/117502 629452 23 cmhofman 2012-05-21 13:47:28 -0700 Is this really fixed? Looming at the patch, I doubt it very much. Is it clear what the real problem is? The problem is that when developing with the 10.5 SDK setting a clear background color is rendered as black, because that SDK will use NSCompositeCopy to draw instead of NSCompositeSourceOver. However, this really depends on the SDK that is used for the app that uses WebKit, it is NOT related to the SDK that is used to compile the WebKit libraries itself. Therefore checking the macros (at compile time for WebKit), as in the patch, won't work. 629470 24 ap 2012-05-21 13:56:48 -0700 *** Bug 86895 has been marked as a duplicate of this bug. *** 629480 25 bdakin 2012-05-21 14:10:55 -0700 (In reply to comment #23) > Is this really fixed? Looming at the patch, I doubt it very much. Is it clear what the real problem is? The problem is that when developing with the 10.5 SDK setting a clear background color is rendered as black, because that SDK will use NSCompositeCopy to draw instead of NSCompositeSourceOver. However, this really depends on the SDK that is used for the app that uses WebKit, it is NOT related to the SDK that is used to compile the WebKit libraries itself. Therefore checking the macros (at compile time for WebKit), as in the patch, won't work. Christiaan, have you actually tested the patch or are you just guessing that this is not fixed? I have verified that this patch fixes FileMaker and Nick has verified that is has fixed his applications. If you know that this bug still occurs, please give concrete steps about how to reproduce with with the latest tip of tree build of WebKit. 142380 2012-05-16 17:45:19 -0700 2012-05-17 10:46:13 -0700 Patch for-review.txt text/plain 5959 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzM2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA1LTE2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODYyNjYKKyAgICAgICAgNS8xMC8xMiB1cGRhdGUgdG8gU25vdyBM ZW9wYXJkIGFuZCBMaW9uIGJyZWFrcyBXZWJ2aWV3IGZvcm0gaW5wdXQgZmllbGRzCisgICAgICAg IC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExNDAwNDMwPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY29k ZSB3YXMgdXNpbmcgTlNUZXh0RmllbGRDZWxsIHdpdGggYSBjbGVhciBiYWNrZ3JvdW5kIGZvciBh bGwgdGV4dCBmaWVsZHMgCisgICAgICAgIHdoZW4gdGhlIGRldmljZSBzY2FsZSBmYWN0b3IgaXMg MXguIFRoZSBjbGVhciBiYWNrZ3JvdW5kIGlzIGRlZmluaXRlbHkgY2F1c2luZyB0aGUgCisgICAg ICAgIHByb2JsZW0uIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGJ1ZyBieSB1c2luZyBhbiBvbGQgV2Vi Q29yZVN5c3RlbUludGVyZmFjZSBmdW5jdGlvbiAKKyAgICAgICAgdG8gcGFpbnQgYWxsIHRleHQg ZmllbGRzIG9uIExpb24gYW5kIFNub3dMZW9wYXJkIHRoYXQgYXJlIHN0eWxlZC4gVGhpcyBpcyB3 aGF0IHdlIAorICAgICAgICB1c2VkIHRvIHBhaW50IGFsbCB0ZXh0IGZpZWxkcyBpbiB0aGUgdmVy c2lvbiBvZiBTYWZhcmkgdGhhdCB3b3JrZWQgYmVmb3JlIHRoZSAKKyAgICAgICAgNS8xMC8xMiB1 cGRhdGUuIFVuLXN0eWxlZCB0ZXh0IGZpZWxkcyB3aWxsIHN0aWxsIHVzZSBOU1RleHRGaWVsZENl bGwgb24gdGhlc2UgCisgICAgICAgIHBsYXRmb3JtcywgYnV0IHdpdGggYSBoYXJkY29kZWQgd2hp dGUgYmFja2dyb3VuZC4gCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmg6Cisg ICAgICAgIChSZW5kZXJUaGVtZU1hYyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1l TWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVNYWM6OnBhaW50VGV4dEZpZWxk KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjp0ZXh0RmllbGQpOgorCiAyMDEy LTA1LTE2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUg c2hvd1N0eWxlIGZyb20gQ1NTU3R5bGVEZWNsYXJhdGlvbiB0byBTdHlsZVByb3BlcnR5U2V0Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMuaAkocmV2aXNpb24g MTE3MzA4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgJKHdv cmtpbmcgY29weSkKQEAgLTIxOSw3ICsyMTksNyBAQCBwcml2YXRlOgogICAgIE5TTWVudSogc2Vh cmNoTWVudVRlbXBsYXRlKCkgY29uc3Q7CiAgICAgTlNTbGlkZXJDZWxsKiBzbGlkZXJUaHVtYkhv cml6b250YWwoKSBjb25zdDsKICAgICBOU1NsaWRlckNlbGwqIHNsaWRlclRodW1iVmVydGljYWwo KSBjb25zdDsKLSAgICBOU1RleHRGaWVsZENlbGwqIHRleHRGaWVsZChib29sIHVzZU5ld0dyYWRp ZW50KSBjb25zdDsKKyAgICBOU1RleHRGaWVsZENlbGwqIHRleHRGaWVsZCgpIGNvbnN0OwogCiAj aWYgRU5BQkxFKE1FVEVSX1RBRykKICAgICBOU0xldmVsSW5kaWNhdG9yU3R5bGUgbGV2ZWxJbmRp Y2F0b3JTdHlsZUZvcihDb250cm9sUGFydCkgY29uc3Q7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCShyZXZpc2lvbiAxMTczMDgpCisrKyBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTcz NCwxOCArNzM0LDIzIEBAIGJvb2wgUmVuZGVyVGhlbWVNYWM6OnBhaW50VGV4dEZpZWxkKFJlbmQK IHsKICAgICBMb2NhbEN1cnJlbnRHcmFwaGljc0NvbnRleHQgbG9jYWxDb250ZXh0KHBhaW50SW5m by5jb250ZXh0KTsKIAotICAgIGJvb2wgdXNlTmV3R3JhZGllbnQgPSB0cnVlOworICAgIGJvb2wg dXNlTlNUZXh0RmllbGRDZWxsID0gdHJ1ZTsKICNpZiBkZWZpbmVkKEJVSUxESU5HX09OX0xJT04p IHx8IGRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQotICAgIC8vIFNlZSBjb21tZW50 IGluIFJlbmRlclRoZW1lTWFjOjp0ZXh0RmllbGQoKSBmb3IgYSBjb21wbGV0ZSBleHBsYW5hdGlv biBvZiB0aGlzLgotICAgIHVzZU5ld0dyYWRpZW50ID0gV2ViQ29yZTo6ZGV2aWNlU2NhbGVGYWN0 b3Ioby0+ZnJhbWUoKSkgIT0gMTsKLSAgICBpZiAodXNlTmV3R3JhZGllbnQpIHsKLSAgICAgICAg dXNlTmV3R3JhZGllbnQgPSBvLT5zdHlsZSgpLT5oYXNBcHBlYXJhbmNlKCkKLSAgICAgICAgICAg ICYmIG8tPnN0eWxlKCktPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUJhY2tncm91 bmRDb2xvcikgPT0gQ29sb3I6OndoaXRlCi0gICAgICAgICAgICAmJiAhby0+c3R5bGUoKS0+aGFz QmFja2dyb3VuZEltYWdlKCk7Ci0gICAgfQorICAgIHVzZU5TVGV4dEZpZWxkQ2VsbCA9IG8tPnN0 eWxlKCktPmhhc0FwcGVhcmFuY2UoKQorICAgICAgICAmJiBvLT5zdHlsZSgpLT52aXNpdGVkRGVw ZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3IpID09IENvbG9yOjp3aGl0ZQor ICAgICAgICAmJiAhby0+c3R5bGUoKS0+aGFzQmFja2dyb3VuZEltYWdlKCk7CiAjZW5kaWYKIAot ICAgIE5TVGV4dEZpZWxkQ2VsbCogdGV4dEZpZWxkID0gdGhpcy0+dGV4dEZpZWxkKHVzZU5ld0dy YWRpZW50KTsKKyAgICAvLyBXZSBkbyBub3QgdXNlIE5TVGV4dEZpZWxkQ2VsbCB0byBkcmF3IHN0 eWxlZCB0ZXh0IGZpZWxkcyBvbiBMaW9uIGFuZCBTbm93TGVvcGFyZCBiZWNhdXNlCisgICAgLy8g dGhlcmUgYXJlIGEgbnVtYmVyIG9mIGJ1Z3Mgb24gdGhvc2UgcGxhdGZvcm1zIHRoYXQgcmVxdWly ZSBOU1RleHRGaWVsZENlbGwgdG8gYmUgaW4gY2hhcmdlCisgICAgLy8gb2YgcGFpbnRpbmcgaXRz IG93biBiYWNrZ3JvdW5kLiBXZSBuZWVkIFdlYkNvcmUgdG8gcGFpbnQgc3R5bGVkIGJhY2tncm91 bmRzLCBzbyB3ZSdsbCB1c2UKKyAgICAvLyB0aGlzIFdlYkNvcmVTeXN0ZW1JbnRlcmZhY2UgZnVu Y3Rpb24gaW5zdGVhZC4KKyAgICBpZiAoIXVzZU5TVGV4dEZpZWxkQ2VsbCkgeworICAgICAgICB3 a0RyYXdCZXplbGVkVGV4dEZpZWxkQ2VsbChyLCBpc0VuYWJsZWQobykgJiYgIWlzUmVhZE9ubHlD b250cm9sKG8pKTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKworICAgIE5TVGV4dEZp ZWxkQ2VsbCogdGV4dEZpZWxkID0gdGhpcy0+dGV4dEZpZWxkKCk7CiAKICAgICBHcmFwaGljc0Nv bnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIoKnBhaW50SW5mby5jb250ZXh0KTsKIApAQCAtMjE2 NCw3ICsyMTY5LDcgQEAgTlNTbGlkZXJDZWxsKiBSZW5kZXJUaGVtZU1hYzo6c2xpZGVyVGh1bQog ICAgIHJldHVybiBtX3NsaWRlclRodW1iVmVydGljYWwuZ2V0KCk7CiB9CiAKLU5TVGV4dEZpZWxk Q2VsbCogUmVuZGVyVGhlbWVNYWM6OnRleHRGaWVsZChib29sIHVzZU5ld0dyYWRpZW50KSBjb25z dAorTlNUZXh0RmllbGRDZWxsKiBSZW5kZXJUaGVtZU1hYzo6dGV4dEZpZWxkKCkgY29uc3QKIHsK ICAgICBpZiAoIW1fdGV4dEZpZWxkKSB7CiAgICAgICAgIG1fdGV4dEZpZWxkLmFkb3B0TlMoW1tX ZWJDb3JlVGV4dEZpZWxkQ2VsbCBhbGxvY10gaW5pdFRleHRDZWxsOkAiIl0pOwpAQCAtMjE3Mywy NyArMjE3OCwxNSBAQCBOU1RleHRGaWVsZENlbGwqIFJlbmRlclRoZW1lTWFjOjp0ZXh0RmllCiAg ICAgICAgIFttX3RleHRGaWVsZC5nZXQoKSBzZXRGb2N1c1JpbmdUeXBlOk5TRm9jdXNSaW5nVHlw ZUV4dGVyaW9yXTsKICNpZiBkZWZpbmVkKEJVSUxESU5HX09OX0xJT04pIHx8IGRlZmluZWQoQlVJ TERJTkdfT05fU05PV19MRU9QQVJEKQogICAgICAgICBbbV90ZXh0RmllbGQuZ2V0KCkgc2V0RHJh d3NCYWNrZ3JvdW5kOllFU107CisgICAgICAgIFttX3RleHRGaWVsZC5nZXQoKSBzZXRCYWNrZ3Jv dW5kQ29sb3I6W05TQ29sb3Igd2hpdGVDb2xvcl1dOwogI2Vsc2UKLSAgICAgICAgVU5VU0VEX1BB UkFNKHVzZU5ld0dyYWRpZW50KTsKKyAgICAgICAgLy8gUG9zdC1MaW9uLCBXZWJDb3JlIGNhbiBi ZSBpbiBjaGFybmdlIG9mIHBhaW50aW5uZyB0aGUgYmFja2dyb3VuZCB0aGFua3MgdG8KKyAgICAg ICAgLy8gdGhlIHdvcmthcm91bmQgaW4gcGxhY2UgZm9yIDxyZGFyOi8vcHJvYmxlbS8xMTM4NTQ2 MT4sIHdoaWNoIGlzIGltcGxlbWVudGVkCisgICAgICAgIC8vIGFib3ZlIGFzIF9jb3JlVUlEcmF3 T3B0aW9uc1dpdGhGcmFtZS4KICAgICAgICAgW21fdGV4dEZpZWxkLmdldCgpIHNldERyYXdzQmFj a2dyb3VuZDpOT107CiAjZW5kaWYKICAgICB9CiAKLSNpZiBkZWZpbmVkKEJVSUxESU5HX09OX0xJ T04pIHx8IGRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQotICAgIC8vIFRoaXMgaXMg YSB3b3JrYXJvdW5kIGZvciA8cmRhcjovL3Byb2JsZW0vMTEzODU0NjE+IG9uIExpb24gYW5kIFNu b3dMZW9wYXJkLiBOZXdlciB2ZXJzaW9ucyBvZiB0aGUKLSAgICAvLyBPUyBjYW4gYWx3YXlzIHVz ZSB0aGUgbmV3ZXIgdmVyc2lvbiBvZiB0aGUgdGV4dCBmaWVsZCB3aXRoIHRoZSB3b3JrYXJvdW5k IGFib3ZlIGluCi0gICAgLy8gX2NvcmVVSURyYXdPcHRpb25zV2l0aEZyYW1lLiBXaXRoIHRoaXMg d29ya2Fyb3VuZCBmb3Igb2xkZXIgT1Mncywgd2hlbiB0aGUgZGV2aWNlU2NhbGVGYWN0b3IgaXMg MSwKLSAgICAvLyB3ZSBoYXZlIGFuIG9sZC1zY2hvb2wgZ3JhZGllbnQgYmV6ZWwgaW4gdGV4dCBm aWVsZHMgd2hldGhlciB0aGV5IGFyZSBzdHlsZWQgb3Igbm90LiBUaGlzIGlzIGZpbmUgYW5kCi0g ICAgLy8gbWF0Y2hlcyBzaGlwcGluZyBTYWZhcmkuIFdoZW4gdGhlIGRldmljZVNjYWxlRmFjdG9y IGlzIGdyZWF0ZXIgdGhhbiAxLCB0ZXh0IGZpZWxkcyB3aWxsIGhhdmUgbmV3ZXIsCi0gICAgLy8g QXBwS2l0LW1hdGNoaW5nIGdyYWRpZW50cyB0aGF0IGxvb2sgbXVjaCBtb3JlIGFwcHJvcHJpYXRl IGF0IHRoZSBoaWdoZXIgcmVzb2x1dGlvbnMuIEhvd2V2ZXIsIGlmIHRoZQotICAgIC8vIHRleHQg ZmllbGQgaXMgc3R5bGVkICBpbiBhbnkgd2F5LCB3ZSdsbCByZXZlcnQgdG8gdGhlIG9sZC1zY2hv b2wgYmV6ZWwsIHdoaWNoIGRvZXNuJ3QgbG9vayBncmVhdCBpbgotICAgIC8vIEhpRFBJLCBidXQg aXQgbG9va3MgYmV0dGVyIHRoYW4gdGhlIENTUyBib3JkZXIsIHdoaWNoIGlzIHRoZSBvbmx5IGFs dGVybmF0aXZlIHVudGlsIDExMzg1NDYxIGlzIHJlc29sdmVkLgotICAgIGlmICh1c2VOZXdHcmFk aWVudCkKLSAgICAgICAgW21fdGV4dEZpZWxkLmdldCgpIHNldEJhY2tncm91bmRDb2xvcjpbTlND b2xvciB3aGl0ZUNvbG9yXV07Ci0gICAgZWxzZQotICAgICAgICBbbV90ZXh0RmllbGQuZ2V0KCkg c2V0QmFja2dyb3VuZENvbG9yOltOU0NvbG9yIGNsZWFyQ29sb3JdXTsKLSNlbmRpZgotCiAgICAg cmV0dXJuIG1fdGV4dEZpZWxkLmdldCgpOwogfQogCg== 142503 2012-05-17 10:46:13 -0700 2012-05-17 13:00:05 -0700 Updated patch for-review-2.txt text/plain 6571 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzM2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM3IEBACisyMDEyLTA1LTE2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODYyNjYKKyAgICAgICAgcjExMjY0My9yMTE2Njk3IGJyZWFrIFdl YnZpZXcgZm9ybSBpbnB1dCBmaWVsZHMKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTE0MDA0MzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgYSByZWNlbnQgaGlzdG9yeSBvZiBjaGFu Z2VzIGluIHRoaXMgYXJlIHRoYXQgc2VlbSB3b3J0aCBkb2N1bWVudGluZy4gCisgICAgICAgIEZp cnN0IHdhcyB0aGUgY2hhbmdlIHRvIHN3aXRjaCB0byB1c2luZyBOU1RleHRGaWVsZENlbGwgdG8g ZHJhdyB0ZXh0IGZpZWxkczogCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzEwNDI0MAorCisgICAgICAgIFRoYXQgbGVkIHRvIHByb2JsZW1zIGJlY2F1c2Ugb2YgdGhl IGNsZWFyIGJhY2tncm91bmQgdGhhdCBJIHRob3VnaHQgYXQgdGhlIHRpbWUgCisgICAgICAgIHdl cmUgc3BlY2lmaWMgdG8gTW91bnRhaW5MaW9uLiBUbyBmaXggdGhhdCwgSSBtYWRlIHRoaXMgY2hh bmdlOgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMTA0ODAKKwor ICAgICAgICBCdXQgdGhhdCBjaGFuZ2UgcmVzdWx0ZWQgaW4gc3R5bGVkIHRleHQgZmllbGRzIGdl dHRpbmcgYW4gdW4tdGhlbWVkIGJvcmRlciwgd2hpY2ggCisgICAgICAgIGxlZCB0byB0aGlzIGNo YW5nZSBvbiB0aGUgYnJhbmNoOiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMTI2 NDMgYW5kIGEgCisgICAgICAgIGNoYW5nZSBvbiBUT1QgdGhhdCB3YXMgaWRlbnRpY2FsIGZvciBM aW9uIGFuZCBTbm93TGVvcGFyZCBidXQgaW50cm9kdWNlZCBuZXcgCisgICAgICAgIGJlaGF2aW9y IGZvciBNb3VudGFpbkxpb24uCisKKyAgICAgICAgQW5kIHRoYXQgYnJpbmdzIHVzIHRvIHRoaXMg YnVnLCB3aGVyZSBpdCB0dXJucyBvdXQgdGhlIGNsZWFyIGJhY2tncm91bmQgaXMgYSAKKyAgICAg ICAgcHJvYmxlbSBvbiBMaW9uIGFuZCBTbm93TGVvcGFyZCB0b28uIFRoaXMgcGF0Y2ggZml4ZXMg dGhlIGJ1ZyBieSB1c2luZyB0aGUgCisgICAgICAgIG9yaWdpbmFsIFdlYkNvcmVTeXN0ZW1JbnRl cmZhY2UgZnVuY3Rpb24gdG8gcGFpbnQgYWxsIHRleHQgZmllbGRzIG9uIExpb24gYW5kIAorICAg ICAgICBTbm93TGVvcGFyZCB0aGF0IGFyZSBzdHlsZWQuIFRoaXMgaXMgd2hhdCB3ZSB1c2VkIHRv IHBhaW50IGFsbCB0ZXh0IGZpZWxkcyBiZWZvcmUgCisgICAgICAgIHIxMDQyNDAsIHdoaWNoIGlz IHRoZSBmaXJzdCBjaGFuZ2UgbGlzdGVkIGFib3ZlLiBVbi1zdHlsZWQgdGV4dCBmaWVsZHMgd2ls bCBzdGlsbCAKKyAgICAgICAgdXNlIE5TVGV4dEZpZWxkQ2VsbCBvbiB0aGVzZSBwbGF0Zm9ybXMs IGJ1dCB3aXRoIGEgaGFyZGNvZGVkIHdoaXRlIGJhY2tncm91bmQuIAorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJUaGVtZU1hYy5oOgorICAgICAgICAoUmVuZGVyVGhlbWVNYWMpOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl clRoZW1lTWFjOjpwYWludFRleHRGaWVsZCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVt ZU1hYzo6dGV4dEZpZWxkKToKKwogMjAxMi0wNS0xNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIHNob3dTdHlsZSBmcm9tIENTU1N0eWxlRGVjbGFyYXRp b24gdG8gU3R5bGVQcm9wZXJ0eVNldApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lTWFjLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lTWFjLmgJKHJldmlzaW9uIDExNzMwOCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZU1hYy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMTksNyArMjE5LDcgQEAg cHJpdmF0ZToKICAgICBOU01lbnUqIHNlYXJjaE1lbnVUZW1wbGF0ZSgpIGNvbnN0OwogICAgIE5T U2xpZGVyQ2VsbCogc2xpZGVyVGh1bWJIb3Jpem9udGFsKCkgY29uc3Q7CiAgICAgTlNTbGlkZXJD ZWxsKiBzbGlkZXJUaHVtYlZlcnRpY2FsKCkgY29uc3Q7Ci0gICAgTlNUZXh0RmllbGRDZWxsKiB0 ZXh0RmllbGQoYm9vbCB1c2VOZXdHcmFkaWVudCkgY29uc3Q7CisgICAgTlNUZXh0RmllbGRDZWxs KiB0ZXh0RmllbGQoKSBjb25zdDsKIAogI2lmIEVOQUJMRShNRVRFUl9UQUcpCiAgICAgTlNMZXZl bEluZGljYXRvclN0eWxlIGxldmVsSW5kaWNhdG9yU3R5bGVGb3IoQ29udHJvbFBhcnQpIGNvbnN0 OwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQkocmV2 aXNpb24gMTE3MzA4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC03MzQsMTggKzczNCwyMiBAQCBib29sIFJlbmRlclRoZW1l TWFjOjpwYWludFRleHRGaWVsZChSZW5kCiB7CiAgICAgTG9jYWxDdXJyZW50R3JhcGhpY3NDb250 ZXh0IGxvY2FsQ29udGV4dChwYWludEluZm8uY29udGV4dCk7CiAKLSAgICBib29sIHVzZU5ld0dy YWRpZW50ID0gdHJ1ZTsKICNpZiBkZWZpbmVkKEJVSUxESU5HX09OX0xJT04pIHx8IGRlZmluZWQo QlVJTERJTkdfT05fU05PV19MRU9QQVJEKQotICAgIC8vIFNlZSBjb21tZW50IGluIFJlbmRlclRo ZW1lTWFjOjp0ZXh0RmllbGQoKSBmb3IgYSBjb21wbGV0ZSBleHBsYW5hdGlvbiBvZiB0aGlzLgot ICAgIHVzZU5ld0dyYWRpZW50ID0gV2ViQ29yZTo6ZGV2aWNlU2NhbGVGYWN0b3Ioby0+ZnJhbWUo KSkgIT0gMTsKLSAgICBpZiAodXNlTmV3R3JhZGllbnQpIHsKLSAgICAgICAgdXNlTmV3R3JhZGll bnQgPSBvLT5zdHlsZSgpLT5oYXNBcHBlYXJhbmNlKCkKLSAgICAgICAgICAgICYmIG8tPnN0eWxl KCktPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xvcikgPT0g Q29sb3I6OndoaXRlCi0gICAgICAgICAgICAmJiAhby0+c3R5bGUoKS0+aGFzQmFja2dyb3VuZElt YWdlKCk7CisgICAgYm9vbCB1c2VOU1RleHRGaWVsZENlbGwgPSBvLT5zdHlsZSgpLT5oYXNBcHBl YXJhbmNlKCkKKyAgICAgICAgJiYgby0+c3R5bGUoKS0+dmlzaXRlZERlcGVuZGVudENvbG9yKENT U1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKSA9PSBDb2xvcjo6d2hpdGUKKyAgICAgICAgJiYgIW8t PnN0eWxlKCktPmhhc0JhY2tncm91bmRJbWFnZSgpOworCisgICAgLy8gV2UgZG8gbm90IHVzZSBO U1RleHRGaWVsZENlbGwgdG8gZHJhdyBzdHlsZWQgdGV4dCBmaWVsZHMgb24gTGlvbiBhbmQgU25v d0xlb3BhcmQgYmVjYXVzZQorICAgIC8vIHRoZXJlIGFyZSBhIG51bWJlciBvZiBidWdzIG9uIHRo b3NlIHBsYXRmb3JtcyB0aGF0IHJlcXVpcmUgTlNUZXh0RmllbGRDZWxsIHRvIGJlIGluIGNoYXJn ZQorICAgIC8vIG9mIHBhaW50aW5nIGl0cyBvd24gYmFja2dyb3VuZC4gV2UgbmVlZCBXZWJDb3Jl IHRvIHBhaW50IHN0eWxlZCBiYWNrZ3JvdW5kcywgc28gd2UnbGwgdXNlCisgICAgLy8gdGhpcyBX ZWJDb3JlU3lzdGVtSW50ZXJmYWNlIGZ1bmN0aW9uIGluc3RlYWQuCisgICAgaWYgKCF1c2VOU1Rl eHRGaWVsZENlbGwpIHsKKyAgICAgICAgd2tEcmF3QmV6ZWxlZFRleHRGaWVsZENlbGwociwgaXNF bmFibGVkKG8pICYmICFpc1JlYWRPbmx5Q29udHJvbChvKSk7CisgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICB9CiAjZW5kaWYKIAotICAgIE5TVGV4dEZpZWxkQ2VsbCogdGV4dEZpZWxkID0gdGhp cy0+dGV4dEZpZWxkKHVzZU5ld0dyYWRpZW50KTsKKyAgICBOU1RleHRGaWVsZENlbGwgKnRleHRG aWVsZCA9IHRoaXMtPnRleHRGaWVsZCgpOwogCiAgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZl ciBzdGF0ZVNhdmVyKCpwYWludEluZm8uY29udGV4dCk7CiAKQEAgLTIxNjQsNyArMjE2OCw3IEBA IE5TU2xpZGVyQ2VsbCogUmVuZGVyVGhlbWVNYWM6OnNsaWRlclRodW0KICAgICByZXR1cm4gbV9z bGlkZXJUaHVtYlZlcnRpY2FsLmdldCgpOwogfQogCi1OU1RleHRGaWVsZENlbGwqIFJlbmRlclRo ZW1lTWFjOjp0ZXh0RmllbGQoYm9vbCB1c2VOZXdHcmFkaWVudCkgY29uc3QKK05TVGV4dEZpZWxk Q2VsbCogUmVuZGVyVGhlbWVNYWM6OnRleHRGaWVsZCgpIGNvbnN0CiB7CiAgICAgaWYgKCFtX3Rl eHRGaWVsZCkgewogICAgICAgICBtX3RleHRGaWVsZC5hZG9wdE5TKFtbV2ViQ29yZVRleHRGaWVs ZENlbGwgYWxsb2NdIGluaXRUZXh0Q2VsbDpAIiJdKTsKQEAgLTIxNzMsMjcgKzIxNzcsMTUgQEAg TlNUZXh0RmllbGRDZWxsKiBSZW5kZXJUaGVtZU1hYzo6dGV4dEZpZQogICAgICAgICBbbV90ZXh0 RmllbGQuZ2V0KCkgc2V0Rm9jdXNSaW5nVHlwZTpOU0ZvY3VzUmluZ1R5cGVFeHRlcmlvcl07CiAj aWYgZGVmaW5lZChCVUlMRElOR19PTl9MSU9OKSB8fCBkZWZpbmVkKEJVSUxESU5HX09OX1NOT1df TEVPUEFSRCkKICAgICAgICAgW21fdGV4dEZpZWxkLmdldCgpIHNldERyYXdzQmFja2dyb3VuZDpZ RVNdOworICAgICAgICBbbV90ZXh0RmllbGQuZ2V0KCkgc2V0QmFja2dyb3VuZENvbG9yOltOU0Nv bG9yIHdoaXRlQ29sb3JdXTsKICNlbHNlCi0gICAgICAgIFVOVVNFRF9QQVJBTSh1c2VOZXdHcmFk aWVudCk7CisgICAgICAgIC8vIFBvc3QtTGlvbiwgV2ViQ29yZSBjYW4gYmUgaW4gY2hhcmdlIG9m IHBhaW50aW5uZyB0aGUgYmFja2dyb3VuZCB0aGFua3MgdG8KKyAgICAgICAgLy8gdGhlIHdvcmth cm91bmQgaW4gcGxhY2UgZm9yIDxyZGFyOi8vcHJvYmxlbS8xMTM4NTQ2MT4sIHdoaWNoIGlzIGlt cGxlbWVudGVkCisgICAgICAgIC8vIGFib3ZlIGFzIF9jb3JlVUlEcmF3T3B0aW9uc1dpdGhGcmFt ZS4KICAgICAgICAgW21fdGV4dEZpZWxkLmdldCgpIHNldERyYXdzQmFja2dyb3VuZDpOT107CiAj ZW5kaWYKICAgICB9CiAKLSNpZiBkZWZpbmVkKEJVSUxESU5HX09OX0xJT04pIHx8IGRlZmluZWQo QlVJTERJTkdfT05fU05PV19MRU9QQVJEKQotICAgIC8vIFRoaXMgaXMgYSB3b3JrYXJvdW5kIGZv ciA8cmRhcjovL3Byb2JsZW0vMTEzODU0NjE+IG9uIExpb24gYW5kIFNub3dMZW9wYXJkLiBOZXdl ciB2ZXJzaW9ucyBvZiB0aGUKLSAgICAvLyBPUyBjYW4gYWx3YXlzIHVzZSB0aGUgbmV3ZXIgdmVy c2lvbiBvZiB0aGUgdGV4dCBmaWVsZCB3aXRoIHRoZSB3b3JrYXJvdW5kIGFib3ZlIGluCi0gICAg Ly8gX2NvcmVVSURyYXdPcHRpb25zV2l0aEZyYW1lLiBXaXRoIHRoaXMgd29ya2Fyb3VuZCBmb3Ig b2xkZXIgT1Mncywgd2hlbiB0aGUgZGV2aWNlU2NhbGVGYWN0b3IgaXMgMSwKLSAgICAvLyB3ZSBo YXZlIGFuIG9sZC1zY2hvb2wgZ3JhZGllbnQgYmV6ZWwgaW4gdGV4dCBmaWVsZHMgd2hldGhlciB0 aGV5IGFyZSBzdHlsZWQgb3Igbm90LiBUaGlzIGlzIGZpbmUgYW5kCi0gICAgLy8gbWF0Y2hlcyBz aGlwcGluZyBTYWZhcmkuIFdoZW4gdGhlIGRldmljZVNjYWxlRmFjdG9yIGlzIGdyZWF0ZXIgdGhh biAxLCB0ZXh0IGZpZWxkcyB3aWxsIGhhdmUgbmV3ZXIsCi0gICAgLy8gQXBwS2l0LW1hdGNoaW5n IGdyYWRpZW50cyB0aGF0IGxvb2sgbXVjaCBtb3JlIGFwcHJvcHJpYXRlIGF0IHRoZSBoaWdoZXIg cmVzb2x1dGlvbnMuIEhvd2V2ZXIsIGlmIHRoZQotICAgIC8vIHRleHQgZmllbGQgaXMgc3R5bGVk ICBpbiBhbnkgd2F5LCB3ZSdsbCByZXZlcnQgdG8gdGhlIG9sZC1zY2hvb2wgYmV6ZWwsIHdoaWNo IGRvZXNuJ3QgbG9vayBncmVhdCBpbgotICAgIC8vIEhpRFBJLCBidXQgaXQgbG9va3MgYmV0dGVy IHRoYW4gdGhlIENTUyBib3JkZXIsIHdoaWNoIGlzIHRoZSBvbmx5IGFsdGVybmF0aXZlIHVudGls IDExMzg1NDYxIGlzIHJlc29sdmVkLgotICAgIGlmICh1c2VOZXdHcmFkaWVudCkKLSAgICAgICAg W21fdGV4dEZpZWxkLmdldCgpIHNldEJhY2tncm91bmRDb2xvcjpbTlNDb2xvciB3aGl0ZUNvbG9y XV07Ci0gICAgZWxzZQotICAgICAgICBbbV90ZXh0RmllbGQuZ2V0KCkgc2V0QmFja2dyb3VuZENv bG9yOltOU0NvbG9yIGNsZWFyQ29sb3JdXTsKLSNlbmRpZgotCiAgICAgcmV0dXJuIG1fdGV4dEZp ZWxkLmdldCgpOwogfQogCg==