86265 2012-05-11 15:49:10 -0700 REGRESSION(r104885): Images missing from printed YummySoup! recipes 2012-05-11 16:19:37 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ap oldest_to_newest 622054 0 beidson 2012-05-11 15:49:10 -0700 REGRESSION(r104885): Images missing from printed YummySoup! recipes We know we suspected we might break certain apps in http://trac.webkit.org/changeset/104885 One of those was fixed in http://trac.webkit.org/changeset/107355 where we assumed we were seeing "Paths-as-URLs" passed in at the API layer. In exploring YummySoup! we found that these bogus URLs were more likely to be "file URLs with file: stripped off the beginning" 107355 didn't *quite* handle this properly, so a different fix is forthcoming. In radar as <rdar://problem/11361907> 622064 1 141518 beidson 2012-05-11 15:56:42 -0700 Created attachment 141518 Patch v1 622068 2 141518 ap 2012-05-11 16:00:35 -0700 Comment on attachment 141518 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=141518&action=review > Source/WebKit/mac/ChangeLog:12 > + Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrMalformedFileURL, and change it "Malformed" may sound like too much of a real thing, perhaps "Legacy" would be better? 622071 3 beidson 2012-05-11 16:03:59 -0700 (In reply to comment #2) > (From update of attachment 141518 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141518&action=review > > > Source/WebKit/mac/ChangeLog:12 > > + Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrMalformedFileURL, and change it > > "Malformed" may sound like too much of a real thing, perhaps "Legacy" would be better? "LegacyFileURL" implies it was ever a valid file URL. I chose "Malformed" to stress its invalidity. I'll go with "Invalid". 622082 4 ap 2012-05-11 16:11:40 -0700 A schemeless URL like this is still a valid relative URL AFAICT, and it points to a different file system object that may or may not exist. "Legacy URL" is also somewhat misleading, but it should communicate that part at least. 622088 5 beidson 2012-05-11 16:15:01 -0700 Alexey and I discussed more on IRC and agreed on "Schemeless" 622093 6 beidson 2012-05-11 16:19:37 -0700 http://trac.webkit.org/changeset/116820 141518 2012-05-11 15:56:42 -0700 2012-05-11 16:01:36 -0700 Patch v1 patch.txt text/plain 4721 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBmMzVlMTlhLi4xNWIzMmExIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjcgQEAKKzIwMTItMDUtMTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTM2MTkwNz4gYW5kIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjI2NQorICAgICAgICBSRUdSRVNTSU9OKHIx MDQ4ODUpOiBJbWFnZXMgbWlzc2luZyBmcm9tIHByaW50ZWQgWXVtbXlTb3VwISByZWNpcGVzCisK KyAgICAgICAgV2UgdGhvdWdodCBjbGllbnRzIHdlcmUgcGFzc2luZyBwYXRocyBhcyBVUkxzLgor ICAgICAgICBJdCB0dXJucyBvdXQgaXQgd2FzIG1vcmUgbGlrZWx5IHRoZXkgd2VyZSBwYXNzaW5n IGZpbGU6IFVSTHMgd2l0aCB0aGUgZmlsZTogcmVtb3ZlZC4KKyAgICAgICAgQW5kIHRoYXQgaml2 ZXMgcGVyZmVjdGx5IHdpdGggdGhlIGJlaGF2aW9yIGNoYW5nZSBjYXVzZWQgYnkgcjEwNDg4NS4K KyAgICAgICAgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbmFtZSBfd2Via2l0X1VSTEZyb21VUkxPclBhdGggdG8gX3dlYmtpdF9VUkxGcm9tVVJMT3JN YWxmb3JtZWRGaWxlVVJMLCBhbmQgY2hhbmdlIGl0CisgICAgICAgIHRvIGNyZWF0ZSB0aGUgbmV3 IFVSTCBzaW1wbHkgYnkgYXBwZW5kaW5nICJmaWxlOiI6CisgICAgICAgICogTWlzYy9XZWJOU1VS TEV4dHJhcy5oOgorICAgICAgICAqIE1pc2MvV2ViTlNVUkxFeHRyYXMubW06CisgICAgICAgICgt W05TVVJMIF93ZWJraXRfVVJMRnJvbVVSTE9yTWFsZm9ybWVkRmlsZVVSTF0pOgorCisgICAgICAg ICogV2ViVmlldy9XZWJGcmFtZS5tbToKKyAgICAgICAgKC1bV2ViRnJhbWUgbG9hZFJlcXVlc3Q6 XSk6IENyZWF0ZSB0aGUgZml4ZWQgdXJsIHNpbXBseSBieSBhcHBlbmRpbmcgImZpbGU6IiB0byB0 aGUKKyAgICAgICAgICBleGlzdGluZyBVUkwgc3RyaW5nLgorICAgICAgICAoLVtXZWJGcmFtZSBs b2FkRGF0YTpNSU1FVHlwZTp0ZXh0RW5jb2RpbmdOYW1lOmJhc2VVUkw6XSk6CisgICAgICAgICgt W1dlYkZyYW1lIGxvYWRIVE1MU3RyaW5nOmJhc2VVUkw6XSk6CisgICAgICAgICgtW1dlYkZyYW1l IGxvYWRBbHRlcm5hdGVIVE1MU3RyaW5nOmJhc2VVUkw6Zm9yVW5yZWFjaGFibGVVUkw6XSk6CisK IDIwMTItMDUtMTAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAog ICAgICAgICBNb3ZlIHJlc3VtZUFuaW1hdGlvbnMgdG8gdXNlIEludGVybmFscyBpbnRlcmZhY2UK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNVUkxFeHRyYXMuaCBiL1Nv dXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNVUkxFeHRyYXMuaAppbmRleCA2YjE3MGE3Li4yZThj ZGEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYk5TVVJMRXh0cmFzLmgK KysrIGIvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJOU1VSTEV4dHJhcy5oCkBAIC02OSw3ICs2 OSw3IEBACiAKIC0gKE5TU3RyaW5nICopX3dlYmtpdF9zdWdnZXN0ZWRGaWxlbmFtZVdpdGhNSU1F VHlwZTooTlNTdHJpbmcgKilNSU1FVHlwZTsKIAotLSAoTlNVUkwgKilfd2Via2l0X1VSTEZyb21V UkxPclBhdGg7CistIChOU1VSTCAqKV93ZWJraXRfVVJMRnJvbVVSTE9yTWFsZm9ybWVkRmlsZVVS TDsKIAogQGVuZAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYk5TVVJM RXh0cmFzLm1tIGIvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJOU1VSTEV4dHJhcy5tbQppbmRl eCA5OGZmZjdhLi42NGNiZDM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dl Yk5TVVJMRXh0cmFzLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNVUkxFeHRy YXMubW0KQEAgLTI3NiwxMiArMjc2LDEyIEBAIC0gKE5TU3RyaW5nICopX3dlYmtpdF9zdWdnZXN0 ZWRGaWxlbmFtZVdpdGhNSU1FVHlwZTooTlNTdHJpbmcgKilNSU1FVHlwZQogICAgIHJldHVybiBz dWdnZXN0ZWRGaWxlbmFtZVdpdGhNSU1FVHlwZShzZWxmLCBNSU1FVHlwZSk7CiB9CiAKLS0gKE5T VVJMICopX3dlYmtpdF9VUkxGcm9tVVJMT3JQYXRoCistIChOU1VSTCAqKV93ZWJraXRfVVJMRnJv bVVSTE9yTWFsZm9ybWVkRmlsZVVSTAogewogICAgIGlmIChbc2VsZiBzY2hlbWVdKQogICAgICAg ICByZXR1cm4gc2VsZjsKIAotICAgIHJldHVybiBbTlNVUkwgZmlsZVVSTFdpdGhQYXRoOltzZWxm IGFic29sdXRlU3RyaW5nXV07CisgICAgcmV0dXJuIFtOU1VSTCBVUkxXaXRoU3RyaW5nOltAImZp bGU6IiBzdHJpbmdCeUFwcGVuZGluZ1N0cmluZzpbc2VsZiBhYnNvbHV0ZVN0cmluZ11dXTsKIH0K IAogQGVuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5t bSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KaW5kZXggNDE2YmQ3ZC4u NjAzMGJkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCkBAIC0xMzg0LDcg KzEzODQsNyBAQCAtICh2b2lkKWxvYWRSZXF1ZXN0OihOU1VSTFJlcXVlc3QgKilyZXF1ZXN0CiAg ICAgLy8gTm90ZSB0aGF0IG90aGVyIHVzZXJzIG9mIFdlYktpdCBBUEkgdXNlIG5pbCByZXF1ZXN0 cyBvciByZXF1ZXN0cyB3aXRoIG5pbCBVUkxzLCBzbyB3ZQogICAgIC8vIG9ubHkgaW1wbGVtZW50 IHRoaXMgd29ya2Fyb3VuZCB3aGVuIHRoZSByZXF1ZXN0IGhhZCBhIG5vbi1uaWwgVVJMLgogICAg IGlmICghcmVzb3VyY2VSZXF1ZXN0LnVybCgpLmlzVmFsaWQoKSAmJiBbcmVxdWVzdCBVUkxdKQot ICAgICAgICByZXNvdXJjZVJlcXVlc3Quc2V0VVJMKFtOU1VSTCBmaWxlVVJMV2l0aFBhdGg6W1ty ZXF1ZXN0IFVSTF0gYWJzb2x1dGVTdHJpbmddXSk7CisgICAgICAgIHJlc291cmNlUmVxdWVzdC5z ZXRVUkwoW05TVVJMIFVSTFdpdGhTdHJpbmc6W0AiZmlsZToiIHN0cmluZ0J5QXBwZW5kaW5nU3Ry aW5nOltbcmVxdWVzdCBVUkxdIGFic29sdXRlU3RyaW5nXV1dKTsKIAogICAgIGNvcmVGcmFtZS0+ bG9hZGVyKCktPmxvYWQocmVzb3VyY2VSZXF1ZXN0LCBmYWxzZSk7CiB9CkBAIC0xNDI3LDcgKzE0 MjcsNyBAQCAtICh2b2lkKWxvYWREYXRhOihOU0RhdGEgKilkYXRhIE1JTUVUeXBlOihOU1N0cmlu ZyAqKU1JTUVUeXBlIHRleHRFbmNvZGluZ05hbWU6KAogICAgIAogICAgIGlmICghTUlNRVR5cGUp CiAgICAgICAgIE1JTUVUeXBlID0gQCJ0ZXh0L2h0bWwiOwotICAgIFtzZWxmIF9sb2FkRGF0YTpk YXRhIE1JTUVUeXBlOk1JTUVUeXBlIHRleHRFbmNvZGluZ05hbWU6ZW5jb2RpbmdOYW1lIGJhc2VV Ukw6W2Jhc2VVUkwgX3dlYmtpdF9VUkxGcm9tVVJMT3JQYXRoXSB1bnJlYWNoYWJsZVVSTDpuaWxd OworICAgIFtzZWxmIF9sb2FkRGF0YTpkYXRhIE1JTUVUeXBlOk1JTUVUeXBlIHRleHRFbmNvZGlu Z05hbWU6ZW5jb2RpbmdOYW1lIGJhc2VVUkw6W2Jhc2VVUkwgX3dlYmtpdF9VUkxGcm9tVVJMT3JN YWxmb3JtZWRGaWxlVVJMXSB1bnJlYWNoYWJsZVVSTDpuaWxdOwogfQogCiAtICh2b2lkKV9sb2Fk SFRNTFN0cmluZzooTlNTdHJpbmcgKilzdHJpbmcgYmFzZVVSTDooTlNVUkwgKiliYXNlVVJMIHVu cmVhY2hhYmxlVVJMOihOU1VSTCAqKXVucmVhY2hhYmxlVVJMCkBAIC0xNDQwLDE0ICsxNDQwLDE0 IEBAIC0gKHZvaWQpbG9hZEhUTUxTdHJpbmc6KE5TU3RyaW5nICopc3RyaW5nIGJhc2VVUkw6KE5T VVJMICopYmFzZVVSTAogewogICAgIFdlYkNvcmVUaHJlYWRWaW9sYXRpb25DaGVja1JvdW5kVHdv KCk7CiAKLSAgICBbc2VsZiBfbG9hZEhUTUxTdHJpbmc6c3RyaW5nIGJhc2VVUkw6W2Jhc2VVUkwg X3dlYmtpdF9VUkxGcm9tVVJMT3JQYXRoXSB1bnJlYWNoYWJsZVVSTDpuaWxdOworICAgIFtzZWxm IF9sb2FkSFRNTFN0cmluZzpzdHJpbmcgYmFzZVVSTDpbYmFzZVVSTCBfd2Via2l0X1VSTEZyb21V UkxPck1hbGZvcm1lZEZpbGVVUkxdIHVucmVhY2hhYmxlVVJMOm5pbF07CiB9CiAKIC0gKHZvaWQp bG9hZEFsdGVybmF0ZUhUTUxTdHJpbmc6KE5TU3RyaW5nICopc3RyaW5nIGJhc2VVUkw6KE5TVVJM ICopYmFzZVVSTCBmb3JVbnJlYWNoYWJsZVVSTDooTlNVUkwgKil1bnJlYWNoYWJsZVVSTAogewog ICAgIFdlYkNvcmVUaHJlYWRWaW9sYXRpb25DaGVja1JvdW5kVHdvKCk7CiAKLSAgICBbc2VsZiBf bG9hZEhUTUxTdHJpbmc6c3RyaW5nIGJhc2VVUkw6W2Jhc2VVUkwgX3dlYmtpdF9VUkxGcm9tVVJM T3JQYXRoXSB1bnJlYWNoYWJsZVVSTDpbdW5yZWFjaGFibGVVUkwgX3dlYmtpdF9VUkxGcm9tVVJM T3JQYXRoXV07CisgICAgW3NlbGYgX2xvYWRIVE1MU3RyaW5nOnN0cmluZyBiYXNlVVJMOltiYXNl VVJMIF93ZWJraXRfVVJMRnJvbVVSTE9yTWFsZm9ybWVkRmlsZVVSTF0gdW5yZWFjaGFibGVVUkw6 W3VucmVhY2hhYmxlVVJMIF93ZWJraXRfVVJMRnJvbVVSTE9yTWFsZm9ybWVkRmlsZVVSTF1dOwog fQogCiAtICh2b2lkKWxvYWRBcmNoaXZlOihXZWJBcmNoaXZlICopYXJjaGl2ZQo=