86264 2012-05-11 15:41:24 -0700 layerX/layerY warning should be removed 2012-05-16 13:50:15 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 21868 69951 1 ojan jchaffraix arv jamesr jchaffraix mjs rniwa simon.fraser webkit.review.bot oldest_to_newest 622046 0 ojan 2012-05-11 15:41:24 -0700 This wasn't ever discussed on webkit-dev and there doesn't seem to be much agreement that this is worth the compatibility hit. Do we have histograms or anything about the usage of these in the wild? 622049 1 arv 2012-05-11 15:45:08 -0700 If I remember correctly, the WebKit implementation of layerX/layerY is broken as is. 622094 2 ojan 2012-05-11 16:20:28 -0700 Relevant webkit-dev discussion: https://lists.webkit.org/pipermail/webkit-dev/2012-May/020620.html. I don't actually care what we do here. I was more annoyed with the other console spew in that discussion. 624461 3 jchaffraix 2012-05-15 13:17:38 -0700 For the record, warnDeprecatedLayerXYUsage (the layerX / layerY warning) was at some point one of Chromium's top crashers due to Y! mail hitting a NULL console(). Following the talk on IRC last week, it looks like it may have been premature to deprecate it as people seem to be using it and we have no replacement. Also we haven't done a proper investigation before making the move. I will be moving forward with removing the deprecation warning unless someone objects. We can still add it back once we are ready to follow the proper deprecation protocol. 624470 4 jamesr 2012-05-15 13:22:42 -0700 I think we should remove the warning regardless of whether we decide to deprecate, they don't seem to be helping (and we aren't collecting any data to tell us if they would be). 624485 5 simon.fraser 2012-05-15 13:30:55 -0700 We should do a warnOnce() thing, where it only spews once per session. 624861 6 jchaffraix 2012-05-15 19:11:50 -0700 (In reply to comment #5) > We should do a warnOnce() thing, where it only spews once per session. I have one issue with that. Per our newly minted deprecation policy, we haven't done the proper investigation and we should show the example here. On top of that, maintaining layerX and layerY is virtually zero effort (nobody touched this code in years) and the compatibility breakage relatively high. All those points make me think that we should just remove the warning for now and come back once we have a better idea of our current state. 624874 7 jamesr 2012-05-15 19:27:20 -0700 warnOnce() would be lying to developers once (instead of over and over). The log message says that layerX/layerY will be removed soon, which isn't true. 625636 8 142300 jchaffraix 2012-05-16 10:56:07 -0700 Created attachment 142300 Proposed warning removal. 625658 9 142300 jamesr 2012-05-16 11:16:50 -0700 Comment on attachment 142300 Proposed warning removal. R=me 625826 10 142300 webkit.review.bot 2012-05-16 13:50:09 -0700 Comment on attachment 142300 Proposed warning removal. Clearing flags on attachment: 142300 Committed r117335: <http://trac.webkit.org/changeset/117335> 625827 11 webkit.review.bot 2012-05-16 13:50:15 -0700 All reviewed patches have been landed. Closing bug. 142300 2012-05-16 10:56:07 -0700 2012-05-16 13:50:09 -0700 Proposed warning removal. bug-86264-20120516105606.patch text/plain 14204 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVkZjI1MjQ3OGM4Yjcw MmExNmQwNDZiMjQ2NDNiMDFlNGQxNjJlMS4uNDczYzhmOTk4NDQ0NzQ5ZjBjNGVjMDU5YzQxNWIz NzdmNTQxNDVjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTA1LTE2ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIGxheWVyWC9s YXllclkgd2FybmluZyBzaG91bGQgYmUgcmVtb3ZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYyNjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5OiBmYXN0L2RvbS9XaW5kb3cvd2luZG93 LXh5LXByb3BlcnRpZXMuaHRtbAorICAgICAgICAgICAgICAgICAgICBmYXN0L2V2ZW50cy9pbml0 LWV2ZW50cy5odG1sCisgICAgICAgICAgICAgICAgICAgIGZhc3QvZXZlbnRzL21vdXNlLXJlbGF0 aXZlLXBvc2l0aW9uLmh0bWwKKyAgICAgICAgICAgICAgICAgICAgZmFzdC9ldmVudHMvbW91c2Vj bGljay10YXJnZXQtYW5kLXBvc2l0aW9uaW5nLmh0bWwKKyAgICAgICAgICAgICAgICAgICAgZmFz dC9ldmVudHMvc2ltdWxhdGVkLWNsaWNrLWNvb3Jkcy5odG1sCisgICAgICAgICAgICAgICAgICAg IGpxdWVyeS9ldmVudC5odG1sCisKKyAgICAgICAgVGhpcyBjaGFuZ2UganVzdCByZW1vdmVzIHRo ZSB3YXJuaW5nIHBlbmRpbmcgcHJvcGVyIGludmVzdGlnYXRpb24uCisKKyAgICAgICAgTG9uZ2Vy IGV4cGxhbmF0aW9uOiBUaGUgbGF5ZXJYL2xheWVyWSB3YXJuaW5nIHdhcyBhZGRlZCBwcmVtYXR1 cmVseQorICAgICAgICBhcyB3ZSBkaWRuJ3QgYXNzZXNzIHRoZSB3ZWItY29tcGF0aWJpbGl0eSBw b3RlbnRpYWwgYnJlYWthZ2UgdnMgdGhlCisgICAgICAgIG1haW50ZW5hbmNlIGNvc3QuIFRoZXJl IGlzIGFsc28gbm90IHJlYWRpbHkgYXZhaWxhYmxlIHJlcGxhY2VtZW50LgorCisgICAgICAgICog ZG9tL01vdXNlUmVsYXRlZEV2ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1vdXNlUmVsYXRl ZEV2ZW50OjpsYXllclgpOgorICAgICAgICAoV2ViQ29yZTo6TW91c2VSZWxhdGVkRXZlbnQ6Omxh eWVyWSk6CisgICAgICAgICogZG9tL1VJRXZlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VUlF dmVudDo6bGF5ZXJYKToKKyAgICAgICAgKFdlYkNvcmU6OlVJRXZlbnQ6OmxheWVyWSk6CisgICAg ICAgICogZG9tL1VJRXZlbnQuaDoKKyAgICAgICAgUmVtb3ZlZCB3YXJuRGVwcmVjYXRlZExheWVy WFlVc2FnZSBhbmQgYWxsIHRoZSBhc3NvY2lhdGVkIGNhbGxzLgorCiAyMDEyLTA1LTE1ICBGYWR5 IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gUmVz ZXQgU2NyaXB0SW5zdGFuY2UgaW4gSFRNTFBsdWdJbkVsZW1lbnQgb24gV2ViUGx1Z2luQ29udGFp bmVySW1wbDo6c2V0UGx1Z2luCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTW91c2VS ZWxhdGVkRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL01vdXNlUmVsYXRlZEV2ZW50LmNw cAppbmRleCBjYWVlNThmZTc3YzA2MDFkOTRlZTY2NzhhNjY5NzllNjM4OWY2YjQyLi44ZGYzM2Nh ZTM1NTQzMmRkZmMzZGNkNDQ2MWRlNzAyZTczZjA2NmQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vTW91c2VSZWxhdGVkRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9N b3VzZVJlbGF0ZWRFdmVudC5jcHAKQEAgLTE5Niw3ICsxOTYsNiBAQCB2b2lkIE1vdXNlUmVsYXRl ZEV2ZW50Ojpjb21wdXRlUmVsYXRpdmVQb3NpdGlvbigpCiAKIGludCBNb3VzZVJlbGF0ZWRFdmVu dDo6bGF5ZXJYKCkKIHsKLSAgICB3YXJuRGVwcmVjYXRlZExheWVyWFlVc2FnZSgpOwogICAgIGlm ICghbV9oYXNDYWNoZWRSZWxhdGl2ZVBvc2l0aW9uKQogICAgICAgICBjb21wdXRlUmVsYXRpdmVQ b3NpdGlvbigpOwogICAgIHJldHVybiBtX2xheWVyTG9jYXRpb24ueCgpOwpAQCAtMjA0LDcgKzIw Myw2IEBAIGludCBNb3VzZVJlbGF0ZWRFdmVudDo6bGF5ZXJYKCkKIAogaW50IE1vdXNlUmVsYXRl ZEV2ZW50OjpsYXllclkoKQogewotICAgIHdhcm5EZXByZWNhdGVkTGF5ZXJYWVVzYWdlKCk7CiAg ICAgaWYgKCFtX2hhc0NhY2hlZFJlbGF0aXZlUG9zaXRpb24pCiAgICAgICAgIGNvbXB1dGVSZWxh dGl2ZVBvc2l0aW9uKCk7CiAgICAgcmV0dXJuIG1fbGF5ZXJMb2NhdGlvbi55KCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vVUlFdmVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v VUlFdmVudC5jcHAKaW5kZXggZmYzZmY0YWZjZjliMjEyMTFiN2I1MzFmYWY1NDdkMTNlZjhmZDU2 OS4uOWU3MzMxNmZiOTNiNmZjMWYyMGNkMzA2ZDg0MzE5NzNlYzRlN2NkZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL1VJRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9V SUV2ZW50LmNwcApAQCAtNzgsMTMgKzc4LDExIEBAIGludCBVSUV2ZW50OjpjaGFyQ29kZSgpIGNv bnN0CiAKIGludCBVSUV2ZW50OjpsYXllclgoKQogewotICAgIHdhcm5EZXByZWNhdGVkTGF5ZXJY WVVzYWdlKCk7CiAgICAgcmV0dXJuIDA7CiB9CiAKIGludCBVSUV2ZW50OjpsYXllclkoKQogewot ICAgIHdhcm5EZXByZWNhdGVkTGF5ZXJYWVVzYWdlKCk7CiAgICAgcmV0dXJuIDA7CiB9CiAKQEAg LTEwMywxMyArMTAxLDYgQEAgaW50IFVJRXZlbnQ6OndoaWNoKCkgY29uc3QKICAgICByZXR1cm4g MDsKIH0KIAotdm9pZCBVSUV2ZW50Ojp3YXJuRGVwcmVjYXRlZExheWVyWFlVc2FnZSgpCi17Ci0g ICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIGNvbnNvbGVNZXNzYWdlICwgKCJldmVudC5s YXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktp dC4gVGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVy ZS4iKSk7Ci0gICAgaWYgKG1fdmlldykKLSAgICAgICAgbV92aWV3LT5jb25zb2xlKCktPmFkZE1l c3NhZ2UoSlNNZXNzYWdlU291cmNlLCBMb2dNZXNzYWdlVHlwZSwgV2FybmluZ01lc3NhZ2VMZXZl bCwgY29uc29sZU1lc3NhZ2UpOwotfQotCiBQYXNzUmVmUHRyPEZvY3VzSW5FdmVudERpc3BhdGNo TWVkaWF0b3I+IEZvY3VzSW5FdmVudERpc3BhdGNoTWVkaWF0b3I6OmNyZWF0ZShQYXNzUmVmUHRy PEV2ZW50PiBldmVudCwgUGFzc1JlZlB0cjxOb2RlPiBvbGRGb2N1c2VkTm9kZSkKIHsKICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IEZvY3VzSW5FdmVudERpc3BhdGNoTWVkaWF0b3IoZXZlbnQsIG9s ZEZvY3VzZWROb2RlKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vVUlFdmVudC5o IGIvU291cmNlL1dlYkNvcmUvZG9tL1VJRXZlbnQuaAppbmRleCBkMTI5NGM5NTJmYzFiZDA3Nzhj MWI2MTNjMDFlMDQ3YTVlYjhlOWZhLi4yMDdlYjdiMDRmNmJlNjM4NjIxYWJlYmEwYzQyYWM4NTMw M2U1YWJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vVUlFdmVudC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9VSUV2ZW50LmgKQEAgLTY3LDkgKzY3LDYgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgICAgICBVSUV2ZW50KCk7CiAgICAgICAgIFVJRXZlbnQoY29uc3QgQXRvbWlj U3RyaW5nJiB0eXBlLCBib29sIGNhbkJ1YmJsZSwgYm9vbCBjYW5jZWxhYmxlLCBQYXNzUmVmUHRy PEFic3RyYWN0Vmlldz4sIGludCBkZXRhaWwpOwogCi0gICAgICAgIC8vIGxheWVyWCBhbmQgbGF5 ZXJZIGFyZSBkZXByZWNhdGVkLiBUaGlzIHJlcG9ydHMgYSBtZXNzYWdlIHRvIHRoZSBjb25zb2xl IHVudGlsIHdlIHJlbW92ZSB0aGVtLgotICAgICAgICB2b2lkIHdhcm5EZXByZWNhdGVkTGF5ZXJY WVVzYWdlKCk7Ci0KICAgICBwcml2YXRlOgogICAgICAgICBSZWZQdHI8QWJzdHJhY3RWaWV3PiBt X3ZpZXc7CiAgICAgICAgIGludCBtX2RldGFpbDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0MmRhNjMyNjliNTk1NTk0MjBk Y2UyMGZmMjVmYTFjMTI2Njk1ZDQ5Li45ZjQ4NTUzNzlhOTllOTg3ZGQyZTQ3MjMwZjJiYWI1Nzdk MTYyMmZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDUtMTYgIEp1bGllbiBDaGFmZnJh aXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgbGF5ZXJYL2xheWVyWSB3YXJu aW5nIHNob3VsZCBiZSByZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NjI2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlbW92ZWQgY29uc29sZSBtZXNzYWdlIGFib3V0IGxheWVyWC9sYXllclkg ZGVwcmVjYXRpb24uCisKKyAgICAgICAgKiBmYXN0L2RvbS9XaW5kb3cvd2luZG93LXh5LXByb3Bl cnRpZXMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZXZlbnRzL2luaXQtZXZlbnRzLWV4 cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9tb3VzZS1yZWxhdGl2ZS1wb3NpdGlv bi1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9ldmVudHMvbW91c2VjbGljay10YXJnZXQt YW5kLXBvc2l0aW9uaW5nLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9zaW11 bGF0ZWQtY2xpY2stY29vcmRzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBqcXVlcnkvZXZlbnQt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvZXZlbnRzL21vdXNlLXJl bGF0aXZlLXBvc2l0aW9uLWV4cGVjdGVkLnR4dDoKKwogMjAxMi0wNS0xNSAgUm9iZXJ0IEhvZ2Fu ICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgSGVhcC11c2UtYWZ0ZXItZnJlZSBpbiBX ZWJDb3JlOjpSZW5kZXJCbG9jazo6bGF5b3V0UnVuc0FuZEZsb2F0cwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy14eS1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3cteHktcHJvcGVydGllcy1leHBl Y3RlZC50eHQKaW5kZXggYjgzMjFhMmU0NDg2MDY4ZmYwMTZjMTVkNWE3MGE3ODJlODU0NGQ0OS4u OGZkNDVhNjlkY2NkMzEwY2U0YTgzNzNjZTI1MTBkZjJkODljMDFlNyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy14eS1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXh5LXByb3BlcnRpZXMt ZXhwZWN0ZWQudHh0CkBAIC0xLDExICsxLDMgQEAKLUNPTlNPTEUgTUVTU0FHRTogZXZlbnQubGF5 ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQu IFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1cmUu Ci1DT05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBicm9r ZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIHRo ZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgotQ09OU09MRSBNRVNTQUdFOiBldmVudC5sYXll clggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4g VGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4K LUNPTlNPTEUgTUVTU0FHRTogZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tl biBhbmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhl IGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVy WCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBU aGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgot Q09OU09MRSBNRVNTQUdFOiBldmVudC5sYXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2Vu IGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4gVGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUg ZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4KLUNPTlNPTEUgTUVTU0FHRTogZXZlbnQubGF5ZXJY IGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQuIFRo ZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1cmUuCi1D T05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBicm9rZW4g YW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIHRoZSBl bmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgogUEFTUyBldmVudC5jbGllbnRYIGlzIDUwCiBQQVNT IGV2ZW50LmNsaWVudFkgaXMgNTAKIFBBU1MgZXZlbnQucGFnZVggaXMgNTAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2luaXQtZXZlbnRzLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2luaXQtZXZlbnRzLWV4cGVjdGVkLnR4dAppbmRleCAxZTJiMGIw NTgxMmY1MDI2NjQ2Y2JhYzAzNGU4YjY2NmNkYzExOWNkLi5lMDk3MjVlN2JmOTg5MmE3M2I0MjRm MzUzYzIyNTZlYWQzY2Q1YTdiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9p bml0LWV2ZW50cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW5p dC1ldmVudHMtZXhwZWN0ZWQudHh0CkBAIC0xLDExICsxLDMgQEAKLUNPTlNPTEUgTUVTU0FHRTog ZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBp biBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVh ciBmdXR1cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZ IGFyZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3Zl ZCBmcm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgotQ09OU09MRSBNRVNTQUdFOiBl dmVudC5sYXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGlu IFdlYktpdC4gVGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFy IGZ1dHVyZS4KLUNPTlNPTEUgTUVTU0FHRTogZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkg YXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVk IGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2 ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4g V2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIg ZnV0dXJlLgotQ09OU09MRSBNRVNTQUdFOiBldmVudC5sYXllclggYW5kIGV2ZW50LmxheWVyWSBh cmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4gVGhleSB3aWxsIGJlIHJlbW92ZWQg ZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4KLUNPTlNPTEUgTUVTU0FHRTogZXZl bnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBpbiBX ZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVhciBm dXR1cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZIGFy ZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3ZlZCBm cm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgogVGhpcyB0ZXN0cyB0aGUgaW5pdCBm dW5jdGlvbnMgZm9yIGFsbCB0aGUgZXZlbnQgRE9NIGNsYXNzZXMgdGhhdCBoYXZlIHRoZW0uCiAK IE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL21vdXNlLXJlbGF0aXZlLXBvc2l0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL21vdXNlLXJlbGF0aXZlLXBvc2l0aW9uLWV4cGVjdGVkLnR4dAppbmRleCBj ODA0MDgwM2VjNjdiZTllMTJhZjI1NDFjMjgyMjllZDczOTY2ZTJiLi5jMmFlY2YwMmI1NzBjZDg0 ZTgyN2NkOGQxMjUzMDg5YTIxM2UwMmE0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9tb3VzZS1yZWxhdGl2ZS1wb3NpdGlvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvbW91c2UtcmVsYXRpdmUtcG9zaXRpb24tZXhwZWN0ZWQudHh0CkBAIC0x LDkgKzEsMyBAQAotQ09OU09MRSBNRVNTQUdFOiBldmVudC5sYXllclggYW5kIGV2ZW50LmxheWVy WSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4gVGhleSB3aWxsIGJlIHJlbW92 ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4KLUNPTlNPTEUgTUVTU0FHRTog ZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBp biBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVh ciBmdXR1cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZ IGFyZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3Zl ZCBmcm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgotQ09OU09MRSBNRVNTQUdFOiBl dmVudC5sYXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGlu IFdlYktpdC4gVGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFy IGZ1dHVyZS4KLUNPTlNPTEUgTUVTU0FHRTogZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkg YXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVk IGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2 ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4g V2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIg ZnV0dXJlLgogc3BhbgogCiBQQVNTIHNpbXVsYXRlRWxlbWVudENsaWNrKHRlc3RFbGVtZW50LCBb MTAwLCAxMDAsIDIwMCwgMjAwXSk7IGlzICcxMDAsIDEwMCwgMjAwLCAyMDAnCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tb3VzZWNsaWNrLXRhcmdldC1hbmQtcG9zaXRpb25p bmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbW91c2VjbGljay10YXJn ZXQtYW5kLXBvc2l0aW9uaW5nLWV4cGVjdGVkLnR4dAppbmRleCBjMTc0YTBhZjU2M2IwNjUwZjBi NTUyN2YzNmU1MzE3NmUzNDVjNGUzLi4xOGJkNjgyZWFhOGFmZjE5YTM4YzY1NTBmYTUwNGNkYzc0 ZTAxMjdhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tb3VzZWNsaWNrLXRh cmdldC1hbmQtcG9zaXRpb25pbmctZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL21vdXNlY2xpY2stdGFyZ2V0LWFuZC1wb3NpdGlvbmluZy1leHBlY3RlZC50eHQKQEAg LTEsNSArMSwzIEBACi1DT05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5 ZXJZIGFyZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVt b3ZlZCBmcm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgotQ09OU09MRSBNRVNTQUdF OiBldmVudC5sYXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVk IGluIFdlYktpdC4gVGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBu ZWFyIGZ1dHVyZS4KIFRoaXMgcGFnZSB0ZXN0cyB3aGV0aGVyIGEgY2xpY2sgZXZlbnQgcHJvcG9n YXRlcyB3aXRoIHRoZSBjb3JyZWN0IHRhcmdldCBhbmQgcG9zaXRpb25pbmcuIFNlZSByZGFyOi8v cHJvYmxlbS80NDc3MTI2LgogCiBjbGljayBpbnNpZGUgdGhlIHJlZCBib3g6W10KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NpbXVsYXRlZC1jbGljay1jb29yZHMtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2ltdWxhdGVkLWNsaWNrLWNvb3Jkcy1l eHBlY3RlZC50eHQKaW5kZXggNDM3ZjgyNjk5OGVhZDk4ZDMwZjJkMGYzZmI1N2Q0YzkyNGVjZjJl OC4uNzljZGZiYWM5YTFlMTBiNzMxM2I4Y2IzNDVkMTNlNzAwZjhkNjgxNSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2ltdWxhdGVkLWNsaWNrLWNvb3Jkcy1leHBlY3RlZC50 eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2ltdWxhdGVkLWNsaWNrLWNvb3Jkcy1l eHBlY3RlZC50eHQKQEAgLTEsMTEgKzEsMyBAQAotQ09OU09MRSBNRVNTQUdFOiBldmVudC5sYXll clggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4g VGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4K LUNPTlNPTEUgTUVTU0FHRTogZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tl biBhbmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhl IGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVy WCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBU aGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgot Q09OU09MRSBNRVNTQUdFOiBldmVudC5sYXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2Vu IGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4gVGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUg ZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4KLUNPTlNPTEUgTUVTU0FHRTogZXZlbnQubGF5ZXJY IGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQuIFRo ZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1cmUuCi1D T05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBicm9rZW4g YW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIHRoZSBl bmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgotQ09OU09MRSBNRVNTQUdFOiBldmVudC5sYXllclgg YW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4gVGhl eSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4KLUNP TlNPTEUgTUVTU0FHRTogZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBh bmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVu Z2luZSBpbiB0aGUgbmVhciBmdXR1cmUuCiBFbnN1cmUgdGhhdCBzaW11bGF0ZWQgY2xpY2sgb24g bGFiZWwgZWxlbWVudHMgdXNlcyB0aGUgb3JpZ2luYWwgbW91c2UgY29vcmRpbmF0ZXMuCiAKICBD bGljayBNZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanF1ZXJ5L2V2ZW50LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2pxdWVyeS9ldmVudC1leHBlY3RlZC50eHQKaW5kZXggNTU0MGNjN2Ux MmM2NDhiMTk4NWRjYmNjOWYzNzc1OGM1YTViZjdmMC4uOGFkN2I1Y2I0ZTRmYWIwZjY1Nzk5NGY5 MjMzOWFiMTM5NmZmNjAyMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvanF1ZXJ5L2V2ZW50LWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9qcXVlcnkvZXZlbnQtZXhwZWN0ZWQudHh0CkBA IC0xLDQgKzEsMiBAQAotQ09OU09MRSBNRVNTQUdFOiBldmVudC5sYXllclggYW5kIGV2ZW50Lmxh eWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4gVGhleSB3aWxsIGJlIHJl bW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4KLUNPTlNPTEUgTUVTU0FH RTogZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRl ZCBpbiBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVuZ2luZSBpbiB0aGUg bmVhciBmdXR1cmUuCiBBTEVSVDogMzc2IHRlc3RzIG9mIDM3NiBwYXNzZWQsIDAgZmFpbGVkLgog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2V2ZW50cy9tb3VzZS1y ZWxhdGl2ZS1wb3NpdGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9m YXN0L2V2ZW50cy9tb3VzZS1yZWxhdGl2ZS1wb3NpdGlvbi1leHBlY3RlZC50eHQKaW5kZXggYzgw NDA4MDNlYzY3YmU5ZTEyYWYyNTQxYzI4MjI5ZWQ3Mzk2NmUyYi4uYzJhZWNmMDJiNTcwY2Q4NGU4 MjdjZDhkMTI1MzA4OWEyMTNlMDJhNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvZmFzdC9ldmVudHMvbW91c2UtcmVsYXRpdmUtcG9zaXRpb24tZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZXZlbnRzL21vdXNlLXJlbGF0aXZlLXBvc2l0 aW9uLWV4cGVjdGVkLnR4dApAQCAtMSw5ICsxLDMgQEAKLUNPTlNPTEUgTUVTU0FHRTogZXZlbnQu bGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJyb2tlbiBhbmQgZGVwcmVjYXRlZCBpbiBXZWJL aXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1 cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2ZW50LmxheWVyWCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBi cm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0LiBUaGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9t IHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJlLgotQ09OU09MRSBNRVNTQUdFOiBldmVudC5s YXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJva2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktp dC4gVGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVy ZS4KLUNPTlNPTEUgTUVTU0FHRTogZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXllclkgYXJlIGJy b2tlbiBhbmQgZGVwcmVjYXRlZCBpbiBXZWJLaXQuIFRoZXkgd2lsbCBiZSByZW1vdmVkIGZyb20g dGhlIGVuZ2luZSBpbiB0aGUgbmVhciBmdXR1cmUuCi1DT05TT0xFIE1FU1NBR0U6IGV2ZW50Lmxh eWVyWCBhbmQgZXZlbnQubGF5ZXJZIGFyZSBicm9rZW4gYW5kIGRlcHJlY2F0ZWQgaW4gV2ViS2l0 LiBUaGV5IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIHRoZSBlbmdpbmUgaW4gdGhlIG5lYXIgZnV0dXJl LgotQ09OU09MRSBNRVNTQUdFOiBldmVudC5sYXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgYnJv a2VuIGFuZCBkZXByZWNhdGVkIGluIFdlYktpdC4gVGhleSB3aWxsIGJlIHJlbW92ZWQgZnJvbSB0 aGUgZW5naW5lIGluIHRoZSBuZWFyIGZ1dHVyZS4KIHNwYW4KIAogUEFTUyBzaW11bGF0ZUVsZW1l bnRDbGljayh0ZXN0RWxlbWVudCwgWzEwMCwgMTAwLCAyMDAsIDIwMF0pOyBpcyAnMTAwLCAxMDAs IDIwMCwgMjAwJwo=