8626 2006-04-27 01:32:03 -0700 Strict mode erroneously triggered by a broken comment 2006-07-11 03:40:05 -0700 1 1 1 Unclassified WebKit DOM 418.x Mac OS X 10.4 RESOLVED FIXED http://mayan.tzo.com:888/dreamsp/dreamain.htm P2 Normal --- 1 matt ap ap darin oldest_to_newest 40579 0 matt 2006-04-27 01:32:03 -0700 On this page there is a comment at the start : <!--@@Advance "Dreamspell"-> and right near the bottom there is another one : <!--@@Count "Dreamspell"->. WebKit ignores everything between these comments, whereas other browsers (Firefox, opera and IE Mac) display the page as the author 'intended'. 40580 1 7991 matt 2006-04-27 01:44:13 -0700 Created attachment 7991 A reduction 40637 2 ap 2006-04-27 21:43:58 -0700 The symptom gets fixed with reverting the SGML comment parsing fix made for acid2 (cf. bug 5855). However, there is another related problem - the test is parsed in strict mode, while it apparently shouldn't. Here, strict mode is triggered by having the <!--@@Advance "Dreamspell"-> comment anywhere before BODY. 40677 3 8023 ap 2006-04-28 11:50:43 -0700 Created attachment 8023 proposed fix Properly determine the parsing mode if we have reached Frame::endIfNotLoading() without ever seeing any data from the decoder, which is the case when a broken comment is somewhere before <body>. 40699 4 8023 darin 2006-04-28 17:13:07 -0700 Comment on attachment 8023 proposed fix Why does this new code belong here rather than in Frame::write? What's different about end as opposed to write that means we should do setParseMode in there, but determineParseMode here? 40705 5 ap 2006-04-28 22:40:26 -0700 There are two Frame::write() methods, one also calls determineParseMode(), and another calls setParseMode(Strict). When loading data, it is the first that gets called, so we end up with calling determineParseMode() consistently. I didn't investigate why the second Frame::write() just sets strict mode, as it's not directly related to this issue. Looking at it now, it is used for documents created via document.write(), window.open(), DOMImplementation::createHTMLDocument(), Frame::replaceContentsWithScriptResult(), Frame::changeLocation(), and XSLTProcessor. Presumably, some or all of these uses imply strict mode. It's not immediately obvious if this is always correct (and some of these actually call determineParseMode() on their own), but I don't think this patch changes their behavior anyway. 41268 6 8023 mjs 2006-05-04 13:32:03 -0700 Comment on attachment 8023 proposed fix r=me 49215 7 ddkilzer 2006-07-11 03:40:05 -0700 Note that this bug apparently fixed Bug 7102 as well. 7991 2006-04-27 01:44:13 -0700 2006-04-27 01:44:13 -0700 A reduction Malformed comment.html text/html 209 matt PCEtLUBAQWR2YW5jZSAiRHJlYW1zcGVsbCItPgo8SFRNTD4KPEhFQUQ+CjxUSVRMRT5NYWxmb3Jt ZWQgY29tbWVudHM8L1RJVExFPgo8L0hFQUQ+Cgo8Qk9EWT4KCjxIMT5PdGhlciB3ZWIgYnJvd3Nl cnMgc2hvdyB0aGlzLCB3aGVyZWFzIDwhLS1AQENvdW50ICJEcmVhbXNwZWxsIi0+IFdlYktpdCBv bmx5IHNob3dzIHRoaXMuCjwvSDE+CjwvQk9EWT4KPC9IVE1MPgo= 8023 2006-04-28 11:50:43 -0700 2006-05-04 13:32:03 -0700 proposed fix 8626r1_patch.txt text/plain 3408 ap SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2Jyb2tlbi1jb21tZW50cy12cy1wYXJzaW5n LW1vZGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcGFyc2Vy L2Jyb2tlbi1jb21tZW50cy12cy1wYXJzaW5nLW1vZGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvYnJva2VuLWNvbW1lbnRzLXZzLXBhcnNpbmct bW9kZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTUgQEAKK2xheWVyIGF0 ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJDYW52YXMgYXQgKDAsMCkgc2l6ZSA4MDB4NjAw CitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg4NAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAs MCkgc2l6ZSA4MDB4ODQKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCwxNikgc2l6ZSA3ODR4 NTIKKyAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwwKSBzaXplIDc4NHgxOAorICAgICAgICBS ZW5kZXJJbmxpbmUge0F9IGF0ICgwLDApIHNpemUgNjB4MTggW2NvbG9yPSMwMDAwRUVdCisgICAg ICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgNjB4MTgKKyAgICAgICAgICAg IHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDYwOiAiYnVnIDg2MjYiCisgICAgICAgIFJlbmRlclRl eHQgeyN0ZXh0fSBhdCAoNjAsMCkgc2l6ZSAzNjN4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAo NjAsMCkgd2lkdGggODogIjogIgorICAgICAgICAgIHRleHQgcnVuIGF0ICg2OCwwKSB3aWR0aCAz NTU6ICJTdHJpY3QgbW9kZSBlcnJvbmVvdXNseSB0cmlnZ2VyZWQgYnkgYSBicm9rZW4gY29tbWVu dC4iCisgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMzQpIHNpemUgNzg0eDE4IFtjb2xvcj0j MDBGRjAwXQorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSA2NDJ4MTgK KyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA2NDI6ICJUaGlzIHRleHQgc2hvdWxk IGJlIGdyZWVuLCBub3QgYmxhY2sgKENTUyBjb2xvciB2YWx1ZXMgbm90IGJlZ2lubmluZyB3aXRo ICcjJyBhcmUgT0sgaW4gcXVpcmtzIG1vZGUpLiIKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcGFy c2VyL2Jyb2tlbi1jb21tZW50cy12cy1wYXJzaW5nLW1vZGUuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L3BhcnNlci9icm9rZW4tY29tbWVudHMtdnMtcGFyc2luZy1tb2RlLmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9icm9rZW4tY29tbWVu dHMtdnMtcGFyc2luZy1tb2RlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOSBAQAorPGh0 bWw+Cis8IS0tIEEgYnJva2VuIGNvbW1lbnQgLT4KKzxib2R5PgorPHA+PGEgaHJlZj0iaHR0cDov L2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD04NjI2Ij5idWcgODYyNjwv YT46IAorU3RyaWN0IG1vZGUgZXJyb25lb3VzbHkgdHJpZ2dlcmVkIGJ5IGEgYnJva2VuIGNvbW1l bnQuPC9wPgorCis8cCBzdHlsZT0iY29sb3I6MDBmZjAwIj5UaGlzIHRleHQgc2hvdWxkIGJlIGdy ZWVuLCBub3QgYmxhY2sgKENTUyBjb2xvciB2YWx1ZXMgbm90IGJlZ2lubmluZyB3aXRoICcjJyBh cmUgT0sgaW4gcXVpcmtzIG1vZGUpLjwvcD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvcGFyc2VyL2Jyb2tlbi1jb21tZW50cy12cy1wYXJzaW5nLW1vZGUtZXhwZWN0 ZWQucG5nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KQ2Fubm90IGRpc3BsYXk6IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5 IHR5cGUuCnN2bjptaW1lLXR5cGUgPSBpbWFnZS9wbmcKClByb3BlcnR5IGNoYW5nZXMgb246IGJy b2tlbi1jb21tZW50cy12cy1wYXJzaW5nLW1vZGUtZXhwZWN0ZWQucG5nCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTmFt ZTogc3ZuOm1pbWUtdHlwZQogICArIGltYWdlL3BuZwoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv cGFyc2VyL2Jyb2tlbi1jb21tZW50cy12cy1wYXJzaW5nLW1vZGUtZXhwZWN0ZWQuY2hlY2tzdW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvYnJva2VuLWNvbW1lbnRzLXZz LXBhcnNpbmctbW9kZS1leHBlY3RlZC5jaGVja3N1bQkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvcGFyc2VyL2Jyb2tlbi1jb21tZW50cy12cy1wYXJzaW5nLW1vZGUtZXhwZWN0ZWQu Y2hlY2tzdW0JKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKKzQ5MDZlMTc4ZmI0OGI0NjVkY2Mx YmMyZWE0YTNhMDA4ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogV2ViQ29yZS9w YWdlL0ZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZp c2lvbiAxNDA5OSkKKysrIFdlYkNvcmUvcGFnZS9GcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTY4Myw4ICs2ODMsMTQgQEAgdm9pZCBGcmFtZTo6ZW5kSWZOb3RMb2FkaW5nKCkKIAogICAgIC8v IG1ha2Ugc3VyZSBub3RoaW5nJ3MgbGVmdCBpbiB0aGVyZS4uLgogICAgIGlmIChkLT5tX2RvYykg ewotICAgICAgICBpZiAoZC0+bV9kZWNvZGVyKQotICAgICAgICAgICAgd3JpdGUoZC0+bV9kZWNv ZGVyLT5mbHVzaCgpKTsKKyAgICAgICAgaWYgKGQtPm1fZGVjb2RlcikgeworICAgICAgICAgICAg RGVwcmVjYXRlZFN0cmluZyBkZWNvZGVkID0gZC0+bV9kZWNvZGVyLT5mbHVzaCgpOworICAgICAg ICAgICAgaWYgKGQtPm1fYkZpcnN0RGF0YSkgeworICAgICAgICAgICAgICAgIGQtPm1fZG9jLT5k ZXRlcm1pbmVQYXJzZU1vZGUoZGVjb2RlZCk7CisgICAgICAgICAgICAgICAgZC0+bV9iRmlyc3RE YXRhID0gZmFsc2U7CisgICAgICAgICAgICB9CisgICAgICAgICAgICB3cml0ZShkZWNvZGVkKTsK KyAgICAgICAgfQogICAgICAgICBkLT5tX2RvYy0+ZmluaXNoUGFyc2luZygpOwogICAgIH0gZWxz ZQogICAgICAgICAvLyBXZWJLaXQgcGFydGlhbGx5IHVzZXMgV2ViQ29yZSB3aGVuIGxvYWRpbmcg bm9uLUhUTUwgZG9jcy4gIEluIHRoZXNlIGNhc2VzIGRvYz09bmlsLCBidXQK