86258 2012-05-11 15:23:46 -0700 [chromium] Prevent deadlock on CCVideoLayerImpl destruction 2012-05-11 19:04:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cc-bugs enne eric.carlson feature-media-reviews fischman jamesr nduca scherkus webkit.review.bot oldest_to_newest 622019 0 enne 2012-05-11 15:23:46 -0700 [chromium] Prevent deadlock on CCVideoLayerImpl destruction 622029 1 141510 enne 2012-05-11 15:31:22 -0700 Created attachment 141510 Patch 622037 2 enne 2012-05-11 15:33:24 -0700 jamesr: Your suggestion to use CCLayerTreeHost::acquireLayerTextures to block the compositor thread from using a destroyed provider worked great in the case where you had another commit and much less great when the tree got destroyed and it was unclear whether a client should clear its provider pointer or not. 622040 3 141510 jamesr 2012-05-11 15:36:41 -0700 Comment on attachment 141510 Patch R=me 622053 4 nduca 2012-05-11 15:48:47 -0700 WIN 622100 5 scherkus 2012-05-11 16:26:43 -0700 I also sense great win in this patch. 622184 6 141510 webkit.review.bot 2012-05-11 19:04:03 -0700 Comment on attachment 141510 Patch Clearing flags on attachment: 141510 Committed r116833: <http://trac.webkit.org/changeset/116833> 622185 7 webkit.review.bot 2012-05-11 19:04:08 -0700 All reviewed patches have been landed. Closing bug. 141510 2012-05-11 15:31:22 -0700 2012-05-11 19:04:03 -0700 Patch bug-86258-20120511153121.patch text/plain 3008 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWE0Zjk3MjFjNDg2MTA1 MzA3NTgwYzY1MTdhZjA2MTkyYTE0MWM5Zi4uYjA5NDkyM2RhYmJlNTY3MDRhNTM5ZWZhZjc2NzM4 NDc5YmI1MzgwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA1LTExICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBQcmV2 ZW50IGRlYWRsb2NrIG9uIENDVmlkZW9MYXllckltcGwgZGVzdHJ1Y3Rpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MjU4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgfkNDVmlkZW9MYXllckltcGwgaGFk IGEgY29tbW9uIGRlYWRsb2NrIGlzc3VlIHdoZXJlIGlmIGl0IGdvdAorICAgICAgICBkZXN0cm95 ZWQgYmVmb3JlIFdlYk1lZGlhUGxheWVyQ2xpZW50SW1wbCwgaXQgd291bGQgdGFrZSBhIGxvY2ss CisgICAgICAgIGNhbGwgV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpzZXRWaWRlb0ZyYW1lUHJv dmlkZXJDbGllbnQoMCksCisgICAgICAgIHdoaWNoIGluIHR1cm4gd291bGQgY2FsbCBDQ1ZpZGVv TGF5ZXJJbXBsOjpzdG9wVXNpbmdQcm92aWRlcigpLAorICAgICAgICB3aGljaCB3b3VsZCB0cnkg dG8gdGFrZSB0aGUgc2FtZSBsb2NrIGFuZCB3b3VsZCBkZWFkbG9jay4KKworICAgICAgICBDQ1Zp ZGVvTGF5ZXJJbXBsIGlzIG9ubHkgY3JlYXRlZCBhbmQgZGVzdHJveWVkIGR1cmluZyB0cmVlCisg ICAgICAgIHN5bmNocm9uaXphdGlvbiBpbiBhIGNvbW1pdCBvciBkdXJpbmcgc3luY2hyb25vdXMg Y29tcG9zaXRvciB0aHJlYWQKKyAgICAgICAgZGVzdHJ1Y3Rpb24uIEluIGVpdGhlciBjYXNlLCB0 aGUgbWFpbiB0aHJlYWQgaXMgYmxvY2tlZCwgYW5kIHNvIG5vCisgICAgICAgIGxvY2sgbmVlZHMg dG8gYmUgdGFrZW4gYXQgYWxsLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1ZpZGVvTGF5 ZXJJbXBsOjpDQ1ZpZGVvTGF5ZXJJbXBsKToKKyAgICAgICAgKFdlYkNvcmU6OkNDVmlkZW9MYXll ckltcGw6On5DQ1ZpZGVvTGF5ZXJJbXBsKToKKyAgICAgICAgKFdlYkNvcmU6OkNDVmlkZW9MYXll ckltcGw6OnN0b3BVc2luZ1Byb3ZpZGVyKToKKwogMjAxMi0wNS0xMSAgSWFuIFZvbGxpY2sgIDx2 b2xsaWNrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEVuc3VyZSB0aGF0IGFu aW1hdGlvbnMgY29udGludWUgdG8gcnVuIHdoZW4gdHJhbnNmb3JtLXN0eWxlIGlzIGNoYW5nZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDVmlkZW9MYXllckltcGwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKaW5kZXggOWMwNzZhMmVkNmZhODgyY2Q3 NTVhZDgxMTBmMDQ2NDkwMjkzYzgzZC4uMTJkYTZiYWZhNjQwOTVhOWZlOWIzY2Y1ZTFmOGFiZmRk NGJmMDYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKQEAgLTgwLDEyICs4 MCwxNyBAQCBDQ1ZpZGVvTGF5ZXJJbXBsOjpDQ1ZpZGVvTGF5ZXJJbXBsKGludCBpZCwgV2ViS2l0 OjpXZWJWaWRlb0ZyYW1lUHJvdmlkZXIqIHByb3ZpZAogICAgICwgbV9mcmFtZSgwKQogewogICAg IG1lbWNweShtX3N0cmVhbVRleHR1cmVNYXRyaXgsIGZsaXBUcmFuc2Zvcm0sIHNpemVvZihtX3N0 cmVhbVRleHR1cmVNYXRyaXgpKTsKLSAgICBwcm92aWRlci0+c2V0VmlkZW9GcmFtZVByb3ZpZGVy Q2xpZW50KHRoaXMpOworCisgICAgLy8gVGhpcyBvbmx5IGhhcHBlbnMgZHVyaW5nIGEgY29tbWl0 IG9uIHRoZSBjb21wb3NpdG9yIHRocmVhZCB3aGlsZSB0aGUgbWFpbgorICAgIC8vIHRocmVhZCBp cyBibG9ja2VkLiBUaGF0IG1ha2VzIHRoaXMgYSB0aHJlYWQtc2FmZSBjYWxsIHRvIHNldCB0aGUg dmlkZW8KKyAgICAvLyBmcmFtZSBwcm92aWRlciBjbGllbnQgdGhhdCBkb2VzIG5vdCByZXF1aXJl IGEgbG9jay4gVGhlIHNhbWUgaXMgdHJ1ZSBvZgorICAgIC8vIHRoZSBjYWxsIGluIHRoZSBkZXN0 cnVjdG9yLgorICAgIG1fcHJvdmlkZXItPnNldFZpZGVvRnJhbWVQcm92aWRlckNsaWVudCh0aGlz KTsKIH0KIAogQ0NWaWRlb0xheWVySW1wbDo6fkNDVmlkZW9MYXllckltcGwoKQogewotICAgIE11 dGV4TG9ja2VyIGxvY2tlcihtX3Byb3ZpZGVyTXV0ZXgpOworICAgIC8vIFNlZSBjb21tZW50IGlu IGNvbnN0cnVjdG9yIGZvciB3aHkgdGhpcyBkb2Vzbid0IG5lZWQgYSBsb2NrLgogICAgIGlmICht X3Byb3ZpZGVyKSB7CiAgICAgICAgIG1fcHJvdmlkZXItPnNldFZpZGVvRnJhbWVQcm92aWRlckNs aWVudCgwKTsKICAgICAgICAgbV9wcm92aWRlciA9IDA7CkBAIC05Niw3ICsxMDEsMTAgQEAgQ0NW aWRlb0xheWVySW1wbDo6fkNDVmlkZW9MYXllckltcGwoKQogCiB2b2lkIENDVmlkZW9MYXllcklt cGw6OnN0b3BVc2luZ1Byb3ZpZGVyKCkKIHsKKyAgICAvLyBCbG9jayB0aGUgcHJvdmlkZXIgZnJv bSBzaHV0dGluZyBkb3duIHVudGlsIHRoaXMgY2xpZW50IGlzIGRvbmUKKyAgICAvLyB1c2luZyB0 aGUgZnJhbWUuCiAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fcHJvdmlkZXJNdXRleCk7CisgICAg QVNTRVJUKCFtX2ZyYW1lKTsKICAgICBtX3Byb3ZpZGVyID0gMDsKIH0KIAo=