86240 2012-05-11 12:09:37 -0700 [GTK] [WK2] Memory leak in PluginProcessProxy::scanPlugin 2012-05-11 16:07:47 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gustavo kbalazs mrobinson webkit.review.bot oldest_to_newest 621855 0 naginenis 2012-05-11 12:09:37 -0700 Valgrind reports a memory leak in PluginProcessProxy::scanPlugin(). It seems stdOut received from g_spawn_sync() needs to be freed. ==19600== 6,400 bytes in 6 blocks are definitely lost in loss record 7,532 of 7,586 ==19600== at 0x4C2B7B2: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==19600== by 0xB1A6AF6: g_realloc (gmem.c:224) ==19600== by 0xB1BD5C6: g_string_maybe_expand (gstring.c:102) ==19600== by 0xB1BD8D6: g_string_insert_len (gstring.c:444) ==19600== by 0xB1DE8AD: read_data (gspawn.c:196) ==19600== by 0xB1DED3C: g_spawn_sync (gspawn.c:356) ==19600== by 0x6127CC2: WebKit::PluginProcessProxy::scanPlugin(WTF::String const&, WebKit::RawPluginMetaData&) (PluginProcessProxyGtk.cpp:60) ==19600== by 0x608F933: WebKit::NetscapePluginModule::getPluginInfo(WTF::String const&, WebKit::PluginModuleInfo&) (NetscapePluginModuleX11.cpp:131) ==19600== by 0x612830E: WebKit::PluginInfoStore::getPluginInfo(WTF::String const&, WebKit::PluginModuleInfo&) (PluginInfoStoreUnix.cpp:98) ==19600== by 0x6110CA8: WebKit::PluginInfoStore::loadPlugin(WTF::Vector<WebKit::PluginModuleInfo, 0ul>&, WTF::String const&) (PluginInfoStore.cpp:105) ==19600== by 0x6110C01: WebKit::PluginInfoStore::loadPluginsIfNecessary() (PluginInfoStore.cpp:95) ==19600== by 0x6110D07: WebKit::PluginInfoStore::plugins() (PluginInfoStore.cpp:116) ==19600== by 0x61368AA: WebKit::WebContext::getPlugins(bool, WTF::Vector<WebCore::PluginInfo, 0ul>&) (WebContext.cpp:612) ==19600== by 0x6287662: void CoreIPC::callMemberFunction<WebKit::WebContext, void (WebKit::WebContext::*)(bool, WTF::Vector<WebCore::PluginInfo, 0ul>&), bool, WTF::Vector<WebCore:: ==19600== by 0x62872B2: void CoreIPC::handleMessage<Messages::WebContext::GetPlugins, WebKit::WebContext, void (WebKit::WebContext::*)(bool, WTF::Vector<WebCore::PluginInfo, 0ul>&) ==19600== by 0x6286D85: WebKit::WebContext::didReceiveSyncWebContextMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*, WTF::OwnPtr<CoreIPC::ArgumentEncode ==19600== by 0x6137268: WebKit::WebContext::didReceiveSyncMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*, WTF::OwnPtr<CoreIPC::ArgumentEncoder>&) (WebC ==19600== by 0x6198AC3: WebKit::WebProcessProxy::didReceiveSyncMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*, WTF::OwnPtr<CoreIPC::ArgumentEncoder>&) ==19600== by 0x612FED4: WebKit::WebConnectionToWebProcess::didReceiveSyncMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*, WTF::OwnPtr<CoreIPC::ArgumentE ==19600== by 0x6056EE8: CoreIPC::Connection::dispatchSyncMessage(CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) (Connection.cpp:647) ==19600== by 0x6057168: CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::ArgumentDecoder>&) (Connection.cpp:690) ==19600== by 0x6054EA5: CoreIPC::Connection::SyncMessageState::dispatchMessages() (Connection.cpp:169) ==19600== by 0x6054F68: CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesWork() (Connection.cpp:181) ==19600== by 0x60615DB: WTF::FunctionWrapper<void (CoreIPC::Connection::SyncMessageState::*)()>::operator()(CoreIPC::Connection::SyncMessageState*) (Functional.h:173) ==19600== by 0x6061463: WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::SyncMessageState::*)()>, void ()(CoreIPC::Connection::SyncMessageState*)>::operator() ==19600== by 0x606632D: WTF::Function<void ()()>::operator()() const (Functional.h:613) ==19600== by 0x6B3BC74: WebCore::RunLoop::performWork() (RunLoop.cpp:67) ==19600== by 0x75448B1: WebCore::RunLoop::queueWork(WebCore::RunLoop*) (RunLoopGtk.cpp:102) ==19600== by 0xB1A0C99: g_main_context_dispatch (gmain.c:2515) ==19600== by 0xB1A105F: g_main_context_iterate.isra.23 (gmain.c:3123) ==19600== by 0xB1A1459: g_main_loop_run (gmain.c:3317) ==19600== by 0xA6AD25C: gtk_main (gtkmain.c:1165) ==19600== by 0x40B12E: main (main.c:233) 621886 1 141475 naginenis 2012-05-11 12:38:26 -0700 Created attachment 141475 Patch proposal fix memory leak 621935 2 141475 mrobinson 2012-05-11 13:36:02 -0700 Comment on attachment 141475 Patch proposal Thanks! 622079 3 141475 webkit.review.bot 2012-05-11 16:07:37 -0700 Comment on attachment 141475 Patch proposal Clearing flags on attachment: 141475 Committed r116819: <http://trac.webkit.org/changeset/116819> 622080 4 webkit.review.bot 2012-05-11 16:07:47 -0700 All reviewed patches have been landed. Closing bug. 141475 2012-05-11 12:38:26 -0700 2012-05-11 16:07:36 -0700 Patch proposal 86240.patch text/plain 2249 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZWRlNGY0Li5jYTY4Mjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDUtMTEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gW1dLMl0gTWVtb3J5IGxlYWsgaW4gUGx1 Z2luUHJvY2Vzc1Byb3h5OjpzY2FuUGx1Z2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NjI0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZyZWUgdGhlIG91dHB1dCByZWNlaXZlZCBmcm9tIHRoZSBnX3Nw YXduX3N5bmMoKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL2d0ay9QbHVnaW5Qcm9j ZXNzUHJveHlHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Qcm9jZXNzUHJveHk6OnNj YW5QbHVnaW4pOgorCiAyMDEyLTA1LTExICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25v bWUub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjExNjIwNSk6IFtHVEtdOiBidWlsZCBubyBs b25nZXIgc3VwcG9ydHMgdGhpbiBhcmNoaXZlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1BsdWdpbnMvZ3RrL1BsdWdpblByb2Nlc3NQcm94eUd0ay5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9ndGsvUGx1Z2luUHJvY2Vzc1Byb3h5R3RrLmNwcApp bmRleCA2NTNjNzI5Li5mYTkzMzlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvUGx1Z2lucy9ndGsvUGx1Z2luUHJvY2Vzc1Byb3h5R3RrLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9ndGsvUGx1Z2luUHJvY2Vzc1Byb3h5R3RrLmNwcApAQCAt MzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIlBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMu aCIKICNpbmNsdWRlICJQcm9jZXNzRXhlY3V0YWJsZVBhdGguaCIKICNpbmNsdWRlIDxXZWJDb3Jl L0ZpbGVTeXN0ZW0uaD4KKyNpbmNsdWRlIDxXZWJDb3JlL0dPd25QdHJHdGsuaD4KICNpbmNsdWRl IDxnbGliLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUgPHd0Zi90 ZXh0L1dURlN0cmluZy5oPgpAQCAtNTQsOCArNTUsOCBAQCBib29sIFBsdWdpblByb2Nlc3NQcm94 eTo6c2NhblBsdWdpbihjb25zdCBTdHJpbmcmIHBsdWdpblBhdGgsIFJhd1BsdWdpbk1ldGFEYXRh JgogICAgIGFyZ3ZbM10gPSAwOwogCiAgICAgZ2ludCBzdGF0dXM7Ci0gICAgZ2NoYXIqIHN0ZE91 dDsKLSAgICBpZiAoIWdfc3Bhd25fc3luYygwLCBhcmd2LCAwLCBHX1NQQVdOX1NUREVSUl9UT19E RVZfTlVMTCwgMCwgMCwgJnN0ZE91dCwgMCwgJnN0YXR1cywgMCkpCisgICAgR093blB0cjxnY2hh cj4gc3RkT3V0OworICAgIGlmICghZ19zcGF3bl9zeW5jKDAsIGFyZ3YsIDAsIEdfU1BBV05fU1RE RVJSX1RPX0RFVl9OVUxMLCAwLCAwLCAmc3RkT3V0Lm91dFB0cigpLCAwLCAmc3RhdHVzLCAwKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICghV0lGRVhJVEVEKHN0YXR1cykgfHwgV0VY SVRTVEFUVVMoc3RhdHVzKSAhPSBFWElUX1NVQ0NFU1MpCiAgICAgICAgIHJldHVybiBmYWxzZTsK QEAgLTYzLDcgKzY0LDcgQEAgYm9vbCBQbHVnaW5Qcm9jZXNzUHJveHk6OnNjYW5QbHVnaW4oY29u c3QgU3RyaW5nJiBwbHVnaW5QYXRoLCBSYXdQbHVnaW5NZXRhRGF0YSYKICAgICBjb25zdCB1bnNp Z25lZCBrTnVtTGluZXNFeHBlY3RlZCA9IDM7CiAgICAgU3RyaW5nIGxpbmVzW2tOdW1MaW5lc0V4 cGVjdGVkXTsKICAgICB1bnNpZ25lZCBsaW5lSW5kZXggPSAwOwotICAgIGNvbnN0IFVDaGFyKiBj dXJyZW50ID0gcmVpbnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+KHN0ZE91dCk7CisgICAgY29u c3QgVUNoYXIqIGN1cnJlbnQgPSByZWludGVycHJldF9jYXN0PGNvbnN0IFVDaGFyKj4oc3RkT3V0 LmdldCgpKTsKICAgICB3aGlsZSAobGluZUluZGV4IDwga051bUxpbmVzRXhwZWN0ZWQpIHsKICAg ICAgICAgY29uc3QgVUNoYXIqIHN0YXJ0ID0gY3VycmVudDsKICAgICAgICAgd2hpbGUgKCpjdXJy ZW50KysgIT0gVUNoYXIoJ1xuJykpIHsgfQo=