86233 2012-05-11 10:56:02 -0700 Remove bbox caching from SVGPathElement 2012-05-19 13:55:24 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis zimmermann oldest_to_newest 621803 0 rwlbuis 2012-05-11 10:56:02 -0700 I dont think this code adds much value, as SVGLocatable::getBBox is not used much out there. 621808 1 141450 rwlbuis 2012-05-11 10:58:04 -0700 Created attachment 141450 Patch 622178 2 rwlbuis 2012-05-11 18:29:51 -0700 I ran run-perf-tests on the svg PageLoad performance tests and there were no speed regressions there (makes sense since the changed code path is not called by these heavy svg tests). From our layout tests only svg/custom/getBBox-path.svg uses it, and there it is only asked once, so caching is not useful for this test. So overall I think the benefits outweigh the drawbacks of removing this caching, I just don't see this as a hot code path. 628417 3 141450 zimmermann 2012-05-19 08:23:53 -0700 Comment on attachment 141450 Patch Good idea, this was more beneficial in the past where renderers grabbed bounds using getBBox(). 628487 4 rwlbuis 2012-05-19 13:55:24 -0700 Committed r117696: <http://trac.webkit.org/changeset/117696> 141450 2012-05-11 10:58:04 -0700 2012-05-19 08:23:53 -0700 Patch bug-86233-20120511135834.patch text/plain 3406 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMzNjMwMzljNDE4MzQ0 OTQ5NjUwOTJlNjY2MGIxZDU0MTlmNDE5NS4uNjFjOTNhOWQzOWIzZTgyNDBjNjc1YjNlZDNiYjM3 MDE4ZDFmN2E4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTExICBSb2Ig QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGJib3ggY2FjaGluZyBmcm9t IFNWR1BhdGhFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NjIzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZSBjYWNoaW5nIG9mIHBhdGggYm91bmRpbmcgYm94LCBzaW5jZSBTVkdMb2Nh dGFibGU6OmdldEJCb3ggaXMgbm90IHVzZWQgbXVjaCBhdCBhbGwuCisgICAgICAgIFRoaXMgc2F2 ZXMgMjAwayBvZiBtZW1vcnkgZm9yIHdvcmxkY3VwLnN2ZyBvbiA2NC1iaXQgbWFjaGluZS4KKwor ICAgICAgICAqIHN2Zy9TVkdQYXRoRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdQ YXRoRWxlbWVudDo6U1ZHUGF0aEVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHUGF0aEVs ZW1lbnQ6OnN2Z0F0dHJpYnV0ZUNoYW5nZWQpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHUGF0aEVs ZW1lbnQ6OnBhdGhTZWdMaXN0Q2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpTVkdQYXRoRWxl bWVudDo6Z2V0QkJveCk6CisgICAgICAgICogc3ZnL1NWR1BhdGhFbGVtZW50Lmg6CisgICAgICAg IChTVkdQYXRoRWxlbWVudCk6CisKIDIwMTItMDUtMTEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogbW92ZSBicmVha3BvaW50 IG1hbmFnZXIgZnJvbSBkZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsIHRvIFdlYkluc3BlY3Rvci4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYXRoRWxlbWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHUGF0aEVsZW1lbnQuY3BwCmluZGV4IGNjYWMzMDFlMTllNWNhZTFl ZGE1MjhlOWE4YjM3YWIzNDVlNDVlNmMuLjc2NWQyMjM1MDQ5YTM4YTMzMjBjOTY2NDE1NjE4ZGMz YmMwMDhmZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYXRoRWxlbWVudC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1BhdGhFbGVtZW50LmNwcApAQCAtNzYsNyAr NzYsNiBAQCBpbmxpbmUgU1ZHUGF0aEVsZW1lbnQ6OlNWR1BhdGhFbGVtZW50KGNvbnN0IFF1YWxp ZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50KiBkbwogICAgIDogU1ZHU3R5bGVkVHJhbnNmb3Jt YWJsZUVsZW1lbnQodGFnTmFtZSwgZG9jdW1lbnQpCiAgICAgLCBtX3BhdGhCeXRlU3RyZWFtKFNW R1BhdGhCeXRlU3RyZWFtOjpjcmVhdGUoKSkKICAgICAsIG1fcGF0aFNlZ0xpc3QoUGF0aFNlZ1Vu YWx0ZXJlZFJvbGUpCi0gICAgLCBtX2NhY2hlZEJCb3hSZWN0SXNWYWxpZChmYWxzZSkKICAgICAs IG1faXNBbmltVmFsT2JzZXJ2ZWQoZmFsc2UpCiB7CiAgICAgQVNTRVJUKGhhc1RhZ05hbWUoU1ZH TmFtZXM6OnBhdGhUYWcpKTsKQEAgLTI2Niw3ICsyNjUsNiBAQCB2b2lkIFNWR1BhdGhFbGVtZW50 OjpzdmdBdHRyaWJ1dGVDaGFuZ2VkKGNvbnN0IFF1YWxpZmllZE5hbWUmIGF0dHJOYW1lKQogICAg ICAgICAgICAgU1ZHUGF0aFNlZ0xpc3QgbmV3TGlzdChQYXRoU2VnVW5hbHRlcmVkUm9sZSk7CiAg ICAgICAgICAgICBidWlsZFNWR1BhdGhTZWdMaXN0RnJvbUJ5dGVTdHJlYW0obV9wYXRoQnl0ZVN0 cmVhbS5nZXQoKSwgdGhpcywgbmV3TGlzdCwgVW5hbHRlcmVkUGFyc2luZyk7CiAgICAgICAgICAg ICBtX3BhdGhTZWdMaXN0LnZhbHVlID0gbmV3TGlzdDsKLSAgICAgICAgICAgIG1fY2FjaGVkQkJv eFJlY3RJc1ZhbGlkID0gZmFsc2U7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAocmVuZGVyZXIp CkBAIC0zNDksOCArMzQ3LDYgQEAgdm9pZCBTVkdQYXRoRWxlbWVudDo6cGF0aFNlZ0xpc3RDaGFu Z2VkKFNWR1BhdGhTZWdSb2xlIHJvbGUpCiAKICAgICBpbnZhbGlkYXRlU1ZHQXR0cmlidXRlcygp OwogICAgIAotICAgIG1fY2FjaGVkQkJveFJlY3RJc1ZhbGlkID0gZmFsc2U7Ci0KICAgICBSZW5k ZXJTVkdQYXRoKiByZW5kZXJlciA9IHN0YXRpY19jYXN0PFJlbmRlclNWR1BhdGgqPih0aGlzLT5y ZW5kZXJlcigpKTsKICAgICBpZiAoIXJlbmRlcmVyKQogICAgICAgICByZXR1cm47CkBAIC0zNzAs MTIgKzM2Niw3IEBAIEZsb2F0UmVjdCBTVkdQYXRoRWxlbWVudDo6Z2V0QkJveChTdHlsZVVwZGF0 ZVN0cmF0ZWd5IHN0eWxlVXBkYXRlU3RyYXRlZ3kpCiAgICAgaWYgKCFyZW5kZXJlcikKICAgICAg ICAgcmV0dXJuIEZsb2F0UmVjdCgpOwogCi0gICAgaWYgKCFtX2NhY2hlZEJCb3hSZWN0SXNWYWxp ZCkgewotICAgICAgICBtX2NhY2hlZEJCb3hSZWN0ID0gcmVuZGVyZXItPnBhdGgoKS5ib3VuZGlu Z1JlY3QoKTsKLSAgICAgICAgbV9jYWNoZWRCQm94UmVjdElzVmFsaWQgPSB0cnVlOwotICAgIH0K LSAgICAKLSAgICByZXR1cm4gbV9jYWNoZWRCQm94UmVjdDsKKyAgICByZXR1cm4gcmVuZGVyZXIt PnBhdGgoKS5ib3VuZGluZ1JlY3QoKTsKIH0KIAogUmVuZGVyT2JqZWN0KiBTVkdQYXRoRWxlbWVu dDo6Y3JlYXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZSopCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUGF0aEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJD b3JlL3N2Zy9TVkdQYXRoRWxlbWVudC5oCmluZGV4IDY4NTU4ZGI0M2IzNTM4NDA0NmFmNzYxNWI2 NjRlNGJlZTQ0MDI5OGMuLjdjNGM5YTY4NDAyZjQ2YzlhZjJkMGQ0N2E0NmQ3NjExOTg4ZDE2MzYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYXRoRWxlbWVudC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3N2Zy9TVkdQYXRoRWxlbWVudC5oCkBAIC0xMzEsOCArMTMxLDYgQEAgcHJp dmF0ZToKIHByaXZhdGU6CiAgICAgT3duUHRyPFNWR1BhdGhCeXRlU3RyZWFtPiBtX3BhdGhCeXRl U3RyZWFtOwogICAgIG11dGFibGUgU1ZHU3luY2hyb25pemFibGVBbmltYXRlZFByb3BlcnR5PFNW R1BhdGhTZWdMaXN0PiBtX3BhdGhTZWdMaXN0OwotICAgIEZsb2F0UmVjdCBtX2NhY2hlZEJCb3hS ZWN0OwotICAgIGJvb2wgbV9jYWNoZWRCQm94UmVjdElzVmFsaWQ7ICAgICAgICAgICAgICAgICAg ICAgICAKICAgICBib29sIG1faXNBbmltVmFsT2JzZXJ2ZWQ7CiB9OwogCg==