86226 2012-05-11 10:21:06 -0700 Remove RenderLayer::m_scrollOverflow 2012-05-11 11:47:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix enne eric jamesr simon.fraser webkit.review.bot oldest_to_newest 621759 0 jchaffraix 2012-05-11 10:21:06 -0700 m_scrollOverflow is used in only 1 place: IntSize scrolledContentOffset() const { return scrollOffset() + m_scrollOverflow; } m_scrollOverflow is always set to the opposite of scrollOrigin in computeScrollDimensions() and the previous function is basically returning m_scrollOffset as RenderLayer::scrollOffset() adds scrollOrigin() to m_scrollOffset. Let's kill this confusing variable. 621770 1 141440 jchaffraix 2012-05-11 10:31:24 -0700 Created attachment 141440 Proposed removal 1. 621842 2 141440 webkit.review.bot 2012-05-11 11:47:37 -0700 Comment on attachment 141440 Proposed removal 1. Clearing flags on attachment: 141440 Committed r116790: <http://trac.webkit.org/changeset/116790> 621843 3 webkit.review.bot 2012-05-11 11:47:42 -0700 All reviewed patches have been landed. Closing bug. 141440 2012-05-11 10:31:24 -0700 2012-05-11 11:47:37 -0700 Proposed removal 1. bug-86226-20120511103122.patch text/plain 3260 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVhN2ZmNmJiYTI3ZGUy NWZmN2E0MGJmZmE1YWEzMDgxOWJlNGE5NC4uNGMxN2VmNzQ0NjRmZDg1MWJlZWRlZGE4NzIyNjVj OWQzZGY0NjIxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA1LTExICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBS ZW5kZXJMYXllcjo6bV9zY3JvbGxPdmVyZmxvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYyMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBleHBlY3RlZCBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyTGF5ZXI6OmNvbXB1dGVTY3JvbGxEaW1lbnNpb25zKToKKyAgICAgICAgQWRkZWQgMiBsb2Nh bCB2YXJpYWJsZXMgdG8gY29tcHV0ZSB0aGUgbGVmdCAvIHRvcCBzY3JvbGxhYmxlIG92ZXJmbG93 cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5oOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyTGF5ZXI6OnNjcm9sbGVkQ29udGVudE9mZnNldCk6CisgICAgICAgIFJldHVybmVk IG1fc2Nyb2xsT2Zmc2V0IGRpcmVjdGx5IGFzIHRoaXMgaXMgd2hhdCB0aGUgb2xkIGNvZGUgd2Fz IGRvaW5nIGJ5IGFkZGluZworICAgICAgICBtX3Njcm9sbE9yaWdpbiB0aGVuIGFkZGluZyBtX3Nj cm9sbE92ZXJmbG93ICh3aGljaCB3YXMgc2V0IHRvIC1tX3Njcm9sbE9yaWdpbiBpbgorICAgICAg ICBjb21wdXRlU2Nyb2xsRGltZW5zaW9ucykuCisKKyAgICAgICAgKFJlbmRlckxheWVyOjptX3Nj cm9sbE9mZnNldCk6IEltcHJvdmVkIHRoZSBjb21tZW50IGFib3V0IHdoYXQgbV9zY3JvbGxPZmZz ZXQgaXMuCisKIDIwMTItMDUtMTEgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIFByb2ZpbGVyLmdldEhlYXBPYmplY3RJ ZCBjb21tYW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCAx YzExMDNjZTk5MTJjZGI1MDNiOTcwOGZlZjg0MWQ3Y2ZkMTdkYmJlLi43M2U5N2ZhODg3ZGQ5MWI5 MDhmOWQzYThlMjM1ZjgxMGFmY2MxOTc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5jcHAKQEAgLTI0MzIsMTMgKzI0MzIsMTIgQEAgdm9pZCBSZW5kZXJMYXllcjo6Y29t cHV0ZVNjcm9sbERpbWVuc2lvbnMoKQogCiAgICAgbV9zY3JvbGxEaW1lbnNpb25zRGlydHkgPSBm YWxzZTsKIAotICAgIG1fc2Nyb2xsT3ZlcmZsb3cuc2V0V2lkdGgob3ZlcmZsb3dMZWZ0KCkgLSBi b3gtPmJvcmRlckxlZnQoKSk7Ci0gICAgbV9zY3JvbGxPdmVyZmxvdy5zZXRIZWlnaHQob3ZlcmZs b3dUb3AoKSAtIGJveC0+Ym9yZGVyVG9wKCkpOwotCiAgICAgbV9zY3JvbGxTaXplLnNldFdpZHRo KG92ZXJmbG93UmlnaHQoKSAtIG92ZXJmbG93TGVmdCgpKTsKICAgICBtX3Njcm9sbFNpemUuc2V0 SGVpZ2h0KG92ZXJmbG93Qm90dG9tKCkgLSBvdmVyZmxvd1RvcCgpKTsKIAotICAgIHNldFNjcm9s bE9yaWdpbihJbnRQb2ludCgtbV9zY3JvbGxPdmVyZmxvdy53aWR0aCgpLCAtbV9zY3JvbGxPdmVy Zmxvdy5oZWlnaHQoKSkpOworICAgIGludCBzY3JvbGxhYmxlTGVmdE92ZXJmbG93ID0gb3ZlcmZs b3dMZWZ0KCkgLSBib3gtPmJvcmRlckxlZnQoKTsKKyAgICBpbnQgc2Nyb2xsYWJsZVRvcE92ZXJm bG93ID0gb3ZlcmZsb3dUb3AoKSAtIGJveC0+Ym9yZGVyVG9wKCk7CisgICAgc2V0U2Nyb2xsT3Jp Z2luKEludFBvaW50KC1zY3JvbGxhYmxlTGVmdE92ZXJmbG93LCAtc2Nyb2xsYWJsZVRvcE92ZXJm bG93KSk7CiB9CiAKIGJvb2wgUmVuZGVyTGF5ZXI6Omhhc0hvcml6b250YWxPdmVyZmxvdygpIGNv bnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCmluZGV4IDliMzRlN2Y2NmQy NWMxYzRlZTU2MDZiZGE5OTNhZWZlZTM5M2JlMTkuLmViMzZjMzRkMzJmNTFhNmQ0MGZjZWMxMWMw NWE0NTgwOTQ4OThkZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCkBA IC02MzUsNyArNjM1LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIHVwZGF0ZVNjcm9sbGJhcnNBZnRl ckxheW91dCgpOwogCiAgICAgZnJpZW5kIEludFNpemUgUmVuZGVyQm94OjpzY3JvbGxlZENvbnRl bnRPZmZzZXQoKSBjb25zdDsKLSAgICBJbnRTaXplIHNjcm9sbGVkQ29udGVudE9mZnNldCgpIGNv bnN0IHsgcmV0dXJuIHNjcm9sbE9mZnNldCgpICsgbV9zY3JvbGxPdmVyZmxvdzsgfQorICAgIElu dFNpemUgc2Nyb2xsZWRDb250ZW50T2Zmc2V0KCkgY29uc3QgeyByZXR1cm4gbV9zY3JvbGxPZmZz ZXQ7IH0KIAogICAgIC8vIFRoZSBub3JtYWwgb3BlcmF0b3IgbmV3IGlzIGRpc2FsbG93ZWQgb24g YWxsIHJlbmRlciBvYmplY3RzLgogICAgIHZvaWQqIG9wZXJhdG9yIG5ldyhzaXplX3QpIHRocm93 KCk7CkBAIC04ODMsMTEgKzg4Myw5IEBAIHByb3RlY3RlZDoKICAgICAvLyBUaGUgbGF5ZXIncyB3 aWR0aC9oZWlnaHQKICAgICBJbnRTaXplIG1fbGF5ZXJTaXplOwogCi0gICAgLy8gT3VyIHNjcm9s bCBvZmZzZXRzIGlmIHRoZSB2aWV3IGlzIHNjcm9sbGVkLgorICAgIC8vIFRoaXMgaXMgdGhlIChz Y3JvbGwpIG9mZnNldCBmcm9tIHNjcm9sbE9yaWdpbigpLgogICAgIEludFNpemUgbV9zY3JvbGxP ZmZzZXQ7CiAKLSAgICBJbnRTaXplIG1fc2Nyb2xsT3ZlcmZsb3c7Ci0gICAgCiAgICAgLy8gVGhl IHdpZHRoL2hlaWdodCBvZiBvdXIgc2Nyb2xsZWQgYXJlYS4KICAgICBMYXlvdXRTaXplIG1fc2Ny b2xsU2l6ZTsKIAo=