86219 2012-05-11 08:45:42 -0700 ImageSkia.cpp does not conform to style guidelines 2012-05-11 14:40:10 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P5 Trivial --- 0 keyar webkit-unassigned keyar senorblanco webkit.review.bot oldest_to_newest 621671 0 keyar 2012-05-11 08:45:42 -0700 The file WebCore/platform/graphics/skia/ImageSkia.cpp does not conform to the style guidelines. 621807 1 141449 keyar 2012-05-11 10:57:45 -0700 Created attachment 141449 Patch 621821 2 141449 senorblanco 2012-05-11 11:18:08 -0700 Comment on attachment 141449 Patch Looks good (assuming the bots like it). Thanks for the cleanup. r=me 621985 3 141449 webkit.review.bot 2012-05-11 14:40:06 -0700 Comment on attachment 141449 Patch Clearing flags on attachment: 141449 Committed r116806: <http://trac.webkit.org/changeset/116806> 621986 4 webkit.review.bot 2012-05-11 14:40:10 -0700 All reviewed patches have been landed. Closing bug. 141449 2012-05-11 10:57:45 -0700 2012-05-11 14:40:06 -0700 Patch bug-86219-20120511135743.patch text/plain 4057 keyar U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzJmOTBmNmI2NDMyNTg4 NTMzZTIxZGQ2ZDU5NGI4YWMwYTA2N2Y5MS4uOTliYjFmMDAyMDJmMzkyMTJlN2EwNjNkMjhjOGRi NzMxYzA0NmFhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTExICBLZXlh ciBIb29kICA8a2V5YXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEltYWdlU2tpYS5jcHAgZG9l cyBub3QgY29uZm9ybSB0byBzdHlsZSBndWlkZWxpbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjIxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIHRlc3RzIGFzIHRoaXMgaXMgcHVyZWx5IHN0eWxl IGNoYW5nZWVzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6VHJhbnNmb3JtRGltZW5zaW9ucyk6CisgICAgICAgIChX ZWJDb3JlOjpCaXRtYXBJbWFnZTo6ZHJhdyk6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFn ZVNpbmdsZUZyYW1lU2tpYTo6ZHJhdyk6CisKIDIwMTItMDUtMTAgIEFiaGlzaGVrIEFyeWEgIDxp bmZlcm5vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDcmFzaCBpbiBJbnNlcnRQYXJhZ3JhcGhT ZXBhcmF0b3JDb21tYW5kOjpkb0FwcGx5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCmluZGV4IDQ3MzJkMWQyMmM3ZjUzZGMwNmZl NDRhZDVlNzYwZmZkZDI1ZDdiMTEuLjU3YmFmMTBiN2VkMWNhMDZmYmI5NTIyM2RjZWI4YzgwY2Uy ZjI1ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv SW1hZ2VTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0ltYWdlU2tpYS5jcHAKQEAgLTI1MywyMCArMjUzLDIxIEBAIHN0YXRpYyB2b2lkIHBhaW50U2tC aXRtYXAoUGxhdGZvcm1Db250ZXh0U2tpYSogcGxhdGZvcm1Db250ZXh0LCBjb25zdCBOYXRpdmVJ bWFnCiAKIC8vIFRyYW5zZm9ybXMgdGhlIGdpdmVuIGRpbWVuc2lvbnMgd2l0aCB0aGUgZ2l2ZW4g bWF0cml4LiBVc2VkIHRvIHNlZSBob3cgYmlnCiAvLyBpbWFnZXMgd2lsbCBiZSBvbmNlIHRyYW5z Zm9ybWVkLgotc3RhdGljIHZvaWQgVHJhbnNmb3JtRGltZW5zaW9ucyhjb25zdCBTa01hdHJpeCYg bWF0cml4LCBmbG9hdCBzcmNXaWR0aCwgZmxvYXQgc3JjSGVpZ2h0LCBmbG9hdCogZGVzdFdpZHRo LCBmbG9hdCogZGVzdEhlaWdodCkgeworc3RhdGljIHZvaWQgVHJhbnNmb3JtRGltZW5zaW9ucyhj b25zdCBTa01hdHJpeCYgbWF0cml4LCBmbG9hdCBzcmNXaWR0aCwgZmxvYXQgc3JjSGVpZ2h0LCBm bG9hdCogZGVzdFdpZHRoLCBmbG9hdCogZGVzdEhlaWdodCkKK3sKICAgICAvLyBUcmFuc2Zvcm0g MyBwb2ludHMgdG8gc2VlIGhvdyBsb25nIGVhY2ggc2lkZSBvZiB0aGUgYml0bWFwIHdpbGwgYmUu Ci0gICAgU2tQb2ludCBzcmNfcG9pbnRzWzNdOyAgLy8gKDAsIDApLCAod2lkdGgsIDApLCAoMCwg aGVpZ2h0KS4KLSAgICBzcmNfcG9pbnRzWzBdLnNldCgwLCAwKTsKLSAgICBzcmNfcG9pbnRzWzFd LnNldChTa0Zsb2F0VG9TY2FsYXIoc3JjV2lkdGgpLCAwKTsKLSAgICBzcmNfcG9pbnRzWzJdLnNl dCgwLCBTa0Zsb2F0VG9TY2FsYXIoc3JjSGVpZ2h0KSk7CisgICAgU2tQb2ludCBzcmNQb2ludHNb M107IC8vICgwLCAwKSwgKHdpZHRoLCAwKSwgKDAsIGhlaWdodCkuCisgICAgc3JjUG9pbnRzWzBd LnNldCgwLCAwKTsKKyAgICBzcmNQb2ludHNbMV0uc2V0KFNrRmxvYXRUb1NjYWxhcihzcmNXaWR0 aCksIDApOworICAgIHNyY1BvaW50c1syXS5zZXQoMCwgU2tGbG9hdFRvU2NhbGFyKHNyY0hlaWdo dCkpOwogCiAgICAgLy8gTm93IG1lYXN1cmUgdGhlIGxlbmd0aCBvZiB0aGUgdHdvIHRyYW5zZm9y bWVkIHZlY3RvcnMgcmVsYXRpdmUgdG8gdGhlCiAgICAgLy8gdHJhbnNmb3JtZWQgb3JpZ2luIHRv IHNlZSBob3cgYmlnIHRoZSBiaXRtYXAgd2lsbCBiZS4gTm90ZTogZm9yIHNrZXdzLAogICAgIC8v IHRoaXMgaXNuJ3QgdGhlIGJlc3QgdGhpbmcsIGJ1dCB3ZSBkb24ndCBoYXZlIHNrZXdzLgotICAg IFNrUG9pbnQgZGVzdF9wb2ludHNbM107Ci0gICAgbWF0cml4Lm1hcFBvaW50cyhkZXN0X3BvaW50 cywgc3JjX3BvaW50cywgMyk7Ci0gICAgKmRlc3RXaWR0aCA9IFNrU2NhbGFyVG9GbG9hdCgoZGVz dF9wb2ludHNbMV0gLSBkZXN0X3BvaW50c1swXSkubGVuZ3RoKCkpOwotICAgICpkZXN0SGVpZ2h0 ID0gU2tTY2FsYXJUb0Zsb2F0KChkZXN0X3BvaW50c1syXSAtIGRlc3RfcG9pbnRzWzBdKS5sZW5n dGgoKSk7CisgICAgU2tQb2ludCBkZXN0UG9pbnRzWzNdOworICAgIG1hdHJpeC5tYXBQb2ludHMo ZGVzdFBvaW50cywgc3JjUG9pbnRzLCAzKTsKKyAgICAqZGVzdFdpZHRoID0gU2tTY2FsYXJUb0Zs b2F0KChkZXN0UG9pbnRzWzFdIC0gZGVzdFBvaW50c1swXSkubGVuZ3RoKCkpOworICAgICpkZXN0 SGVpZ2h0ID0gU2tTY2FsYXJUb0Zsb2F0KChkZXN0UG9pbnRzWzJdIC0gZGVzdFBvaW50c1swXSku bGVuZ3RoKCkpOwogfQogCiAvLyBBIGhlbHBlciBtZXRob2QgZm9yIHRyYW5zbGF0aW5nIG5lZ2F0 aXZlIHdpZHRoIGFuZCBoZWlnaHQgdmFsdWVzLgpAQCAtNDI4LDEzICs0MjksMTMgQEAgdm9pZCBC aXRtYXBJbWFnZTo6ZHJhdyhHcmFwaGljc0NvbnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVjdCYg ZHN0UmVjdCwKIAogICAgIE5hdGl2ZUltYWdlU2tpYSogYm0gPSBuYXRpdmVJbWFnZUZvckN1cnJl bnRGcmFtZSgpOwogICAgIGlmICghYm0pCi0gICAgICAgIHJldHVybjsgIC8vIEl0J3MgdG9vIGVh cmx5IGFuZCB3ZSBkb24ndCBoYXZlIGFuIGltYWdlIHlldC4KKyAgICAgICAgcmV0dXJuOyAvLyBJ dCdzIHRvbyBlYXJseSBhbmQgd2UgZG9uJ3QgaGF2ZSBhbiBpbWFnZSB5ZXQuCiAKICAgICBGbG9h dFJlY3Qgbm9ybURzdFJlY3QgPSBub3JtYWxpemVSZWN0KGRzdFJlY3QpOwogICAgIEZsb2F0UmVj dCBub3JtU3JjUmVjdCA9IG5vcm1hbGl6ZVJlY3Qoc3JjUmVjdCk7CiAKICAgICBpZiAobm9ybVNy Y1JlY3QuaXNFbXB0eSgpIHx8IG5vcm1Ec3RSZWN0LmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJu OyAgLy8gTm90aGluZyB0byBkcmF3LgorICAgICAgICByZXR1cm47IC8vIE5vdGhpbmcgdG8gZHJh dy4KIAogICAgIHBhaW50U2tCaXRtYXAoY3R4dC0+cGxhdGZvcm1Db250ZXh0KCksCiAgICAgICAg ICAgICAgICAgICAqYm0sCkBAIC00NTgsNyArNDU5LDcgQEAgdm9pZCBCaXRtYXBJbWFnZVNpbmds ZUZyYW1lU2tpYTo6ZHJhdyhHcmFwaGljc0NvbnRleHQqIGN0eHQsCiAgICAgRmxvYXRSZWN0IG5v cm1TcmNSZWN0ID0gbm9ybWFsaXplUmVjdChzcmNSZWN0KTsKIAogICAgIGlmIChub3JtU3JjUmVj dC5pc0VtcHR5KCkgfHwgbm9ybURzdFJlY3QuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm47ICAv LyBOb3RoaW5nIHRvIGRyYXcuCisgICAgICAgIHJldHVybjsgLy8gTm90aGluZyB0byBkcmF3Lgog CiAgICAgcGFpbnRTa0JpdG1hcChjdHh0LT5wbGF0Zm9ybUNvbnRleHQoKSwKICAgICAgICAgICAg ICAgICAgIG1fbmF0aXZlSW1hZ2UsCkBAIC00ODYsNCArNDg3LDQgQEAgUGFzc1JlZlB0cjxCaXRt YXBJbWFnZVNpbmdsZUZyYW1lU2tpYT4gQml0bWFwSW1hZ2VTaW5nbGVGcmFtZVNraWE6OmNyZWF0 ZShjb25zdAogICAgIHJldHVybiBhZG9wdFJlZihuZXcgQml0bWFwSW1hZ2VTaW5nbGVGcmFtZVNr aWEoYml0bWFwKSk7CiB9CiAKLX0gIC8vIG5hbWVzcGFjZSBXZWJDb3JlCit9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCg==