86205 2012-05-11 06:03:47 -0700 Internals::touchPositionAdjustedToBestClickableNode adjust twice for scroll-offset 2012-05-11 07:04:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 621545 0 allan.jensen 2012-05-11 06:03:47 -0700 The function Internals::touchPositionAdjustedToBestClickableNode adjusts internally for scroll-offset, but this adjustment is now performed earlier and more generally and should not be performed here. 621548 1 141393 allan.jensen 2012-05-11 06:06:47 -0700 Created attachment 141393 Patch 621605 2 141393 webkit.review.bot 2012-05-11 07:04:00 -0700 Comment on attachment 141393 Patch Clearing flags on attachment: 141393 Committed r116766: <http://trac.webkit.org/changeset/116766> 621606 3 webkit.review.bot 2012-05-11 07:04:04 -0700 All reviewed patches have been landed. Closing bug. 141393 2012-05-11 06:06:47 -0700 2012-05-11 07:04:00 -0700 Patch bug-86205-20120511150651.patch text/plain 7515 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWQwMmRhM2FiMDc2OGZm ODUyMzU0ZDQ4YWFhOTEzNGFmOTY1MGNiMS4uODllYTg4NDUyOTVjNGQ4MTAwYzY0N2Y3M2FhODdl NjJhYzEwZDNhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTExICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIElu dGVybmFsczo6dG91Y2hQb3NpdGlvbkFkanVzdGVkVG9CZXN0Q2xpY2thYmxlTm9kZSBhZGp1c3Qg dHdpY2UgZm9yIHNjcm9sbC1vZmZzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg2MjA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSByZWR1bmRhbnQgY29udmVyc2lvbiBmcm9tIGRvY3Vt ZW50IHRvIHdpbmRvdyBjb29yZHMuCisKKyAgICAgICAgVGVzdDogdG91Y2hhZGp1c3RtZW50L3Nj cm9sbC1vZmZzZXQuaHRtbAorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW50ZXJuYWxzOjp0b3VjaFBvc2l0aW9uQWRqdXN0ZWRUb0Jlc3RDbGlj a2FibGVOb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6YmVzdFpvb21hYmxlQXJl YUZvclRvdWNoUG9pbnQpOgorCiAyMDEyLTA1LTA3ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGdldCByaWQgb2YgSW5zcGVj dG9yQWdlbnQ6OmVtaXRDb21taXRMb2FkSWZOZWVkZWQgbWV0aG9kCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5jcHAKaW5kZXggYmY3ZGViOWYwZWRjZGI1MDU5ODkwMThlMDNkNzRiYmMzMmZh MjFlNy4uYzU2MDgwYmZjNWY0OGVhNDU5YWQ5ZDJhNmIzMTdkZDE0MTMzNWM0MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtNzI1LDExICs3MjUsMTIgQEAgUGFzc1JlZlB0 cjxXZWJLaXRQb2ludD4gSW50ZXJuYWxzOjp0b3VjaFBvc2l0aW9uQWRqdXN0ZWRUb0Jlc3RDbGlj a2FibGVOb2RlKGxvbmcKIAogICAgIE5vZGUqIHRhcmdldE5vZGU7CiAgICAgSW50UG9pbnQgYWRq dXN0ZWRQb2ludDsKLSAgICBkb2N1bWVudC0+ZnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPmJlc3RD bGlja2FibGVOb2RlRm9yVG91Y2hQb2ludChwb2ludCwgcmFkaXVzLCBhZGp1c3RlZFBvaW50LCB0 YXJnZXROb2RlKTsKLSAgICBpZiAodGFyZ2V0Tm9kZSkKLSAgICAgICAgYWRqdXN0ZWRQb2ludCA9 IHRhcmdldE5vZGUtPmRvY3VtZW50KCktPnZpZXcoKS0+Y29udGVudHNUb1dpbmRvdyhhZGp1c3Rl ZFBvaW50KTsKIAotICAgIHJldHVybiBXZWJLaXRQb2ludDo6Y3JlYXRlKGFkanVzdGVkUG9pbnQu eCgpLCBhZGp1c3RlZFBvaW50LnkoKSk7CisgICAgYm9vbCBmb3VuZE5vZGUgPSBkb2N1bWVudC0+ ZnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPmJlc3RDbGlja2FibGVOb2RlRm9yVG91Y2hQb2ludChw b2ludCwgcmFkaXVzLCBhZGp1c3RlZFBvaW50LCB0YXJnZXROb2RlKTsKKyAgICBpZiAoZm91bmRO b2RlKQorICAgICAgICByZXR1cm4gV2ViS2l0UG9pbnQ6OmNyZWF0ZShhZGp1c3RlZFBvaW50Lngo KSwgYWRqdXN0ZWRQb2ludC55KCkpOworCisgICAgcmV0dXJuIDA7CiB9CiAKIE5vZGUqIEludGVy bmFsczo6dG91Y2hOb2RlQWRqdXN0ZWRUb0Jlc3RDbGlja2FibGVOb2RlKGxvbmcgeCwgbG9uZyB5 LCBsb25nIHdpZHRoLCBsb25nIGhlaWdodCwgRG9jdW1lbnQqIGRvY3VtZW50LCBFeGNlcHRpb25D b2RlJiBlYykKQEAgLTc2MCw5ICs3NjEsMTEgQEAgUGFzc1JlZlB0cjxDbGllbnRSZWN0PiBJbnRl cm5hbHM6OmJlc3Rab29tYWJsZUFyZWFGb3JUb3VjaFBvaW50KGxvbmcgeCwgbG9uZyB5LAogCiAg ICAgTm9kZSogdGFyZ2V0Tm9kZTsKICAgICBJbnRSZWN0IHpvb21hYmxlQXJlYTsKLSAgICBkb2N1 bWVudC0+ZnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPmJlc3Rab29tYWJsZUFyZWFGb3JUb3VjaFBv aW50KHBvaW50LCByYWRpdXMsIHpvb21hYmxlQXJlYSwgdGFyZ2V0Tm9kZSk7CisgICAgYm9vbCBm b3VuZE5vZGUgPSBkb2N1bWVudC0+ZnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPmJlc3Rab29tYWJs ZUFyZWFGb3JUb3VjaFBvaW50KHBvaW50LCByYWRpdXMsIHpvb21hYmxlQXJlYSwgdGFyZ2V0Tm9k ZSk7CisgICAgaWYgKGZvdW5kTm9kZSkKKyAgICAgICAgcmV0dXJuIENsaWVudFJlY3Q6OmNyZWF0 ZSh6b29tYWJsZUFyZWEpOwogCi0gICAgcmV0dXJuIENsaWVudFJlY3Q6OmNyZWF0ZSh6b29tYWJs ZUFyZWEpOworICAgIHJldHVybiAwOwogfQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZjFhMzk5ZTRhMzMx YTkyYTM5MDA0MGJjNWQ2NjBlYTRjMGU1NTM1Li45NGUwOGMxN2Y5YTdiMGI0YjExYzMyNDRmY2Y3 ZTgzNjY3NjA0MWIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUtMTEgIEFsbGFuIFNh bmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CisKKyAgICAgICAgSW50ZXJu YWxzOjp0b3VjaFBvc2l0aW9uQWRqdXN0ZWRUb0Jlc3RDbGlja2FibGVOb2RlIGFkanVzdCB0d2lj ZSBmb3Igc2Nyb2xsLW9mZnNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODYyMDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgdGVzdCBvZiB0b3VjaFBvc2l0aW9uQWRqdXN0ZWRUb0Jlc3RDbGlja2Fi bGVOb2RlIHdpdGggc2Nyb2xsLW9mZnNldC4KKworICAgICAgICAqIHRvdWNoYWRqdXN0bWVudC9z Y3JvbGwtb2Zmc2V0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogdG91Y2hhZGp1c3Rt ZW50L3Njcm9sbC1vZmZzZXQuaHRtbDogQWRkZWQuCisKIDIwMTItMDUtMTAgIEFuZHJleSBLb3N5 YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbRXh0 ZW5zaW9ucyBBUEldIGFkZCBhdWRpdCBmb3JtYXR0ZXJzIGZvciByZW1vdGUgb2JqZWN0cyBhbmQg RE9NIGVsZW1lbnRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90b3VjaGFkanVzdG1lbnQvc2Ny b2xsLW9mZnNldC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy90b3VjaGFkanVzdG1lbnQvc2Ny b2xsLW9mZnNldC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjkyNGNjOTUzMGMxODdjZDdiODll YzdhZWZlZjAwNTlkMzA2MjVkOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3RvdWNo YWRqdXN0bWVudC9zY3JvbGwtb2Zmc2V0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIwIEBACitM aW5rIDAKK0xpbmsgMQorVGVzdCB0b3VjaCBhZGp1c3RtZW50IHdoZW4gbWFpbiBmcmFtZSBpcyBz Y3JvbGwgb2Zmc2V0LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitQQVNTIGFkanVzdGVkTm9k ZS5pZCBpcyAiYTAiCitQQVNTIGFkanVzdGVkTm9kZS5pZCBpcyAiYTEiCitQQVNTIGFkanVzdGVk UG9pbnQgaXMgbm9uLW51bGwuCitQQVNTIGFkanVzdGVkTm9kZS5pZCBpcyAiYTAiCitQQVNTIGFk anVzdGVkUG9pbnQgaXMgbm9uLW51bGwuCitQQVNTIGFkanVzdGVkTm9kZS5pZCBpcyAiYTEiCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvdG91Y2hhZGp1c3RtZW50L3Njcm9sbC1vZmZzZXQuaHRtbCBiL0xh eW91dFRlc3RzL3RvdWNoYWRqdXN0bWVudC9zY3JvbGwtb2Zmc2V0Lmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u MGE5NzM3ODY2MmFhZTkzZjMxMTdiZDU5YjBhZGE3ZDU3MGM2ZGU1NQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3RvdWNoYWRqdXN0bWVudC9zY3JvbGwtb2Zmc2V0Lmh0bWwKQEAgLTAs MCArMSw5NCBAQAorPGh0bWw+Cis8aGVhZD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9y ZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICAgIDxzdHlsZT4KKyAgICAgICAg I3Njcm9sbG9mZnNldGNvbnRhaW5lciB7CisgICAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7 CisgICAgICAgICAgICB0b3A6IDUwMHB4OworICAgICAgICAgICAgaGVpZ2h0OiAxMDAwcHg7Cisg ICAgICAgIH0KKyAgICAgICAgYm9keSB7CisgICAgICAgICAgICBtYXJnaW46IDBweDsKKyAgICAg ICAgfQorICAgICAgICAjZGl2MCB7IG1hcmdpbi1sZWZ0OiAyMHB4OyBoZWlnaHQ6IDEwMHB4OyBi b3gtc2l6aW5nOiBib3JkZXItYm94OyB9CisgICAgICAgICNkaXYxIHsgbWFyZ2luLWxlZnQ6IDEw cHg7IGhlaWdodDogMTAwcHg7IGJveC1zaXppbmc6IGJvcmRlci1ib3g7IH0KKyAgICA8L3N0eWxl PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0cygpIj4KKworPGRpdiBpZD1zY3JvbGxv ZmZzZXRjb250YWluZXI+CisgICAgPGRpdiBpZD1kaXYwPgorICAgICAgICA8YSBpZD1hMCBocmVm PSIjZGl2MCI+TGluayAwPC9hPgorICAgIDwvZGl2PgorICAgIDxkaXYgaWQ9ZGl2MT4KKyAgICAg ICAgPGEgaWQ9YTEgaHJlZj0iI2RpdjEiPkxpbmsgMTwvYT4KKyAgICA8L2Rpdj4KKzwvZGl2Pgor Cis8cCBpZD0nZGVzY3JpcHRpb24nPjwvcD4KKzxkaXYgaWQ9J2NvbnNvbGUnPjwvZGl2PgorCis8 c2NyaXB0PgorICAgIHZhciBhZGp1c3RlZE5vZGU7CisgICAgdmFyIGFkanVzdGVkUG9pbnQ7Cisg ICAgZnVuY3Rpb24gbm9kZUF0VG91Y2goeCwgeSwgcmFkaXVzKQorICAgIHsKKyAgICAgICAgdmFy IHggPSB4IC0gcmFkaXVzOworICAgICAgICB2YXIgeSA9IHkgLSByYWRpdXM7CisgICAgICAgIHZh ciB3aWR0aCA9IHJhZGl1cyAqIDI7CisgICAgICAgIHZhciBoZWlnaHQgPSByYWRpdXMgKiAyOwor ICAgICAgICB2YXIgYWRqdXN0ZWROb2RlID0gaW50ZXJuYWxzLnRvdWNoTm9kZUFkanVzdGVkVG9C ZXN0Q2xpY2thYmxlTm9kZSh4LCB5LCB3aWR0aCwgaGVpZ2h0LCBkb2N1bWVudCk7CisgICAgICAg IGlmIChhZGp1c3RlZE5vZGUgJiYgYWRqdXN0ZWROb2RlLm5vZGVUeXBlID09IDMpIC8vIFRFWFQg bm9kZQorICAgICAgICAgICAgYWRqdXN0ZWROb2RlID0gYWRqdXN0ZWROb2RlLnBhcmVudE5vZGU7 CisgICAgICAgIHJldHVybiBhZGp1c3RlZE5vZGU7CisgICAgfQorICAgIGZ1bmN0aW9uIGFkanVz dGVkUG9pbnRBdFRvdWNoKHgsIHksIHJhZGl1cykKKyAgICB7CisgICAgICAgIHZhciB4ID0geCAt IHJhZGl1czsKKyAgICAgICAgdmFyIHkgPSB5IC0gcmFkaXVzOworICAgICAgICB2YXIgd2lkdGgg PSByYWRpdXMgKiAyOworICAgICAgICB2YXIgaGVpZ2h0ID0gcmFkaXVzICogMjsKKyAgICAgICAg dmFyIHBvc2l0aW9uID0gaW50ZXJuYWxzLnRvdWNoUG9zaXRpb25BZGp1c3RlZFRvQmVzdENsaWNr YWJsZU5vZGUoeCwgeSwgd2lkdGgsIGhlaWdodCwgZG9jdW1lbnQpOworICAgICAgICByZXR1cm4g cG9zaXRpb247CisgICAgfQorCisgICAgZnVuY3Rpb24gdGVzdERpcmVjdFRvdWNoZXMoKQorICAg IHsKKyAgICAgICAgYWRqdXN0ZWROb2RlID0gbm9kZUF0VG91Y2goNDAsIDEzMCwgNTApOworICAg ICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2FkanVzdGVkTm9kZS5pZCcsICdhMCcpOworCisg ICAgICAgIGFkanVzdGVkTm9kZSA9IG5vZGVBdFRvdWNoKDMwLCAyMzAsIDUwKTsKKyAgICAgICAg c2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdhZGp1c3RlZE5vZGUuaWQnLCAnYTEnKTsKKyAgICB9Cisg ICAgZnVuY3Rpb24gdGVzdEFkanVzdGVkVG91Y2hlcygpCisgICAgeworICAgICAgICBhZGp1c3Rl ZFBvaW50ID0gYWRqdXN0ZWRQb2ludEF0VG91Y2goMTAsIDEyMCwgODApOworICAgICAgICBzaG91 bGRCZU5vbk51bGwoJ2FkanVzdGVkUG9pbnQnLCBudWxsKTsKKyAgICAgICAgYWRqdXN0ZWROb2Rl ID0gZG9jdW1lbnQuZWxlbWVudEZyb21Qb2ludChhZGp1c3RlZFBvaW50LngsIGFkanVzdGVkUG9p bnQueSk7CisgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnYWRqdXN0ZWROb2RlLmlkJywg J2EwJyk7CisKKyAgICAgICAgYWRqdXN0ZWRQb2ludCA9IGFkanVzdGVkUG9pbnRBdFRvdWNoKDUs IDIyMCwgODApOworICAgICAgICBzaG91bGRCZU5vbk51bGwoJ2FkanVzdGVkUG9pbnQnLCBudWxs KTsKKyAgICAgICAgYWRqdXN0ZWROb2RlID0gZG9jdW1lbnQuZWxlbWVudEZyb21Qb2ludChhZGp1 c3RlZFBvaW50LngsIGFkanVzdGVkUG9pbnQueSk7CisgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0 cmluZygnYWRqdXN0ZWROb2RlLmlkJywgJ2ExJyk7CisgICAgfQorCisgICAgZnVuY3Rpb24gcnVu VGVzdHMoKQorICAgIHsKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlciAm JiB3aW5kb3cuaW50ZXJuYWxzICYmIGludGVybmFscy50b3VjaE5vZGVBZGp1c3RlZFRvQmVzdENs aWNrYWJsZU5vZGUpIHsKKyAgICAgICAgICAgIGRlc2NyaXB0aW9uKCdUZXN0IHRvdWNoIGFkanVz dG1lbnQgd2hlbiBtYWluIGZyYW1lIGlzIHNjcm9sbCBvZmZzZXQuJyk7CisgICAgICAgICAgICB3 aW5kb3cuc2Nyb2xsQnkoMCw0MDApOworICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu ZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGls RG9uZSgpOworICAgICAgICAgICAgdGVzdERpcmVjdFRvdWNoZXMoKTsKKyAgICAgICAgICAgIHRl c3RBZGp1c3RlZFRvdWNoZXMoKTsKKyAgICAgICAgICAgIGlzU3VjY2Vzc2Z1bGx5UGFyc2VkKCk7 CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgICAg IH0KKyAgICB9Cis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CisKKzwvYm9keT4KKzwvaHRtbD4K