86202 2012-05-11 05:51:19 -0700 Web Inspector: Can't type spaces in "Override User Agent" field 2012-05-11 06:42:03 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 621532 0 apavlov 2012-05-11 05:51:19 -0700 What steps will reproduce the problem? 1. On any web page, open the developer tools (either from "View", "Developer" or by pressing Command+Option+J). 2. Click the gear icon in the lower right corner of the window. 3. Check the checkbox near where it says "Override User Agent". 4. Pick "Other..." from the dropdown menu to enter your own user agent string. 5. Try to type "Mozilla/5.0 (whatever)". What is the expected result? I should be able to enter the user agent string I am trying to type. What happens instead? Pressing the space bar closes the settings popup. Please provide any additional information below. Attach a screenshot if possible. I am able to work around the problem by copying a space and pasting it into the text field. Upstreaming http://code.google.com/p/chromium/issues/detail?id=125796 621552 1 141394 apavlov 2012-05-11 06:11:13 -0700 Created attachment 141394 Patch 621555 2 141394 yurys 2012-05-11 06:16:37 -0700 Comment on attachment 141394 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141394&action=review > Source/WebCore/inspector/front-end/HelpScreen.js:50 > + this.closeKeys = [ Can we have a virtual method instead and override it in SettingsScreen or pass the key set as a parameter to the constructor? We don't override fields in the front-end code. 621562 3 141398 apavlov 2012-05-11 06:26:42 -0700 Created attachment 141398 Patch 621581 4 apavlov 2012-05-11 06:42:03 -0700 Committed r116762: <http://trac.webkit.org/changeset/116762> 141394 2012-05-11 06:11:13 -0700 2012-05-11 06:26:35 -0700 Patch bug-86202-20120511171111.patch text/plain 2790 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThhNDgyNzQ2YjNiZDE0 ODNiM2M2OWY2YzNhOWYyNzQxMTA0ODg1Yy4uNmU2ODI5NmY0ZmM1MTA5MzVmMDQwOWE4NDUxNTEy MmRiOTk2YjI5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTA1LTExICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogQ2FuJ3QgdHlwZSBzcGFjZXMgaW4gIk92ZXJyaWRlIFVzZXIgQWdlbnQiIGZpZWxkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjIwMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9IZWxwU2NyZWVuLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlbHBTY3Jl ZW4pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlbHBTY3JlZW4ucHJvdG90eXBlLl9vbktleURv d24pOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3NTY3JlZW4uanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuU2V0dGluZ3NTY3JlZW4pOgorCisyMDEyLTA1LTExICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogU2VhcmNoIGJveCBkb2Vzbid0IGFsbG93IENTUyBzZWxlY3RvcnMgYW55bW9yZQogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYxOTYKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWxwU2NyZWVuLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWxwU2NyZWVuLmpzCmluZGV4 IGVlZTNhNzc3MjJhZTY1MzQ4ZmVlNTM5ZTE5ZjYzMjU1YjE4YzUyMjQuLjAzMDQwYmYxZDMwOWY5 MzViNGFmNzljMTcwNzE4ZmQ2ZGJhNmNkNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvSGVscFNjcmVlbi5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanMKQEAgLTQ3LDcgKzQ3LDcgQEAgV2ViSW5zcGVj dG9yLkhlbHBTY3JlZW4gPSBmdW5jdGlvbih0aXRsZSkKIAogICAgIGNsb3NlQnV0dG9uLnRleHRD b250ZW50ID0gIlx1MjcxNiI7IC8vIENvZGUgc3RhbmRzIGZvciBIRUFWWSBNVUxUSVBMSUNBVElP TiBYLgogICAgIGNsb3NlQnV0dG9uLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5oaWRl LmJpbmQodGhpcyksIGZhbHNlKTsKLSAgICB0aGlzLl9jbG9zZUtleXMgPSBbCisgICAgdGhpcy5j bG9zZUtleXMgPSBbCiAgICAgICAgIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleXMu RW50ZXIuY29kZSwKICAgICAgICAgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5cy5F c2MuY29kZSwKICAgICAgICAgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5cy5TcGFj ZS5jb2RlLApAQCAtOTAsNyArOTAsNyBAQCBXZWJJbnNwZWN0b3IuSGVscFNjcmVlbi5wcm90b3R5 cGUgPSB7CiAKICAgICBfb25LZXlEb3duOiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0gICAgICAg IGlmICh0aGlzLl9pc1Nob3duICYmIHRoaXMuX2Nsb3NlS2V5cy5pbmRleE9mKGV2ZW50LmtleUNv ZGUpID49IDApIHsKKyAgICAgICAgaWYgKHRoaXMuX2lzU2hvd24gJiYgdGhpcy5jbG9zZUtleXMu aW5kZXhPZihldmVudC5rZXlDb2RlKSA+PSAwKSB7CiAgICAgICAgICAgICB0aGlzLmhpZGUoKTsK ICAgICAgICAgICAgIGV2ZW50LmNvbnN1bWUoKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5nc1NjcmVlbi5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3NTY3JlZW4uanMKaW5kZXggNTZm ZTI2MDBmMjg5NmFjZjExNDVhM2I4MmFjYWMyMzhkOWY4M2EyYS4uMTM5ZTU2Nzk0ZTdlYjU1NjVh OGFlYmQ0MzZmMDVmYWNhN2QyZDViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9TZXR0aW5nc1NjcmVlbi5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzU2NyZWVuLmpzCkBAIC0zNiw2ICszNiwxMSBAQCBXZWJJ bnNwZWN0b3IuU2V0dGluZ3NTY3JlZW4gPSBmdW5jdGlvbigpCiB7CiAgICAgV2ViSW5zcGVjdG9y LkhlbHBTY3JlZW4uY2FsbCh0aGlzLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNldHRpbmdzIikp OwogCisgICAgdGhpcy5jbG9zZUtleXMgPSBbCisgICAgICAgIFdlYkluc3BlY3Rvci5LZXlib2Fy ZFNob3J0Y3V0LktleXMuRW50ZXIuY29kZSwKKyAgICAgICAgV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQuS2V5cy5Fc2MuY29kZSwKKyAgICBdOworCiAgICAgdGhpcy5fbGVmdENvbHVtbkVs ZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0ZCIpOwogICAgIHRoaXMuX3JpZ2h0Q29s dW1uRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRkIik7CiAgICAgdmFyIHAgPSB0 aGlzLl9hcHBlbmRTZWN0aW9uKFdlYkluc3BlY3Rvci5VSVN0cmluZygiR2VuZXJhbCIpKTsK 141398 2012-05-11 06:26:42 -0700 2012-05-11 06:31:05 -0700 Patch bug-86202-20120511172640.patch text/plain 3210 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThhNDgyNzQ2YjNiZDE0 ODNiM2M2OWY2YzNhOWYyNzQxMTA0ODg1Yy4uMjJkOGU2MmFkZDE5MzExNjVlNjRjN2U0YWRjMDU3 NTliM2E0ZTRjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTA1LTExICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogQ2FuJ3QgdHlwZSBzcGFjZXMgaW4gIk92ZXJyaWRlIFVzZXIgQWdlbnQiIGZpZWxkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjIwMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9IZWxwU2NyZWVuLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlbHBTY3Jl ZW4ucHJvdG90eXBlLmlzQ2xvc2luZ0tleSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVscFNj cmVlbi5wcm90b3R5cGUuX29uS2V5RG93bik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9TZXR0aW5nc1NjcmVlbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TZXR0aW5nc1NjcmVl bi5wcm90b3R5cGUuaXNDbG9zaW5nS2V5KToKKworMjAxMi0wNS0xMSAgQWxleGFuZGVyIFBhdmxv diAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNlYXJj aCBib3ggZG9lc24ndCBhbGxvdyBDU1Mgc2VsZWN0b3JzIGFueW1vcmUKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MTk2CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVscFNjcmVlbi5qcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVscFNjcmVlbi5qcwppbmRleCBlZWUzYTc3NzIy YWU2NTM0OGZlZTUzOWUxOWY2MzI1NWIxOGM1MjI0Li4yMWM1ZWE4MjI4NDk4YzMxZTY5NGMwN2Zl NjI0YTM1N2ZmNzE2ZTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0hlbHBTY3JlZW4uanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9IZWxwU2NyZWVuLmpzCkBAIC00NywxMSArNDcsNiBAQCBXZWJJbnNwZWN0b3IuSGVscFNj cmVlbiA9IGZ1bmN0aW9uKHRpdGxlKQogCiAgICAgY2xvc2VCdXR0b24udGV4dENvbnRlbnQgPSAi XHUyNzE2IjsgLy8gQ29kZSBzdGFuZHMgZm9yIEhFQVZZIE1VTFRJUExJQ0FUSU9OIFguCiAgICAg Y2xvc2VCdXR0b24uYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLmhpZGUuYmluZCh0aGlz KSwgZmFsc2UpOwotICAgIHRoaXMuX2Nsb3NlS2V5cyA9IFsKLSAgICAgICAgV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQuS2V5cy5FbnRlci5jb2RlLAotICAgICAgICBXZWJJbnNwZWN0b3Iu S2V5Ym9hcmRTaG9ydGN1dC5LZXlzLkVzYy5jb2RlLAotICAgICAgICBXZWJJbnNwZWN0b3IuS2V5 Ym9hcmRTaG9ydGN1dC5LZXlzLlNwYWNlLmNvZGUsCi0gICAgXTsKIH0KIAogV2ViSW5zcGVjdG9y LkhlbHBTY3JlZW4udmlzaWJsZVNjcmVlbl8gPSBudWxsOwpAQCAtODgsOSArODMsMjIgQEAgV2Vi SW5zcGVjdG9yLkhlbHBTY3JlZW4ucHJvdG90eXBlID0gewogICAgICAgICB9CiAgICAgfSwKIAor ICAgIC8qKgorICAgICAqIEBwYXJhbSB7bnVtYmVyfSBrZXlDb2RlCisgICAgICogQHJldHVybiB7 Ym9vbGVhbn0KKyAgICAgKi8KKyAgICBpc0Nsb3NpbmdLZXk6IGZ1bmN0aW9uKGtleUNvZGUpCisg ICAgeworICAgICAgICByZXR1cm4gWworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQuS2V5cy5FbnRlci5jb2RlLAorICAgICAgICAgICAgV2ViSW5zcGVjdG9yLktleWJv YXJkU2hvcnRjdXQuS2V5cy5Fc2MuY29kZSwKKyAgICAgICAgICAgIFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0LktleXMuU3BhY2UuY29kZSwKKyAgICAgICAgXS5pbmRleE9mKGtleUNvZGUp ID49IDA7CisgICAgfSwKKwogICAgIF9vbktleURvd246IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsK LSAgICAgICAgaWYgKHRoaXMuX2lzU2hvd24gJiYgdGhpcy5fY2xvc2VLZXlzLmluZGV4T2YoZXZl bnQua2V5Q29kZSkgPj0gMCkgeworICAgICAgICBpZiAodGhpcy5faXNTaG93biAmJiB0aGlzLmlz Q2xvc2luZ0tleShldmVudC5rZXlDb2RlKSkgewogICAgICAgICAgICAgdGhpcy5oaWRlKCk7CiAg ICAgICAgICAgICBldmVudC5jb25zdW1lKCk7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3NTY3JlZW4uanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzU2NyZWVuLmpzCmluZGV4IDU2ZmUy NjAwZjI4OTZhY2YxMTQ1YTNiODJhY2FjMjM4ZDlmODNhMmEuLjQ1MmVjNzdmOWQ3Y2ZlZmNlNDkx MjY0YmUyZDllMTUzZjdjNDU3MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2V0dGluZ3NTY3JlZW4uanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9TZXR0aW5nc1NjcmVlbi5qcwpAQCAtMTE0LDYgKzExNCwxOCBAQCBXZWJJ bnNwZWN0b3IuU2V0dGluZ3NTY3JlZW4gPSBmdW5jdGlvbigpCiB9CiAKIFdlYkluc3BlY3Rvci5T ZXR0aW5nc1NjcmVlbi5wcm90b3R5cGUgPSB7CisKKyAgICAvKioKKyAgICAgKiBAb3ZlcnJpZGUK KyAgICAgKi8KKyAgICBpc0Nsb3NpbmdLZXk6IGZ1bmN0aW9uKGtleUNvZGUpCisgICAgeworICAg ICAgICByZXR1cm4gWworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQu S2V5cy5FbnRlci5jb2RlLAorICAgICAgICAgICAgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQuS2V5cy5Fc2MuY29kZSwKKyAgICAgICAgXS5pbmRleE9mKGtleUNvZGUpID49IDA7CisgICAg fSwKKwogICAgIC8qKgogICAgICAqIEBwYXJhbSB7c3RyaW5nfSBuYW1lCiAgICAgICogQHBhcmFt IHtib29sZWFuPX0gcmlnaHQK