<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>86194</bug_id>
          
          <creation_ts>2012-05-11 03:58:35 -0700</creation_ts>
          <short_desc>[EFL] Rounding errors on 32-bit machines causes tests to fail</short_desc>
          <delta_ts>2012-05-21 03:59:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>87000</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>mrobinson</cc>
    
    <cc>rakuco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>621471</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-11 03:58:35 -0700</bug_when>
    <thetext>Rounding errors on 32-bit machines causes tests to fail.

Usually, the results are 1 pixel off compared to exectations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621474</commentid>
    <comment_count>1</comment_count>
      <attachid>141376</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-11 04:02:40 -0700</bug_when>
    <thetext>Created attachment 141376
Patch

Use scalar floating-point instructions present in the SSE instruction set on 32-bit. This is the default choice for the x86-64 compiler but not for 32-bit. Without enabling this, we get a lot of rounding errors on 32-bit machines causing a lot of tests to fail (off by 1 pixel).

The same issue was reported on GTK port and solved in the same way:
Bug 72254</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621520</commentid>
    <comment_count>2</comment_count>
      <attachid>141376</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-11 05:40:51 -0700</bug_when>
    <thetext>Comment on attachment 141376
Patch

Attachment 141376 did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12663667</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621569</commentid>
    <comment_count>3</comment_count>
      <attachid>141399</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-11 06:30:51 -0700</bug_when>
    <thetext>Created attachment 141399
Patch

Fix patch so that the flags are used only on 32 bit. The patch is now almost the same as for GTK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621614</commentid>
    <comment_count>4</comment_count>
      <attachid>141399</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-05-11 07:11:15 -0700</bug_when>
    <thetext>Comment on attachment 141399
Patch

webkitdirs.pm looks like the wrong place to do this (and determineArchitecture() only seems to work for GTK and Mac). We already detect the processor type in the top-level CMakeLists.txt and define some compiler flags in Source/cmake/WebKitHelpers.cmake, so I guess it makes sense to add these to the latter.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621618</commentid>
    <comment_count>5</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-05-11 07:12:47 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 141399 [details])
&gt; webkitdirs.pm looks like the wrong place to do this (and determineArchitecture() only seems to work for GTK and Mac). We already detect the processor type in the top-level CMakeLists.txt and define some compiler flags in Source/cmake/WebKitHelpers.cmake, so I guess it makes sense to add these to the latter.

Hmm, I&apos;ve just seen your first attempt there. If you enclose your SET() call within an IF (WTF_CPU_X86) it should work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621622</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-11 07:16:13 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; (From update of attachment 141399 [details] [details])
&gt; &gt; webkitdirs.pm looks like the wrong place to do this (and determineArchitecture() only seems to work for GTK and Mac). We already detect the processor type in the top-level CMakeLists.txt and define some compiler flags in Source/cmake/WebKitHelpers.cmake, so I guess it makes sense to add these to the latter.
&gt; 
&gt; Hmm, I&apos;ve just seen your first attempt there. If you enclose your SET() call within an IF (WTF_CPU_X86) it should work.

Thanks, I&apos;ll do that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621627</commentid>
    <comment_count>7</comment_count>
      <attachid>141413</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-11 07:23:11 -0700</bug_when>
    <thetext>Created attachment 141413
Patch

Take rakuco&apos;s feedback into consideration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621662</commentid>
    <comment_count>8</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-05-11 08:37:00 -0700</bug_when>
    <thetext>The reason we did this in webkitdirs.pm is that -march=pentium4 -msse2 -mfpmath=sse could have some unknown performance impact. This is acceptable on our bots, which just test correctness, but not acceptable to ship in our releases and to downstream.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>621918</commentid>
    <comment_count>9</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-05-11 13:13:50 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; The reason we did this in webkitdirs.pm is that -march=pentium4 -msse2 -mfpmath=sse could have some unknown performance impact. This is acceptable on our bots, which just test correctness, but not acceptable to ship in our releases and to downstream.

That makes sense, with my FreeBSD packager hat on I find it bad when upstream hardcodes compiler flags that way. In that case, shouldn&apos;t users just export those compiler flags locally then?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622689</commentid>
    <comment_count>10</comment_count>
      <attachid>141648</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-13 23:35:26 -0700</bug_when>
    <thetext>Created attachment 141648
Patch

Take feedback into consideration.

Now, setting the flags in Tools/Scripts/webkitdirs.pm and make determineArchitecture() function work on EFL port.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622698</commentid>
    <comment_count>11</comment_count>
      <attachid>141648</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-13 23:45:28 -0700</bug_when>
    <thetext>Comment on attachment 141648
Patch

Attachment 141648 did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12685242</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622702</commentid>
    <comment_count>12</comment_count>
      <attachid>141651</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-13 23:50:42 -0700</bug_when>
    <thetext>Created attachment 141651
Patch

Forgot to remove debug in previous patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>622983</commentid>
    <comment_count>13</comment_count>
      <attachid>141651</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-05-14 08:12:45 -0700</bug_when>
    <thetext>Comment on attachment 141651
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141651&amp;action=review

Seems sane, though I think this could use a little cleanup.

&gt; Tools/Scripts/webkitdirs.pm:333
&gt; +        } else {
&gt; +            # Fall back to output of `arch&apos;, if it is present.
&gt; +            $architecture = `arch`;
&gt; +            chomp $architecture;

The fallback is now repeated three times. Perhaps it&apos;s better to put it in a helper function at this point or restructure the code so it&apos;s not repeated.

&gt; Tools/Scripts/webkitdirs.pm:2100
&gt; +    if ($architecture ne &quot;x86_64&quot; &amp;&amp; !isARM()) {
&gt; +        $ENV{&apos;CXXFLAGS&apos;} = &quot;-march=pentium4 -msse2 -mfpmath=sse&quot;;
&gt; +    }

You&apos;re completely overwriting CXXFLAGS here. It might be better to preserve any that already exist.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>623755</commentid>
    <comment_count>14</comment_count>
      <attachid>141879</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-15 00:45:45 -0700</bug_when>
    <thetext>Created attachment 141879
Patch

Take feedback into consideration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624082</commentid>
    <comment_count>15</comment_count>
      <attachid>141879</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-05-15 07:45:18 -0700</bug_when>
    <thetext>Comment on attachment 141879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141879&amp;action=review

Looks good, though I have one doubt.

&gt; Tools/Scripts/webkitdirs.pm:328
&gt; +    if (!$architecture) {

I&apos;m a little bit worried here because it looks almost like this will call arch on all platforms now. I&apos;m not sure if calling arch for !isGtk &amp;&amp; !isAppleMacWebKit &amp;&amp; !isEfl is a problem here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624487</commentid>
    <comment_count>16</comment_count>
      <attachid>141879</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-05-15 13:32:55 -0700</bug_when>
    <thetext>Comment on attachment 141879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141879&amp;action=review

I still wonder if it doesn&apos;t make sense to simply check for the presence of these flags at configure-time and warn the user depending on the processor and/or document it somewhere?

&gt; Tools/Scripts/webkitdirs.pm:320
&gt; +        my $cmakesystem_file = &quot;$configurationProductDir/CMakeFiles/CMakeSystem.cmake&quot;;

This requires that one to have run CMake for this file to exist. Capturing the output of `cmake --system-information&apos; is better.

&gt; Tools/Scripts/webkitdirs.pm:324
&gt; +            $architecture = $1;

This has the same problem we have solved in the top-level CMakeLists.txt -- &quot;x86_64&quot; might be returned as &quot;amd64&quot; on some platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625059</commentid>
    <comment_count>17</comment_count>
      <attachid>142174</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-16 00:20:18 -0700</bug_when>
    <thetext>Created attachment 142174
Patch

Take feedback into consideration. I still prefer adding the flags automatically in the build script like other ports do.
I know the user could do it manually but it is less convenient.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625453</commentid>
    <comment_count>18</comment_count>
      <attachid>142174</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-05-16 08:17:26 -0700</bug_when>
    <thetext>Comment on attachment 142174
Patch

I guess that should work; one last thing: why not check if the architecture is x86 instead of checking if it&apos;s not something else?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625454</commentid>
    <comment_count>19</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-05-16 08:18:31 -0700</bug_when>
    <thetext>I mean, in CMakeLists.txt we also check for mips, and keeping the checks here and there in sync is error-prone.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625506</commentid>
    <comment_count>20</comment_count>
      <attachid>142174</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-05-16 08:59:30 -0700</bug_when>
    <thetext>Comment on attachment 142174
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142174&amp;action=review

&gt; Tools/Scripts/webkitdirs.pm:1872
&gt; +        $ENV{&apos;CXXFLAGS&apos;} = &quot;-march=pentium4 -msse2 -mfpmath=sse &quot; . $ENV{&apos;CXXFLAGS&apos;};

Thanks for fixing this one as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625519</commentid>
    <comment_count>21</comment_count>
      <attachid>142174</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-16 09:08:58 -0700</bug_when>
    <thetext>Comment on attachment 142174
Patch

Clearing flags on attachment: 142174

Committed r117298: &lt;http://trac.webkit.org/changeset/117298&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625520</commentid>
    <comment_count>22</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-16 09:09:07 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141376</attachid>
            <date>2012-05-11 04:02:40 -0700</date>
            <delta_ts>2012-05-11 06:30:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86194_sse.patch</filename>
            <type>text/plain</type>
            <size>1747</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzN2RhZDczLi43ZGI1N2Q2
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK
KzIwMTItMDUtMTEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNv
bT4KKworICAgICAgICBbRUZMXSBSb3VuZGluZyBlcnJvcnMgb24gMzItYml0IG1hY2hpbmVzIGNh
dXNlcyB0ZXN0cyB0byBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD04NjE5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFVzZSBzY2FsYXIgZmxvYXRpbmctcG9pbnQgaW5zdHJ1Y3Rpb25zIHByZXNlbnQg
aW4gdGhlIFNTRSBpbnN0cnVjdGlvbgorICAgICAgICBzZXQgb24gMzItYml0LiBUaGlzIGlzIHRo
ZSBkZWZhdWx0IGNob2ljZSBmb3IgdGhlIHg4Ni02NCBjb21waWxlciBidXQKKyAgICAgICAgbm90
IGZvciAzMi1iaXQuIFdpdGhvdXQgZW5hYmxpbmcgdGhpcywgd2UgZ2V0IGEgbG90IG9mIHJvdW5k
aW5nIGVycm9ycworICAgICAgICBvbiAzMi1iaXQgbWFjaGluZXMgY2F1c2luZyBhIGxvdCBvZiB0
ZXN0cyB0byBmYWlsIChvZmYgYnkgMSBwaXhlbCkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2Uv
V2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAxMi0wNS0xMCAgTU9SSVRBIEhhamltZSAgPG1vcnJp
dGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBFbGVtZW50U2hhZG93IHNob3VsZCBtaW5pbWl6ZSB0
aGUgdXNhZ2Ugb2YgIlNoYWRvd1Jvb3QiIG5hbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9X
ZWJLaXRIZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKaW5k
ZXggMWYzNzJjYy4uM2Q2MTE2ZiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdEhlbHBl
cnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKQEAgLTMyLDYg
KzMyLDEwIEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3RhcmdldCkK
IAogICAgIFNFVChPTERfQ09NUElMRV9GTEFHUyAiLWZuby1leGNlcHRpb25zIC1mbm8tc3RyaWN0
LWFsaWFzaW5nICR7T0xEX0NPTVBJTEVfRkxBR1N9IikKIAorICAgICMgVXNlIHNjYWxhciBmbG9h
dGluZy1wb2ludCBpbnN0cnVjdGlvbnMgcHJlc2VudCBpbiB0aGUgU1NFIGluc3RydWN0aW9uIHNl
dC4KKyAgICAjIEF2b2lkIHJvdW5kaW5nIGlzc3VlcyBvbiAzMmJpdCBjYXVzaW5nIGxheW91dCB0
ZXN0cyB0byBmYWlsIGJ5IDEgcGl4ZWwuCisgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICItbWFy
Y2g9cGVudGl1bTQgLW1zc2UyIC1tZnBtYXRoPXNzZSAke09MRF9DT01QSUxFX0ZMQUdTfSIpCisK
ICAgICAjIEVuYWJsZSB3YXJuaW5ncyBieSBkZWZhdWx0CiAgICAgU0VUKE9MRF9DT01QSUxFX0ZM
QUdTICItVyAtREFOT1RIRVJfQlJJQ0tfSU5fVEhFIC1XYWxsIC1XZXh0cmEgLVdjYXN0LWFsaWdu
IC1XY2hhci1zdWJzY3JpcHRzIC1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1m
b3JtYXQtYXR0cmlidXRlIC1Xbm8tZm9ybWF0LXkyayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51
c2VkLXBhcmFtZXRlciAtV3BvaW50ZXItYXJpdGggIC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dy
aXRlLXN0cmluZ3MgJHtPTERfQ09NUElMRV9GTEFHU30iKQogCg==
</data>
<flag name="commit-queue"
          id="147493"
          type_id="3"
          status="-"
          setter="gyuyoung.kim"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141399</attachid>
            <date>2012-05-11 06:30:51 -0700</date>
            <delta_ts>2012-05-11 07:23:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86194_sse.patch</filename>
            <type>text/plain</type>
            <size>1526</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxMjZl
YmU3Li4xZDM5ZjIwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDUtMTEgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSb3VuZGluZyBlcnJv
cnMgb24gMzItYml0IG1hY2hpbmVzIGNhdXNlcyB0ZXN0cyB0byBmYWlsCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjE5NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3MgYWRkaXRpb25hbCBDWFhGTEFH
UyB0byBDTWFrZSBpbiBhbiBhdHRlbXB0IHRvIGhhcm1vbml6ZSBmbG9hdGluZworICAgICAgICBw
b2ludCB2YWx1ZXMgYmV0d2VlbiAzMi1iaXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgorICAg
ICAgICBTYW1lIGZsYWdzIGFyZSBhbHJlYWR5IHVzZWQgYnkgUXQgYW5kIEdUSyBwb3J0cy4KKwor
ICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGdlbmVyYXRlQnVpbGRT
eXN0ZW1Gcm9tQ01ha2VQcm9qZWN0KToKKwogMjAxMi0wNS0xMCAgT2phbiBWYWZhaSAgPG9qYW5A
Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBhIHBlcmYgdGFiIHRvIGdhcmRlbi1vLW1hdGlj
CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRz
L3dlYmtpdGRpcnMucG0KaW5kZXggMjAzODUzYi4uYzhmZDYwNyAxMDA3NTUKLS0tIGEvVG9vbHMv
U2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpA
QCAtMjA1Myw2ICsyMDUzLDE0IEBAIHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJv
amVjdAogCiAgICAgcHVzaCBAYXJncywgJyInIC4gc291cmNlRGlyKCkgLiAnIic7CiAKKyAgICAj
IENvbXBpbGVyIG9wdGlvbnMgdG8ga2VlcCBmbG9hdGluZyBwb2ludCB2YWx1ZXMgY29uc2lzdGVu
dAorICAgICMgYmV0d2VlbiAzMi1iaXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLiBUaGUgb3B0
aW9ucyBhcmUgYWxzbworICAgICMgdXNlZCBvbiBDaHJvbWl1bSBidWlsZC4KKyAgICBkZXRlcm1p
bmVBcmNoaXRlY3R1cmUoKTsKKyAgICBpZiAoJGFyY2hpdGVjdHVyZSBuZSAieDg2XzY0IiAmJiAh
aXNBUk0oKSkgeworICAgICAgICAkRU5WeydDWFhGTEFHUyd9ID0gIi1tYXJjaD1wZW50aXVtNCAt
bXNzZTIgLW1mcG1hdGg9c3NlIjsKKyAgICB9CisKICAgICAjIFdlIGNhbGwgc3lzdGVtKCJjbWFr
ZSBAYXJncyIpIGluc3RlYWQgb2Ygc3lzdGVtKCJjbWFrZSIsIEBhcmdzKSBzbyB0aGF0IEBhcmdz
IGlzCiAgICAgIyBwYXJzZWQgZm9yIHNoZWxsIG1ldGFjaGFyYWN0ZXJzLgogICAgIG15ICR3cmFw
cGVyID0gamhidWlsZFdyYXBwZXJQcmVmaXhJZk5lZWRlZCgpIC4gIiAiOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141413</attachid>
            <date>2012-05-11 07:23:11 -0700</date>
            <delta_ts>2012-05-13 23:35:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86194_sse.patch</filename>
            <type>text/plain</type>
            <size>1624</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzN2RhZDczLi4zOWU3NjE0
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK
KzIwMTItMDUtMTEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNv
bT4KKworICAgICAgICBbRUZMXSBSb3VuZGluZyBlcnJvcnMgb24gMzItYml0IG1hY2hpbmVzIGNh
dXNlcyB0ZXN0cyB0byBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD04NjE5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFBhc3MgYWRkaXRpb25hbCBDWFhGTEFHUyB0byBDTWFrZSBpbiBhbiBhdHRlbXB0
IHRvIGhhcm1vbml6ZSBmbG9hdGluZworICAgICAgICBwb2ludCB2YWx1ZXMgYmV0d2VlbiAzMi1i
aXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgorICAgICAgICBTYW1lIGZsYWdzIGFyZSBhbHJl
YWR5IHVzZWQgYnkgUXQgYW5kIEdUSyBwb3J0cy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9X
ZWJLaXRIZWxwZXJzLmNtYWtlOgorCiAyMDEyLTA1LTEwICBNT1JJVEEgSGFqaW1lICA8bW9ycml0
YUBnb29nbGUuY29tPgogCiAgICAgICAgIEVsZW1lbnRTaGFkb3cgc2hvdWxkIG1pbmltaXplIHRo
ZSB1c2FnZSBvZiAiU2hhZG93Um9vdCIgbmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dl
YktpdEhlbHBlcnMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQppbmRl
eCAxZjM3MmNjLi5hMjYxNGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVy
cy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQpAQCAtMzIsNiAr
MzIsMTIgQEAgTUFDUk8oV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBfdGFyZ2V0KQog
CiAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICItZm5vLWV4Y2VwdGlvbnMgLWZuby1zdHJpY3Qt
YWxpYXNpbmcgJHtPTERfQ09NUElMRV9GTEFHU30iKQogCisgICAgIyBDb21waWxlciBvcHRpb25z
IHRvIGtlZXAgZmxvYXRpbmcgcG9pbnQgdmFsdWVzIGNvbnNpc3RlbnQKKyAgICAjIGJldHdlZW4g
MzItYml0IGFuZCA2NC1iaXQgYXJjaGl0ZWN0dXJlcy4KKyAgICBJRiAoV1RGX0NQVV9YODYpCisg
ICAgICAgIFNFVChPTERfQ09NUElMRV9GTEFHUyAiLW1hcmNoPXBlbnRpdW00IC1tc3NlMiAtbWZw
bWF0aD1zc2UgJHtPTERfQ09NUElMRV9GTEFHU30iKQorICAgIEVORElGICgpCisKICAgICAjIEVu
YWJsZSB3YXJuaW5ncyBieSBkZWZhdWx0CiAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICItVyAt
REFOT1RIRVJfQlJJQ0tfSU5fVEhFIC1XYWxsIC1XZXh0cmEgLVdjYXN0LWFsaWduIC1XY2hhci1z
dWJzY3JpcHRzIC1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1mb3JtYXQtYXR0
cmlidXRlIC1Xbm8tZm9ybWF0LXkyayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51c2VkLXBhcmFt
ZXRlciAtV3BvaW50ZXItYXJpdGggIC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dyaXRlLXN0cmlu
Z3MgJHtPTERfQ09NUElMRV9GTEFHU30iKQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141648</attachid>
            <date>2012-05-13 23:35:26 -0700</date>
            <delta_ts>2012-05-13 23:50:42 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86194_sse.patch</filename>
            <type>text/plain</type>
            <size>2362</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNjAw
YjUzLi4wMzQyNDAyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMTMgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSb3VuZGluZyBlcnJv
cnMgb24gMzItYml0IG1hY2hpbmVzIGNhdXNlcyB0ZXN0cyB0byBmYWlsCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjE5NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3MgYWRkaXRpb25hbCBDWFhGTEFH
UyB0byBDTWFrZSBpbiBhbiBhdHRlbXB0IHRvIGhhcm1vbml6ZSBmbG9hdGluZworICAgICAgICBw
b2ludCB2YWx1ZXMgYmV0d2VlbiAzMi1iaXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgorICAg
ICAgICBTYW1lIGZsYWdzIGFyZSBhbHJlYWR5IHVzZWQgYnkgUXQgYW5kIEdUSyBwb3J0cy4gCisK
KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVBcmNo
aXRlY3R1cmUpOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3Qp
OgorCiAyMDEyLTA1LTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg
ICAgIHBlcmZvcm1hbmNlIHRlc3RzIHNob3VsZCBiZSBhYmxlIHRvIG1lYXN1cmUgcnVucy9zZWMg
cmF0aGVyIHRoYW4gdGltZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt
IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGIwMDQ1MTYuLjliOWQwYWIgMTAw
NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRz
L3dlYmtpdGRpcnMucG0KQEAgLTMyMCw2ICszMjAsMTkgQEAgc3ViIGRldGVybWluZUFyY2hpdGVj
dHVyZQogICAgICAgICAgICAgJGFyY2hpdGVjdHVyZSA9ICRzdXBwb3J0czY0Qml0ID8gJ3g4Nl82
NCcgOiBgYXJjaGA7CiAgICAgICAgICAgICBjaG9tcCAkYXJjaGl0ZWN0dXJlOwogICAgICAgICB9
CisgICAgfSBlbHNpZiAoaXNFZmwoKSkgeworICAgICAgICBteSAkaG9zdF9wcm9jZXNzb3IgPSAi
IjsKKyAgICAgICAgbXkgJGNtYWtlc3lzdGVtX2ZpbGUgPSAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0
RGlyL0NNYWtlRmlsZXMvQ01ha2VTeXN0ZW0uY21ha2UiOworICAgICAgICAkaG9zdF9wcm9jZXNz
b3IgPSBgZ3JlcCAtRSAnXlNFVFxcKENNQUtFX0hPU1RfU1lTVEVNX1BST0NFU1NPUiAnICRjbWFr
ZXN5c3RlbV9maWxlYCBpZiAtZSAiJGNtYWtlc3lzdGVtX2ZpbGUiOworICAgICAgICBpZiAoJGhv
c3RfcHJvY2Vzc29yID1+IG0vXlNFVFwoQ01BS0VfSE9TVF9TWVNURU1fUFJPQ0VTU09SIFwiKFte
Il0rKVwiXCkvKSB7CisgICAgICAgICAgICBkaWUgImFyY2hpdGVjdHVyZSBpcyAkMSI7CisgICAg
ICAgICAgICAjIFdlIGhhdmUgYSBjb25maWd1cmVkIGJ1aWxkIHRyZWU7IHVzZSBpdC4KKyAgICAg
ICAgICAgICRhcmNoaXRlY3R1cmUgPSAkMTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAg
ICMgRmFsbCBiYWNrIHRvIG91dHB1dCBvZiBgYXJjaCcsIGlmIGl0IGlzIHByZXNlbnQuCisgICAg
ICAgICAgICAkYXJjaGl0ZWN0dXJlID0gYGFyY2hgOworICAgICAgICAgICAgY2hvbXAgJGFyY2hp
dGVjdHVyZTsKKyAgICAgICAgfQogICAgIH0KIH0KIApAQCAtMjA4MCw2ICsyMDkzLDEzIEBAIHN1
YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAogCiAgICAgcHVzaCBAYXJncywg
JyInIC4gc291cmNlRGlyKCkgLiAnIic7CiAKKyAgICAjIENvbXBpbGVyIG9wdGlvbnMgdG8ga2Vl
cCBmbG9hdGluZyBwb2ludCB2YWx1ZXMgY29uc2lzdGVudAorICAgICMgYmV0d2VlbiAzMi1iaXQg
YW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgorICAgIGRldGVybWluZUFyY2hpdGVjdHVyZSgpOwor
ICAgIGlmICgkYXJjaGl0ZWN0dXJlIG5lICJ4ODZfNjQiICYmICFpc0FSTSgpKSB7CisgICAgICAg
ICRFTlZ7J0NYWEZMQUdTJ30gPSAiLW1hcmNoPXBlbnRpdW00IC1tc3NlMiAtbWZwbWF0aD1zc2Ui
OworICAgIH0KKwogICAgICMgV2UgY2FsbCBzeXN0ZW0oImNtYWtlIEBhcmdzIikgaW5zdGVhZCBv
ZiBzeXN0ZW0oImNtYWtlIiwgQGFyZ3MpIHNvIHRoYXQgQGFyZ3MgaXMKICAgICAjIHBhcnNlZCBm
b3Igc2hlbGwgbWV0YWNoYXJhY3RlcnMuCiAgICAgbXkgJHdyYXBwZXIgPSBqaGJ1aWxkV3JhcHBl
clByZWZpeElmTmVlZGVkKCkgLiAiICI7Cg==
</data>
<flag name="commit-queue"
          id="147815"
          type_id="3"
          status="-"
          setter="gyuyoung.kim"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141651</attachid>
            <date>2012-05-13 23:50:42 -0700</date>
            <delta_ts>2012-05-15 00:45:45 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86194_sse.patch</filename>
            <type>text/plain</type>
            <size>2323</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNjAw
YjUzLi4wMzQyNDAyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMTMgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSb3VuZGluZyBlcnJv
cnMgb24gMzItYml0IG1hY2hpbmVzIGNhdXNlcyB0ZXN0cyB0byBmYWlsCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjE5NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3MgYWRkaXRpb25hbCBDWFhGTEFH
UyB0byBDTWFrZSBpbiBhbiBhdHRlbXB0IHRvIGhhcm1vbml6ZSBmbG9hdGluZworICAgICAgICBw
b2ludCB2YWx1ZXMgYmV0d2VlbiAzMi1iaXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgorICAg
ICAgICBTYW1lIGZsYWdzIGFyZSBhbHJlYWR5IHVzZWQgYnkgUXQgYW5kIEdUSyBwb3J0cy4gCisK
KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVBcmNo
aXRlY3R1cmUpOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3Qp
OgorCiAyMDEyLTA1LTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg
ICAgIHBlcmZvcm1hbmNlIHRlc3RzIHNob3VsZCBiZSBhYmxlIHRvIG1lYXN1cmUgcnVucy9zZWMg
cmF0aGVyIHRoYW4gdGltZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt
IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGIwMDQ1MTYuLjMyMDc3YTcgMTAw
NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRz
L3dlYmtpdGRpcnMucG0KQEAgLTMyMCw2ICszMjAsMTggQEAgc3ViIGRldGVybWluZUFyY2hpdGVj
dHVyZQogICAgICAgICAgICAgJGFyY2hpdGVjdHVyZSA9ICRzdXBwb3J0czY0Qml0ID8gJ3g4Nl82
NCcgOiBgYXJjaGA7CiAgICAgICAgICAgICBjaG9tcCAkYXJjaGl0ZWN0dXJlOwogICAgICAgICB9
CisgICAgfSBlbHNpZiAoaXNFZmwoKSkgeworICAgICAgICBteSAkaG9zdF9wcm9jZXNzb3IgPSAi
IjsKKyAgICAgICAgbXkgJGNtYWtlc3lzdGVtX2ZpbGUgPSAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0
RGlyL0NNYWtlRmlsZXMvQ01ha2VTeXN0ZW0uY21ha2UiOworICAgICAgICAkaG9zdF9wcm9jZXNz
b3IgPSBgZ3JlcCAtRSAnXlNFVFxcKENNQUtFX0hPU1RfU1lTVEVNX1BST0NFU1NPUiAnICRjbWFr
ZXN5c3RlbV9maWxlYCBpZiAtZSAiJGNtYWtlc3lzdGVtX2ZpbGUiOworICAgICAgICBpZiAoJGhv
c3RfcHJvY2Vzc29yID1+IG0vXlNFVFwoQ01BS0VfSE9TVF9TWVNURU1fUFJPQ0VTU09SIFwiKFte
Il0rKVwiXCkvKSB7CisgICAgICAgICAgICAjIFdlIGhhdmUgYSBjb25maWd1cmVkIGJ1aWxkIHRy
ZWU7IHVzZSBpdC4KKyAgICAgICAgICAgICRhcmNoaXRlY3R1cmUgPSAkMTsKKyAgICAgICAgfSBl
bHNlIHsKKyAgICAgICAgICAgICMgRmFsbCBiYWNrIHRvIG91dHB1dCBvZiBgYXJjaCcsIGlmIGl0
IGlzIHByZXNlbnQuCisgICAgICAgICAgICAkYXJjaGl0ZWN0dXJlID0gYGFyY2hgOworICAgICAg
ICAgICAgY2hvbXAgJGFyY2hpdGVjdHVyZTsKKyAgICAgICAgfQogICAgIH0KIH0KIApAQCAtMjA4
MCw2ICsyMDkyLDEzIEBAIHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAog
CiAgICAgcHVzaCBAYXJncywgJyInIC4gc291cmNlRGlyKCkgLiAnIic7CiAKKyAgICAjIENvbXBp
bGVyIG9wdGlvbnMgdG8ga2VlcCBmbG9hdGluZyBwb2ludCB2YWx1ZXMgY29uc2lzdGVudAorICAg
ICMgYmV0d2VlbiAzMi1iaXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgorICAgIGRldGVybWlu
ZUFyY2hpdGVjdHVyZSgpOworICAgIGlmICgkYXJjaGl0ZWN0dXJlIG5lICJ4ODZfNjQiICYmICFp
c0FSTSgpKSB7CisgICAgICAgICRFTlZ7J0NYWEZMQUdTJ30gPSAiLW1hcmNoPXBlbnRpdW00IC1t
c3NlMiAtbWZwbWF0aD1zc2UiOworICAgIH0KKwogICAgICMgV2UgY2FsbCBzeXN0ZW0oImNtYWtl
IEBhcmdzIikgaW5zdGVhZCBvZiBzeXN0ZW0oImNtYWtlIiwgQGFyZ3MpIHNvIHRoYXQgQGFyZ3Mg
aXMKICAgICAjIHBhcnNlZCBmb3Igc2hlbGwgbWV0YWNoYXJhY3RlcnMuCiAgICAgbXkgJHdyYXBw
ZXIgPSBqaGJ1aWxkV3JhcHBlclByZWZpeElmTmVlZGVkKCkgLiAiICI7Cg==
</data>
<flag name="review"
          id="147818"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141879</attachid>
            <date>2012-05-15 00:45:45 -0700</date>
            <delta_ts>2012-05-16 00:20:18 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86194_sse.patch</filename>
            <type>text/plain</type>
            <size>3380</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YzI4
NWEzLi45MGQwZTg5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMTMgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSb3VuZGluZyBlcnJv
cnMgb24gMzItYml0IG1hY2hpbmVzIGNhdXNlcyB0ZXN0cyB0byBmYWlsCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjE5NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3MgYWRkaXRpb25hbCBDWFhGTEFH
UyB0byBDTWFrZSBpbiBhbiBhdHRlbXB0IHRvIGhhcm1vbml6ZSBmbG9hdGluZworICAgICAgICBw
b2ludCB2YWx1ZXMgYmV0d2VlbiAzMi1iaXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgorICAg
ICAgICBTYW1lIGZsYWdzIGFyZSBhbHJlYWR5IHVzZWQgYnkgUXQgYW5kIEdUSyBwb3J0cy4gCisK
KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVBcmNo
aXRlY3R1cmUpOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3Qp
OgorCiAyMDEyLTA1LTE0ICBMdWtlIE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9y
Zz4KIAogICAgICAgICBJbnRyb2R1Y2UgRU5BQkxFX0NTU19WQVJJQUJMRVMgY29tcGlsZSBmbGFn
LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0
cy93ZWJraXRkaXJzLnBtCmluZGV4IGIwMDQ1MTYuLjA2M2M1NWIgMTAwNzU1Ci0tLSBhL1Rvb2xz
L1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0K
QEAgLTMwMiwxMCArMzAyLDYgQEAgc3ViIGRldGVybWluZUFyY2hpdGVjdHVyZQogICAgICAgICBp
ZiAoJGhvc3RfdHJpcGxlID1+IG0vXmhvc3QgPSAoW14tXSspLS8pIHsKICAgICAgICAgICAgICMg
V2UgaGF2ZSBhIGNvbmZpZ3VyZWQgYnVpbGQgdHJlZTsgdXNlIGl0LgogICAgICAgICAgICAgJGFy
Y2hpdGVjdHVyZSA9ICQxOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgIyBGYWxsIGJh
Y2sgdG8gb3V0cHV0IG9mIGBhcmNoJywgaWYgaXQgaXMgcHJlc2VudC4KLSAgICAgICAgICAgICRh
cmNoaXRlY3R1cmUgPSBgYXJjaGA7Ci0gICAgICAgICAgICBjaG9tcCAkYXJjaGl0ZWN0dXJlOwog
ICAgICAgICB9CiAgICAgfSBlbHNpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7CiAgICAgICAgIGlm
IChvcGVuIEFSQ0hJVEVDVFVSRSwgIiRiYXNlUHJvZHVjdERpci9BcmNoaXRlY3R1cmUiKSB7CkBA
IC0zMTcsMTAgKzMxMywyMyBAQCBzdWIgZGV0ZXJtaW5lQXJjaGl0ZWN0dXJlCiAgICAgICAgIH0g
ZWxzZSB7CiAgICAgICAgICAgICBteSAkc3VwcG9ydHM2NEJpdCA9IGBzeXNjdGwgLW4gaHcub3B0
aW9uYWwueDg2XzY0YDsKICAgICAgICAgICAgIGNob21wICRzdXBwb3J0czY0Qml0OwotICAgICAg
ICAgICAgJGFyY2hpdGVjdHVyZSA9ICRzdXBwb3J0czY0Qml0ID8gJ3g4Nl82NCcgOiBgYXJjaGA7
Ci0gICAgICAgICAgICBjaG9tcCAkYXJjaGl0ZWN0dXJlOworICAgICAgICAgICAgJGFyY2hpdGVj
dHVyZSA9ICd4ODZfNjQnIGlmICRzdXBwb3J0czY0Qml0OworICAgICAgICB9CisgICAgfSBlbHNp
ZiAoaXNFZmwoKSkgeworICAgICAgICBteSAkaG9zdF9wcm9jZXNzb3IgPSAiIjsKKyAgICAgICAg
bXkgJGNtYWtlc3lzdGVtX2ZpbGUgPSAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyL0NNYWtlRmls
ZXMvQ01ha2VTeXN0ZW0uY21ha2UiOworICAgICAgICAkaG9zdF9wcm9jZXNzb3IgPSBgZ3JlcCAt
RSAnXlNFVFxcKENNQUtFX0hPU1RfU1lTVEVNX1BST0NFU1NPUiAnICRjbWFrZXN5c3RlbV9maWxl
YCBpZiAtZSAiJGNtYWtlc3lzdGVtX2ZpbGUiOworICAgICAgICBpZiAoJGhvc3RfcHJvY2Vzc29y
ID1+IG0vXlNFVFwoQ01BS0VfSE9TVF9TWVNURU1fUFJPQ0VTU09SIFwiKFteIl0rKVwiXCkvKSB7
CisgICAgICAgICAgICAjIFdlIGhhdmUgYSBjb25maWd1cmVkIGJ1aWxkIHRyZWU7IHVzZSBpdC4K
KyAgICAgICAgICAgICRhcmNoaXRlY3R1cmUgPSAkMTsKICAgICAgICAgfQogICAgIH0KKworICAg
IGlmICghJGFyY2hpdGVjdHVyZSkgeworICAgICAgICAjIEZhbGwgYmFjayB0byBvdXRwdXQgb2Yg
YGFyY2gnLCBpZiBpdCBpcyBwcmVzZW50LgorICAgICAgICAkYXJjaGl0ZWN0dXJlID0gYGFyY2hg
OworICAgICAgICBjaG9tcCAkYXJjaGl0ZWN0dXJlOworICAgIH0KIH0KIAogc3ViIGRldGVybWlu
ZU51bWJlck9mQ1BVcwpAQCAtMTg2MCw3ICsxODY5LDcgQEAgc3ViIHJ1bkF1dG9nZW5Gb3JBdXRv
dG9vbHNQcm9qZWN0SWZOZWNlc3NhcnkoJEApCiAgICAgIyB1c2VkIG9uIENocm9taXVtIGJ1aWxk
LgogICAgIGRldGVybWluZUFyY2hpdGVjdHVyZSgpOwogICAgIGlmICgkYXJjaGl0ZWN0dXJlIG5l
ICJ4ODZfNjQiICYmICFpc0FSTSgpKSB7Ci0gICAgICAgICRFTlZ7J0NYWEZMQUdTJ30gPSAiLW1h
cmNoPXBlbnRpdW00IC1tc3NlMiAtbWZwbWF0aD1zc2UiOworICAgICAgICAkRU5WeydDWFhGTEFH
Uyd9ID0gIi1tYXJjaD1wZW50aXVtNCAtbXNzZTIgLW1mcG1hdGg9c3NlICIgLiAkRU5WeydDWFhG
TEFHUyd9OwogICAgIH0KIAogICAgICMgUHJlZml4IHRoZSBjb21tYW5kIHdpdGggamhidWlsZCBy
dW4uCkBAIC0yMDgwLDYgKzIwODksMTMgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01h
a2VQcm9qZWN0CiAKICAgICBwdXNoIEBhcmdzLCAnIicgLiBzb3VyY2VEaXIoKSAuICciJzsKIAor
ICAgICMgQ29tcGlsZXIgb3B0aW9ucyB0byBrZWVwIGZsb2F0aW5nIHBvaW50IHZhbHVlcyBjb25z
aXN0ZW50CisgICAgIyBiZXR3ZWVuIDMyLWJpdCBhbmQgNjQtYml0IGFyY2hpdGVjdHVyZXMuCisg
ICAgZGV0ZXJtaW5lQXJjaGl0ZWN0dXJlKCk7CisgICAgaWYgKCRhcmNoaXRlY3R1cmUgbmUgIng4
Nl82NCIgJiYgIWlzQVJNKCkpIHsKKyAgICAgICAgJEVOVnsnQ1hYRkxBR1MnfSA9ICItbWFyY2g9
cGVudGl1bTQgLW1zc2UyIC1tZnBtYXRoPXNzZSAiIC4gJEVOVnsnQ1hYRkxBR1MnfTsKKyAgICB9
CisKICAgICAjIFdlIGNhbGwgc3lzdGVtKCJjbWFrZSBAYXJncyIpIGluc3RlYWQgb2Ygc3lzdGVt
KCJjbWFrZSIsIEBhcmdzKSBzbyB0aGF0IEBhcmdzIGlzCiAgICAgIyBwYXJzZWQgZm9yIHNoZWxs
IG1ldGFjaGFyYWN0ZXJzLgogICAgIG15ICR3cmFwcGVyID0gamhidWlsZFdyYXBwZXJQcmVmaXhJ
Zk5lZWRlZCgpIC4gIiAiOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>142174</attachid>
            <date>2012-05-16 00:20:18 -0700</date>
            <delta_ts>2012-05-16 09:08:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86194_sse.patch</filename>
            <type>text/plain</type>
            <size>3349</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5M2Ix
ZjNlLi5lMWY2ODE3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMTYgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSb3VuZGluZyBlcnJv
cnMgb24gMzItYml0IG1hY2hpbmVzIGNhdXNlcyB0ZXN0cyB0byBmYWlsCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjE5NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3MgYWRkaXRpb25hbCBDWFhGTEFH
UyB0byBDTWFrZSBpbiBhbiBhdHRlbXB0IHRvIGhhcm1vbml6ZSBmbG9hdGluZworICAgICAgICBw
b2ludCB2YWx1ZXMgYmV0d2VlbiAzMi1iaXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgorICAg
ICAgICBTYW1lIGZsYWdzIGFyZSBhbHJlYWR5IHVzZWQgYnkgUXQgYW5kIEdUSyBwb3J0cy4gCisK
KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVBcmNo
aXRlY3R1cmUpOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3Qp
OgorCiAyMDEyLTA1LTE1ICBLYW5naWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KIAog
ICAgICAgICBbRUZMXVtEUlRdIEZpeCBldmVudFNlbmRlciBrZXkgcHJvdmlkaW5nCmRpZmYgLS1n
aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRp
cnMucG0KaW5kZXggYjAwNDUxNi4uNmQ1ZDk5OCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93
ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMzAyLDEw
ICszMDIsNiBAQCBzdWIgZGV0ZXJtaW5lQXJjaGl0ZWN0dXJlCiAgICAgICAgIGlmICgkaG9zdF90
cmlwbGUgPX4gbS9eaG9zdCA9IChbXi1dKyktLykgewogICAgICAgICAgICAgIyBXZSBoYXZlIGEg
Y29uZmlndXJlZCBidWlsZCB0cmVlOyB1c2UgaXQuCiAgICAgICAgICAgICAkYXJjaGl0ZWN0dXJl
ID0gJDE7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAjIEZhbGwgYmFjayB0byBvdXRw
dXQgb2YgYGFyY2gnLCBpZiBpdCBpcyBwcmVzZW50LgotICAgICAgICAgICAgJGFyY2hpdGVjdHVy
ZSA9IGBhcmNoYDsKLSAgICAgICAgICAgIGNob21wICRhcmNoaXRlY3R1cmU7CiAgICAgICAgIH0K
ICAgICB9IGVsc2lmIChpc0FwcGxlTWFjV2ViS2l0KCkpIHsKICAgICAgICAgaWYgKG9wZW4gQVJD
SElURUNUVVJFLCAiJGJhc2VQcm9kdWN0RGlyL0FyY2hpdGVjdHVyZSIpIHsKQEAgLTMxNywxMCAr
MzEzLDIzIEBAIHN1YiBkZXRlcm1pbmVBcmNoaXRlY3R1cmUKICAgICAgICAgfSBlbHNlIHsKICAg
ICAgICAgICAgIG15ICRzdXBwb3J0czY0Qml0ID0gYHN5c2N0bCAtbiBody5vcHRpb25hbC54ODZf
NjRgOwogICAgICAgICAgICAgY2hvbXAgJHN1cHBvcnRzNjRCaXQ7Ci0gICAgICAgICAgICAkYXJj
aGl0ZWN0dXJlID0gJHN1cHBvcnRzNjRCaXQgPyAneDg2XzY0JyA6IGBhcmNoYDsKLSAgICAgICAg
ICAgIGNob21wICRhcmNoaXRlY3R1cmU7CisgICAgICAgICAgICAkYXJjaGl0ZWN0dXJlID0gJ3g4
Nl82NCcgaWYgJHN1cHBvcnRzNjRCaXQ7CisgICAgICAgIH0KKyAgICB9IGVsc2lmIChpc0VmbCgp
KSB7CisgICAgICAgIG15ICRob3N0X3Byb2Nlc3NvciA9ICIiOworICAgICAgICAkaG9zdF9wcm9j
ZXNzb3IgPSBgY21ha2UgLS1zeXN0ZW0taW5mb3JtYXRpb24gfCBncmVwIENNQUtFX1NZU1RFTV9Q
Uk9DRVNTT1JgOworICAgICAgICBpZiAoJGhvc3RfcHJvY2Vzc29yID1+IG0vXkNNQUtFX1NZU1RF
TV9QUk9DRVNTT1IgXCIoW14iXSspXCIvKSB7CisgICAgICAgICAgICAjIFdlIGhhdmUgYSBjb25m
aWd1cmVkIGJ1aWxkIHRyZWU7IHVzZSBpdC4KKyAgICAgICAgICAgICRhcmNoaXRlY3R1cmUgPSAk
MTsKKyAgICAgICAgICAgICRhcmNoaXRlY3R1cmUgPSAneDg2XzY0JyBpZiAkYXJjaGl0ZWN0dXJl
IGVxICdhbWQ2NCc7CiAgICAgICAgIH0KICAgICB9CisKKyAgICBpZiAoISRhcmNoaXRlY3R1cmUg
JiYgKGlzR3RrKCkgfHwgaXNBcHBsZU1hY1dlYktpdCgpIHx8IGlzRWZsKCkpKSB7CisgICAgICAg
ICMgRmFsbCBiYWNrIHRvIG91dHB1dCBvZiBgYXJjaCcsIGlmIGl0IGlzIHByZXNlbnQuCisgICAg
ICAgICRhcmNoaXRlY3R1cmUgPSBgYXJjaGA7CisgICAgICAgIGNob21wICRhcmNoaXRlY3R1cmU7
CisgICAgfQogfQogCiBzdWIgZGV0ZXJtaW5lTnVtYmVyT2ZDUFVzCkBAIC0xODYwLDcgKzE4Njks
NyBAQCBzdWIgcnVuQXV0b2dlbkZvckF1dG90b29sc1Byb2plY3RJZk5lY2Vzc2FyeSgkQCkKICAg
ICAjIHVzZWQgb24gQ2hyb21pdW0gYnVpbGQuCiAgICAgZGV0ZXJtaW5lQXJjaGl0ZWN0dXJlKCk7
CiAgICAgaWYgKCRhcmNoaXRlY3R1cmUgbmUgIng4Nl82NCIgJiYgIWlzQVJNKCkpIHsKLSAgICAg
ICAgJEVOVnsnQ1hYRkxBR1MnfSA9ICItbWFyY2g9cGVudGl1bTQgLW1zc2UyIC1tZnBtYXRoPXNz
ZSI7CisgICAgICAgICRFTlZ7J0NYWEZMQUdTJ30gPSAiLW1hcmNoPXBlbnRpdW00IC1tc3NlMiAt
bWZwbWF0aD1zc2UgIiAuICRFTlZ7J0NYWEZMQUdTJ307CiAgICAgfQogCiAgICAgIyBQcmVmaXgg
dGhlIGNvbW1hbmQgd2l0aCBqaGJ1aWxkIHJ1bi4KQEAgLTIwODAsNiArMjA4OSwxMyBAQCBzdWIg
Z2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QKIAogICAgIHB1c2ggQGFyZ3MsICci
JyAuIHNvdXJjZURpcigpIC4gJyInOwogCisgICAgIyBDb21waWxlciBvcHRpb25zIHRvIGtlZXAg
ZmxvYXRpbmcgcG9pbnQgdmFsdWVzIGNvbnNpc3RlbnQKKyAgICAjIGJldHdlZW4gMzItYml0IGFu
ZCA2NC1iaXQgYXJjaGl0ZWN0dXJlcy4KKyAgICBkZXRlcm1pbmVBcmNoaXRlY3R1cmUoKTsKKyAg
ICBpZiAoJGFyY2hpdGVjdHVyZSBuZSAieDg2XzY0IiAmJiAhaXNBUk0oKSkgeworICAgICAgICAk
RU5WeydDWFhGTEFHUyd9ID0gIi1tYXJjaD1wZW50aXVtNCAtbXNzZTIgLW1mcG1hdGg9c3NlICIg
LiAkRU5WeydDWFhGTEFHUyd9OworICAgIH0KKwogICAgICMgV2UgY2FsbCBzeXN0ZW0oImNtYWtl
IEBhcmdzIikgaW5zdGVhZCBvZiBzeXN0ZW0oImNtYWtlIiwgQGFyZ3MpIHNvIHRoYXQgQGFyZ3Mg
aXMKICAgICAjIHBhcnNlZCBmb3Igc2hlbGwgbWV0YWNoYXJhY3RlcnMuCiAgICAgbXkgJHdyYXBw
ZXIgPSBqaGJ1aWxkV3JhcHBlclByZWZpeElmTmVlZGVkKCkgLiAiICI7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>