86188 2012-05-11 02:01:39 -0700 Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel 2012-05-11 02:35:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 621404 0 caseq 2012-05-11 02:01:39 -0700 This is a follow-up fix for r116739. The audit panel uses span as a container for formatted results, including those produced by node formatter. ElementsTreeOutline needs offsetWidth in treeElementFromEvent(), which is only meaningful for block-level elements (returns 0 for inline). 621407 1 141358 caseq 2012-05-11 02:04:23 -0700 Created attachment 141358 Patch 621414 2 141358 yurys 2012-05-11 02:14:36 -0700 Comment on attachment 141358 Patch We should consider making ElementsTreeOutline element a div. 621430 3 caseq 2012-05-11 02:35:13 -0700 Committed r116743: <http://trac.webkit.org/changeset/116743> 141358 2012-05-11 02:04:23 -0700 2012-05-11 02:14:36 -0700 Patch bug-86188-20120511130421.patch text/plain 4153 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGNkMDhmNTVkMGQ1YTgx YmU0Y2U5MWViN2Y5NDYwZjNjNGY4NzFhMi4uNGM0MWRkNWY2N2E4YTU3ZmNiZDYwOTQ0NTVkZDBm OThhMjZiNTU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTExICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogdXNlIGRpdiwgbm90IHNwYW4gYXMgYSBwYXJlbnQgZWxlbWVudCBmb3IgRWxlbWVudHNUcmVl T3V0bGluZSBpbiBBdWRpdHMgcGFuZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg2MTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2UgbmVlZCB0byB1c2UgPGRpdj4sIG5vdCA8c3Bhbj4gYXMgYSBjb250 YWluZXIgZm9yIEVsZW1lbnRzVHJlZU91dGxpbmUsIGFzIGxhdHRlciBhY2Nlc3NlcyBpdHMgcGFy ZW50IG9mZnNldFdpZHRoCisgICAgICAgIHdpdGhpbiBfdHJlZUVsZW1lbnRGcm9tRXZlbnQoKSwg d2hpY2ggcmV0dXJucyAwIGZvciBpbmxpbmUgZWxlbWVudHMuCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0F1ZGl0Rm9ybWF0dGVycy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5B dWRpdEZvcm1hdHRlcnMubm9kZS5vbk5vZGVBdmFpbGFibGUpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkF1ZGl0Rm9ybWF0dGVycy5ub2RlKToKKwogMjAxMi0wNS0xMCAgQW5kcmV5IEtvc3lha292 ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtFeHRlbnNp b25zIEFQSV0gYWRkIGF1ZGl0IGZvcm1hdHRlcnMgZm9yIHJlbW90ZSBvYmplY3RzIGFuZCBET00g ZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv QXVkaXRGb3JtYXR0ZXJzLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9B dWRpdEZvcm1hdHRlcnMuanMKaW5kZXggNzEwZDEzNDAxMGI5ZTZjNmRiMTVmMGQyZjlhYzZiMTk4 YTJkNTQ1OC4uNWYyMDM3YjdhN2ZhYjgxMjJhMmFjMmIxNmYzYzhmNWJlODRiZGFhMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdEZvcm1hdHRlcnMu anMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdEZvcm1hdHRl cnMuanMKQEAgLTEyMSw3ICsxMjEsNyBAQCBXZWJJbnNwZWN0b3IuQXVkaXRGb3JtYXR0ZXJzID0g ewogICAgICAqLwogICAgIG5vZGU6IGZ1bmN0aW9uKGV4cHJlc3Npb24pCiAgICAgewotICAgICAg ICB2YXIgdHJlZU91dGxpbmUgPSBuZXcgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUo ZmFsc2UsIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgdmFyIHBhcmVudEVsZW1lbnQgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAgLyoqCiAgICAgICAgICAqIEBwYXJhbSB7 P251bWJlcn0gbm9kZUlkCiAgICAgICAgICAqLwpAQCAtMTI5LDkgKzEyOSwxMSBAQCBXZWJJbnNw ZWN0b3IuQXVkaXRGb3JtYXR0ZXJzID0gewogICAgICAgICB7CiAgICAgICAgICAgICBpZiAoIW5v ZGVJZCkKICAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB2YXIgdHJlZU91dGxp bmUgPSBuZXcgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUoZmFsc2UsIGZhbHNlLCB0 cnVlKTsKICAgICAgICAgICAgIHRyZWVPdXRsaW5lLnJvb3RET01Ob2RlID0gV2ViSW5zcGVjdG9y LmRvbUFnZW50Lm5vZGVGb3JJZChub2RlSWQpOwogICAgICAgICAgICAgdHJlZU91dGxpbmUuZWxl bWVudC5hZGRTdHlsZUNsYXNzKCJvdXRsaW5lLWRpc2Nsb3N1cmUiKTsKICAgICAgICAgICAgIHRy ZWVPdXRsaW5lLnNldFZpc2libGUodHJ1ZSk7CisgICAgICAgICAgICBwYXJlbnRFbGVtZW50LmFw cGVuZENoaWxkKHRyZWVPdXRsaW5lLmVsZW1lbnQpOwogICAgICAgICB9CiAgICAgICAgIC8qKgog ICAgICAgICAgKiBAcGFyYW0ge1dlYkluc3BlY3Rvci5SZW1vdGVPYmplY3R9IHJlbW90ZU9iamVj dApAQCAtMTQxLDcgKzE0Myw3IEBAIFdlYkluc3BlY3Rvci5BdWRpdEZvcm1hdHRlcnMgPSB7CiAg ICAgICAgICAgICByZW1vdGVPYmplY3QucHVzaE5vZGVUb0Zyb250ZW5kKG9uTm9kZUF2YWlsYWJs ZSk7CiAgICAgICAgIH0KICAgICAgICAgV2ViSW5zcGVjdG9yLkF1ZGl0Rm9ybWF0dGVycy5VdGls aXRpZXMuZXZhbHVhdGUoZXhwcmVzc2lvbiwgb25FdmFsdWF0ZSk7Ci0gICAgICAgIHJldHVybiB0 cmVlT3V0bGluZS5lbGVtZW50OworICAgICAgICByZXR1cm4gcGFyZW50RWxlbWVudDsKICAgICB9 CiB9OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggOGYxYTM5OWU0YTMzMWE5MmEzOTAwNDBiYzVkNjYwZWE0YzBlNTUzNS4u MDdhOWZiZjM3M2M1MzE2ZmY2ZmUwMzYwMjNiYjY2ZWVmZDZjMjVlYSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDEyLTA1LTExICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogdXNlIGRpdiwgbm90IHNwYW4gYXMgYSBwYXJlbnQg ZWxlbWVudCBmb3IgRWxlbWVudHNUcmVlT3V0bGluZSBpbiBBdWRpdHMgcGFuZWwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MTg4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZXh0ZW5z aW9ucy9leHRlbnNpb25zLWF1ZGl0cy1leHBlY3RlZC50eHQ6IHJlYmFzZWxpbmUgdG8gYWNjb3Vu dCBmb3IgZXh0cmEgPGRpdj4uCisKIDIwMTItMDUtMTAgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2Vx QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbRXh0ZW5zaW9ucyBBUEld IGFkZCBhdWRpdCBmb3JtYXR0ZXJzIGZvciByZW1vdGUgb2JqZWN0cyBhbmQgRE9NIGVsZW1lbnRz CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNpb25z LWF1ZGl0cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9l eHRlbnNpb25zLWF1ZGl0cy1leHBlY3RlZC50eHQKaW5kZXggMmU4YjdkM2JiNWViM2U0OWI4YTg3 ZmU2OGUwOTU5Yjg3NWNjMzdlMi4uZTIwZWE3ZWJlZmM5MDI1YzJiMmE0YWIxNTIwMmI0YjI5ODRi MmMyMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMvZXh0ZW5z aW9ucy1hdWRpdHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9leHRl bnNpb25zL2V4dGVuc2lvbnMtYXVkaXRzLWV4cGVjdGVkLnR4dApAQCAtMjksMTUgKzI5LDE1IEBA IFJVTk5JTkcgVEVTVDogZXh0ZW5zaW9uX3Rlc3RBdWRpdHMKICAgICAgICAgICAgICBfX3Byb3Rv X18KICAgICAgICAgICAgICA6IAogICAgICAgICAgICAgIE9iamVjdAotICAgICAgICAgICAgPAot ICAgICAgICAgICAgIHNwYW4KLSAgICAgICAgICAgICAKLSAgICAgICAgICAgICAgaWQKLSAgICAg ICAgICAgICA9IgotICAgICAgICAgICAgICB0ZXN0LWVsZW1lbnQKLSAgICAgICAgICAgICAiCi0g ICAgICAgICAgICA+Ci0gICAgICAgICAgIAorICAgICAgICAgICAgIDwKKyAgICAgICAgICAgICAg c3BhbgorICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgIGlkCisgICAgICAgICAgICAgID0i CisgICAgICAgICAgICAgICB0ZXN0LWVsZW1lbnQKKyAgICAgICAgICAgICAgIgorICAgICAgICAg ICAgID4KKyAgICAgICAgICAgIAogICAgICAgICAgZXh0ZW5zaW9ucy1hdWRpdHMuaHRtbDoyMAog ICAgIFBhc3NlZCBydWxlCiAgICAgIHRoaXMgcnVsZSBhbHdheXMgcGFzc2VzIG9rCg==