86179 2012-05-11 00:04:23 -0700 [Qt] tab-size CSS property doesn't work at all 2012-07-24 08:34:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 85203 92119 52994 87008 1 ossy bruno.abinader allan.jensen bruno.abinader cmarcelo morrita ossy simon.fraser webkit.review.bot oldest_to_newest 621319 0 ossy 2012-05-11 00:04:23 -0700 New test introduced in https://trac.webkit.org/changeset/116723 fails on Qt. It seems tab-size doesn't work at all on Qt: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r116723%20%2822802%29/fast/css/tab-size-diffs.html 621329 1 ossy 2012-05-11 00:14:38 -0700 I skipped it on Qt until proper fix - https://trac.webkit.org/changeset/116734 622791 2 allan.jensen 2012-05-14 03:38:21 -0700 It is not limited to tab-size. Qt platform doesn't support tabs at all. We always normalize the tabs to spaces before drawing them. 649281 3 bruno.abinader 2012-06-14 10:34:19 -0700 Adding bug 85203 as dependency, using Caio's patches for modifying the default font the results are now passing. The issue is related to the fact that non-monospaced fonts do have different lengths for each character, so now if the tab size, for example, equals to 8, then it will be exactly the lenght of a whitespace multiplied by 8. For even better control,a font-family:monospace would force even more proper image comparison results, what do you guys think? 649313 4 147619 bruno.abinader 2012-06-14 11:12:14 -0700 Created attachment 147619 "Force tab size layout test to use monospace" patch This patch forces the tab size layout test to use monospace font family. However, please notice this patch *still* does not fix the Qt issue as it depends on bug 85203. This patch makes sure every other platform uses monospace to avoid character/whitespace length variations that could cause test image comparison to fail. 651432 5 allan.jensen 2012-06-18 09:16:37 -0700 (In reply to comment #2) > It is not limited to tab-size. Qt platform doesn't support tabs at all. We always normalize the tabs to spaces before drawing them. This comment is obviously wrong, so just ignore it. I was confused by the fact that some of other backends handle tabs in the platform-code while Qt doesn't. 676045 6 147619 cmarcelo 2012-07-23 15:00:39 -0700 Comment on attachment 147619 "Force tab size layout test to use monospace" patch View in context: https://bugs.webkit.org/attachment.cgi?id=147619&action=review > LayoutTests/fast/css/tab-size.html:43 > +<body style="font-family:'monospace'" onload="test();"> > <div id="template" style="display:none;"> > <pre>&Tab;x</pre> Setting the style here is wrong. We are using <pre> tag and it should select a monospace font in the test environment. 676294 7 bruno.abinader 2012-07-23 18:43:50 -0700 Thanks Caio :) My bad actually, I've runned the patch back when patch from bug 85203 wasn't applied yet, so <pre> was not properly using monospace-like fonts, thus the forced usage. After bug 85203, layout tests results are okay, so if anyone mind I'm setting this bug to "fixed". (In reply to comment #6) > (From update of attachment 147619 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147619&action=review > > > LayoutTests/fast/css/tab-size.html:43 > > +<body style="font-family:'monospace'" onload="test();"> > > <div id="template" style="display:none;"> > > <pre>&Tab;x</pre> > > Setting the style here is wrong. We are using <pre> tag and it should select a monospace font in the test environment. 676670 8 cmarcelo 2012-07-24 04:59:17 -0700 Bruno, could you make a patch to unskip it? :-) 676717 9 154032 bruno.abinader 2012-07-24 05:56:59 -0700 Created attachment 154032 Unskip layout test patch This patch unskips the fast/css/tab-size.html layout test, after monospace fix from r121971. 676773 10 bruno.abinader 2012-07-24 06:59:14 -0700 Marking as "reopened" to trigger commit-queue. 676841 11 154032 webkit.review.bot 2012-07-24 08:25:40 -0700 Comment on attachment 154032 Unskip layout test patch Clearing flags on attachment: 154032 Committed r123478: <http://trac.webkit.org/changeset/123478> 676842 12 webkit.review.bot 2012-07-24 08:25:45 -0700 All reviewed patches have been landed. Closing bug. 147619 2012-06-14 11:12:14 -0700 2012-07-24 05:56:59 -0700 "Force tab size layout test to use monospace" patch 0001-Force-Tab-size-layout-test-to-use-monospace.patch text/plain 2813 bruno.abinader RnJvbSBmOGM4ZDhkZGIzNjM1MDNjMGU3ZDQyM2FlNWEyMDdiNDYzMjJiZjcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcnVubyBkZSBPbGl2ZWlyYSBBYmluYWRlciA8YnJ1bm8uYWJp bmFkZXJAYmFzeXNrb20uY29tPgpEYXRlOiBUaHUsIDE0IEp1biAyMDEyIDE0OjA3OjE4IC0wNDAw ClN1YmplY3Q6IFtQQVRDSF0gRm9yY2UgVGFiIHNpemUgbGF5b3V0IHRlc3QgdG8gdXNlIG1vbm9z cGFjZQoKQXMgY2hhcmFjdGVycyBhbmQgd2hpdGVzcGFjZSBsZW5ndGhzIG1heSB2YXJ5IHVzaW5n IG5vbi1tb25vc3BhY2VkIGZvbnRzLCBhbgppbWFnZSBjb21wYXJpc29uIHRlc3QgbWlnaHQgZmFp bCB3aGVuIHVzZWQgdG8gY29tcGFyZSBhZ2FpbnN0IHRhYiBzaXplcywgdGhhdApvbmx5IHRha2Vz IGluIGNvbnNpZGVyYXRpb24gd2hpdGVzcGFjZSBsZW5ndGhzLiBVc2luZyBtb25vc3BhY2UtbGlr ZSBmb250cwpndWFyYW50ZWVzIHRoYXQgZXZlcnkgY2hhcmFjdGVyL3doaXRlc3BhY2UgaGFzIHRo ZSBzYW1lIGxlbmd0aCwgc28gdGFiIHNpemVzCndpbGwgYmVoYXZlIHRoZSBzYW1lIGFzIHdoaXRl c3BhY2VzIGluIHRlcm1zIG9mIHRvdGFsIGxlbmd0aC4KClNpZ25lZC1vZmYtYnk6IEJydW5vIGRl IE9saXZlaXJhIEFiaW5hZGVyIDxicnVuby5hYmluYWRlckBiYXN5c2tvbS5jb20+Ci0tLQogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTggKysrKysrKysr KysrKysrKysrCiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy90YWItc2l6ZS1leHBlY3RlZC5odG1sIHwg ICAgMiArLQogTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGFiLXNpemUuaHRtbCAgICAgICAgICB8ICAg IDIgKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggYzdkNzRmOC4uYTdmMzRjNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2 LTE0ICBCcnVubyBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29t LmNvbT4KKworICAgICAgICBGb3JjZSBUYWIgc2l6ZSBsYXlvdXQgdGVzdCB0byB1c2UgbW9ub3Nw YWNlCisKKyAgICAgICAgQXMgY2hhcmFjdGVycyBhbmQgd2hpdGVzcGFjZSBsZW5ndGhzIG1heSB2 YXJ5IHVzaW5nIG5vbi1tb25vc3BhY2VkIGZvbnRzLCBhbgorICAgICAgICBpbWFnZSBjb21wYXJp c29uIHRlc3QgbWlnaHQgZmFpbCB3aGVuIHVzZWQgdG8gY29tcGFyZSBhZ2FpbnN0IHRhYiBzaXpl cywgdGhhdAorICAgICAgICBvbmx5IHRha2VzIGluIGNvbnNpZGVyYXRpb24gd2hpdGVzcGFjZSBs ZW5ndGhzLiBVc2luZyBtb25vc3BhY2UtbGlrZSBmb250cworICAgICAgICBndWFyYW50ZWVzIHRo YXQgZXZlcnkgY2hhcmFjdGVyL3doaXRlc3BhY2UgaGFzIHRoZSBzYW1lIGxlbmd0aCwgc28gdGFi IHNpemVzCisgICAgICAgIHdpbGwgYmVoYXZlIHRoZSBzYW1lIGFzIHdoaXRlc3BhY2VzIGluIHRl cm1zIG9mIHRvdGFsIGxlbmd0aC4KKworICAgICAgICBbUXRdIHRhYi1zaXplIENTUyBwcm9wZXJ0 eSBkb2Vzbid0IHdvcmsgYXQgYWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NjE3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp CisKKyAgICAgICAgKiBmYXN0L2Nzcy90YWItc2l6ZS1leHBlY3RlZC5odG1sOgorICAgICAgICAq IGZhc3QvY3NzL3RhYi1zaXplLmh0bWw6CisKIDIwMTItMDYtMTQgIFNpbW9uIFBlbmEgIDxzcGVu YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIE1hcmsgZmFzdC9mb3Jtcy90ZXh0LWlucHV0 LWV2ZW50Lmh0bWwgYXMgZmxha3kgaW4gVGVzdEV4cGVjdGF0aW9ucwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9jc3MvdGFiLXNpemUtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvY3NzL3RhYi1zaXplLWV4cGVjdGVkLmh0bWwKaW5kZXggZDZmZjAyZS4uYmI1MTI0YSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGFiLXNpemUtZXhwZWN0ZWQuaHRtbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90YWItc2l6ZS1leHBlY3RlZC5odG1sCkBAIC00LDcgKzQs NyBAQAogcHJlIHsgbWFyZ2luOiAwLjFlbTsgfQogPC9zdHlsZT4KIDwvaGVhZD4KLTxib2R5Pgor PGJvZHkgc3R5bGU9ImZvbnQtZmFtaWx5Oidtb25vc3BhY2UnIj4KIDxiPkRlZmF1bHQgdGFiIHNp emUgKDgpLjwvYj4KIDxkaXY+CiA8cHJlPiAgICAgICAgeDwvcHJlPgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9jc3MvdGFiLXNpemUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Rh Yi1zaXplLmh0bWwKaW5kZXggYTA5ZmY0Mi4uZGVlZWZiNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9jc3MvdGFiLXNpemUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90YWIt c2l6ZS5odG1sCkBAIC0zOCw3ICszOCw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogfQogPC9zY3JpcHQ+ CiA8L2hlYWQ+Ci08Ym9keSBvbmxvYWQ9InRlc3QoKTsiPgorPGJvZHkgc3R5bGU9ImZvbnQtZmFt aWx5Oidtb25vc3BhY2UnIiBvbmxvYWQ9InRlc3QoKTsiPgogPGRpdiBpZD0idGVtcGxhdGUiIHN0 eWxlPSJkaXNwbGF5Om5vbmU7Ij4KIDxwcmU+JlRhYjt4PC9wcmU+CiA8cHJlPiZUYWI7JlRhYjt4 PC9wcmU+Ci0tIAoxLjcuOS41Cgo= 154032 2012-07-24 05:56:59 -0700 2012-07-24 08:25:39 -0700 Unskip layout test patch 0001-Qt-Unskip-layout-test-after-monospace-font-fix.patch text/plain 2063 bruno.abinader RnJvbSBlNWI2NmI2MGIzZWI3NTJkOWFlZGE0ZGEzYjgzYmQxYmNjMGU2MmNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcnVubyBkZSBPbGl2ZWlyYSBBYmluYWRlciA8YnJ1bm8uYWJp bmFkZXJAYmFzeXNrb20uY29tPgpEYXRlOiBUdWUsIDI0IEp1bCAyMDEyIDA4OjU0OjA4IC0wNDAw ClN1YmplY3Q6IFtQQVRDSF0gW1F0XSBVbnNraXAgbGF5b3V0IHRlc3QgYWZ0ZXIgbW9ub3NwYWNl LWZvbnQgZml4CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYxNzkK ClRoaXMgdGVzdCBoYXMgYmVlbiBza2lwcGVkIGJlY2F1c2UgbW9ub3NwYWNlIGZvbnRzIHdlcmVu J3QgcHJvcGVybHkgdG8KSFRNTCB0YWdzIGxpa2UgPHByZT4sIGZvciBpbnN0YW5jZS4gQWZ0ZXIg cjEyMTk3MSwgdGhlIHRlc3QgcmVzdWx0cyBhcmUKbm9ybWFsIGFnYWluLgotLS0KIExheW91dFRl c3RzL0NoYW5nZUxvZyAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIExheW91dFRlc3Rz L3BsYXRmb3JtL3F0L1NraXBwZWQgfCAgICA0IC0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5z ZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGQ3ODBiNC4uOTE1ZDYyMSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTI0ICBCcnVubyBkZSBPbGl2ZWlyYSBBYmluYWRl ciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKworICAgICAgICBbUXRdIFVuc2tpcCBs YXlvdXQgdGVzdCBhZnRlciBtb25vc3BhY2UtZm9udCBmaXgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IGhhcyBiZWVuIHNraXBwZWQgYmVj YXVzZSBtb25vc3BhY2UgZm9udHMgd2VyZW4ndCBwcm9wZXJseSB0bworICAgICAgICBIVE1MIHRh Z3MgbGlrZSA8cHJlPiwgZm9yIGluc3RhbmNlLiBBZnRlciByMTIxOTcxLCB0aGUgdGVzdCByZXN1 bHRzIGFyZQorICAgICAgICBub3JtYWwgYWdhaW4uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9T a2lwcGVkOiBVbnNraXBwZWQgZmFzdC9jc3MvdGFiLXNpemUuaHRtbC4KKwogMjAxMi0wNy0yNCAg Q2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eu b3JnPgogCiAgICAgICAgIFtRdF0gZmFzdC9jc3MvdGV4dC10cmFuc2Zvcm0tc2VsZWN0Lmh0bWwg c2hvdWxkIGJlIHJlYmFzZWxpbmVkIGZvciBXSzEgYW5kIFdLMiBvbiBRdCA1LjAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC9Ta2lwcGVkCmluZGV4IDQyMzBlNTguLjNjOTJiMDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tp cHBlZApAQCAtMjUyMiwxMCArMjUyMiw2IEBAIGh0dHAvdGVzdHMvY29va2llcy9zaW5nbGUtcXVv dGVkLXZhbHVlLmh0bWwKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg2MDc3CiBodG1sNWxpYi9ydW5uZXIuaHRtbAogCi0jIFtRdF0gdGFiLXNpemUgQ1NTIHByb3Bl cnR5IGRvZXNuJ3Qgd29yayBhdCBhbGwKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg2MTc5Ci1mYXN0L2Nzcy90YWItc2l6ZS5odG1sCi0KICMgW1F0XSBmYXN0L2Zy YW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1pbmhlcml0ZWQtZG9jdW1lbnQtc3R5bGUuaHRtbCBmYWls cwogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYxODIKIGZhc3Qv ZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWluaGVyaXRlZC1kb2N1bWVudC1zdHlsZS5odG1sCi0t IAoxLjcuOS41Cgo=