86159 2012-05-10 16:48:54 -0700 REGRESSION(r116677): This patch causes linker error to some mac bots (Requested by jianli_ on #webkit). 2012-05-10 17:01:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85844 1 webkit.review.bot webkit.review.bot jianli koivisto rniwa oldest_to_newest 621119 0 webkit.review.bot 2012-05-10 16:48:54 -0700 http://trac.webkit.org/changeset/116677 broke the build: This patch causes linker error to some mac bots (Requested by jianli_ on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 621121 1 141293 webkit.review.bot 2012-05-10 16:49:42 -0700 Created attachment 141293 ROLLOUT of r116677 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 621127 2 jianli 2012-05-10 16:53:40 -0700 There is linker error in the following build: http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/10552 Undefined symbols: "__ZNK7WebCore4Node16traverseNextNodeEPKS0_", referenced from: __ZN7WebCore15RetainedDOMInfo15GetElementCountEv in libwebcore_remaining.a(RetainedDOMInfo.o) ld: symbol(s) not found It seems that mac-ews bot also failed in linking (http://queues.webkit.org/patch/141191) 621136 3 141293 webkit.review.bot 2012-05-10 17:01:20 -0700 Comment on attachment 141293 ROLLOUT of r116677 Clearing flags on attachment: 141293 Committed r116705: <http://trac.webkit.org/changeset/116705> 621137 4 webkit.review.bot 2012-05-10 17:01:25 -0700 All reviewed patches have been landed. Closing bug. 141293 2012-05-10 16:49:42 -0700 2012-05-10 17:01:20 -0700 ROLLOUT of r116677 bug-86159-20120510235338.patch text/plain 5966 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJmY2JkZjZhYWJmMDI4 M2QyYzFmMzE3YjA3MjgzMDY5MjhkZDllZS4uNjU5ZDI2Zjg0MGE1NjQ5MTY5ZmM5ODIzNGZmZTBk MGM4NmEyNjhlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTEwICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTE2Njc3LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTY2NzcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg2MTU5CisKKyAgICAgICAgVGhpcyBwYXRjaCBjYXVzZXMgbGlua2VyIGVycm9y IHRvIHNvbWUgbWFjIGJvdHMgKFJlcXVlc3RlZCBieQorICAgICAgICBqaWFubGlfIG9uICN3ZWJr aXQpLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisgICAgICAgICogZG9tL0NvbnRhaW5l ck5vZGUuaDoKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb2Rl Ojp0cmF2ZXJzZU5leHROb2RlKToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OnRyYXZlcnNlTmV4 dFNpYmxpbmcpOgorICAgICAgICAqIGRvbS9Ob2RlLmg6CisgICAgICAgIChOb2RlKToKKwogMjAx Mi0wNS0xMCAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IENyYXNoIGluIEZvbnRDYWNoZTo6cmVsZWFzZUZvbnREYXRhIGR1ZSB0byBpbmZpbml0ZSBmbG9h dCBzaXplLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4gYi9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgppbmRleCBhNTNjMjY2Y2Y1YmU2ZjgzMTFkYzgwY2E0 N2Q4YTIxNzlmYjZkYzJmLi4xNmM5Y2MzZDM5YjBlNmZiMzc5NmJhZDljYWE0ZTA0ZTRiYTlkOTU0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgorKysgYi9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmV4cC5pbgpAQCAtMjA5OSw3ICsyMDk5LDcgQEAgX19aTjdXZWJDb3Jl OERvY3VtZW50MjVzZXRGdWxsU2NyZWVuUmVuZGVyZXJTaXplRVJLTlNfN0ludFNpemVFCiBfX1pO N1dlYkNvcmU4RG9jdW1lbnQzNnNldEZ1bGxTY3JlZW5SZW5kZXJlckJhY2tncm91bmRDb2xvckVO U181Q29sb3JFCiBfX1pON1dlYkNvcmU4RG9jdW1lbnQyMnNldEFuaW1hdGluZ0Z1bGxTY3JlZW5F YgogX19aTks3V2ViQ29yZThEb2N1bWVudDlkb21XaW5kb3dFdgotX19aTks3V2ViQ29yZTROb2Rl Mjd0cmF2ZXJzZU5leHRBbmNlc3RvclNpYmxpbmdFdgorX19aTks3V2ViQ29yZTROb2RlMTZ0cmF2 ZXJzZU5leHROb2RlRVBLUzBfCiAjZW5kaWYKIAogX19aTjdXZWJDb3JlMTZBcHBsaWNhdGlvbkNh Y2hlMThkaXNrVXNhZ2VGb3JPcmlnaW5FUE5TXzE0U2VjdXJpdHlPcmlnaW5FCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5oIGIvU291cmNlL1dlYkNvcmUvZG9t L0NvbnRhaW5lck5vZGUuaAppbmRleCAxNDM5YjM2OTcxNzllODJkMzM1ZWZlMzBlYTI5MjQ1NWMx MGEyNzdhLi4yMzNlMDM0ZjIyYmVlYjM1Nzg3OTYyYzMwYzE1MDZhYmY3OWEyMDBiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Db250YWluZXJOb2RlLmgKQEAgLTIyOSwzNiArMjI5LDYgQEAgaW5saW5lIE5vZGUq IE5vZGU6OmhpZ2hlc3RBbmNlc3RvcigpIGNvbnN0CiAgICAgcmV0dXJuIGhpZ2hlc3Q7CiB9CiAK LWlubGluZSBOb2RlKiBOb2RlOjp0cmF2ZXJzZU5leHRTaWJsaW5nKCkgY29uc3QKLXsKLSAgICBp ZiAobmV4dFNpYmxpbmcoKSkKLSAgICAgICAgcmV0dXJuIG5leHRTaWJsaW5nKCk7Ci0gICAgcmV0 dXJuIHRyYXZlcnNlTmV4dEFuY2VzdG9yU2libGluZygpOwotfQotCi1pbmxpbmUgTm9kZSogTm9k ZTo6dHJhdmVyc2VOZXh0Tm9kZSgpIGNvbnN0Ci17Ci0gICAgaWYgKGZpcnN0Q2hpbGQoKSkKLSAg ICAgICAgcmV0dXJuIGZpcnN0Q2hpbGQoKTsKLSAgICByZXR1cm4gdHJhdmVyc2VOZXh0U2libGlu ZygpOwotfQotCi1pbmxpbmUgTm9kZSogTm9kZTo6dHJhdmVyc2VOZXh0U2libGluZyhjb25zdCBO b2RlKiBzdGF5V2l0aGluKSBjb25zdAotewotICAgIGlmICh0aGlzID09IHN0YXlXaXRoaW4pCi0g ICAgICAgIHJldHVybiAwOwotICAgIGlmIChuZXh0U2libGluZygpKQotICAgICAgICByZXR1cm4g bmV4dFNpYmxpbmcoKTsKLSAgICByZXR1cm4gdHJhdmVyc2VOZXh0QW5jZXN0b3JTaWJsaW5nKHN0 YXlXaXRoaW4pOwotfQotCi1pbmxpbmUgTm9kZSogTm9kZTo6dHJhdmVyc2VOZXh0Tm9kZShjb25z dCBOb2RlKiBzdGF5V2l0aGluKSBjb25zdAotewotICAgIGlmIChmaXJzdENoaWxkKCkpCi0gICAg ICAgIHJldHVybiBmaXJzdENoaWxkKCk7Ci0gICAgcmV0dXJuIHRyYXZlcnNlTmV4dFNpYmxpbmco c3RheVdpdGhpbik7Ci19Ci0KIHR5cGVkZWYgVmVjdG9yPFJlZlB0cjxOb2RlPiwgMTE+IE5vZGVW ZWN0b3I7CiAKIGlubGluZSB2b2lkIGdldENoaWxkTm9kZXMoTm9kZSogbm9kZSwgTm9kZVZlY3Rv ciYgbm9kZXMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggNjk4N2JlYmRmYzViMjVkYjgxMGIxMjZkNjg1 ZTM1ZTJiMmFlNWIzZi4uMGE3MjQ4NzY0YWJlMGFmNzU0NzE2ODYyOWJhYjhmZWI1MGI1NWM4MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Ob2RlLmNwcApAQCAtMTA4OCwyNiArMTA4OCwzMyBAQCB2b2lkIE5vZGU6OnJlbW92 ZUNhY2hlZENoaWxkTm9kZUxpc3QoKQogICAgIHJhcmVEYXRhKCktPnNldENoaWxkTm9kZUxpc3Qo MCk7CiB9CiAKLU5vZGUqIE5vZGU6OnRyYXZlcnNlTmV4dEFuY2VzdG9yU2libGluZygpIGNvbnN0 CitOb2RlKiBOb2RlOjp0cmF2ZXJzZU5leHROb2RlKGNvbnN0IE5vZGUqIHN0YXlXaXRoaW4pIGNv bnN0CiB7Ci0gICAgQVNTRVJUKCFuZXh0U2libGluZygpKTsKLSAgICBmb3IgKGNvbnN0IE5vZGUq IG5vZGUgPSBwYXJlbnROb2RlKCk7IG5vZGU7IG5vZGUgPSBub2RlLT5wYXJlbnROb2RlKCkpIHsK LSAgICAgICAgaWYgKG5vZGUtPm5leHRTaWJsaW5nKCkpCi0gICAgICAgICAgICByZXR1cm4gbm9k ZS0+bmV4dFNpYmxpbmcoKTsKLSAgICB9CisgICAgaWYgKGZpcnN0Q2hpbGQoKSkKKyAgICAgICAg cmV0dXJuIGZpcnN0Q2hpbGQoKTsKKyAgICBpZiAodGhpcyA9PSBzdGF5V2l0aGluKQorICAgICAg ICByZXR1cm4gMDsKKyAgICBpZiAobmV4dFNpYmxpbmcoKSkKKyAgICAgICAgcmV0dXJuIG5leHRT aWJsaW5nKCk7CisgICAgY29uc3QgTm9kZSAqbiA9IHRoaXM7CisgICAgd2hpbGUgKG4gJiYgIW4t Pm5leHRTaWJsaW5nKCkgJiYgKCFzdGF5V2l0aGluIHx8IG4tPnBhcmVudE5vZGUoKSAhPSBzdGF5 V2l0aGluKSkKKyAgICAgICAgbiA9IG4tPnBhcmVudE5vZGUoKTsKKyAgICBpZiAobikKKyAgICAg ICAgcmV0dXJuIG4tPm5leHRTaWJsaW5nKCk7CiAgICAgcmV0dXJuIDA7CiB9CiAKLU5vZGUqIE5v ZGU6OnRyYXZlcnNlTmV4dEFuY2VzdG9yU2libGluZyhjb25zdCBOb2RlKiBzdGF5V2l0aGluKSBj b25zdAorTm9kZSogTm9kZTo6dHJhdmVyc2VOZXh0U2libGluZyhjb25zdCBOb2RlKiBzdGF5V2l0 aGluKSBjb25zdAogewotICAgIEFTU0VSVCghbmV4dFNpYmxpbmcoKSk7Ci0gICAgQVNTRVJUKHRo aXMgIT0gc3RheVdpdGhpbik7Ci0gICAgZm9yIChjb25zdCBOb2RlKiBub2RlID0gcGFyZW50Tm9k ZSgpOyBub2RlOyBub2RlID0gbm9kZS0+cGFyZW50Tm9kZSgpKSB7Ci0gICAgICAgIGlmIChub2Rl ID09IHN0YXlXaXRoaW4pCi0gICAgICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgaWYgKG5vZGUt Pm5leHRTaWJsaW5nKCkpCi0gICAgICAgICAgICByZXR1cm4gbm9kZS0+bmV4dFNpYmxpbmcoKTsK LSAgICB9CisgICAgaWYgKHRoaXMgPT0gc3RheVdpdGhpbikKKyAgICAgICAgcmV0dXJuIDA7Cisg ICAgaWYgKG5leHRTaWJsaW5nKCkpCisgICAgICAgIHJldHVybiBuZXh0U2libGluZygpOworICAg IGNvbnN0IE5vZGUgKm4gPSB0aGlzOworICAgIHdoaWxlIChuICYmICFuLT5uZXh0U2libGluZygp ICYmICghc3RheVdpdGhpbiB8fCBuLT5wYXJlbnROb2RlKCkgIT0gc3RheVdpdGhpbikpCisgICAg ICAgIG4gPSBuLT5wYXJlbnROb2RlKCk7CisgICAgaWYgKG4pCisgICAgICAgIHJldHVybiBuLT5u ZXh0U2libGluZygpOwogICAgIHJldHVybiAwOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaAppbmRleCAzMjhjMDI5 YjA5ODFhZmQ0ZjZmN2RmY2IwMTcwY2E4MzRiYWM5ZGM3Li44NzVjODJhZmFlZTFhYTEzMzc4NDBl ODkyNWFiNWZiYzFhYmMyYjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKQEAgLTQzMSwxMiArNDMxLDEwIEBAIHB1 YmxpYzoKICAgICAvLyBUaGlzIHVzZXMgdGhlIHNhbWUgb3JkZXIgdGhhdCB0YWdzIGFwcGVhciBp biB0aGUgc291cmNlIGZpbGUuIElmIHRoZSBzdGF5V2l0aGluCiAgICAgLy8gYXJndW1lbnQgaXMg bm9uLW51bGwsIHRoZSB0cmF2ZXJzYWwgd2lsbCBzdG9wIG9uY2UgdGhlIHNwZWNpZmllZCBub2Rl IGlzIHJlYWNoZWQuCiAgICAgLy8gVGhpcyBjYW4gYmUgdXNlZCB0byByZXN0cmljdCB0cmF2ZXJz YWwgdG8gYSBwYXJ0aWN1bGFyIHN1Yi10cmVlLgotICAgIE5vZGUqIHRyYXZlcnNlTmV4dE5vZGUo KSBjb25zdDsKLSAgICBOb2RlKiB0cmF2ZXJzZU5leHROb2RlKGNvbnN0IE5vZGUqIHN0YXlXaXRo aW4pIGNvbnN0OworICAgIE5vZGUqIHRyYXZlcnNlTmV4dE5vZGUoY29uc3QgTm9kZSogc3RheVdp dGhpbiA9IDApIGNvbnN0OwogCiAgICAgLy8gTGlrZSB0cmF2ZXJzZU5leHROb2RlLCBidXQgc2tp cHMgY2hpbGRyZW4gYW5kIHN0YXJ0cyB3aXRoIHRoZSBuZXh0IHNpYmxpbmcuCi0gICAgTm9kZSog dHJhdmVyc2VOZXh0U2libGluZygpIGNvbnN0OwotICAgIE5vZGUqIHRyYXZlcnNlTmV4dFNpYmxp bmcoY29uc3QgTm9kZSogc3RheVdpdGhpbikgY29uc3Q7CisgICAgTm9kZSogdHJhdmVyc2VOZXh0 U2libGluZyhjb25zdCBOb2RlKiBzdGF5V2l0aGluID0gMCkgY29uc3Q7CiAKICAgICAvLyBEb2Vz IGEgcmV2ZXJzZSBwcmUtb3JkZXIgdHJhdmVyc2FsIHRvIGZpbmQgdGhlIG5vZGUgdGhhdCBjb21l cyBiZWZvcmUgdGhlIGN1cnJlbnQgb25lIGluIGRvY3VtZW50IG9yZGVyCiAgICAgTm9kZSogdHJh dmVyc2VQcmV2aW91c05vZGUoY29uc3QgTm9kZSogc3RheVdpdGhpbiA9IDApIGNvbnN0OwpAQCAt NzY5LDkgKzc2Nyw2IEBAIHByaXZhdGU6CiAKICAgICBFbGVtZW50KiBhbmNlc3RvckVsZW1lbnQo KSBjb25zdDsKIAotICAgIE5vZGUqIHRyYXZlcnNlTmV4dEFuY2VzdG9yU2libGluZygpIGNvbnN0 OwotICAgIE5vZGUqIHRyYXZlcnNlTmV4dEFuY2VzdG9yU2libGluZyhjb25zdCBOb2RlKiBzdGF5 V2l0aGluKSBjb25zdDsKLQogICAgIC8vIFVzZSBOb2RlOjpwYXJlbnROb2RlIGFzIHRoZSBjb25z aXN0ZW50IHdheSBvZiBxdWVyeWluZyBhIHBhcmVudCBub2RlLgogICAgIC8vIFRoaXMgbWV0aG9k IGlzIG1hZGUgcHJpdmF0ZSB0byBlbnN1cmUgYSBjb21waWxlciBlcnJvciBvbiBjYWxsIHNpdGVz IHRoYXQKICAgICAvLyBkb24ndCBmb2xsb3cgdGhpcyBydWxlLgo=