86158 2012-05-10 16:47:21 -0700 Overlay scrollbars without layers never paint in overflow regions in tiled drawing mode 2012-05-11 13:34:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin eric webkit.review.bot oldest_to_newest 621115 0 bdakin 2012-05-10 16:47:21 -0700 Overlay scrollbars without layers never paint in overflow regions in tiled drawing mode. <rdar://problem/11289546> 621131 1 141295 bdakin 2012-05-10 16:56:56 -0700 Created attachment 141295 Patch 621145 2 141295 darin 2012-05-10 17:16:47 -0700 Comment on attachment 141295 Patch Can we land a regression test for this? Manual test if necessary? 621148 3 bdakin 2012-05-10 17:22:18 -0700 We don't have a way to test overlay scrollbars, and we also don't have a way to test tiled drawing. Even the very simplest <div style="overflow:scroll"> will demonstrate the bug (so long as there is enough overflow to require the scrollbar). I definitely could land a manual test like that, but it's so simple that I'm not sure it's valuable. Is it? 621934 4 bdakin 2012-05-11 13:34:28 -0700 http://trac.webkit.org/changeset/116711 141295 2012-05-10 16:56:56 -0700 2012-05-10 17:16:47 -0700 Patch for-review.txt text/plain 4591 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjcwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM2IEBACisyMDEyLTA1LTEwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODYxNTgKKyAgICAgICAgT3ZlcmxheSBzY3JvbGxiYXJzIHdpdGhv dXQgbGF5ZXJzIG5ldmVyIHBhaW50IGluIG92ZXJmbG93IHJlZ2lvbnMgaW4gdGlsZWQgZHJhd2lu ZyBtb2RlCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzExMjg5NTQ2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbmRlckxheWVycyBwYWludCBzY3JvbGxiYXJzIHRoYXQgZG8gbm90IGhhdmUgdGhl aXIgb3duIGxheWVycyBieSAKKyAgICAgICAgcnVubmluZyBhIHNlY29uZCBwYXNzIHRocm91Z2gg dGhlIGxheWVyIHRyZWUgYWZ0ZXIgdGhlIGxheWVyIHRyZWUgaGFzIAorICAgICAgICBwYWludGVk LiBUaGlzIGVuc3VyZXMgdGhhdCB0aGUgc2Nyb2xsYmFycyBhbHdheXMgcGFpbnQgb24gdG9wIG9m IAorICAgICAgICBjb250ZW50LiBIb3dldmVyLCB0aGlzIG1lY2hhbmlzbSB3YXMgcmVseWluZyBv biAKKyAgICAgICAgRnJhbWVWaWV3OjpwYWludENvbnRlbnRzKCkgYXMgYSBjaG9rZS1wb2ludCBm b3IgYWxsIHBhaW50aW5nIHRvIAorICAgICAgICB0cmlnZ2VyIHRoZSBzZWNvbmQgcGFpbnRpbmcg cGFzcy4gVGhhdCBpcyBub3QgYSByZWFzb25hYmxlIGNob2tlLXBvaW50IAorICAgICAgICBpbiB0 aWxlZCBkcmF3aW5nLCBzbyB0aGlzIHBhdGNoIGFkZHMgc2ltaWxhciBjb2RlIHRvIAorICAgICAg ICBSZW5kZXJMYXllckJhY2tpbmcuCisKKyAgICAgICAgT25seSBvcHQgaW50byB0aGUgc2Vjb25k IHBhaW50aW5nIHBhc3MgZm9yIHNjcm9sbGJhcnMgdGhhdCBkbyBub3QgaGF2ZSAKKyAgICAgICAg dGhlaXIgb3duIGxheWVycy4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnBhaW50T3ZlcmZsb3dDb250cm9scyk6Cisg ICAgICAgIAorICAgICAgICBBIGxheWVyIHRoYXQgcGFpbnRzIGludG8gaXRzIGJhY2tpbmcgY2Fu bm90IHJldHVybiBlYXJseSBoZXJlIGlmIGl0IAorICAgICAgICBoYXMgb3ZlcmxheSBzY3JvbGxi YXJzIHRvIHBhaW50LgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnBhaW50TGF5ZXIp OgorICAgICAgICAKKyAgICAgICAgVGhpcyByZXBsaWNhdGVzIGNvZGUgaW4gRnJhbWVWaWV3Ojpw YWludENvbnRlbnRzKCkuIEFmdGVyIHBhaW50aW5nIHRoZSAKKyAgICAgICAgb3duaW5nIGxheWVy LCBkbyBhIHNlY29uZCBwYXNzIGlmIHRoZXJlIGFyZSBvdmVybGF5IHNjcm9sbGJhcnMgdG8gCisg ICAgICAgIHBhaW50LgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludEludG9MYXllcik6 CisKIDIwMTItMDUtMTAgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBDcmFzaCBpbiBGb250Q2FjaGU6OnJlbGVhc2VGb250RGF0YSBkdWUgdG8gaW5maW5p dGUgZmxvYXQgc2l6ZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy LmNwcAkocmV2aXNpb24gMTE2NTY5KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU1OSw5ICsyNTU5LDE0IEBAIHZvaWQgUmVu ZGVyTGF5ZXI6OnBhaW50T3ZlcmZsb3dDb250cm9scygKICAgICAvLyBhbmQgd2UnbGwgcGFpbnQg dGhlIHNjcm9sbGJhcnMgdGhlbi4gSW4gdGhlIG1lYW50aW1lLCBjYWNoZSB0eCBhbmQgdHkgc28g dGhhdCB0aGUgCiAgICAgLy8gc2Vjb25kIHBhc3MgZG9lc24ndCBuZWVkIHRvIHJlLWVudGVyIHRo ZSBSZW5kZXJUcmVlIHRvIGdldCBpdCByaWdodC4KICAgICBpZiAoaGFzT3ZlcmxheVNjcm9sbGJh cnMoKSAmJiAhcGFpbnRpbmdPdmVybGF5Q29udHJvbHMpIHsKKyAgICAgICAgbV9jYWNoZWRPdmVy bGF5U2Nyb2xsYmFyT2Zmc2V0ID0gcGFpbnRPZmZzZXQ7CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NP TVBPU0lUSU5HKQorICAgICAgICAvLyBJdCdzIG5vdCBuZWNlc3NhcnkgdG8gZG8gdGhlIHNlY29u ZCBwYXNzIGlmIHRoZSBzY3JvbGxiYXJzIHBhaW50IGludG8gbGF5ZXJzLgorICAgICAgICBpZiAo KG1faEJhciAmJiBsYXllckZvckhvcml6b250YWxTY3JvbGxiYXIoKSkgfHwgKG1fdkJhciAmJiBs YXllckZvclZlcnRpY2FsU2Nyb2xsYmFyKCkpKQorICAgICAgICAgICAgcmV0dXJuOworI2VuZGlm CiAgICAgICAgIFJlbmRlclZpZXcqIHJlbmRlclZpZXcgPSByZW5kZXJlcigpLT52aWV3KCk7CiAg ICAgICAgIHJlbmRlclZpZXctPmxheWVyKCktPnNldENvbnRhaW5zRGlydHlPdmVybGF5U2Nyb2xs YmFycyh0cnVlKTsKLSAgICAgICAgbV9jYWNoZWRPdmVybGF5U2Nyb2xsYmFyT2Zmc2V0ID0gcGFp bnRPZmZzZXQ7CiAgICAgICAgIHJlbmRlclZpZXctPmZyYW1lVmlldygpLT5zZXRDb250YWluc1Nj cm9sbGFibGVBcmVhV2l0aE92ZXJsYXlTY3JvbGxiYXJzKHRydWUpOwogICAgICAgICByZXR1cm47 CiAgICAgfQpAQCAtMjg4Miw3ICsyODg3LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRMYXll cihSZW5kZXJMYXllcgogICAgICAgICAvLyBidXQgd2UgbmVlZCB0byBlbnN1cmUgdGhhdCB3ZSBk b24ndCBjYWNoZSBjbGlwIHJlY3RzIGNvbXB1dGVkIHdpdGggdGhlIHdyb25nIHJvb3QgaW4gdGhp cyBjYXNlLgogICAgICAgICBpZiAoY29udGV4dC0+dXBkYXRpbmdDb250cm9sVGludHMoKSB8fCAo cGFpbnRCZWhhdmlvciAmIFBhaW50QmVoYXZpb3JGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnMpKQog ICAgICAgICAgICAgcGFpbnRGbGFncyB8PSBQYWludExheWVyVGVtcG9yYXJ5Q2xpcFJlY3RzOwot ICAgICAgICBlbHNlIGlmICghYmFja2luZygpLT5wYWludHNJbnRvV2luZG93KCkgJiYgIWJhY2tp bmcoKS0+cGFpbnRzSW50b0NvbXBvc2l0ZWRBbmNlc3RvcigpICYmICFzaG91bGREb1NvZnR3YXJl UGFpbnQodGhpcywgcGFpbnRGbGFncyAmIFBhaW50TGF5ZXJQYWludGluZ1JlZmxlY3Rpb24pKSB7 CisgICAgICAgIGVsc2UgaWYgKCFiYWNraW5nKCktPnBhaW50c0ludG9XaW5kb3coKSAmJiAhYmFj a2luZygpLT5wYWludHNJbnRvQ29tcG9zaXRlZEFuY2VzdG9yKCkgJiYgIXNob3VsZERvU29mdHdh cmVQYWludCh0aGlzLCBwYWludEZsYWdzICYgUGFpbnRMYXllclBhaW50aW5nUmVmbGVjdGlvbikg JiYgIXJvb3RMYXllci0+Y29udGFpbnNEaXJ0eU92ZXJsYXlTY3JvbGxiYXJzKCkpIHsKICAgICAg ICAgICAgIC8vIElmIHRoaXMgUmVuZGVyTGF5ZXIgc2hvdWxkIHBhaW50IGludG8gaXRzIGJhY2tp bmcsIHRoYXQgd2lsbCBiZSBkb25lIHZpYSBSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50SW50b0xh eWVyKCkuCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCShyZXZpc2lvbiAxMTY1 NzApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTE2OSw2ICsxMTY5LDkgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tp bmc6OnBhaW50SW50b0xheWVyKAogICAgIC8vIEZJWE1FOiBHcmFwaGljc0xheWVycyBuZWVkIGEg d2F5IHRvIHNwbGl0IGZvciBSZW5kZXJSZWdpb25zLgogICAgIG1fb3duaW5nTGF5ZXItPnBhaW50 TGF5ZXJDb250ZW50cyhyb290TGF5ZXIsIGNvbnRleHQsIHBhaW50RGlydHlSZWN0LCBwYWludEJl aGF2aW9yLCBwYWludGluZ1Jvb3QsIDAsIDAsIHBhaW50RmxhZ3MpOwogCisgICAgaWYgKG1fb3du aW5nTGF5ZXItPmNvbnRhaW5zRGlydHlPdmVybGF5U2Nyb2xsYmFycygpKQorICAgICAgICBtX293 bmluZ0xheWVyLT5wYWludE92ZXJsYXlTY3JvbGxiYXJzKGNvbnRleHQsIHBhaW50RGlydHlSZWN0 LCBwYWludEJlaGF2aW9yLCBwYWludGluZ1Jvb3QpOworCiAgICAgQVNTRVJUKCFtX293bmluZ0xh eWVyLT5tX3VzZWRUcmFuc3BhcmVuY3kpOwogfQogCg==