86151 2012-05-10 15:47:56 -0700 Reduce GradientAttributes object size 2012-08-20 22:46:03 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis eric rniwa webkit.review.bot zimmermann oldest_to_newest 621073 0 rwlbuis 2012-05-10 15:47:56 -0700 This can use better bitpacking. 621083 1 141283 rwlbuis 2012-05-10 15:54:51 -0700 Created attachment 141283 Patch 693243 2 141283 eric 2012-08-12 04:30:18 -0700 Comment on attachment 141283 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review > Source/WebCore/svg/GradientAttributes.h:80 > + unsigned m_spreadMethod : 2; > + unsigned m_gradientUnits : 2; Do we need to add any COMPILE_ASSERTS that these fit in two bits? Will the compiler warn us as-is? 693306 3 141283 rniwa 2012-08-12 12:51:58 -0700 Comment on attachment 141283 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review > Source/WebCore/svg/GradientAttributes.h:84 > bool m_spreadMethodSet : 1; > bool m_gradientUnitsSet : 1; We can make these member variables to unsigned and save more space on Windows. 693307 4 141283 rniwa 2012-08-12 12:51:59 -0700 Comment on attachment 141283 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review > Source/WebCore/svg/GradientAttributes.h:84 > bool m_spreadMethodSet : 1; > bool m_gradientUnitsSet : 1; We can make these member variables to unsigned and save more space on Windows. 699145 5 rniwa 2012-08-19 18:37:43 -0700 Has this been landed yet? 699488 6 rwlbuis 2012-08-20 07:27:53 -0700 (In reply to comment #5) > Has this been landed yet? No, I plan to make some changes and will maybe post again for the final patch. 700368 7 159593 rwlbuis 2012-08-20 19:36:46 -0700 Created attachment 159593 Patch 700485 8 159593 webkit.review.bot 2012-08-20 22:45:59 -0700 Comment on attachment 159593 Patch Clearing flags on attachment: 159593 Committed r126134: <http://trac.webkit.org/changeset/126134> 700486 9 webkit.review.bot 2012-08-20 22:46:03 -0700 All reviewed patches have been landed. Closing bug. 141283 2012-05-10 15:54:51 -0700 2012-08-20 19:36:11 -0700 Patch bug-86151-20120510185450.patch text/plain 2208 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM5Y2ExZjVjYzM5Mjlj MjJmZDljNGRmYTM0MzdiNGRjMDA0NWVlYy4uNjU4YjA1Y2FmNTJhNjg5MzUwODg1ODVkZWE2YmZk ODRhOTJhNDI2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTEwICBSb2Ig QnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZWR1Y2UgR3JhZGllbnRBdHRy aWJ1dGVzIG9iamVjdCBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NjE1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgcmVkdWNlcyBHcmFkaWVudEF0dHJpYnV0ZXMgaW4gbWVtb3J5IHNpemUg YnkgOCBieXRlcyBvbiBteSA2NC1iaXQgc3lzdGVtLiBJdCBhbHNvCisgICAgICAgIHJlZHVjZXMg dGhlIHNpemUgb2YgUmVuZGVyU1ZHUmVzb3VyY2VMaW5lYXJHcmFkaWVudCBhbmQgUmVuZGVyU1ZH UmVzb3VyY2VSYWRpYWxHcmFkaWVudC4KKworICAgICAgICAqIHN2Zy9HcmFkaWVudEF0dHJpYnV0 ZXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYWRpZW50QXR0cmlidXRlczo6c3ByZWFkTWV0aG9k KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYWRpZW50QXR0cmlidXRlczo6Z3JhZGllbnRVbml0cyk6 CisgICAgICAgIChHcmFkaWVudEF0dHJpYnV0ZXMpOgorCiAyMDEyLTA1LTA5ICBSb2IgQnVpcyAg PHJ3bGJ1aXNAd2Via2l0Lm9yZz4KIAogICAgICAgICBDbGVhbnVwIFNWR0VsZW1lbnQuY3BwCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvR3JhZGllbnRBdHRyaWJ1dGVzLmggYi9Tb3Vy Y2UvV2ViQ29yZS9zdmcvR3JhZGllbnRBdHRyaWJ1dGVzLmgKaW5kZXggYjdjZmU4YTcxMzJlZDBl NWE2YTc1NmEzMGViNjIzNDE2NGU2NmYwYi4uOGI5YmJiMmQxMmZiMjdiNDg2ZmFiNWU0YTBiMTk1 ODlkM2VkYmJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL0dyYWRpZW50QXR0cmli dXRlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9HcmFkaWVudEF0dHJpYnV0ZXMuaApAQCAt MzcsOCArMzcsOCBAQCBzdHJ1Y3QgR3JhZGllbnRBdHRyaWJ1dGVzIHsKICAgICB7CiAgICAgfQog Ci0gICAgU1ZHU3ByZWFkTWV0aG9kVHlwZSBzcHJlYWRNZXRob2QoKSBjb25zdCB7IHJldHVybiBt X3NwcmVhZE1ldGhvZDsgfQotICAgIFNWR1VuaXRUeXBlczo6U1ZHVW5pdFR5cGUgZ3JhZGllbnRV bml0cygpIGNvbnN0IHsgcmV0dXJuIG1fZ3JhZGllbnRVbml0czsgfQorICAgIFNWR1NwcmVhZE1l dGhvZFR5cGUgc3ByZWFkTWV0aG9kKCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8U1ZHU3By ZWFkTWV0aG9kVHlwZT4obV9zcHJlYWRNZXRob2QpOyB9CisgICAgU1ZHVW5pdFR5cGVzOjpTVkdV bml0VHlwZSBncmFkaWVudFVuaXRzKCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8U1ZHVW5p dFR5cGVzOjpTVkdVbml0VHlwZT4obV9ncmFkaWVudFVuaXRzKTsgfQogICAgIEFmZmluZVRyYW5z Zm9ybSBncmFkaWVudFRyYW5zZm9ybSgpIGNvbnN0IHsgcmV0dXJuIG1fZ3JhZGllbnRUcmFuc2Zv cm07IH0KICAgICBjb25zdCBWZWN0b3I8R3JhZGllbnQ6OkNvbG9yU3RvcD4mIHN0b3BzKCkgY29u c3QgeyByZXR1cm4gbV9zdG9wczsgfQogCkBAIC03MywxMSArNzMsMTIgQEAgc3RydWN0IEdyYWRp ZW50QXR0cmlidXRlcyB7CiAKIHByaXZhdGU6CiAgICAgLy8gUHJvcGVydGllcwotICAgIFNWR1Nw cmVhZE1ldGhvZFR5cGUgbV9zcHJlYWRNZXRob2Q7Ci0gICAgU1ZHVW5pdFR5cGVzOjpTVkdVbml0 VHlwZSBtX2dyYWRpZW50VW5pdHM7CiAgICAgQWZmaW5lVHJhbnNmb3JtIG1fZ3JhZGllbnRUcmFu c2Zvcm07CiAgICAgVmVjdG9yPEdyYWRpZW50OjpDb2xvclN0b3A+IG1fc3RvcHM7CiAKKyAgICB1 bnNpZ25lZCBtX3NwcmVhZE1ldGhvZCA6IDI7CisgICAgdW5zaWduZWQgbV9ncmFkaWVudFVuaXRz IDogMjsKKwogICAgIC8vIFByb3BlcnR5IHN0YXRlcwogICAgIGJvb2wgbV9zcHJlYWRNZXRob2RT ZXQgOiAxOwogICAgIGJvb2wgbV9ncmFkaWVudFVuaXRzU2V0IDogMTsK 159593 2012-08-20 19:36:46 -0700 2012-08-20 22:45:59 -0700 Patch bug-86151-20120820223556.patch text/plain 2799 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTA4MzlkMjAzNmI2ZDBh YjM1NjZiYzk2MDVjNGFjNGNkODMxZWExNi4uMWMwNTVjYTNiNDg3YTA4NzJjZDdjYmNmYjk2NmFm MzJmNzU4YmViNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTIwICBSb2Ig QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgUmVkdWNlIEdyYWRpZW50QXR0cmlidXRl cyBvYmplY3Qgc2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODYxNTEKKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAg ICBUaGlzIHJlZHVjZXMgR3JhZGllbnRBdHRyaWJ1dGVzIGluIG1lbW9yeSBzaXplIGJ5IDggYnl0 ZXMgb24gbXkgNjQtYml0IHN5c3RlbS4gSXQgYWxzbworICAgICAgICByZWR1Y2VzIHRoZSBzaXpl IG9mIFJlbmRlclNWR1Jlc291cmNlTGluZWFyR3JhZGllbnQgYW5kIFJlbmRlclNWR1Jlc291cmNl UmFkaWFsR3JhZGllbnQuCisKKyAgICAgICAgKiBzdmcvR3JhZGllbnRBdHRyaWJ1dGVzLmg6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFkaWVudEF0dHJpYnV0ZXM6OnNwcmVhZE1ldGhvZCk6CisgICAg ICAgIChXZWJDb3JlOjpHcmFkaWVudEF0dHJpYnV0ZXM6OmdyYWRpZW50VW5pdHMpOgorICAgICAg ICAoR3JhZGllbnRBdHRyaWJ1dGVzKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoU2Ft ZVNpemVBc0dyYWRpZW50QXR0cmlidXRlcyk6CisKIDIwMTItMDctMjIgIEtlbnQgVGFtdXJhICA8 dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbmFtZSBFTkFCTEVfREVUQUlMUyB0byBF TkFCTEVfREVUQUlMU19FTEVNRU5UCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvR3Jh ZGllbnRBdHRyaWJ1dGVzLmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvR3JhZGllbnRBdHRyaWJ1dGVz LmgKaW5kZXggYjdjZmU4YTcxMzJlZDBlNWE2YTc1NmEzMGViNjIzNDE2NGU2NmYwYi4uY2NkMGM4 ZWE1NGQ4NTgyZWNmYjcxNjI1ZjU3YjVhZTk5Njg1ZTUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvc3ZnL0dyYWRpZW50QXR0cmlidXRlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9H cmFkaWVudEF0dHJpYnV0ZXMuaApAQCAtMzcsOCArMzcsOCBAQCBzdHJ1Y3QgR3JhZGllbnRBdHRy aWJ1dGVzIHsKICAgICB7CiAgICAgfQogCi0gICAgU1ZHU3ByZWFkTWV0aG9kVHlwZSBzcHJlYWRN ZXRob2QoKSBjb25zdCB7IHJldHVybiBtX3NwcmVhZE1ldGhvZDsgfQotICAgIFNWR1VuaXRUeXBl czo6U1ZHVW5pdFR5cGUgZ3JhZGllbnRVbml0cygpIGNvbnN0IHsgcmV0dXJuIG1fZ3JhZGllbnRV bml0czsgfQorICAgIFNWR1NwcmVhZE1ldGhvZFR5cGUgc3ByZWFkTWV0aG9kKCkgY29uc3QgeyBy ZXR1cm4gc3RhdGljX2Nhc3Q8U1ZHU3ByZWFkTWV0aG9kVHlwZT4obV9zcHJlYWRNZXRob2QpOyB9 CisgICAgU1ZHVW5pdFR5cGVzOjpTVkdVbml0VHlwZSBncmFkaWVudFVuaXRzKCkgY29uc3QgeyBy ZXR1cm4gc3RhdGljX2Nhc3Q8U1ZHVW5pdFR5cGVzOjpTVkdVbml0VHlwZT4obV9ncmFkaWVudFVu aXRzKTsgfQogICAgIEFmZmluZVRyYW5zZm9ybSBncmFkaWVudFRyYW5zZm9ybSgpIGNvbnN0IHsg cmV0dXJuIG1fZ3JhZGllbnRUcmFuc2Zvcm07IH0KICAgICBjb25zdCBWZWN0b3I8R3JhZGllbnQ6 OkNvbG9yU3RvcD4mIHN0b3BzKCkgY29uc3QgeyByZXR1cm4gbV9zdG9wczsgfQogCkBAIC03Mywx OCArNzMsMjcgQEAgc3RydWN0IEdyYWRpZW50QXR0cmlidXRlcyB7CiAKIHByaXZhdGU6CiAgICAg Ly8gUHJvcGVydGllcwotICAgIFNWR1NwcmVhZE1ldGhvZFR5cGUgbV9zcHJlYWRNZXRob2Q7Ci0g ICAgU1ZHVW5pdFR5cGVzOjpTVkdVbml0VHlwZSBtX2dyYWRpZW50VW5pdHM7CiAgICAgQWZmaW5l VHJhbnNmb3JtIG1fZ3JhZGllbnRUcmFuc2Zvcm07CiAgICAgVmVjdG9yPEdyYWRpZW50OjpDb2xv clN0b3A+IG1fc3RvcHM7CiAKKyAgICB1bnNpZ25lZCBtX3NwcmVhZE1ldGhvZCA6IDI7CisgICAg dW5zaWduZWQgbV9ncmFkaWVudFVuaXRzIDogMjsKKwogICAgIC8vIFByb3BlcnR5IHN0YXRlcwot ICAgIGJvb2wgbV9zcHJlYWRNZXRob2RTZXQgOiAxOwotICAgIGJvb2wgbV9ncmFkaWVudFVuaXRz U2V0IDogMTsKLSAgICBib29sIG1fZ3JhZGllbnRUcmFuc2Zvcm1TZXQgOiAxOwotICAgIGJvb2wg bV9zdG9wc1NldCA6IDE7CisgICAgdW5zaWduZWQgbV9zcHJlYWRNZXRob2RTZXQgOiAxOworICAg IHVuc2lnbmVkIG1fZ3JhZGllbnRVbml0c1NldCA6IDE7CisgICAgdW5zaWduZWQgbV9ncmFkaWVu dFRyYW5zZm9ybVNldCA6IDE7CisgICAgdW5zaWduZWQgbV9zdG9wc1NldCA6IDE7Cit9OworCitz dHJ1Y3QgU2FtZVNpemVBc0dyYWRpZW50QXR0cmlidXRlcyB7CisgICAgQWZmaW5lVHJhbnNmb3Jt IGE7CisgICAgVmVjdG9yPEdyYWRpZW50OjpDb2xvclN0b3A+IGI7CisgICAgdW5zaWduZWQgYyA6 IDg7CiB9OwogCitDT01QSUxFX0FTU0VSVChzaXplb2YoR3JhZGllbnRBdHRyaWJ1dGVzKSA9PSBz aXplb2YoU2FtZVNpemVBc0dyYWRpZW50QXR0cmlidXRlcyksIEdyYWRpZW50QXR0cmlidXRlc19z aXplX2d1YXJkKTsKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxF KFNWRykK