86149 2012-05-10 15:10:54 -0700 libjpeg_turbo doesn't properly set the alpha value to 0xFF on Android 2012-05-15 12:43:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 86180 66687 1 abarth abarth hbono noel.gordon qinmin oldest_to_newest 621045 0 abarth 2012-05-10 15:10:54 -0700 libjpeg_turbo doesn't properly set the alpha value to 0xFF on Android 621048 1 141275 abarth 2012-05-10 15:11:50 -0700 Created attachment 141275 Patch 621049 2 abarth 2012-05-10 15:12:20 -0700 I'm not entirely sure what to do with this patch. Noel: Any thoughts? 621054 3 qinmin 2012-05-10 15:19:54 -0700 Hironori has a patch that fixed this in libjpeg_turbo: http://libjpeg-turbo.svn.sourceforge.net/viewvc/libjpeg-turbo?view=revision&revision=810 But the change has't been merged into chromium yet. So I am wondering whether we should wait for that to happen or we can submit this change first and wait for that change to merge. 621067 4 abarth 2012-05-10 15:41:04 -0700 > Hironori has a patch that fixed this in libjpeg_turbo: > http://libjpeg-turbo.svn.sourceforge.net/viewvc/libjpeg-turbo?view=revision&revision=810 > But the change has't been merged into chromium yet. Fri Mar 16 14:30:46 2012 UTC (7 weeks, 6 days ago) What's the ETA for merging that into Chromium? > So I am wondering whether we should wait for that to happen or we can submit this change first and wait for that change to merge. One possibility is to submit this change with a link to the fix so that folks will know when to remove it in the future. 621072 5 qinmin 2012-05-10 15:46:42 -0700 (In reply to comment #4) > > Hironori has a patch that fixed this in libjpeg_turbo: > > http://libjpeg-turbo.svn.sourceforge.net/viewvc/libjpeg-turbo?view=revision&revision=810 > > But the change has't been merged into chromium yet. > > Fri Mar 16 14:30:46 2012 UTC (7 weeks, 6 days ago) > > What's the ETA for merging that into Chromium? Hironori san, any idea when this change will be merged into chromium? > > > So I am wondering whether we should wait for that to happen or we can submit this change first and wait for that change to merge. > > One possibility is to submit this change with a link to the fix so that folks will know when to remove it in the future. That should also work, let's see how long will that fix go into chromium first. 621153 6 hbono 2012-05-10 17:30:41 -0700 Greetings Min, Thanks for your update. I will update our copy of libjpeg-turbo to the latest trunk next week. Regards, Hironori Bono (In reply to comment #5) > Hironori san, any idea when this change will be merged into chromium? 621169 7 141275 abarth 2012-05-10 17:57:17 -0700 Comment on attachment 141275 Patch Thanks! I'm going to leave this bug open for a bit to remind me to follow up. 621173 8 noel.gordon 2012-05-10 18:15:29 -0700 Sounds good, want hbono's fix for libjpeg-turbo in the chromium tree, http://crbug.com/106020 623591 9 noel.gordon 2012-05-14 20:23:02 -0700 Right, new libjpeg-turbo r829 is now in webkit and should obviate the need for this change. @qinmin could you build and test Android with webkit TOT libjpeg-turbo r829, and let us know here if it works without all the #if OS(ANDROID) in the current patch? 623596 10 noel.gordon 2012-05-14 20:27:16 -0700 The webkit revision to test should be http://trac.webkit.org/changeset/117020 (r117020) or above. 623599 11 qinmin 2012-05-14 20:33:14 -0700 Will do that tomorrow 624372 12 qinmin 2012-05-15 12:13:17 -0700 Yes, with libjpeg-turbo r829, the images now render correctly without this patch. I will remove the code from downstream android implementation after our next merge. 624404 13 abarth 2012-05-15 12:43:41 -0700 Thanks Min! 141275 2012-05-10 15:11:50 -0700 2012-05-10 17:57:17 -0700 Patch bug-86149-20120510151149.patch text/plain 1817 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjY5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTEwICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgbGlianBlZ190dXJibyBkb2Vzbid0 IHByb3Blcmx5IHNldCB0aGUgYWxwaGEgdmFsdWUgdG8gMHhGRiBvbiBBbmRyb2lkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjE0OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2Ut ZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpQ RUdJbWFnZURlY29kZXI6Om91dHB1dFNjYW5saW5lcyk6CisKIDIwMTItMDUtMTAgIEVyaWMgU2Vp ZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgSUZSQU1FX1NFQU1MRVNTIGNo aWxkIGRvY3VtZW50cyBpbmhlcml0IHN0eWxlcyBmcm9tIHRoZWlyIHBhcmVudCBpZnJhbWUgZWxl bWVudApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9K UEVHSW1hZ2VEZWNvZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwCShyZXZpc2lvbiAxMTY2 OTEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJ bWFnZURlY29kZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjYsNyArNTI2LDE1IEBAIGJvb2wg SlBFR0ltYWdlRGVjb2Rlcjo6b3V0cHV0U2NhbmxpbmVzKCkKICAgICAgICAgIHdoaWxlIChpbmZv LT5vdXRwdXRfc2NhbmxpbmUgPCBpbmZvLT5vdXRwdXRfaGVpZ2h0KSB7CiAgICAgICAgICAgICAg dW5zaWduZWQgY2hhciogcm93ID0gcmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZCBjaGFyKj4oYnVm ZmVyLmdldEFkZHIoMCwgaW5mby0+b3V0cHV0X3NjYW5saW5lKSk7CiAgICAgICAgICAgICAgaWYg KGpwZWdfcmVhZF9zY2FubGluZXMoaW5mbywgJnJvdywgMSkgIT0gMSkKLSAgICAgICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworI2lmIE9T KEFORFJPSUQpCisgICAgICAgICAgICAgLy8gVGhlcmUgaXMgYSBidWcgaW4gbGlianBlZ190dXJi byB0aGF0IGFscGhhIHZhbHVlIGlzIG5vdCBzZXQgdG8KKyAgICAgICAgICAgICAvLyAweEZGIG9u IGFuZHJvaWQgd2hlbiBkb19mYW5jeV9zYW1wbGluZyBpcyBzZXQgdG8gZmFsc2UuIFNldAorICAg ICAgICAgICAgIC8vIGFscGhhIHZhbHVlcyBoZXJlIHV0aWwgdGhlIGJ1ZyBpcyBmaXhlZCBpbiBs aWJqcGVnX3R1cmJvLgorICAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIqIGFscGhhID0gcm93ICsg MzsKKyAgICAgICAgICAgICBmb3IgKGludCB4ID0gMDsgeCA8IChpbnQpIGluZm8tPm91dHB1dF93 aWR0aDsgKyt4LCBhbHBoYSArPSA0KQorICAgICAgICAgICAgICAgICAqYWxwaGEgPSAweEZGOwor I2VuZGlmCiAgICAgICAgICB9CiAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgfQo=