86148 2012-05-10 14:43:45 -0700 [Qt] Fix build after QPA file renaming 2012-05-16 07:56:15 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 sirspudd webkit-unassigned girish hausmann noam ossy sirspudd vestbo webkit.review.bot oldest_to_newest 621012 0 sirspudd 2012-05-10 14:43:45 -0700 Fixes Webkit to build after: https://codereview.qt-project.org/#change,23443 621021 1 141268 sirspudd 2012-05-10 14:45:45 -0700 Created attachment 141268 build fix 621026 2 webkit.review.bot 2012-05-10 14:49:53 -0700 Attachment 141268 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/plugins/qt/PluginViewQt.cpp:87: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 621053 3 141268 webkit-ews 2012-05-10 15:19:24 -0700 Comment on attachment 141268 build fix Attachment 141268 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12672096 622844 4 ossy 2012-05-14 04:55:10 -0700 It seems it is what I searched. :) Let me try it. 622867 5 ossy 2012-05-14 05:44:31 -0700 The build works fine, but unfortunately there is a serious regression in Qt5 somewhere, because _all_ tests crash with this backtrace: $ run-in-xvfb.sh gdb WebKitBuild/Debug/bin/DumpRenderTree GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree...done. (gdb) run css2.1/t0402-c71-fwd-parsing-00-f.html Starting program: /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree css2.1/t0402-c71-fwd-parsing-00-f.html [Thread debugging using libthread_db enabled] Program received signal SIGABRT, Aborted. 0x00007fffebfe91b5 in *__GI_raise (sig=<value optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 64 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory. in ../nptl/sysdeps/unix/sysv/linux/raise.c Current language: auto The current source language is "auto; currently c". (gdb) bt #0 0x00007fffebfe91b5 in *__GI_raise (sig=<value optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 #1 0x00007fffebfebfc0 in *__GI_abort () at abort.c:92 #2 0x00007fffecfe3c45 in qt_message_output(QtMsgType, QMessageLogContext const&, QString const&) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5 #3 0x00007fffecfe41b6 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5 #4 0x00007fffecfe4353 in QMessageLogger::fatal(char const*, ...) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5 #5 0x00007fffed6c9c5d in QGuiApplicationPrivate::createPlatformIntegration() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtGui.so.5 #6 0x00007fffed6cadbd in QGuiApplicationPrivate::createEventDispatcher() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtGui.so.5 #7 0x00007fffed18e00a in QCoreApplication::init() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5 #8 0x00007fffed18e275 in QCoreApplication::QCoreApplication(QCoreApplicationPrivate&) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5 #9 0x00007fffed6cab8d in QGuiApplication::QGuiApplication(QGuiApplicationPrivate&) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtGui.so.5 #10 0x00007fffeed1d6e7 in QApplication::QApplication(int&, char**, int) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtWidgets.so.5 #11 0x000000000042d33a in main (argc=2, argv=0x7fffffffe368) at /home/oszi/WebKit/Tools/DumpRenderTree/qt/main.cpp:152 5146b9449d58b2c3fe54173ebbdfb07b6e0da19f is the latest working Qt5 hash and df4acd4b44261fed883c456b77e442a4234aa746 has this bug. (and the latest 47e8da3a178579ac4c05feb66db9cfafc0fe64d6 has it too) 622955 6 noam 2012-05-14 07:25:24 -0700 (In reply to comment #5) > The build works fine, but unfortunately there is a serious regression in Qt5 somewhere, because _all_ tests crash with this backtrace: > > $ run-in-xvfb.sh gdb WebKitBuild/Debug/bin/DumpRenderTree > #4 0x00007fffecfe4353 in QMessageLogger::fatal(char const*, ...) () from Do we know what the fatal error log actually is? 622956 7 ossy 2012-05-14 07:26:46 -0700 How can I get it? 622959 8 noam 2012-05-14 07:32:11 -0700 (In reply to comment #7) > How can I get it? It should be in stderr right before the crash. 622976 9 ossy 2012-05-14 08:02:33 -0700 (In reply to comment #8) > (In reply to comment #7) > > How can I get it? > It should be in stderr right before the crash. I can't find any additionalt error, I copy/pasted the full log. 623821 10 ossy 2012-05-15 02:10:53 -0700 Simon found the culprit, thanks for it: configure disabled XCB because of missing libxcb-randr0-dev package. It is a new dependency for XCB after this qtbase commit: f280efc6201adf8933c9d48a1d5b6983ee9fed9b I'll rebuild Qt5 again and test WebKit with it. 625435 11 141268 ossy 2012-05-16 07:53:38 -0700 Comment on attachment 141268 build fix r=me 625437 12 141268 ossy 2012-05-16 07:56:03 -0700 Comment on attachment 141268 build fix Clearing flags on attachment: 141268 Committed r117291: <http://trac.webkit.org/changeset/117291> 625438 13 ossy 2012-05-16 07:56:15 -0700 All reviewed patches have been landed. Closing bug. 141268 2012-05-10 14:45:45 -0700 2012-05-16 07:56:03 -0700 build fix webkit-qpa-fix.diff text/plain 2002 sirspudd SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjY3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTEwICBEb25hbGQg Q2FyciAgPGRvbmFsZC5jYXJyQG5va2lhLmNvbT4KKworICAgICAgICBGaXhlcyB0aGUgYnVpbGQg d2l0aCBRdCA1IEhFQUQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYkNvcmUucHJpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9UZXh0dXJlTWFwcGVyR0wuY3BwOgorICAgICAgICAqIHBsdWdpbnMvcXQvUGx1Z2luVmlld1F0 LmNwcDoKKwogMjAxMi0wNS0xMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAK ICAgICAgICAgSW5saW5lIE5vZGU6OnRyYXZlcnNlTmV4dE5vZGUKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyR0wuY3BwCShyZXZpc2lvbiAxMTY2NzIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMs NyArMzMsNyBAQAogI2lmIFBMQVRGT1JNKFFUKQogI2lmIFFUX1ZFUlNJT04gPj0gMHgwNTAwMDAK ICNpbmNsdWRlIDxRT3BlbkdMQ29udGV4dD4KLSNpbmNsdWRlIDxRUGxhdGZvcm1QaXhtYXA+Cisj aW5jbHVkZSA8cXBhL3FwbGF0Zm9ybXBpeG1hcC5oPgogI2Vsc2UKICNpbmNsdWRlIDxRR0xDb250 ZXh0PgogI2VuZGlmIC8vIFFUX1ZFUlNJT04KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUu cHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCShyZXZpc2lvbiAx MTY2NzIpCisrKyBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQkod29ya2luZyBjb3B5KQpAQCAt MTIsNyArMTIsNyBAQAogIyBXZSBlbmFibGUgVGV4dHVyZU1hcHBlciBieSBkZWZhdWx0OyByZW1v dmUgdGhpcyBsaW5lIHRvIGVuYWJsZSBHcmFwaGljc0xheWVyUXQuCiBDT05GSUcgKz0gdGV4bWFw CiAKLVFUICo9IG5ldHdvcmsgc3FsCitRVCAqPSBuZXR3b3JrIHNxbCBndWktcHJpdmF0ZQogCiBX RUJDT1JFX0dFTkVSQVRFRF9TT1VSQ0VTX0RJUiA9ICQke1JPT1RfQlVJTERfRElSfS9Tb3VyY2Uv V2ViQ29yZS8kJHtHRU5FUkFURURfU09VUkNFU19ERVNURElSfQogCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCShyZXZpc2lvbiAxMTY2NzIpCisrKyBT b3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTg0LDcgKzg0LDcgQEAKICNpZiBIQVZFKFFUNSkKICNpbmNsdWRlICJRdFgxMUltYWdlQ29u dmVyc2lvbi5oIgogI2luY2x1ZGUgPFFHdWlBcHBsaWNhdGlvbj4KLSNpbmNsdWRlIDxRUGxhdGZv cm1OYXRpdmVJbnRlcmZhY2U+CisjaW5jbHVkZSA8cXBhL3FwbGF0Zm9ybW5hdGl2ZWludGVyZmFj ZS5oPgogI2luY2x1ZGUgPFFXaW5kb3c+CiAjZWxzZQogI2luY2x1ZGUgIlBsdWdpbkNvbnRhaW5l clF0LmgiCg==