86103 2012-05-10 09:18:49 -0700 Some Spelling Mistakes Result in Compile Errors with ENABLE(FILE_SYSTEM) in LocalFileSystem.cpp 2012-05-17 22:43:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 chutten kinuko chutten kinuko kpiascik mlattanzio rwlbuis tabbott oldest_to_newest 620624 0 chutten 2012-05-10 09:18:49 -0700 As per Bug#84135, there are some compilation errors in LocalFileSystem.cpp (FileSystemSynchronousMode doesn't exist, for instance). This bug shall track their resolution. 624054 1 141962 kinuko 2012-05-15 07:20:28 -0700 Created attachment 141962 Patch 624055 2 kinuko 2012-05-15 07:21:19 -0700 I think this should fix build errors with ENABLE(FILE_SYSTEM) on non-chromium ports (though I couldn't test on all platforms). 624064 3 chutten 2012-05-15 07:26:39 -0700 (In reply to comment #2) > I think this should fix build errors with ENABLE(FILE_SYSTEM) on non-chromium ports (though I couldn't test on all platforms). Sorry about that. We're looking to get a BlackBerry buildbot up and running ASAP to make this less painful all around. Patch lgtm, but that's all I can do :S Adding some people from our port. 626552 4 141962 rwlbuis 2012-05-17 07:27:45 -0700 Comment on attachment 141962 Patch Looks good, thanks for the BB fix too! 627350 5 kinuko 2012-05-17 22:43:27 -0700 Committed r117544: <http://trac.webkit.org/changeset/117544> 141962 2012-05-15 07:20:28 -0700 2012-05-17 07:27:45 -0700 Patch bug-86103-20120515232027.patch text/plain 6794 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGE0M2YzMWIwZDI5OWQw ODAyZTM2OGIxYjM3YjdmOTliNjY1MjZhZi4uM2U4ZDhmYmNiMTEzNzRiMjc1ODMwNjA2YmNiOTRj Zjc2Y2E2MGFiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA1LTE1ICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBTb21lIFNwZWxsaW5n IE1pc3Rha2VzIFJlc3VsdCBpbiBDb21waWxlIEVycm9ycyB3aXRoIEVOQUJMRShGSUxFX1NZU1RF TSkgaW4gTG9jYWxGaWxlU3lzdGVtLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODYxMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGRlZCBidWlsZCBmaXhlcyBhbmQgc29tZSAobGltaXRlZCkgY29t bW9uIGltcGxlbWVudGF0aW9uIGZvciBub24tY2hyb21pdW0gcG9ydHMuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzIGFzIHRoaXMgc2hvdWxkIGhhdmUgbm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2VzLgor CisgICAgICAgICogTW9kdWxlcy9maWxlc3lzdGVtL0RPTUZpbGVTeXN0ZW0uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RE9NRmlsZVN5c3RlbUJhc2U6OmlzVmFsaWRUeXBlKTogQWRkZWQgY29tbW9u IGltcGxlbWVudGF0aW9uIGZvciBub24tY2hyb21pdW0gcG9ydHMuCisgICAgICAgIChXZWJDb3Jl OjpET01GaWxlU3lzdGVtQmFzZTo6Y3JhY2tGaWxlU3lzdGVtVVJMKTogRGl0dG8uCisgICAgICAg IChXZWJDb3JlOjpET01GaWxlU3lzdGVtQmFzZTo6c3VwcG9ydHNUb1VSTCk6IERpdHRvLgorICAg ICAgICAoV2ViQ29yZTo6RE9NRmlsZVN5c3RlbUJhc2U6OmNyZWF0ZUZpbGVTeXN0ZW1VUkwpOiBE aXR0by4KKyAgICAgICAgKiBNb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkxvY2FsRmlsZVN5c3RlbTo6cmVhZEZpbGVTeXN0ZW0pOiBGaXhl ZC4KKyAgICAgICAgKFdlYkNvcmU6OkxvY2FsRmlsZVN5c3RlbTo6cmVxdWVzdEZpbGVTeXN0ZW0p OiBGaXhlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ibGFja2JlcnJ5L0FzeW5jRmlsZVN5c3RlbUJs YWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXN5bmNGaWxlU3lzdGVtOjpvcGVuRmls ZVN5c3RlbSk6IEZpeGVkLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Bc3luY0ZpbGVTeXN0ZW1H dGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXN5bmNGaWxlU3lzdGVtOjpvcGVuRmlsZVN5c3Rl bSk6IEZpeGVkLgorCiAyMDEyLTA1LTE0ICBNaWtlIFdlc3QgIDxtaWtlQG1pa2V3ZXN0Lm9yZz4K IAogICAgICAgICBDb250ZW50IFNlY3VyaXR5IFBvbGljeSBjb25zb2xlIGVycm9ycyBpbmNsdWRl IHZpb2xhdGVkIGRpcmVjdGl2ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv ZmlsZXN5c3RlbS9ET01GaWxlU3lzdGVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmls ZXN5c3RlbS9ET01GaWxlU3lzdGVtLmNwcAppbmRleCAwOTBiY2MwNTIwZDA3MjA2MWE3YjE0ZTNi ZDU0N2MwNThiYzBhODcwLi43YzkwOTlhN2EzODY1YjQxMTcyZmJkZTJkOGFhNzIwNDdkNDY5Y2I3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0ZW0vRE9NRmlsZVN5 c3RlbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0RPTUZpbGVT eXN0ZW0uY3BwCkBAIC01Miw2ICs1Miw1MCBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyNp ZiAhUExBVEZPUk0oQ0hST01JVU0pCisvLyBzdGF0aWMKK2Jvb2wgRE9NRmlsZVN5c3RlbUJhc2U6 OmlzVmFsaWRUeXBlKEZpbGVTeXN0ZW1UeXBlIHR5cGUpCit7CisgICAgcmV0dXJuIHR5cGUgPT0g RmlsZVN5c3RlbVR5cGVUZW1wb3JhcnkgfHwgdHlwZSA9PSBGaWxlU3lzdGVtVHlwZVBlcnNpc3Rl bnQ7Cit9CisKKy8vIHN0YXRpYworYm9vbCBET01GaWxlU3lzdGVtQmFzZTo6Y3JhY2tGaWxlU3lz dGVtVVJMKGNvbnN0IEtVUkwmIHVybCwgRmlsZVN5c3RlbVR5cGUmIHR5cGUsIFN0cmluZyYgZmls ZVBhdGgpCit7CisgICAgaWYgKCF1cmwucHJvdG9jb2xJcygiZmlsZXN5c3RlbSIpKQorICAgICAg ICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoIXVybC5pbm5lclVSTCgpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICBTdHJpbmcgdHlwZVN0cmluZyA9IHVybC5pbm5lclVSTCgpLT5wYXRo KCkuc3Vic3RyaW5nKDEpOworICAgIGlmICh0eXBlU3RyaW5nID09IHRlbXBvcmFyeVBhdGhQcmVm aXgpCisgICAgICAgIHR5cGUgPSBGaWxlU3lzdGVtVHlwZVRlbXBvcmFyeTsKKyAgICBlbHNlIGlm ICh0eXBlU3RyaW5nID09IHBlcnNpc3RlbnRQYXRoUHJlZml4KQorICAgICAgICB0eXBlID0gRmls ZVN5c3RlbVR5cGVQZXJzaXN0ZW50OworICAgIGVsc2UKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor CisgICAgZmlsZVBhdGggPSBkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXModXJsLnBhdGgoKSk7Cisg ICAgcmV0dXJuIHRydWU7Cit9CisKK2Jvb2wgRE9NRmlsZVN5c3RlbUJhc2U6OnN1cHBvcnRzVG9V UkwoKSBjb25zdAoreworICAgIEFTU0VSVChpc1ZhbGlkVHlwZShtX3R5cGUpKTsKKyAgICByZXR1 cm4gdHJ1ZTsKK30KKworS1VSTCBET01GaWxlU3lzdGVtQmFzZTo6Y3JlYXRlRmlsZVN5c3RlbVVS TChjb25zdCBTdHJpbmcmIGZ1bGxQYXRoKSBjb25zdAoreworICAgIEFTU0VSVChET01GaWxlUGF0 aDo6aXNBYnNvbHV0ZShmdWxsUGF0aCkpOworICAgIEtVUkwgdXJsID0gbV9maWxlc3lzdGVtUm9v dFVSTDsKKyAgICAvLyBSZW1vdmUgdGhlIGV4dHJhIGxlYWRpbmcgc2xhc2guCisgICAgdXJsLnNl dFBhdGgodXJsLnBhdGgoKSArIGVuY29kZVdpdGhVUkxFc2NhcGVTZXF1ZW5jZXMoZnVsbFBhdGgu c3Vic3RyaW5nKDEpKSk7CisgICAgcmV0dXJuIHVybDsKK30KKyNlbmRpZgorCiAvLyBzdGF0aWMK IFBhc3NSZWZQdHI8RE9NRmlsZVN5c3RlbT4gRE9NRmlsZVN5c3RlbTo6Y3JlYXRlKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IFN0cmluZyYgbmFtZSwgRmlsZVN5c3RlbVR5 cGUgdHlwZSwgY29uc3QgS1VSTCYgcm9vdFVSTCwgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW0+ IGFzeW5jRmlsZVN5c3RlbSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv ZmlsZXN5c3RlbS9Mb2NhbEZpbGVTeXN0ZW0uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9m aWxlc3lzdGVtL0xvY2FsRmlsZVN5c3RlbS5jcHAKaW5kZXggMGVhYWZhZTE5MDc3OGZmNDFmYjQ1 NWEzY2FmMDkxMDI0MmVjYzEwOS4uNjY0MzUyMTg0YzMzODhmOGUwNjZmMWZhMWVhYTFjODk1ZmJm NzA5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0xvY2Fs RmlsZVN5c3RlbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0xv Y2FsRmlsZVN5c3RlbS5jcHAKQEAgLTgyLDEzICs4MiwxMyBAQCBzdGF0aWMgdm9pZCBvcGVuRmls ZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgY29uc3QgU3RyaW5nJiBiYXNlUGF0aCwg Y29ucwogICAgIEFzeW5jRmlsZVN5c3RlbTo6b3BlbkZpbGVTeXN0ZW0oYmFzZVBhdGgsIGlkZW50 aWZpZXIsIGNyZWF0ZSwgY2FsbGJhY2tzKTsKIH0KIAotdm9pZCBMb2NhbEZpbGVTeXN0ZW06OnJl YWRGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIERPTUZpbGVTeXN0 ZW1CYXNlOjpUeXBlLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4gY2FsbGJh Y2tzLCBGaWxlU3lzdGVtU3luY2hyb25vdXNNb2RlKQordm9pZCBMb2NhbEZpbGVTeXN0ZW06OnJl YWRGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEZpbGVTeXN0ZW1U eXBlLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4gY2FsbGJhY2tzLCBGaWxl U3lzdGVtU3luY2hyb25vdXNUeXBlKQogewogICAgIC8vIEFzeW5jRmlsZVN5c3RlbTo6b3BlbkZp bGVTeXN0ZW0gY2FsbHMgY2FsbGJhY2tzIHN5bmNocm9ub3VzbHksIHNvIHRoZSBtZXRob2QgbmVl ZHMgdG8gYmUgY2FsbGVkIGFzeW5jaHJvbm91c2x5LgogICAgIGNvbnRleHQtPnBvc3RUYXNrKGNy ZWF0ZUNhbGxiYWNrVGFzaygmb3BlbkZpbGVTeXN0ZW0sIGZpbGVTeXN0ZW1CYXNlUGF0aCgpLCBj b250ZXh0LT5zZWN1cml0eU9yaWdpbigpLT5kYXRhYmFzZUlkZW50aWZpZXIoKSwgZmFsc2UsIGNh bGxiYWNrcykpOwogfQogCi12b2lkIExvY2FsRmlsZVN5c3RlbTo6cmVxdWVzdEZpbGVTeXN0ZW0o U2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgRE9NRmlsZVN5c3RlbUJhc2U6OlR5cGUs IGxvbmcgbG9uZywgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW1DYWxsYmFja3M+IGNhbGxiYWNr cywgRmlsZVN5c3RlbVN5bmNocm9ub3VzVHlwZSkKK3ZvaWQgTG9jYWxGaWxlU3lzdGVtOjpyZXF1 ZXN0RmlsZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBGaWxlU3lzdGVt VHlwZSwgbG9uZyBsb25nLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4gY2Fs bGJhY2tzLCBGaWxlU3lzdGVtU3luY2hyb25vdXNUeXBlKQogewogICAgIC8vIEFzeW5jRmlsZVN5 c3RlbTo6b3BlbkZpbGVTeXN0ZW0gY2FsbHMgY2FsbGJhY2tzIHN5bmNocm9ub3VzbHksIHNvIHRo ZSBtZXRob2QgbmVlZHMgdG8gYmUgY2FsbGVkIGFzeW5jaHJvbm91c2x5LgogICAgIGNvbnRleHQt PnBvc3RUYXNrKGNyZWF0ZUNhbGxiYWNrVGFzaygmb3BlbkZpbGVTeXN0ZW0sIGZpbGVTeXN0ZW1C YXNlUGF0aCgpLCBjb250ZXh0LT5zZWN1cml0eU9yaWdpbigpLT5kYXRhYmFzZUlkZW50aWZpZXIo KSwgdHJ1ZSwgY2FsbGJhY2tzKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ibGFja2JlcnJ5L0FzeW5jRmlsZVN5c3RlbUJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9Bc3luY0ZpbGVTeXN0ZW1CbGFja0JlcnJ5LmNwcAppbmRl eCA3MTYwMWVjN2E3Njg2YTY3MzRlNzlhNWE1NmU3Zjk0NjExMDMwMjMyLi44NjJjNzgzYjhkNzEy YjJkMGJlYjljMjVhZTMyNTA3YWQwY2IzZTdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ibGFja2JlcnJ5L0FzeW5jRmlsZVN5c3RlbUJsYWNrQmVycnkuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvQXN5bmNGaWxlU3lzdGVtQmxhY2tCZXJy eS5jcHAKQEAgLTQwLDcgKzQwLDcgQEAgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW0+IEFzeW5j RmlsZVN5c3RlbTo6Y3JlYXRlKCkKICAgICByZXR1cm4gYWRvcHRQdHIobmV3IEFzeW5jRmlsZVN5 c3RlbUJsYWNrQmVycnkoKSk7CiB9CiAKLXZvaWQgQXN5bmNGaWxlU3lzdGVtOjpvcGVuRmlsZVN5 c3RlbShjb25zdCBLVVJMJiBiYXNlUGF0aCwgY29uc3QgU3RyaW5nJiBzdG9yYWdlSWRlbnRpZmll ciwgYm9vbCwgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW1DYWxsYmFja3M+IGNhbGxiYWNrcykK K3ZvaWQgQXN5bmNGaWxlU3lzdGVtOjpvcGVuRmlsZVN5c3RlbShjb25zdCBTdHJpbmcmIGJhc2VQ YXRoLCBjb25zdCBTdHJpbmcmIHN0b3JhZ2VJZGVudGlmaWVyLCBib29sLCBQYXNzT3duUHRyPEFz eW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4gY2FsbGJhY2tzKQogewogICAgIFVOVVNFRF9QQVJBTShi YXNlUGF0aCk7CiAgICAgVU5VU0VEX1BBUkFNKHN0b3JhZ2VJZGVudGlmaWVyKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Bc3luY0ZpbGVTeXN0ZW1HdGsuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0FzeW5jRmlsZVN5c3RlbUd0ay5jcHAKaW5kZXgg YWE2MGJhNDU2ODllMjBiNDM5NzJjMTNjYjI2ZTlmZTJhYzM3YTVlZC4uZjJjZmE4NzdmYzlkOGI2 ZjJhNTY3MDk0YjI5Yzk3ZmEyNDJiNWE3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0FzeW5jRmlsZVN5c3RlbUd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0FzeW5jRmlsZVN5c3RlbUd0ay5jcHAKQEAgLTQwLDcgKzQwLDcgQEAgUGFzc093 blB0cjxBc3luY0ZpbGVTeXN0ZW0+IEFzeW5jRmlsZVN5c3RlbTo6Y3JlYXRlKCkKICAgICByZXR1 cm4gYWRvcHRQdHIobmV3IEFzeW5jRmlsZVN5c3RlbUd0aygpKTsKIH0KIAotdm9pZCBBc3luY0Zp bGVTeXN0ZW06Om9wZW5GaWxlU3lzdGVtKGNvbnN0IEtVUkwmIGJhc2VQYXRoLCBjb25zdCBTdHJp bmcmIHN0b3JhZ2VJZGVudGlmaWVyLCBib29sLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbUNh bGxiYWNrcz4gY2FsbGJhY2tzKQordm9pZCBBc3luY0ZpbGVTeXN0ZW06Om9wZW5GaWxlU3lzdGVt KGNvbnN0IFN0cmluZyYgYmFzZVBhdGgsIGNvbnN0IFN0cmluZyYgc3RvcmFnZUlkZW50aWZpZXIs IGJvb2wsIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBjYWxsYmFja3MpCiB7 CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKICAgICBjYWxsYmFja3MtPmRpZEZhaWwoTk9UX1NVUFBP UlRFRF9FUlIpOwo=