86102 2012-05-10 08:29:11 -0700 Web Inspector: heap snapshot comparison view is broken 2012-05-10 13:23:46 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 620601 0 yurys 2012-05-10 08:29:11 -0700 1. Take 1 heap snapshot, wait for the summary view to open. 2. Take another heap snapshot, wait for the summary view to open. 3. Select "Comparison" view. Result: Nothing happens. Note that after frontend reopening if you open the second snapshot and select "Comparison" view the diff will show up. 620611 1 yurys 2012-05-10 08:47:14 -0700 This is a regression after http://trac.webkit.org/changeset/116218 (early return from WebInspector.HeapProfileHeader.prototype.load) 620633 2 141184 yurys 2012-05-10 09:33:01 -0700 Created attachment 141184 Patch 620898 3 141184 webkit.review.bot 2012-05-10 13:23:41 -0700 Comment on attachment 141184 Patch Clearing flags on attachment: 141184 Committed r116681: <http://trac.webkit.org/changeset/116681> 620899 4 webkit.review.bot 2012-05-10 13:23:46 -0700 All reviewed patches have been landed. Closing bug. 141184 2012-05-10 09:33:01 -0700 2012-05-10 13:23:41 -0700 Patch bug-86102-20120510203259.patch text/plain 1638 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFiM2JkMjA1MzBiYjE2 ZGFhNGU1NjcxN2M4ZGM4ZTQ3MmJiNzY4ZS4uMjgzMjJlMDM4ZjUwNTMzMGU4NmVkYzgxMzg5Mjk0 NjhkOTI2MzQ4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTEwICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGhlYXAgc25hcHNob3QgY29tcGFyaXNvbiB2aWV3IGlzIGJyb2tlbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYxMDIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXNzIEhlYXBTbmFwc2hvdFByb3h5 IGluc3RlYWQgb2YgdW5kZWZpbmVkIHRvIHRoZSBwcm9maWxlIGxvYWQgY2FsbGJhY2suIEFkZGVk CisgICAgICAgIGNvbXBpbGVyIGFubm90YXRpb25zIHRvIGF2b2lkIHN1Y2ggZXJyb3JzIGluIHRo ZSBmdXR1cmUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZp ZXcuanM6CisKIDIwMTItMDUtMTAgIEpvZSBUaG9tYXMgIDxqb2V0aG9tYXNAbW90b3JvbGEuY29t PgogCiAgICAgICAgIFtDU1MzIEJhY2tncm91bmRzIGFuZCBCb3JkZXJzXSBBZGQgYmFja2dyb3Vu ZC1zaXplIHRvIHRoZSBiYWNrZ3JvdW5kIHNob3J0aGFuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3LmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3LmpzCmluZGV4IDZjNTE0 ODBmYzFhY2RjYzBmYTkxNTJjMGQ4NGIxMGZjOTQyNjJhMWMuLjliZWNhYjNhZTRiYTM4N2I0YWE4 MGQ5ZmNkZGJjMTI4MTlkOTVlNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcuanMKQEAgLTc5MCwxMiArNzkwLDEyIEBA IFdlYkluc3BlY3Rvci5IZWFwUHJvZmlsZUhlYWRlciA9IGZ1bmN0aW9uKHByb2ZpbGVUeXBlLCB0 aXRsZSwgdWlkLCBtYXhKU09iamVjdElkCiBXZWJJbnNwZWN0b3IuSGVhcFByb2ZpbGVIZWFkZXIu cHJvdG90eXBlID0gewogICAgIC8qKgogICAgICAqIEBvdmVycmlkZQotICAgICAqIEBwYXJhbSB7 RnVuY3Rpb259IGNhbGxiYWNrCisgICAgICogQHBhcmFtIHtmdW5jdGlvbihXZWJJbnNwZWN0b3Iu SGVhcFNuYXBzaG90UHJveHkpOnZvaWR9IGNhbGxiYWNrCiAgICAgICovCiAgICAgbG9hZDogZnVu Y3Rpb24oY2FsbGJhY2spCiAgICAgewogICAgICAgICBpZiAodGhpcy5fbG9hZGVkKSB7Ci0gICAg ICAgICAgICBjYWxsYmFjay5jYWxsKG51bGwpOworICAgICAgICAgICAgY2FsbGJhY2sodGhpcy5f cHJveHkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAK