86096 2012-05-10 06:55:00 -0700 [BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame->view() are invalid 2012-05-10 10:15:46 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonikitoo tonikitoo tonikitoo oldest_to_newest 620550 0 tonikitoo 2012-05-10 06:55:00 -0700 George Staikos 2012-05-06 23:04:05 EDT This is an interesting bug. IntPoint BackingStoreClient::scrollPosition() const { ASSERT(m_frame); return m_frame->view()->scrollPosition() - pointToSize(m_frame->view()->mini mumScrollPosition()); } m_frame->view() is null. m_frame is in the middle of construction and is trying to create its view but malloc is blocked on a mutex. Meanwhile the test driver, which runs in the Plaid Zone in terms of speed, is already pinch zooming the page. Realistically no user can ever hit this. In actuality, the assertions in backingstoreclient are wrong and need to be fixed. at a minimum, m_frame->view() can be null or invalid, and perhaps m_frame can be too. Adam / Antonio please fix in all branches. 620558 1 141163 tonikitoo 2012-05-10 07:09:20 -0700 Created attachment 141163 (committed r116657, r=rbuis) Patch 620564 2 141163 rwlbuis 2012-05-10 07:15:58 -0700 Comment on attachment 141163 (committed r116657, r=rbuis) Patch LGTM. 620678 3 141163 tonikitoo 2012-05-10 10:15:38 -0700 Comment on attachment 141163 (committed r116657, r=rbuis) Patch Committed r116657. 141163 2012-05-10 07:09:20 -0700 2012-05-10 10:15:38 -0700 (committed r116657, r=rbuis) Patch 0001-BlackBerry-Assertions-and-assumptions-in-BackingStor.patch text/plain 6123 tonikitoo RnJvbSBjMzVkY2FiMGM2NjAyNzc0NTVhZDQ1ZjY2OTM5YzE3MmZmZTJiODNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog VGh1LCAxMCBNYXkgMjAxMiAxMDowNzozNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFja0Jl cnJ5XSBBc3NlcnRpb25zIGFuZCBhc3N1bXB0aW9ucyBpbgogQmFja2luZ1N0b3JlQ2xpZW50IGFy b3VuZCBtX2ZyYW1lIGFuZCBtX2ZyYW1lLT52aWV3KCkgYXJlCiBpbnZhbGlkIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjA5NgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuClBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPGFnb21lc0ByaW0uY29tPgoKQSBGcmFtZSdz IEZyYW1lVmlldyBoYXMgYWx3YXlzIHRvIGJlIGNoZWNrZWQgc2luY2UgaXQgaXMKYSB2b2xhdGls ZSBvYmplY3QsIGFuZCBnZXRzIGNyZWF0ZWQgYW5kIGRlc3Ryb3llZCBhbGwgdGhlIHRpbWUuCgpX ZSBoYXZlIGJlZW4gZmFjaW5nIGEgcGFydGljdWxhciBpc3N1ZSwgd2hlcmUgZHVyaW5nIG91ciBh dXRvbWF0ZWQKaW50ZXJhY3Rpb24gdGVzdHMsIHRoZSBtYWluIGZyYW1lIG9iamVjdCB3YXMgYmVp bmcgcGluY2ggem9vbWVkIGluCnRoZSBtaWRkbGUgb2YgaXQgY3JlYXRpb24sIGFuZCBXZWJLaXQg dGhyZWFkIHdhcyBibG9ja2VkIGJ5IGEgbXV0ZXguCkluIHByYWN0aWNlLCBpdCBpcyBhIGNhc2Ug dGhhdCB3b3VsZCBub3QgYmUgcG9zc2libGUgaW4gYSByZWFsCndvcmxkIHNjZW5hcmlvLCBidXQg c2hvd3MgdGhhdCB0aGUgQVNTRVJUcyBhcmUgYm9ndXMgcmVnYXJkbGVzcy4KCiogV2ViS2l0U3Vw cG9ydC9CYWNraW5nU3RvcmVDbGllbnQuY3BwOgooQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5n U3RvcmVDbGllbnQ6OnNjcm9sbFBvc2l0aW9uKToKKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2lu Z1N0b3JlQ2xpZW50OjpzZXRTY3JvbGxQb3NpdGlvbik6CihCbGFja0JlcnJ5OjpXZWJLaXQ6OkJh Y2tpbmdTdG9yZUNsaWVudDo6bWF4aW11bVNjcm9sbFBvc2l0aW9uKToKKEJsYWNrQmVycnk6Oldl YktpdDo6QmFja2luZ1N0b3JlQ2xpZW50Ojp2aWV3cG9ydFNpemUpOgooQmxhY2tCZXJyeTo6V2Vi S2l0OjpCYWNraW5nU3RvcmVDbGllbnQ6OnRyYW5zZm9ybWVkVmlld3BvcnRTaXplKToKKEJsYWNr QmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlQ2xpZW50Ojp2aXNpYmxlQ29udGVudHNSZWN0KToK KEJsYWNrQmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlQ2xpZW50Ojpjb250ZW50c1NpemUpOgot LS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwg ICAyNSArKysrKysrKysrKysrKysKIC4uLi9XZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVu dC5jcHAgICAgICAgICAgIHwgICAzMyArKysrKysrKysrKysrKysrLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDUyIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cKaW5kZXggNGE2MDliYS4uZDc4NTg1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTItMDUtMTAgIEFudG9uaW8gR29tZXMgIDxhZ29t ZXNAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQXNzZXJ0aW9ucyBhbmQgYXNzdW1w dGlvbnMgaW4gQmFja2luZ1N0b3JlQ2xpZW50IGFyb3VuZCBtX2ZyYW1lIGFuZCBtX2ZyYW1lLT52 aWV3KCkgYXJlIGludmFsaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg2MDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQSBGcmFtZSdzIEZyYW1lVmlldyBoYXMgYWx3YXlzIHRvIGJlIGNoZWNrZWQgc2lu Y2UgaXQgaXMKKyAgICAgICAgYSB2b2xhdGlsZSBvYmplY3QsIGFuZCBnZXRzIGNyZWF0ZWQgYW5k IGRlc3Ryb3llZCBhbGwgdGhlIHRpbWUuCisKKyAgICAgICAgV2UgaGF2ZSBiZWVuIGZhY2luZyBh IHBhcnRpY3VsYXIgaXNzdWUsIHdoZXJlIGR1cmluZyBvdXIgYXV0b21hdGVkCisgICAgICAgIGlu dGVyYWN0aW9uIHRlc3RzLCB0aGUgbWFpbiBmcmFtZSBvYmplY3Qgd2FzIGJlaW5nIHBpbmNoIHpv b21lZCBpbgorICAgICAgICB0aGUgbWlkZGxlIG9mIGl0IGNyZWF0aW9uLCBhbmQgV2ViS2l0IHRo cmVhZCB3YXMgYmxvY2tlZCBieSBhIG11dGV4LgorICAgICAgICBJbiBwcmFjdGljZSwgaXQgaXMg YSBjYXNlIHRoYXQgd291bGQgbm90IGJlIHBvc3NpYmxlIGluIGEgcmVhbAorICAgICAgICB3b3Js ZCBzY2VuYXJpbywgYnV0IHNob3dzIHRoYXQgdGhlIEFTU0VSVHMgYXJlIGJvZ3VzIHJlZ2FyZGxl c3MuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5jcHA6Cisg ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZUNsaWVudDo6c2Nyb2xsUG9z aXRpb24pOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVDbGllbnQ6 OnNldFNjcm9sbFBvc2l0aW9uKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2lu Z1N0b3JlQ2xpZW50OjptYXhpbXVtU2Nyb2xsUG9zaXRpb24pOgorICAgICAgICAoQmxhY2tCZXJy eTo6V2ViS2l0OjpCYWNraW5nU3RvcmVDbGllbnQ6OnZpZXdwb3J0U2l6ZSk6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZUNsaWVudDo6dHJhbnNmb3JtZWRWaWV3cG9y dFNpemUpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVDbGllbnQ6 OnZpc2libGVDb250ZW50c1JlY3QpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNr aW5nU3RvcmVDbGllbnQ6OmNvbnRlbnRzU2l6ZSk6CisKIDIwMTItMDUtMDggIENocmlzIEd1YW4g IDxjaHJpcy5ndWFuQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tiZXJyeV0g cmVtb3ZlIG1faXNSZXF1ZXN0ZWRCeVBsdWdpbiBpbiBSZXNvdXJjZVJlcXVlc3QKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNs aWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9CYWNraW5n U3RvcmVDbGllbnQuY3BwCmluZGV4IGM3ZGU3NzEuLmU3ZTRkNjUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQmFja2luZ1N0b3Jl Q2xpZW50LmNwcApAQCAtMTY4LDYgKzE2OCw5IEBAIEludFBvaW50IEJhY2tpbmdTdG9yZUNsaWVu dDo6dHJhbnNmb3JtZWRBYnNvbHV0ZUxvY2F0aW9uKCkgY29uc3QKIEludFBvaW50IEJhY2tpbmdT dG9yZUNsaWVudDo6c2Nyb2xsUG9zaXRpb24oKSBjb25zdAogewogICAgIEFTU0VSVChtX2ZyYW1l KTsKKyAgICBpZiAoIW1fZnJhbWUtPnZpZXcoKSkKKyAgICAgICAgcmV0dXJuIEludFBvaW50KCk7 CisKICAgICByZXR1cm4gbV9mcmFtZS0+dmlldygpLT5zY3JvbGxQb3NpdGlvbigpIC0gcG9pbnRU b1NpemUobV9mcmFtZS0+dmlldygpLT5taW5pbXVtU2Nyb2xsUG9zaXRpb24oKSk7CiB9CiAKQEAg LTE3OCw3ICsxODEsMTAgQEAgSW50UG9pbnQgQmFja2luZ1N0b3JlQ2xpZW50Ojp0cmFuc2Zvcm1l ZFNjcm9sbFBvc2l0aW9uKCkgY29uc3QKIAogdm9pZCBCYWNraW5nU3RvcmVDbGllbnQ6OnNldFNj cm9sbFBvc2l0aW9uKGNvbnN0IEludFBvaW50JiBwb3MpCiB7Ci0gICAgQVNTRVJUKG1fZnJhbWUt PnZpZXcoKSk7CisgICAgQVNTRVJUKG1fZnJhbWUpOworICAgIGlmICghbV9mcmFtZS0+dmlldygp KQorICAgICAgICByZXR1cm47CisKICAgICBpZiAocG9zID09IHNjcm9sbFBvc2l0aW9uKCkpCiAg ICAgICAgIHJldHVybjsKIApAQCAtMTk2LDcgKzIwMiwxMCBAQCB2b2lkIEJhY2tpbmdTdG9yZUNs aWVudDo6c2V0U2Nyb2xsUG9zaXRpb24oY29uc3QgSW50UG9pbnQmIHBvcykKIAogSW50UG9pbnQg QmFja2luZ1N0b3JlQ2xpZW50OjptYXhpbXVtU2Nyb2xsUG9zaXRpb24oKSBjb25zdAogewotICAg IEFTU0VSVChtX2ZyYW1lLT52aWV3KCkpOworICAgIEFTU0VSVChtX2ZyYW1lKTsKKyAgICBpZiAo IW1fZnJhbWUtPnZpZXcoKSkKKyAgICAgICAgcmV0dXJuIEludFBvaW50KCk7CisKICAgICByZXR1 cm4gbV9mcmFtZS0+dmlldygpLT5tYXhpbXVtU2Nyb2xsUG9zaXRpb24oKSAtIHBvaW50VG9TaXpl KG1fZnJhbWUtPnZpZXcoKS0+bWluaW11bVNjcm9sbFBvc2l0aW9uKCkpOwogfQogCkBAIC0yMjAs NyArMjI5LDEwIEBAIEludFNpemUgQmFja2luZ1N0b3JlQ2xpZW50Ojp0cmFuc2Zvcm1lZEFjdHVh bFZpc2libGVTaXplKCkgY29uc3QKIAogSW50U2l6ZSBCYWNraW5nU3RvcmVDbGllbnQ6OnZpZXdw b3J0U2l6ZSgpIGNvbnN0CiB7Ci0gICAgQVNTRVJUKG1fZnJhbWUtPnZpZXcoKSk7CisgICAgQVNT RVJUKG1fZnJhbWUpOworICAgIGlmICghbV9mcmFtZS0+dmlldygpKQorICAgICAgICByZXR1cm4g SW50U2l6ZSgpOworCiAgICAgaWYgKGlzTWFpbkZyYW1lKCkpCiAgICAgICAgIHJldHVybiBtX3dl YlBhZ2UtPmQtPnZpZXdwb3J0U2l6ZSgpOwogCkBAIC0yMjksMTAgKzI0MSwxMyBAQCBJbnRTaXpl IEJhY2tpbmdTdG9yZUNsaWVudDo6dmlld3BvcnRTaXplKCkgY29uc3QKIAogSW50U2l6ZSBCYWNr aW5nU3RvcmVDbGllbnQ6OnRyYW5zZm9ybWVkVmlld3BvcnRTaXplKCkgY29uc3QKIHsKKyAgICBB U1NFUlQobV9mcmFtZSk7CisgICAgaWYgKCFtX2ZyYW1lLT52aWV3KCkpCisgICAgICAgIHJldHVy biBJbnRTaXplKCk7CisKICAgICBpZiAoaXNNYWluRnJhbWUoKSkKICAgICAgICAgcmV0dXJuIG1f d2ViUGFnZS0+ZC0+dHJhbnNmb3JtZWRWaWV3cG9ydFNpemUoKTsKIAotICAgIEFTU0VSVChtX2Zy YW1lLT52aWV3KCkpOwogICAgIGNvbnN0IEludFNpemUgdW50cmFuc2Zvcm1lZFZpZXdwb3J0U2l6 ZSA9IG1fZnJhbWUtPnZpZXcoKS0+dmlzaWJsZUNvbnRlbnRSZWN0KCkuc2l6ZSgpOwogICAgIGNv bnN0IEZsb2F0UG9pbnQgdHJhbnNmb3JtZWRCb3R0b21SaWdodCA9IG1fd2ViUGFnZS0+ZC0+bV90 cmFuc2Zvcm1hdGlvbk1hdHJpeC0+bWFwUG9pbnQoCiAgICAgICAgIEZsb2F0UG9pbnQodW50cmFu c2Zvcm1lZFZpZXdwb3J0U2l6ZS53aWR0aCgpLCB1bnRyYW5zZm9ybWVkVmlld3BvcnRTaXplLmhl aWdodCgpKSk7CkBAIC0yNDEsNyArMjU2LDEwIEBAIEludFNpemUgQmFja2luZ1N0b3JlQ2xpZW50 Ojp0cmFuc2Zvcm1lZFZpZXdwb3J0U2l6ZSgpIGNvbnN0CiAKIEludFJlY3QgQmFja2luZ1N0b3Jl Q2xpZW50Ojp2aXNpYmxlQ29udGVudHNSZWN0KCkgY29uc3QKIHsKLSAgICBBU1NFUlQobV9mcmFt ZS0+dmlldygpKTsKKyAgICBBU1NFUlQobV9mcmFtZSk7CisgICAgaWYgKCFtX2ZyYW1lLT52aWV3 KCkpCisgICAgICAgIHJldHVybiBJbnRSZWN0KCk7CisKICAgICBJbnRSZWN0IHZpc2libGVDb250 ZW50UmVjdCA9IG1fZnJhbWUtPnZpZXcoKS0+dmlzaWJsZUNvbnRlbnRSZWN0KCk7CiAgICAgaWYg KGlzTWFpbkZyYW1lKCkpCiAgICAgICAgIHJldHVybiB2aXNpYmxlQ29udGVudFJlY3Q7CkBAIC0y NzMsNyArMjkxLDEwIEBAIEludFJlY3QgQmFja2luZ1N0b3JlQ2xpZW50Ojp0cmFuc2Zvcm1lZFZp c2libGVDb250ZW50c1JlY3QoKSBjb25zdAogCiBJbnRTaXplIEJhY2tpbmdTdG9yZUNsaWVudDo6 Y29udGVudHNTaXplKCkgY29uc3QKIHsKLSAgICBBU1NFUlQobV9mcmFtZS0+dmlldygpKTsKKyAg ICBBU1NFUlQobV9mcmFtZSk7CisgICAgaWYgKCFtX2ZyYW1lLT52aWV3KCkpCisgICAgICAgIHJl dHVybiBJbnRTaXplKCk7CisKICAgICByZXR1cm4gbV9mcmFtZS0+dmlldygpLT5jb250ZW50c1Np emUoKTsKIH0KIAotLSAKMS43LjUuNAoK