86087 2012-05-10 05:12:32 -0700 [chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor 2012-05-10 12:10:38 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw eric.carlson feature-media-reviews tkent webkit.review.bot oldest_to_newest 620483 0 tommyw 2012-05-10 05:12:32 -0700 Adding a missing adoptRef call. Adding code that exercises this to WebUserMediaClientMock. 620485 1 141149 tommyw 2012-05-10 05:18:18 -0700 Created attachment 141149 Patch 620792 2 141149 abarth 2012-05-10 11:40:08 -0700 Comment on attachment 141149 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141149&action=review > Source/WebCore/ChangeLog:8 > + Not easy to test but I have added code that excercises this to WebUserMediaClientMock (in DumpRenderTree). You should be able to test it with a unit test. http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/tests 620832 3 141149 webkit.review.bot 2012-05-10 12:10:33 -0700 Comment on attachment 141149 Patch Clearing flags on attachment: 141149 Committed r116674: <http://trac.webkit.org/changeset/116674> 620833 4 webkit.review.bot 2012-05-10 12:10:38 -0700 All reviewed patches have been landed. Closing bug. 141149 2012-05-10 05:18:18 -0700 2012-05-10 12:10:33 -0700 Patch bug-86087-20120510141817.patch text/plain 3667 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODcyMmYwMzY1NDhiNGRh ODhiY2EyOTUxYzg1OGE1Y2VkMjFmYzk2OC4uNmMwMzFmMTdjNzllMGU4YjBlNGUxNmQxNzU3MmE4 MzQwZDU5MThlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTEwICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0g TWVkaWFTdHJlYW0gQVBJOiBGaXggdGhlIEV4dHJhRGF0YSBmdW5jdGlvbmFsaXR5IGluIFdlYk1l ZGlhU3RyZWFtRGVzY3JpcHRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODYwODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBOb3QgZWFzeSB0byB0ZXN0IGJ1dCBJIGhhdmUgYWRkZWQgY29kZSB0aGF0IGV4 Y2VyY2lzZXMgdGhpcyB0byBXZWJVc2VyTWVkaWFDbGllbnRNb2NrIChpbiBEdW1wUmVuZGVyVHJl ZSkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYk1lZGlhU3RyZWFt RGVzY3JpcHRvci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYk1lZGlhU3RyZWFtRGVzY3JpcHRv cjo6c2V0RXh0cmFEYXRhKToKKwogMjAxMi0wNS0xMCAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtGb3Jtc10gTW92ZSBzdGVwIHJlbGF0ZWQgbWV0aG9k cyB0byBJbnB1dFR5cGUgY2xhc3MgZnJvbSBIVE1MSW5wdXRFbGVtZW50IGNsYXNzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYk1lZGlhU3Ry ZWFtRGVzY3JpcHRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBw b3J0L1dlYk1lZGlhU3RyZWFtRGVzY3JpcHRvci5jcHAKaW5kZXggYzdlOWZkYTE5NzI0MWIyODEw OTQ1MmY0OGRkMjhkMGRhYzgyY2M5Ni4uOGU3YTNhN2UyMjU3YjYxNmI0M2MyNDQxYmU4YjFmMGQx ODdlY2QxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3Vw cG9ydC9XZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmNwcApAQCAt ODgsNyArODgsNyBAQCBXZWJNZWRpYVN0cmVhbURlc2NyaXB0b3I6OkV4dHJhRGF0YSogV2ViTWVk aWFTdHJlYW1EZXNjcmlwdG9yOjpleHRyYURhdGEoKSBjb25zdAogCiB2b2lkIFdlYk1lZGlhU3Ry ZWFtRGVzY3JpcHRvcjo6c2V0RXh0cmFEYXRhKEV4dHJhRGF0YSogZXh0cmFEYXRhKQogewotICAg IG1fcHJpdmF0ZS0+c2V0RXh0cmFEYXRhKG5ldyBFeHRyYURhdGFDb250YWluZXIoZXh0cmFEYXRh KSk7CisgICAgbV9wcml2YXRlLT5zZXRFeHRyYURhdGEoYWRvcHRSZWYobmV3IEV4dHJhRGF0YUNv bnRhaW5lcihleHRyYURhdGEpKSk7CiB9CiAKIC8vIEZJWE1FOiBDbGVhbnVwIHdoZW4gdGhlIGNo cm9taXVtIGNvZGUgaGFzIHN3aXRjaGVkIHRvIHRoZSBzcGxpdCBzb3VyY2VzIGltcGxlbWVudGF0 aW9uLgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4 IDliMzk4MGQ3NmI3YTQ0YjBjZjgxMTA0NDdhNjc2NTBhOWM2NTZlMWYuLjBkOWQxYmFhMTI4YmEy NWJiOTRhZGNlZWIwNGYxNGFjOWFiMDM3OWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNS0xMCAgVG9tbXkg V2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIE1l ZGlhU3RyZWFtIEFQSTogRml4IHRoZSBFeHRyYURhdGEgZnVuY3Rpb25hbGl0eSBpbiBXZWJNZWRp YVN0cmVhbURlc2NyaXB0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg2MDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJVc2VyTWVkaWFDbGllbnRNb2Nr LmNwcDoKKyAgICAgICAgKE1vY2tFeHRyYURhdGEpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAg ICAgKFdlYktpdDo6V2ViVXNlck1lZGlhQ2xpZW50TW9jazo6cmVxdWVzdFVzZXJNZWRpYSk6CisK IDIwMTItMDUtMDkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAog ICAgICAgICBNb3ZlIHN1c3BlbmRBbmltYXRpb25zIHRvIHVzZSBJbnRlcm5hbHMgaW50ZXJmYWNl LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVXNlck1lZGlh Q2xpZW50TW9jay5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJVc2VyTWVk aWFDbGllbnRNb2NrLmNwcAppbmRleCBkYmUzMzlhOGYxMzJhZGM1MTEzODQ2N2M0OTdkY2RjMWUz YzRmMGQwLi40ZWZlYjgyZDNiYzU4OWVjNDkyNzA0Mzk5MDgwZTg0ZDc2NTk2ODA3IDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJVc2VyTWVkaWFDbGllbnRNb2Nr LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJVc2VyTWVkaWFDbGll bnRNb2NrLmNwcApAQCAtNDIsNiArNDIsMTEgQEAKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2Ns YXNzIE1vY2tFeHRyYURhdGEgOiBwdWJsaWMgV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjpFeHRy YURhdGEgeworcHVibGljOgorICAgIGludCBmb287Cit9OworCiBQYXNzT3duUHRyPFdlYlVzZXJN ZWRpYUNsaWVudE1vY2s+IFdlYlVzZXJNZWRpYUNsaWVudE1vY2s6OmNyZWF0ZSgpCiB7CiAgICAg cmV0dXJuIGFkb3B0UHRyKG5ldyBXZWJVc2VyTWVkaWFDbGllbnRNb2NrKCkpOwpAQCAtNjMsNyAr NjgsMTIgQEAgdm9pZCBXZWJVc2VyTWVkaWFDbGllbnRNb2NrOjpyZXF1ZXN0VXNlck1lZGlhKGNv bnN0IFdlYlVzZXJNZWRpYVJlcXVlc3QmIHN0cmVhbVIKICAgICBpZiAocmVxdWVzdC52aWRlbygp KQogICAgICAgICB2aWRlb1NvdXJjZXNbMF0uaW5pdGlhbGl6ZSgiTW9ja1ZpZGVvRGV2aWNlIzEi LCBXZWJNZWRpYVN0cmVhbVNvdXJjZTo6VHlwZVZpZGVvLCAiTW9jayB2aWRlbyBkZXZpY2UiKTsK IAotICAgIHJlcXVlc3QucmVxdWVzdFN1Y2NlZWRlZChhdWRpb1NvdXJjZXMsIHZpZGVvU291cmNl cyk7CisgICAgV2ViS2l0OjpXZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IgZGVzY3JpcHRvcjsKKyAg ICBkZXNjcmlwdG9yLmluaXRpYWxpemUoImZvb2JhciIsIGF1ZGlvU291cmNlcywgdmlkZW9Tb3Vy Y2VzKTsKKworICAgIGRlc2NyaXB0b3Iuc2V0RXh0cmFEYXRhKG5ldyBNb2NrRXh0cmFEYXRhKCkp OworCisgICAgcmVxdWVzdC5yZXF1ZXN0U3VjY2VlZGVkKGRlc2NyaXB0b3IpOwogfQogCiB2b2lk IFdlYlVzZXJNZWRpYUNsaWVudE1vY2s6OmNhbmNlbFVzZXJNZWRpYVJlcXVlc3QoY29uc3QgV2Vi VXNlck1lZGlhUmVxdWVzdCYpCg==