86066 2012-05-10 01:19:46 -0700 [Qt] new test http/tests/cookies/single-quoted-value.html is failing 2012-10-22 05:28:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85775 87008 1 kkristof webkit-unassigned allan.jensen ap cmarcelo ossy tullio.lucena webkit.review.bot oldest_to_newest 620366 0 kkristof 2012-05-10 01:19:46 -0700 The test has been introduced in r116601. And it is failing on Qt. --- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/cookies/single-quoted-value-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/cookies/single-quoted-value-actual.txt @@ -4,7 +4,7 @@ Check that setting a cookie with a single-quoted value works. -PASS cookie is 'singleQuoted="value'. +FAIL cookie was 'singleQuoted="value;Version=1;Path=/'. Expected 'singleQuoted="value'. PASS successfullyParsed is true TEST COMPLETE 620369 1 kkristof 2012-05-10 01:26:02 -0700 Committed r116621: <http://trac.webkit.org/changeset/116621> 735002 2 167171 tullio.lucena 2012-10-04 14:09:02 -0700 Created attachment 167171 Patch Unskipping test. 738039 3 cmarcelo 2012-10-09 12:08:55 -0700 It seems to me this was failing on the bot environment. Did something change to expect it's now passing? Maybe we should do a trial run on this test in the bot to see if still fails there. 738050 4 167171 ossy 2012-10-09 12:18:08 -0700 Comment on attachment 167171 Patch I don't know what was the problem a half year before, but now it passes. 738059 5 167171 webkit.review.bot 2012-10-09 12:23:50 -0700 Comment on attachment 167171 Patch Rejecting attachment 167171 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: zt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/qt/TestExpectations Hunk #1 FAILED at 2545. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14229679 738099 6 167827 tullio.lucena 2012-10-09 12:55:55 -0700 Created attachment 167827 Patch Updating last patch. 738521 7 167827 webkit.review.bot 2012-10-09 21:48:12 -0700 Comment on attachment 167827 Patch Clearing flags on attachment: 167827 Committed r130842: <http://trac.webkit.org/changeset/130842> 738522 8 webkit.review.bot 2012-10-09 21:48:16 -0700 All reviewed patches have been landed. Closing bug. 747453 9 allan.jensen 2012-10-22 05:28:14 -0700 It still fails on QtWebKit2.3 167171 2012-10-04 14:09:02 -0700 2012-10-09 12:55:55 -0700 Patch patch.diff text/plain 1270 tullio.lucena ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0N2U1MmVkLi41MGY3NjkxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTAt MDQgIFR1bGxpbyBMdWNlbmEgIDx0dWxsaW8ubHVjZW5hQG9wZW5ib3NzYS5vcmc+CisKKyAgICAg ICAgW1F0XSBuZXcgdGVzdCBodHRwL3Rlc3RzL2Nvb2tpZXMvc2luZ2xlLXF1b3RlZC12YWx1ZS5o dG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg2MDY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVW5za2lwcGluZyB0ZXN0LgorCisgICAgICAgICogcGxhdGZvcm0vcXQvVGVzdEV4cGVj dGF0aW9uczoKKwogMjAxMi0xMC0wNCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeGluZyBleHBlY3RlZCByZXN1bHRzIGZvciBhIHRlc3Qg dGhhdCBuZWVkcyBhIG5ldyBiYXNlbGluZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IGExOWY0OTkuLjIwZWI3NjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjU0NSwxMCArMjU0NSw2IEBAIGZhc3QvZm9ybXMvZmls ZS9maWxlLWlucHV0LWNhcHR1cmUuaHRtbAogaW5zcGVjdG9yL2RlYnVnZ2VyL3NjcmlwdHMtcGFu ZWwuaHRtbAogaW5zcGVjdG9yL2RlYnVnZ2VyL3NvdXJjZS1mcmFtZS5odG1sCiAKLSMgW1F0XSBu ZXcgdGVzdCBodHRwL3Rlc3RzL2Nvb2tpZXMvc2luZ2xlLXF1b3RlZC12YWx1ZS5odG1sIGlzIGZh aWxpbmcKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MDY2Ci1o dHRwL3Rlc3RzL2Nvb2tpZXMvc2luZ2xlLXF1b3RlZC12YWx1ZS5odG1sCi0KICMgVmlld3BvcnQg YXR0cmlidXRlIHZhbHVlcyBhcmUgbGVha2VkIHdoZW4gZG9jdW1lbnQud3JpdGUoKSBpcyB1c2Vk LgogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYwNzcKIGh0bWw1 bGliL3J1bm5lci5odG1sCg== 167827 2012-10-09 12:55:55 -0700 2012-10-09 21:48:12 -0700 Patch patch.diff text/plain 1320 tullio.lucena ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjNGY0MGIwLi45NDdkNjljIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTAt MDkgIFR1bGxpbyBMdWNlbmEgIDx0dWxsaW8ubHVjZW5hQG9wZW5ib3NzYS5vcmc+CisKKyAgICAg ICAgW1F0XSBuZXcgdGVzdCBodHRwL3Rlc3RzL2Nvb2tpZXMvc2luZ2xlLXF1b3RlZC12YWx1ZS5o dG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg2MDY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgor CisgICAgICAgIFVuc2tpcHBpbmcgdGVzdC4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1Rlc3RF eHBlY3RhdGlvbnM6CisKIDIwMTItMTAtMDkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KIAogICAgICAgICBkZmctY3Jvc3MtZ2xvYmFsIHRlc3RzIGFyZSBmbGFreSBiZWNhdXNlIHRo ZXkgbWlzdXNlIGpzLXRlc3QtcHJlLmpzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVj dGF0aW9ucwppbmRleCA1ODhlOGJkLi40OTg3ZDhmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI0OTcsMTAgKzI0OTcsNiBAQCBodHRwL3Rlc3RzL2luc3Bl Y3Rvci9uZXR3b3JrL25ldHdvcmstaW5pdGlhdG9yLmh0bWwKICMgUmVxdWlyZXMgRU5BQkxFKE1F RElBX0NBUFRVUkUpCiBmYXN0L2Zvcm1zL2ZpbGUvZmlsZS1pbnB1dC1jYXB0dXJlLmh0bWwKIAot IyBbUXRdIG5ldyB0ZXN0IGh0dHAvdGVzdHMvY29va2llcy9zaW5nbGUtcXVvdGVkLXZhbHVlLmh0 bWwgaXMgZmFpbGluZwotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODYwNjYKLWh0dHAvdGVzdHMvY29va2llcy9zaW5nbGUtcXVvdGVkLXZhbHVlLmh0bWwKLQogIyBb UXRdIGZhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWluaGVyaXRlZC1kb2N1bWVudC1zdHls ZS5odG1sIGZhaWxzCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NjE4MgogZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtaW5oZXJpdGVkLWRvY3VtZW50LXN0 eWxlLmh0bWwK