86056 2012-05-09 20:50:16 -0700 Don't show partytime if there are non-layout test failures. 2012-05-09 21:33:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth dglazkov webkit.review.bot oldest_to_newest 620205 0 ojan 2012-05-09 20:50:16 -0700 Don't show partytime if there are non-layout test failures. 620206 1 141076 ojan 2012-05-09 20:50:37 -0700 Created attachment 141076 Patch 620215 2 141076 dglazkov 2012-05-09 20:59:19 -0700 Comment on attachment 141076 Patch Can we show at least a small party time? 620219 3 ojan 2012-05-09 21:06:00 -0700 (In reply to comment #2) > (From update of attachment 141076 [details]) > Can we show at least a small party time? No. No partytime 4 u! 620221 4 dglazkov 2012-05-09 21:07:26 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 141076 [details] [details]) > > Can we show at least a small party time? > > No. No partytime 4 u! *sadface*. ok. 620232 5 141076 webkit.review.bot 2012-05-09 21:33:24 -0700 Comment on attachment 141076 Patch Clearing flags on attachment: 141076 Committed r116606: <http://trac.webkit.org/changeset/116606> 620233 6 webkit.review.bot 2012-05-09 21:33:29 -0700 All reviewed patches have been landed. Closing bug. 141076 2012-05-09 20:50:37 -0700 2012-05-09 21:33:24 -0700 Patch bug-86056-20120509205036.patch text/plain 5611 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NTk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGZmMWUzODc5ZDg3NjhiNmU0ZjM4OTcxZDMwMmY3MjNk MDM1YjEzNy4uMGMyZDk2MmU4ODUzNWJhN2UxNTAxMTcyYTlkNjhlNDdlNjJlMjg3YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDEyLTA1LTA5ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgRG9uJ3Qgc2hvdyBwYXJ0eXRpbWUgaWYgdGhlcmUgYXJlIG5vbi1sYXlvdXQgdGVzdCBmYWls dXJlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2 MDU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0 RmFpbHVyZXMvc2NyaXB0cy9jb250cm9sbGVycy5qczoKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2Ny aXB0cy9jb250cm9sbGVyc191bml0dGVzdHMuanM6CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3Njcmlw dHMvZ2FyZGVuLW8tbWF0aWMuanM6CisKKzIwMTItMDUtMDkgIE9qYW4gVmFmYWkgIDxvamFuQGNo cm9taXVtLm9yZz4KKwogICAgICAgICBDaGFuZ2UgImxvc2luZyB0ZXN0IGNvdmVyYWdlIiB0byBj b3ZlciBhbGwgbm9uLWxheW91dCB0ZXN0IHByb2JsZW1zIGluIGdhcmRlbi1vLW1hdGljCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjA0MwogCmRpZmYg LS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9jb250cm9sbGVycy5qcyBiL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RG YWlsdXJlcy9zY3JpcHRzL2NvbnRyb2xsZXJzLmpzCmluZGV4IDJiOThhZGRlMWI2MzJkNmI1ZWVk NzQzMTQzYzQwZGRmNjcyNGJlMmIuLjNkYWNkMjhlOGZlZDBjZDk5NmEzNTY1NzFkZjlmODRkOGE5 OGRmZjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2NvbnRyb2xsZXJzLmpz CisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2NvbnRyb2xsZXJzLmpzCkBAIC0yODcsNiAr Mjg3LDEwIEBAIGNvbnRyb2xsZXJzLkZhaWxpbmdCdWlsZGVycyA9IGJhc2UuZXh0ZW5kcyhPYmpl Y3QsIHsKICAgICAgICAgdGhpcy5fbWVzc2FnZSA9IG1lc3NhZ2U7CiAgICAgICAgIHRoaXMuX25v dGlmaWNhdGlvbiA9IG51bGw7CiAgICAgfSwKKyAgICBoYXNGYWlsdXJlczogZnVuY3Rpb24oKQor ICAgIHsKKyAgICAgICAgcmV0dXJuICEhdGhpcy5fbm90aWZpY2F0aW9uOworICAgIH0sCiAgICAg dXBkYXRlOiBmdW5jdGlvbihmYWlsdXJlc0xpc3QpCiAgICAgewogICAgICAgICBpZiAoT2JqZWN0 LmtleXMoZmFpbHVyZXNMaXN0KS5sZW5ndGggPT0gMCkgewpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZh aWx1cmVzL3NjcmlwdHMvY29udHJvbGxlcnNfdW5pdHRlc3RzLmpzIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVz L3NjcmlwdHMvY29udHJvbGxlcnNfdW5pdHRlc3RzLmpzCmluZGV4IDU1YjhkNGExMWY1MWZhZjcw ZDc2YjQ3ZGUzNTFiMDFkNDY1MmIwMmUuLjg5ZjRjOTM5ZjQ3MDUxZWVhNjU0YjAxMDg2MWM1Y2Mw MTVjNWRmN2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2NvbnRyb2xsZXJz X3VuaXR0ZXN0cy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9jb250cm9sbGVyc191 bml0dGVzdHMuanMKQEAgLTczLDQgKzczLDM0IEBAIHRlc3QoIlVuZXhwZWN0ZWRGYWlsdXJlcyIs IDMsIGZ1bmN0aW9uKCkgewogICAgIH0pOwogfSk7CiAKK3Rlc3QoImNvbnRyb2xsZXJzLkZhaWxp bmdCdWlsZGVycyIsIDMsIGZ1bmN0aW9uKCkgeworICAgIHZhciBNb2NrVmlldyA9IGJhc2UuZXh0 ZW5kcygnZGl2JywgeworICAgICAgICBhZGQ6IGZ1bmN0aW9uKG5vZGUpIHsKKyAgICAgICAgICAg IHRoaXMuYXBwZW5kQ2hpbGQobm9kZSk7CisgICAgICAgIH0KKyAgICB9KQorICAgIHZhciB2aWV3 ID0gbmV3IE1vY2tWaWV3KCk7CisgICAgdmFyIGZhaWxpbmdCdWlsZGVycyA9IG5ldyBjb250cm9s bGVycy5GYWlsaW5nQnVpbGRlcnModmlldywgJ2R1bW15IG1lc3NhZ2UnKTsKKyAgICBvayghZmFp bGluZ0J1aWxkZXJzLmhhc0ZhaWx1cmVzKCkpOworCisgICAgZmFpbGluZ0J1aWxkZXJzLnVwZGF0 ZSh7J0R1bW15QnVpbGRlcic6IFsnd2Via2l0X3Rlc3RzJ119KTsKKyAgICBvayhmYWlsaW5nQnVp bGRlcnMuaGFzRmFpbHVyZXMoKSk7CisKKyAgICBlcXVhbCh2aWV3Lm91dGVySFRNTCwgJzxkaXY+ JyArCisgICAgICAgICc8bGkgc3R5bGU9Im9wYWNpdHk6IDA7ICI+JyArCisgICAgICAgICAgICAn PGRpdiBjbGFzcz0iaG93Ij48dGltZSBjbGFzcz0icmVsYXRpdmUiPjwvdGltZT48L2Rpdj4nICsK KyAgICAgICAgICAgICc8ZGl2IGNsYXNzPSJ3aGF0Ij4nICsKKyAgICAgICAgICAgICAgICAnPGRp diBjbGFzcz0icHJvYmxlbSI+ZHVtbXkgbWVzc2FnZTonICsKKyAgICAgICAgICAgICAgICAgICAg Jzx1bCBjbGFzcz0iZWZmZWN0cyI+JyArCisgICAgICAgICAgICAgICAgICAgICAgICAnPGxpIGNs YXNzPSJidWlsZGVyIj48YSBjbGFzcz0iZmFpbGluZy1idWlsZGVyIiB0YXJnZXQ9Il9ibGFuayIg aHJlZj0iaHR0cDovL2J1aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVtLndlYmtpdC93YXRlcmZh bGw/YnVpbGRlcj1EdW1teUJ1aWxkZXIiPicgKworICAgICAgICAgICAgICAgICAgICAgICAgICAg ICc8c3BhbiBjbGFzcz0idmVyc2lvbiI+RHVtbXlCdWlsZGVyPC9zcGFuPjxzcGFuIGNsYXNzPSJm YWlsdXJlcyI+IHdlYmtpdF90ZXN0czwvc3Bhbj48L2E+JyArCisgICAgICAgICAgICAgICAgICAg ICAgICAnPC9saT4nICsKKyAgICAgICAgICAgICAgICAgICAgJzwvdWw+JyArCisgICAgICAgICAg ICAgICAgJzwvZGl2PicgKworICAgICAgICAgICAgICAgICc8dWwgY2xhc3M9ImNhdXNlcyI+PC91 bD4nICsKKyAgICAgICAgICAgICc8L2Rpdj4nICsKKyAgICAgICAgJzwvbGk+JyArCisgICAgJzwv ZGl2PicpCit9KTsKKwogfSkoKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRz L2dhcmRlbi1vLW1hdGljLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvZ2FyZGVuLW8tbWF0 aWMuanMKaW5kZXggYWIzODJlMWMwMzE1NTU5MDcwODkwYzg0MDRhNjJjM2NmMTcwYjkwMS4uYzQy ZjY1Y2U5Zjc1ZTlmMzYzNWZjMmQyMTMzNGVkNmQ4NTljNzRkZCAxMDA2NDQKLS0tIGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvZ2FyZGVuLW8tbWF0aWMuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVz L3NjcmlwdHMvZ2FyZGVuLW8tbWF0aWMuanMKQEAgLTM2LDYgKzM2LDE0IEBAIHZhciBnX2ZhaWx1 cmVzQ29udHJvbGxlciA9IG51bGw7CiAKIHZhciBnX25vbkxheW91dFRlc3RGYWlsdXJlQnVpbGRl cnMgPSBudWxsOwogCitmdW5jdGlvbiB1cGRhdGVQYXJ0eVRpbWUoKQoreworICAgIGlmICghZ191 bmV4cGVjdGVkRmFpbHVyZXNDb250cm9sbGVyLmxlbmd0aCgpICYmICFnX25vbkxheW91dFRlc3RG YWlsdXJlQnVpbGRlcnMuaGFzRmFpbHVyZXMoKSkKKyAgICAgICAgJCgnI29uZWJhcicpLmFkZENs YXNzKCdwYXJ0eXRpbWUnKTsKKyAgICBlbHNlCisgICAgICAgICQoJyNvbmViYXInKS5yZW1vdmVD bGFzcygncGFydHl0aW1lJyk7Cit9CisKIGZ1bmN0aW9uIHVwZGF0ZSgpCiB7CiAgICAgaWYgKGdf cmV2aXNpb25IaW50KQpAQCAtNTEsNyArNTksMTAgQEAgZnVuY3Rpb24gdXBkYXRlKCkKIAogICAg IGdfaW5mby5hZGQodXBkYXRpbmcpOwogCi0gICAgYnVpbGRlcnMuYnVpbGRlcnNGYWlsaW5nTm9u TGF5b3V0VGVzdHMoZ19ub25MYXlvdXRUZXN0RmFpbHVyZUJ1aWxkZXJzLnVwZGF0ZS5iaW5kKGdf bm9uTGF5b3V0VGVzdEZhaWx1cmVCdWlsZGVycykpOworICAgIGJ1aWxkZXJzLmJ1aWxkZXJzRmFp bGluZ05vbkxheW91dFRlc3RzKGZ1bmN0aW9uKGZhaWx1cmVzTGlzdCkgeworICAgICAgICBnX25v bkxheW91dFRlc3RGYWlsdXJlQnVpbGRlcnMudXBkYXRlKGZhaWx1cmVzTGlzdCk7CisgICAgICAg IHVwZGF0ZVBhcnR5VGltZSgpOworICAgIH0pOwogCiAgICAgYmFzZS5jYWxsSW5QYXJhbGxlbChb bW9kZWwudXBkYXRlUmVjZW50Q29tbWl0cywgbW9kZWwudXBkYXRlUmVzdWx0c0J5QnVpbGRlcl0s IGZ1bmN0aW9uKCkgewogICAgICAgICBpZiAoZ19mYWlsdXJlc0NvbnRyb2xsZXIpCkBAIC02Mywx MCArNzQsNyBAQCBmdW5jdGlvbiB1cGRhdGUoKQogICAgICAgICAgICAgdXBkYXRpbmcudXBkYXRl KCdBbmFseXppbmcgdGVzdCBmYWlsdXJlcyAuLi4gJyArICsrbnVtYmVyT2ZUZXN0c0FuYWx5emVk ICsgJyB0ZXN0cyBhbmFseXplZC4nKTsKICAgICAgICAgICAgIGdfdW5leHBlY3RlZEZhaWx1cmVz Q29udHJvbGxlci51cGRhdGUoZmFpbHVyZUFuYWx5c2lzKTsKICAgICAgICAgfSwgZnVuY3Rpb24o KSB7Ci0gICAgICAgICAgICBpZiAoIWdfdW5leHBlY3RlZEZhaWx1cmVzQ29udHJvbGxlci5sZW5n dGgoKSkKLSAgICAgICAgICAgICAgICAkKCcjb25lYmFyJykuYWRkQ2xhc3MoJ3BhcnR5dGltZScp OwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICQoJyNvbmViYXInKS5yZW1vdmVD bGFzcygncGFydHl0aW1lJyk7CisgICAgICAgICAgICB1cGRhdGVQYXJ0eVRpbWUoKTsKICAgICAg ICAgICAgIGdfdW5leHBlY3RlZEZhaWx1cmVzQ29udHJvbGxlci5wdXJnZSgpOwogCiAgICAgICAg ICAgICB1cGRhdGluZy5kaXNtaXNzKCk7Cg==