86047 2012-05-09 17:39:43 -0700 JIT memory allocator is not returning memory to the OS on Darwin 2012-05-11 15:36:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 620106 0 fpizlo 2012-05-09 17:39:43 -0700 Patch forthcoming. 620107 1 fpizlo 2012-05-09 17:40:30 -0700 <rdar://problem/11414948> 620111 2 141065 fpizlo 2012-05-09 17:41:57 -0700 Created attachment 141065 the patch 620113 3 141065 ggaren 2012-05-09 17:43:25 -0700 Comment on attachment 141065 the patch r=me 620115 4 webkit.review.bot 2012-05-09 17:44:34 -0700 Attachment 141065 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:93: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 620145 5 fpizlo 2012-05-09 18:32:44 -0700 Landed with style fixes in http://trac.webkit.org/changeset/116593 622024 6 fpizlo 2012-05-11 15:29:42 -0700 This cam be made a bit safer. Will post an improvement patch shortly. 622028 7 141509 fpizlo 2012-05-11 15:30:59 -0700 Created attachment 141509 improvement 622035 8 141509 ggaren 2012-05-11 15:33:22 -0700 Comment on attachment 141509 improvement r=me 622039 9 fpizlo 2012-05-11 15:36:35 -0700 Additional fix landed in http://trac.webkit.org/changeset/116813 141065 2012-05-09 17:41:57 -0700 2012-05-11 15:30:59 -0700 the patch fixjitfree_patch_1.diff text/plain 1871 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE2NTg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA1LTA5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SklUIG1lbW9yeSBhbGxvY2F0b3IgaXMgbm90IHJldHVybmluZyBtZW1vcnkgdG8gdGhlIE9TIG9u IERhcndpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODYwNDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExNDE0OTQ4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgV29yayBhcm91bmQgdGhl IHByb2JsZW0gYnkgdXNpbmcgYSBkaWZmZXJlbnQgbWFkdmlzZSgpIGZsYWcsIGJ1dCBvbmx5IGZv ciB0aGUgSklUIG1lbW9yeQorICAgICAgICBhbGxvY2F0b3IuIEFsc28gcHV0IGluIEFTU0VSVHMg dGhhdCB0aGUgY2FsbCBpcyBhY3R1YWxseSB3b3JraW5nLgorCisgICAgICAgICogaml0L0V4ZWN1 dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHA6CisgICAgICAgIChKU0M6OkZpeGVkVk1Qb29s RXhlY3V0YWJsZUFsbG9jYXRvcjo6bm90aWZ5TmVlZFBhZ2UpOgorICAgICAgICAoSlNDOjpGaXhl ZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3I6Om5vdGlmeVBhZ2VJc0ZyZWUpOgorCiAyMDEyLTA1 LTA5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgSXQgc2hvdWxk IGJlIHBvc3NpYmxlIHRvIGdldCB1c2VmdWwgZGVidWcgbG9nZ2luZyBmcm9tIHRoZSBKSVQgbWVt b3J5IGFsbG9jYXRvcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxl QWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAkocmV2aXNpb24gMTE2 NTgzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yRml4 ZWRWTVBvb2wuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCwxMiArNzgsMjYgQEAgcHJvdGVjdGVk OgogICAgIAogICAgIHZpcnR1YWwgdm9pZCBub3RpZnlOZWVkUGFnZSh2b2lkKiBwYWdlKQogICAg IHsKKyNpZiBPUyhEQVJXSU4pCisgICAgICAgIFVOVVNFRF9QQVJBTShwYWdlKTsKKyNlbHNlCiAg ICAgICAgIG1fcmVzZXJ2YXRpb24uY29tbWl0KHBhZ2UsIHBhZ2VTaXplKCkpOworI2VuZGlmCiAg ICAgfQogICAgIAogICAgIHZpcnR1YWwgdm9pZCBub3RpZnlQYWdlSXNGcmVlKHZvaWQqIHBhZ2Up CiAgICAgeworI2lmIE9TKERBUldJTikKKyAgICAgICAgZm9yICg7OykgeworICAgICAgICAgICAg aW50IHJlc3VsdCA9IG1hZHZpc2UocGFnZSwgcGFnZVNpemUoKSwgTUFEVl9GUkVFKTsKKyAgICAg ICAgICAgIGlmIChyZXN1bHQgPT0gMCkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAg ICAgICBBU1NFUlQocmVzdWx0ID09IC0xKTsKKyAgICAgICAgICAgIEFTU0VSVChlcnJubyA9PSBF QUdBSU4pOworICAgICAgICB9CisjZWxzZQogICAgICAgICBtX3Jlc2VydmF0aW9uLmRlY29tbWl0 KHBhZ2UsIHBhZ2VTaXplKCkpOworI2VuZGlmCiAgICAgfQogCiBwcml2YXRlOgo= 141509 2012-05-11 15:30:59 -0700 2012-05-11 15:33:21 -0700 improvement saferjitmalloc_patch_1.diff text/plain 1541 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE2ODExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEyLTA1LTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SklUIG1lbW9yeSBhbGxvY2F0b3IgaXMgbm90IHJldHVybmluZyBtZW1vcnkgdG8gdGhlIE9TIG9u IERhcndpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODYwNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwOgorICAgICAgICAoSlNDOjpG aXhlZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3I6Om5vdGlmeVBhZ2VJc0ZyZWUpOgorCiAyMDEy LTA1LTExICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xh cmlmaWVkIEpTR2xvYmFsRGF0YSAoSmF2YVNjcmlwdCBWTSkgbGlmZXRpbWUKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0 b3JGaXhlZFZNUG9vbC5jcHAJKHJldmlzaW9uIDExNjgwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtOTMsNyArOTMsMTAgQEAgcHJvdGVjdGVkOgogICAgICAgICAgICAgaWYgKCFyZXN1bHQp CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgQVNTRVJUKHJlc3VsdCA9PSAt MSk7Ci0gICAgICAgICAgICBBU1NFUlQoZXJybm8gPT0gRUFHQUlOKTsKKyAgICAgICAgICAgIGlm IChlcnJubyAhPSBFQUdBSU4pIHsKKyAgICAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsgLy8gSW4gZGVidWcgbW9kZSwgdGhpcyBzaG91bGQgYmUgYSBoYXJkIGZhaWx1cmUuCisgICAg ICAgICAgICAgICAgYnJlYWs7IC8vIEluIHJlbGVhc2UgbW9kZSwgd2Ugc2hvdWxkIGp1c3QgaWdu b3JlIHRoZSBlcnJvciAtIG5vdCByZXR1cm5pbmcgbWVtb3J5IHRvIHRoZSBPUyBpcyBiZXR0ZXIg dGhhbiBjcmFzaGluZywgZXNwZWNpYWxseSBzaW5jZSB3ZSBfd2lsbF8gYmUgYWJsZSB0byByZXVz ZSB0aGUgbWVtb3J5IGludGVybmFsbHkgYW55d2F5LgorICAgICAgICAgICAgfQogICAgICAgICB9 CiAjZWxzZQogICAgICAgICBtX3Jlc2VydmF0aW9uLmRlY29tbWl0KHBhZ2UsIHBhZ2VTaXplKCkp Owo=