86046 2012-05-09 17:28:04 -0700 [Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions 2012-05-10 14:13:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 creis tsepez abarth creis webkit.review.bot oldest_to_newest 620088 0 creis 2012-05-09 17:28:04 -0700 The ChromePageNoJavascript test in Source/WebKit/chromium/tests/WebFrameTest.cpp is trying to verify that content injected into the DOM isn't showing up because it's a Chrome page. However, the injected content currently wouldn't be detected even if Chrome URLs were allowed to run JavaScript. There needs to be a webView->layout() call before calling contentsAsText in order to catch it. 620749 1 141202 tsepez 2012-05-10 11:20:19 -0700 Created attachment 141202 Patch containing revised test. 620951 2 141202 webkit.review.bot 2012-05-10 14:13:29 -0700 Comment on attachment 141202 Patch containing revised test. Clearing flags on attachment: 141202 Committed r116686: <http://trac.webkit.org/changeset/116686> 620952 3 webkit.review.bot 2012-05-10 14:13:34 -0700 All reviewed patches have been landed. Closing bug. 141202 2012-05-10 11:20:19 -0700 2012-05-10 14:13:29 -0700 Patch containing revised test. patch_86046.txt text/plain 3005 tsepez SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTY2NjMpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA1LTEwICBUb20gU2VwZXogIDx0c2VwZXpAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtDaHJvbWl1bV0gV2ViRnJhbWVUZXN0LkNocm9tZVBhZ2VOb0phdmFzY3JpcHQgaXNuJ3Qg Y2F0Y2hpbmcgcmVncmVzc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg2MDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdCBib3RoIGNhc2VzIGZvciByZWdpc3RlclVSTFNjaGVtZUFzTm90QWxs b3dpbmdKYXZhc2NyaXB0VVJMcy4gIEFsc28gYWRkCisgICAgICAgIGEgY2FsbCB0byBsYXlvdXQo KSB0byBlbnN1cmUgdGhlIGphdmFzY3JpcHQgcmVzdWx0IGlzIHNlZW4uCisgICAgICAgIAorICAg ICAgICAqIHRlc3RzL1dlYkZyYW1lVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlRFU1RfRik6 CisgICAgICAgIChXZWJLaXQpOgorCiAyMDEyLTA1LTEwICBTYW0gRCAgPGRzYW0yOTEyQGdtYWls LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW5hbWUgSW5zcGVjdG9yQmFja2VuZFN0 dWIuanMgdG8gSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLmpzCkluZGV4OiBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCShyZXZpc2lvbiAxMTY2NTgpCisr KyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEzNywxOSArMTM3LDQwIEBAIFRFU1RfRihXZWJGcmFtZVRlc3QsIEZvcm1XaXRo TnVsbEZyYW1lKQogICAgIFdlYlNlYXJjaGFibGVGb3JtRGF0YSBzZWFyY2hhYmxlRGF0YUZvcm0o Zm9ybXNbMF0pOwogfQogCitURVNUX0YoV2ViRnJhbWVUZXN0LCBDaHJvbWVQYWdlSmF2YXNjcmlw dCkKK3sKKyAgICByZWdpc3Rlck1vY2tlZENocm9tZVVSTExvYWQoImhpc3RvcnkuaHRtbCIpOwor IAorICAgIC8vIFBhc3MgdHJ1ZSB0byBlbmFibGUgSmF2YVNjcmlwdC4KKyAgICBXZWJWaWV3KiB3 ZWJWaWV3ID0gRnJhbWVUZXN0SGVscGVyczo6Y3JlYXRlV2ViVmlld0FuZExvYWQobV9jaHJvbWVV UkwgKyAiaGlzdG9yeS5odG1sIiwgdHJ1ZSk7CisKKyAgICAvLyBUcnkgdG8gcnVuIEpTIGFnYWlu c3QgdGhlIGNocm9tZS1zdHlsZSBVUkwuCisgICAgRnJhbWVUZXN0SGVscGVyczo6bG9hZEZyYW1l KHdlYlZpZXctPm1haW5GcmFtZSgpLCAiamF2YXNjcmlwdDpkb2N1bWVudC5ib2R5LmFwcGVuZENo aWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCdDbG9iYmVyZWQnKSkiKTsKKworICAgIC8vIFJl cXVpcmVkIHRvIHNlZSBhbnkgdXBkYXRlcyBpbiBjb250ZW50QXNUZXh0LgorICAgIHdlYlZpZXct PmxheW91dCgpOworCisgICAgLy8gTm93IHJldHJpZXZlIHRoZSBmcmFtZSdzIHRleHQgYW5kIGVu c3VyZSBpdCB3YXMgbW9kaWZpZWQgYnkgcnVubmluZyBqYXZhc2NyaXB0LgorICAgIHN0ZDo6c3Ry aW5nIGNvbnRlbnQgPSB3ZWJWaWV3LT5tYWluRnJhbWUoKS0+Y29udGVudEFzVGV4dCgxMDI0KS51 dGY4KCk7CisgICAgRVhQRUNUX05FKHN0ZDo6c3RyaW5nOjpucG9zLCBjb250ZW50LmZpbmQoIkNs b2JiZXJlZCIpKTsKK30KKwogVEVTVF9GKFdlYkZyYW1lVGVzdCwgQ2hyb21lUGFnZU5vSmF2YXNj cmlwdCkKIHsKICAgICByZWdpc3Rlck1vY2tlZENocm9tZVVSTExvYWQoImhpc3RvcnkuaHRtbCIp OwogCisgICAgLy8vIFBhc3MgdHJ1ZSB0byBlbmFibGUgSmF2YVNjcmlwdC4KICAgICBXZWJWaWV3 KiB3ZWJWaWV3ID0gRnJhbWVUZXN0SGVscGVyczo6Y3JlYXRlV2ViVmlld0FuZExvYWQobV9jaHJv bWVVUkwgKyAiaGlzdG9yeS5odG1sIiwgdHJ1ZSk7CiAKLSAgICAvLyBUcnkgdG8gcnVuIEpTIGFn YWluc3QgdGhlIGNocm9tZS1zdHlsZSBVUkwuCisgICAgLy8gVHJ5IHRvIHJ1biBKUyBhZ2FpbnN0 IHRoZSBjaHJvbWUtc3R5bGUgVVJMIGFmdGVyIHByb2hpYml0aW5nIGl0LgogICAgIFdlYlNlY3Vy aXR5UG9saWN5OjpyZWdpc3RlclVSTFNjaGVtZUFzTm90QWxsb3dpbmdKYXZhc2NyaXB0VVJMcygi Y2hyb21lIik7CiAgICAgRnJhbWVUZXN0SGVscGVyczo6bG9hZEZyYW1lKHdlYlZpZXctPm1haW5G cmFtZSgpLCAiamF2YXNjcmlwdDpkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRvY3VtZW50LmNy ZWF0ZVRleHROb2RlKCdDbG9iYmVyZWQnKSkiKTsKIAotICAgIC8vIE5vdyByZXRyaWV2ZSB0aGUg ZnJhbWVzIHRleHQgYW5kIHNlZSBpZiBpdCB3YXMgY2xvYmJlcmVkLgorICAgIC8vIFJlcXVpcmVk IHRvIHNlZSBhbnkgdXBkYXRlcyBpbiBjb250ZW50QXNUZXh0LgorICAgIHdlYlZpZXctPmxheW91 dCgpOworCisgICAgLy8gTm93IHJldHJpZXZlIHRoZSBmcmFtZSdzIHRleHQgYW5kIGVuc3VyZSBp dCB3YXNuJ3QgbW9kaWZpZWQgYnkgcnVubmluZyBqYXZhc2NyaXB0LgogICAgIHN0ZDo6c3RyaW5n IGNvbnRlbnQgPSB3ZWJWaWV3LT5tYWluRnJhbWUoKS0+Y29udGVudEFzVGV4dCgxMDI0KS51dGY4 KCk7Ci0gICAgRVhQRUNUX05FKHN0ZDo6c3RyaW5nOjpucG9zLCBjb250ZW50LmZpbmQoIlNpbXVs YXRlZCBDaHJvbWl1bSBIaXN0b3J5IFBhZ2UiKSk7CiAgICAgRVhQRUNUX0VRKHN0ZDo6c3RyaW5n OjpucG9zLCBjb250ZW50LmZpbmQoIkNsb2JiZXJlZCIpKTsKIH0KIAo=