86045 2012-05-09 17:19:32 -0700 [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock 2012-05-09 22:55:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED LATER P2 Normal --- 66687 1 abarth abarth eric johnme peter tkent webkit.review.bot oldest_to_newest 620081 0 abarth 2012-05-09 17:19:32 -0700 [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock 620084 1 141062 abarth 2012-05-09 17:20:53 -0700 Created attachment 141062 Patch 620085 2 abarth 2012-05-09 17:21:18 -0700 Another possibility is to add ENABLE macros to these files. 620087 3 141062 eric 2012-05-09 17:22:20 -0700 Comment on attachment 141062 Patch OK. 620124 4 141062 webkit.review.bot 2012-05-09 18:00:42 -0700 Comment on attachment 141062 Patch Clearing flags on attachment: 141062 Committed r116590: <http://trac.webkit.org/changeset/116590> 620125 5 webkit.review.bot 2012-05-09 18:00:47 -0700 All reviewed patches have been landed. Closing bug. 620258 6 tkent 2012-05-09 22:50:06 -0700 (In reply to comment #4) > (From update of attachment 141062 [details]) > Clearing flags on attachment: 141062 > > Committed r116590: <http://trac.webkit.org/changeset/116590> This made a build error on Android. I reverted the change. /usr/local/google/b/webkit-slave/chromium-linux-android/build/Source/WebKit/chromium/android-ndk-r7b/toolchains/arm-linux-androideabi-4.4.3/prebuilt/linux-x86/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld: out/Release/obj.target/DumpRenderTree/Tools/DumpRenderTree/chromium/WebViewHost.o: in function WebViewHost::userMediaClientMock():Tools/DumpRenderTree/chromium/WebViewHost.cpp:728: error: undefined reference to 'WebKit::WebUserMediaClientMock::create()' 620259 7 abarth 2012-05-09 22:54:35 -0700 Thanks. 620260 8 abarth 2012-05-09 22:55:25 -0700 We're going to need to do these GYP changes later. 141062 2012-05-09 17:20:53 -0700 2012-05-09 18:00:42 -0700 Patch bug-86045-20120509172052.patch text/plain 1602 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNjU4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDEyLTA1LTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0Nocm9taXVtXSBBbmRyb2lkJ3MgRFJUIGRvZXNuJ3Qgd2FudCB0byBidWlsZCBX ZWJVc2VyTWVkaWFDbGllbnRNb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NjA0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwaToKKwogMjAx Mi0wNS0wOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gTGF5b3V0VGVzdENvbnRyb2xsZXIgc2hvdWxkIHVzZSBFTkFCTEUgZ3VhcmRzIGZvciBz b21lIGZlYXR1cmVzCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5n eXBpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5 cGkJKHJldmlzaW9uIDExNjUyNSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJU cmVlLmd5cGkJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDggKzQ2LDYgQEAKICAgICAgICAgICAgICdj aHJvbWl1bS9XZWJQZXJtaXNzaW9ucy5oJywKICAgICAgICAgICAgICdjaHJvbWl1bS9XZWJQcmVm ZXJlbmNlcy5jcHAnLAogICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlByZWZlcmVuY2VzLmgnLAot ICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlVzZXJNZWRpYUNsaWVudE1vY2suY3BwJywKLSAgICAg ICAgICAgICdjaHJvbWl1bS9XZWJVc2VyTWVkaWFDbGllbnRNb2NrLmgnLAogICAgICAgICAgICAg J2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcCcsCiAgICAgICAgICAgICAnY2hyb21pdW0vV2ViVmll d0hvc3QuaCcsCiAgICAgICAgIF0sCkBAIC05Myw3ICs5MSwxMyBAQAogICAgICAgICAgICAgICAg ICAgICAnY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlRNYWMubW0nLAogICAgICAgICAgICAgICAg ICAgICAnY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlRNYWMuaCcsCiAgICAgICAgICAgICAgICAg XSwKLSAgICAgICAgICAgIH1dLCAgICAgICAgICAgIAorICAgICAgICAgICAgfV0sCisgICAgICAg ICAgICBbJ09TIT0iYW5kcm9pZCInLCB7CisgICAgICAgICAgICAgICAgJ2RydF9maWxlcyc6IFsK KyAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlVzZXJNZWRpYUNsaWVudE1vY2suY3Bw JywKKyAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlVzZXJNZWRpYUNsaWVudE1vY2su aCcsCisgICAgICAgICAgICAgICAgXSwKKyAgICAgICAgICAgIH1dLAogICAgICAgICBdLAogICAg IH0KIH0K