86038 2012-05-09 16:50:52 -0700 REGRESSION(r116573): Broke the Chromium Mac compile (Requested by ojan_gardening on #webkit). 2012-05-09 17:17:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85916 1 webkit.review.bot webkit.review.bot fishd fsamuel ojan oldest_to_newest 620027 0 webkit.review.bot 2012-05-09 16:50:52 -0700 http://trac.webkit.org/changeset/116573 broke the build: Broke the Chromium Mac compile (Requested by ojan_gardening on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 620030 1 141051 webkit.review.bot 2012-05-09 16:51:48 -0700 Created attachment 141051 ROLLOUT of r116573 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 620034 2 ojan 2012-05-09 16:53:07 -0700 In file included from webkit/plugins/webview_plugin.cc:5: ./webkit/plugins/webview_plugin.h:65:31: error: 'webkit::WebViewPlugin::container' hides overloaded virtual function [-Werror,-Woverloaded-virtual] WebKit::WebPluginContainer* container() { return container_; } ^ ./third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h:59:33: note: hidden overloaded virtual function 'WebKit::WebPlugin::container' declared here virtual WebPluginContainer* container() const { return 0; } ^ 1 error generated. make: *** [out/Release/obj.target/glue/webkit/plugins/webview_plugin.o] Error 1 620077 3 141051 webkit.review.bot 2012-05-09 17:17:38 -0700 Comment on attachment 141051 ROLLOUT of r116573 Clearing flags on attachment: 141051 Committed r116582: <http://trac.webkit.org/changeset/116582> 620078 4 webkit.review.bot 2012-05-09 17:17:42 -0700 All reviewed patches have been landed. Closing bug. 141051 2012-05-09 16:51:48 -0700 2012-05-09 17:17:38 -0700 ROLLOUT of r116573 bug-86038-20120509235542.patch text/plain 1374 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGE5NDFjMGE2MDFjYzIxMzViZDliZmExZjc1MjA3ZjM2NTFlNDk0NzQuLjg0ZjkxYmFmMWU4ZGVk MWJjYWQ3M2M4N2JiN2E5ZDc3MmVhM2I3ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDUtMDkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTY1NzMu CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzExNjU3MworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYwMzgKKworICAgICAg ICBCcm9rZSB0aGUgQ2hyb21pdW0gTWFjIGNvbXBpbGUgKFJlcXVlc3RlZCBieSBvamFuX2dhcmRl bmluZyBvbgorICAgICAgICAjd2Via2l0KS4KKworICAgICAgICAqIHB1YmxpYy9XZWJQbHVnaW4u aDoKKyAgICAgICAgKFdlYlBsdWdpbik6CisKIDIwMTItMDUtMDkgIEZhZHkgU2FtdWVsICA8ZnNh bXVlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBFeHBvc2UgV2ViUGx1Z2lu Q29udGFpbmVyIG9mIFdlYlBsdWdpbiB0byBlbWJlZGRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJQbHVnaW4uaAppbmRleCAzZjJkMTJkZmM4MDM2NTllMWYxZTEwNzhkMmExOGRh OTBiMzA1YmZlLi5lZGZkYTMyYTQ5NDA3YWZhNDAzODhmNThjMDk1ZmU3ODcxNjUyODNlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVnaW4uaAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVnaW4uaApAQCAtNTYsOCArNTYsNiBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGluaXRpYWxpemUoV2ViUGx1Z2luQ29udGFpbmVy KikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBkZXN0cm95KCkgPSAwOwogCi0gICAgdmlydHVhbCBX ZWJQbHVnaW5Db250YWluZXIqIGNvbnRhaW5lcigpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLQogICAg IHZpcnR1YWwgTlBPYmplY3QqIHNjcmlwdGFibGVPYmplY3QoKSA9IDA7CiAKICAgICAvLyBSZXR1 cm5zIHRydWUgaWYgdGhlIGZvcm0gc3VibWlzc2lvbiB2YWx1ZSBpcyBzdWNjZXNzZnVsbHkgb2J0 YWluZWQK