86034 2012-05-09 16:20:06 -0700 GC race condition in OpaqueJSClass::prototype 2012-05-09 17:03:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough gustavo philn xan.lopez oldest_to_newest 619984 0 barraclough 2012-05-09 16:20:06 -0700 The bug here is basically: if (weakref) weakref->method() where a GC may occur between the if & the method call. 620005 1 141048 barraclough 2012-05-09 16:31:08 -0700 Created attachment 141048 Fix 620014 2 141048 buildbot 2012-05-09 16:38:04 -0700 Comment on attachment 141048 Fix Attachment 141048 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12644873 620017 3 141048 buildbot 2012-05-09 16:39:53 -0700 Comment on attachment 141048 Fix Attachment 141048 did not pass win-ews (win): Output: http://queues.webkit.org/results/12644874 620043 4 barraclough 2012-05-09 17:01:23 -0700 Fixed in r116575 620045 5 barraclough 2012-05-09 17:03:57 -0700 Ooops, landed b0rked version of patch, build fix in r116578. 141048 2012-05-09 16:31:08 -0700 2012-05-09 16:41:56 -0700 Fix 86034.patch text/plain 2531 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE2NTYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTA1LTA5ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBHQyByYWNlIGNvbmRpdGlvbiBpbiBPcGFxdWVKU0NsYXNzOjpwcm90b3R5cGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MDM0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1ZyBo ZXJlIGlzIGJhc2ljYWxseToKKyAgICAgICAgICAgIGlmICh3ZWFrcmVmKSB3ZWFrcmVmLT5tZXRo b2QoKQorICAgICAgICB3aGVyZSBhIEdDIG1heSBvY2N1ciBiZXR3ZWVuIHRoZSBpZiAmIHRoZSBt ZXRob2QgY2FsbC4KKworICAgICAgICAqIEFQSS9KU0NsYXNzUmVmLmNwcDoKKyAgICAgICAgKE9w YXF1ZUpTQ2xhc3M6OnByb3RvdHlwZSk6CisKIDIwMTItMDUtMDkgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVzZSBpbmRlcGVuZGVu dCB2ZXJzaW9uIG51bWJlcnMgZm9yIHB1YmxpYyBsaWJyYXJpZXMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9BUEkvSlNDbGFzc1JlZi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS9KU0NsYXNzUmVmLmNwcAkocmV2aXNpb24gMTE2NTU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS9KU0NsYXNzUmVmLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA5 LDEzICsyMDksMTYgQEAgSlNPYmplY3QqIE9wYXF1ZUpTQ2xhc3M6OnByb3RvdHlwZShFeGVjUwog CiAgICAgT3BhcXVlSlNDbGFzc0NvbnRleHREYXRhJiBqc0NsYXNzRGF0YSA9IGNvbnRleHREYXRh KGV4ZWMpOwogCi0gICAgaWYgKCFqc0NsYXNzRGF0YS5jYWNoZWRQcm90b3R5cGUpIHsKLSAgICAg ICAgLy8gUmVjdXJzaXZlLCBidXQgc2hvdWxkIGJlIGdvb2QgZW5vdWdoIGZvciBvdXIgcHVycG9z ZXMKLSAgICAgICAganNDbGFzc0RhdGEuY2FjaGVkUHJvdG90eXBlID0gUGFzc1dlYWs8SlNPYmpl Y3Q+KEpTQ2FsbGJhY2tPYmplY3Q8SlNOb25GaW5hbE9iamVjdD46OmNyZWF0ZShleGVjLCBleGVj LT5sZXhpY2FsR2xvYmFsT2JqZWN0KCksIGV4ZWMtPmxleGljYWxHbG9iYWxPYmplY3QoKS0+Y2Fs bGJhY2tPYmplY3RTdHJ1Y3R1cmUoKSwgcHJvdG90eXBlQ2xhc3MsICZqc0NsYXNzRGF0YSksIDAp OyAvLyBzZXQganNDbGFzc0RhdGEgYXMgdGhlIG9iamVjdCdzIHByaXZhdGUgZGF0YSwgc28gaXQg Y2FuIGNsZWFyIG91ciByZWZlcmVuY2Ugb24gZGVzdHJ1Y3Rpb24KLSAgICAgICAgaWYgKHBhcmVu dENsYXNzKSB7Ci0gICAgICAgICAgICBpZiAoSlNPYmplY3QqIHByb3RvdHlwZSA9IHBhcmVudENs YXNzLT5wcm90b3R5cGUoZXhlYykpCi0gICAgICAgICAgICAgICAganNDbGFzc0RhdGEuY2FjaGVk UHJvdG90eXBlLT5zZXRQcm90b3R5cGUoZXhlYy0+Z2xvYmFsRGF0YSgpLCBwcm90b3R5cGUpOwot ICAgICAgICB9CisgICAgaWYgKEpTT2JqZWN0KiBwcm90b3R5cGUgPSBqc0NsYXNzRGF0YS5jYWNo ZWRQcm90b3R5cGUuZ2V0KCkpCisgICAgICAgIHJldHVybiBwcm90b3R5cGU7CisKKyAgICAvLyBS ZWN1cnNpdmUsIGJ1dCBzaG91bGQgYmUgZ29vZCBlbm91Z2ggZm9yIG91ciBwdXJwb3NlcworICAg IHByb3RvdHlwZSA9IEpTQ2FsbGJhY2tPYmplY3Q8SlNOb25GaW5hbE9iamVjdD46OmNyZWF0ZShl eGVjLCBleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCksIGV4ZWMtPmxleGljYWxHbG9iYWxPYmpl Y3QoKS0+Y2FsbGJhY2tPYmplY3RTdHJ1Y3R1cmUoKSwgcHJvdG90eXBlQ2xhc3MsICZqc0NsYXNz RGF0YSk7IC8vIHNldCBqc0NsYXNzRGF0YSBhcyB0aGUgb2JqZWN0J3MgcHJpdmF0ZSBkYXRhLCBz byBpdCBjYW4gY2xlYXIgb3VyIHJlZmVyZW5jZSBvbiBkZXN0cnVjdGlvbgorICAgIGlmIChwYXJl bnRDbGFzcykgeworICAgICAgICBpZiAoSlNPYmplY3QqIHBhcmVudFByb3RvdHlwZSA9IHBhcmVu dENsYXNzLT5wcm90b3R5cGUoZXhlYykpCisgICAgICAgICAgICBwcm90b3R5cGUtPnNldFByb3Rv dHlwZShleGVjLT5nbG9iYWxEYXRhKCksIHBhcmVudFByb3RvdHlwZSk7CiAgICAgfQotICAgIHJl dHVybiBqc0NsYXNzRGF0YS5jYWNoZWRQcm90b3R5cGUuZ2V0KCk7CisKKyAgICBqc0NsYXNzRGF0 YS5jYWNoZWRQcm90b3R5cGUgPSBQYXNzV2VhazxKU09iamVjdD4ocHJvdG90eXBlLCAwKTsKKyAg ICByZXR1cm4gcHJvdG90eXBlOwogfQo=