86033 2012-05-09 16:16:59 -0700 Speed up some parts of TileCache drawing 2012-05-09 17:11:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca thorton oldest_to_newest 619979 0 andersca 2012-05-09 16:16:59 -0700 Speed up some parts of TileCache drawing 619983 1 141043 andersca 2012-05-09 16:19:10 -0700 Created attachment 141043 Patch 620050 2 141043 sam 2012-05-09 17:06:18 -0700 Comment on attachment 141043 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141043&action=review > Source/WebCore/platform/graphics/ca/mac/TileCache.mm:278 > + if (m_isInWindow && m_canHaveScrollbars) { Can you add a comment here about why this predicate is right? It might make sense to pull it out into a variable with a descriptive name. 620059 3 andersca 2012-05-09 17:11:56 -0700 Committed r116579: <http://trac.webkit.org/changeset/116579> 141043 2012-05-09 16:19:10 -0700 2012-05-09 17:06:18 -0700 Patch bug-86033-20120509162127.patch text/plain 2908 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGU3ZWI4N2E2NzE3NTJh ZTgyNzc0ZTU4N2EyOWJkYjQ0NzMwMmMwNy4uZTYwNGQyMTg4NGM0MzU1ZDBkZGUwNWY0M2M4YTMw ZWYzNjRmZTBkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTA5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU3BlZWQgdXAgc29t ZSBwYXJ0cyBvZiBUaWxlQ2FjaGUgZHJhd2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYwMzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwOTE5 MzczPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDYWNoZS5tbToKKyAgICAgICAgKFdlYkNvcmU6 OlRpbGVDYWNoZTo6dGlsZUNvdmVyYWdlUmVjdCk6CisgICAgICAgIElmIHdlIGNhbid0IGhhdmUg c2Nyb2xsYmFycywgdGhlcmUncyBub3QgbXVjaCBuZWVkIHRvIGV4dGVuZCB0aGUgdGlsZSBjb3Zl cmFnZSByZWN0IG91dHNpZGUgb2YgdGhlIHZpc2libGUgcmVjdCwgc2luY2UgaXQncworICAgICAg ICB1bmxpa2VseSB0aGF0IHdlJ2xsIGRvIGFueSBmb3JtIG9mIHNjcm9sbGluZyBoZXJlLgorCisg ICAgICAgIChXZWJDb3JlOjpUaWxlQ2FjaGU6OnJldmFsaWRhdGVUaWxlcyk6CisgICAgICAgIERv bid0IHVwZGF0ZSB0aGUgdGlsZSBsYXllciBmcmFtZSBpZiBpdCdzIGJpZyBlbm91Z2ggdG8gY29u dGFpbiB0aGUgdGlsZSBzaXplLiBBbHNvLCBpZiB0aGVyZSBhcmUgbm8gbmV3IHRpbGVzIGNyZWF0 ZWQsCisgICAgICAgIGRvbid0IGNhbGwgcGxhdGZvcm1DQUxheWVyRGlkQ3JlYXRlVGlsZXMgc2lu Y2UgdGhhdCB3aWxsIHRyaWdnZXIgYW4gZXh0cmEgbGF5ZXIgZmx1c2guCisKIDIwMTItMDUtMDkg IEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2hlbiBj cmVhdGluZyBhIG5ldyBwYWdlIGR1cmluZyBhIG5hdmlnYXRpb24sIHByaW1lIHRoZSBpbml0aWFs IGRvY3VtZW50IHdpdGggdGhlIGNvcnJlY3QgcmVmZXJyZXIgcG9saWN5CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNhY2hlLm1tIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDYWNoZS5tbQppbmRleCA5 ZmE2YTQ4YzAyODg0YTIyZjQxYjk5ZWFjYThhM2JhODBlYjEyMjkxLi44MjgyMDc0MDhkZjQ1MDQ0 YWE1MDlkOTVjNzE4NDNmMDUzNmNiZmFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNhY2hlLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlQ2FjaGUubW0KQEAgLTI3NSw3ICsyNzUsNyBAQCBJ bnRSZWN0IFRpbGVDYWNoZTo6dGlsZUNvdmVyYWdlUmVjdCgpIGNvbnN0CiB7CiAgICAgSW50UmVj dCB0aWxlQ292ZXJhZ2VSZWN0ID0gbV92aXNpYmxlUmVjdDsKIAotICAgIGlmIChtX2lzSW5XaW5k b3cpIHsKKyAgICBpZiAobV9pc0luV2luZG93ICYmIG1fY2FuSGF2ZVNjcm9sbGJhcnMpIHsKICAg ICAgICAgLy8gSW5mbGF0ZSB0aGUgY292ZXJhZ2UgcmVjdCBzbyB0aGF0IGl0IGNvdmVycyAyeCBv ZiB0aGUgdmlzaWJsZSB3aWR0aCBhbmQgM3ggb2YgdGhlIHZpc2libGUgaGVpZ2h0LgogICAgICAg ICAvLyBUaGVzZSB2YWx1ZXMgd2VyZSBjaG9zZW4gYmVjYXVzZSBpdCdzIG1vcmUgY29tbW9uIHRv IGhhdmUgdGFsbCBwYWdlcyBhbmQgdG8gc2Nyb2xsIHZlcnRpY2FsbHksCiAgICAgICAgIC8vIHNv IHdlIGtlZXAgbW9yZSB0aWxlcyBhYm92ZSBhbmQgYmVsb3cgdGhlIGN1cnJlbnQgYXJlYS4KQEAg LTM1MSw3ICszNTEsOCBAQCB2b2lkIFRpbGVDYWNoZTo6cmV2YWxpZGF0ZVRpbGVzKCkKICAgICAg ICAgICAgICAgICBbbV90aWxlQ29udGFpbmVyTGF5ZXIuZ2V0KCkgYWRkU3VibGF5ZXI6dGlsZUxh eWVyLmdldCgpXTsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgLy8gV2Ug YWxyZWFkeSBoYXZlIGEgbGF5ZXIgZm9yIHRoaXMgdGlsZS4gRW5zdXJlIHRoYXQgaXRzIHNpemUg aXMgY29ycmVjdC4KLSAgICAgICAgICAgICAgICBpZiAoQ0dTaXplRXF1YWxUb1NpemUoW3RpbGVM YXllci5nZXQoKSBmcmFtZV0uc2l6ZSwgdGlsZVJlY3Quc2l6ZSgpKSkKKyAgICAgICAgICAgICAg ICBDR1NpemUgdGlsZUxheWVyU2l6ZSA9IFt0aWxlTGF5ZXIuZ2V0KCkgZnJhbWVdLnNpemU7Cisg ICAgICAgICAgICAgICAgaWYgKHRpbGVMYXllclNpemUud2lkdGggPj0gdGlsZVJlY3Qud2lkdGgo KSAmJiB0aWxlTGF5ZXJTaXplLmhlaWdodCA+PSB0aWxlUmVjdC5oZWlnaHQoKSkKICAgICAgICAg ICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgW3RpbGVMYXllci5nZXQoKSBz ZXRGcmFtZTp0aWxlUmVjdF07CiAgICAgICAgICAgICB9CkBAIC0zNjksNiArMzcwLDggQEAgdm9p ZCBUaWxlQ2FjaGU6OnJldmFsaWRhdGVUaWxlcygpCiAgICAgICAgIG1fdGlsZUNvdmVyYWdlUmVj dC51bml0ZShyZWN0Rm9yVGlsZUluZGV4KHRpbGVJbmRleCkpOwogICAgIH0KIAorICAgIGlmIChk aXJ0eVJlY3RzLmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIHBsYXRmb3JtTGF5ZXIt Pm93bmVyKCktPnBsYXRmb3JtQ0FMYXllckRpZENyZWF0ZVRpbGVzKGRpcnR5UmVjdHMpOwogfQog Cg==