86032 2012-05-09 16:16:08 -0700 Problems with flipped writing modes and compositing 2012-05-17 21:33:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned bdakin eric mitz simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 619977 0 bdakin 2012-05-09 16:16:08 -0700 While investigating https://bugs.webkit.org/show_bug.cgi?id=86025 Simon and I discovered another strange bug with vertical text and compositing. Open the attached test case in Safari. Scroll to the left to reveal the rest of the green box, and notice that instead of the expected white background, you end up seeing the green box over a shadow or dark linen or something. 619978 1 141042 bdakin 2012-05-09 16:16:27 -0700 Created attachment 141042 Test case 619981 2 webkit-bug-importer 2012-05-09 16:17:38 -0700 <rdar://problem/11419933> 627306 3 142624 mitz 2012-05-17 21:15:31 -0700 Created attachment 142624 Account for flipped writing modes in RenderLayer::calculateLayerBounds() 627310 4 mitz 2012-05-17 21:33:44 -0700 Fixed in r117537. <http://trac.webkit.org/r117537> 141042 2012-05-09 16:16:27 -0700 2012-05-09 16:16:27 -0700 Test case limit-layer-bounds-positioned-and-vertical.html text/html 1583 bdakin PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBt ZWRpYT0ic2NyZWVuIj4KICAgIGJvZHkgewogICAgICBwb3NpdGlvbjogcmVsYXRpdmU7CiAgICB9 CiAgICAuY29udGFpbmVyIHsKICAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgICB3aWR0aDog MTAwcHg7CiAgICAgIGhlaWdodDogMTAwcHg7CiAgICAgIHBhZGRpbmc6IDIwcHg7CiAgICAgIHot aW5kZXg6IDA7CiAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOwogICAgfQogICAgCiAgICB2 aWRlbyB7CiAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgdG9wOiAyMXB4OwogICAgICBs ZWZ0OiAyMXB4OwogICAgICB3aWR0aDogMTAwcHg7CiAgICAgIGhlaWdodDogMTAwcHg7CiAgICB9 CiAgICAKICAgIC5mYXItbGVmdCB7CiAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKICAgICAgd2lk dGg6IDEwMDAwcHg7CiAgICAgIGhlaWdodDogMTAwcHg7CiAgICAgIGJhY2tncm91bmQtY29sb3I6 IGdyZWVuOwogICAgfQogICAgCiAgICAuaW5kaWNhdG9yIHsKICAgICAgcG9zaXRpb246IGFic29s dXRlOwogICAgICB0b3A6IDIxcHg7CiAgICAgIGxlZnQ6IDIxcHg7CiAgICAgIHdpZHRoOiAxMDBw eDsKICAgICAgaGVpZ2h0OiAxMDBweDsKICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmVkOwogICAg fQogIDwvc3R5bGU+CiAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0 Zi04Ij4KICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53 YWl0VW50aWxEb25lKCk7CiAgICB9CgogICAgZnVuY3Rpb24gZG9UZXN0KCkKICAgIHsKICAgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdsYXllcnMnKS5pbm5lclRleHQgPSBsYXlvdXRUZXN0Q29udHJvbGxlci5sYXll clRyZWVBc1RleHQoKTsKICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7 CiAgICAgIH0KICAgIH0KCiAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGRvVGVz dCwgZmFsc2UpOwogIDwvc2NyaXB0Pgo8L2hlYWQ+Cgo8Ym9keSBzdHlsZT0iLXdlYmtpdC13cml0 aW5nLW1vZGU6dmVydGljYWwtcmw7Ij4KICAKICA8IS0tIEdvIGludG8gY29tcG9zaXRpbmcgd2l0 aG91dCB0cmFuc2Zvcm1zLiAtLT4KICA8dmlkZW8gc3JjPSIuLi9yZXNvdXJjZXMvdmlkZW8ubXA0 Ij48L3ZpZGVvPgoKICA8ZGl2IGNsYXNzPSJpbmRpY2F0b3IiPjwvZGl2PgoKICA8IS0tIFRlc3Qg Y2xpcHBpbmcgdG8gdmlld3BvcnQgd2l0aCBzb21lIGludGVybWVkaWF0ZSBsYXllcnMuIC0tPgog IDxkaXYgY2xhc3M9ImNvbnRhaW5lciI+CiAgICA8ZGl2IGNsYXNzPSJmYXItbGVmdCI+CiAgICAg IFRleHQgaGVyZQogICAgPC9kaXY+CiAgPC9kaXY+CiAgPHByZSBpZD0ibGF5ZXJzIj5MYXllciB0 cmVlIGdvZXMgaGVyZSBpbiBEUlQ8L3ByZT4KPC9ib2R5Pgo8L2h0bWw+Cgo= 142624 2012-05-17 21:15:31 -0700 2012-05-17 21:26:39 -0700 Account for flipped writing modes in RenderLayer::calculateLayerBounds() 11419933_r1.diff text/plain 3993 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzUzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTE3ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExNDE5 OTMzPiBQcm9ibGVtcyB3aXRoIGZsaXBwZWQgd3JpdGluZyBtb2RlcyBhbmQgY29tcG9zaXRpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MDMyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogY29t cG9zaXRpbmcvYm91bmRzLWluLWZsaXBwZWQtd3JpdGluZy1tb2RlLmh0bWwKKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXll cjo6Y2FsY3VsYXRlTGF5ZXJCb3VuZHMpOiBBcHBseSBhIHdyaXRpbmctbW9kZSBmbGlwIHRvIHRo ZSBib3VuZGluZyBib3gKKyAgICAgICAgaWYgbmVlZGVkLgorCiAyMDEyLTA1LTE3ICBLZW50YXJv IEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdW1JlZmFjdG9yaW5n XSBSZW1vdmUgVjhQcm94eTo6dGhyb3dFcnJvcihjb25zdCBjaGFyKiwgdjg6Oklzb2xhdGUqID0g MCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNp b24gMTE3NTI4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNDE0OSw4ICs0MTQ5LDEzIEBAIEludFJlY3QgUmVuZGVyTGF5ZXI6 OmNhbGN1bGF0ZUxheWVyQm91bmQKIHsKICAgICBpZiAoIWxheWVyLT5pc1NlbGZQYWludGluZ0xh eWVyKCkpCiAgICAgICAgIHJldHVybiBJbnRSZWN0KCk7Ci0gICAgCisKICAgICBMYXlvdXRSZWN0 IGJvdW5kaW5nQm94UmVjdCA9IGxheWVyLT5sb2NhbEJvdW5kaW5nQm94KCk7CisgICAgaWYgKGxh eWVyLT5yZW5kZXJlcigpLT5pc0JveCgpKQorICAgICAgICBsYXllci0+cmVuZGVyQm94KCktPmZs aXBGb3JXcml0aW5nTW9kZShib3VuZGluZ0JveFJlY3QpOworICAgIGVsc2UKKyAgICAgICAgbGF5 ZXItPnJlbmRlcmVyKCktPmNvbnRhaW5pbmdCbG9jaygpLT5mbGlwRm9yV3JpdGluZ01vZGUoYm91 bmRpbmdCb3hSZWN0KTsKKwogICAgIGlmIChsYXllci0+cmVuZGVyZXIoKS0+aXNSb290KCkpIHsK ICAgICAgICAgLy8gSWYgdGhlIHJvb3QgbGF5ZXIgYmVjb21lcyBjb21wb3NpdGVkIChlLmcuIGJl Y2F1c2Ugc29tZSBkZXNjZW5kYW50IHdpdGggbmVnYXRpdmUgei1pbmRleCBpcyBjb21wb3NpdGVk KSwKICAgICAgICAgLy8gdGhlbiBpdCBoYXMgdG8gYmUgYmlnIGVub3VnaCB0byBjb3ZlciB0aGUg dmlld3BvcnQgaW4gb3JkZXIgdG8gZGlzcGxheSB0aGUgYmFja2dyb3VuZC4gVGhpcyBpcyBha2lu CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAxMTc1MzYpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNS0xNyAgRGFuIEJlcm5zdGVpbiAg PG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTQxOTkzMz4gUHJv YmxlbXMgd2l0aCBmbGlwcGVkIHdyaXRpbmcgbW9kZXMgYW5kIGNvbXBvc2l0aW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjAzMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29tcG9zaXRpbmcvYm91 bmRzLWluLWZsaXBwZWQtd3JpdGluZy1tb2RlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogY29tcG9zaXRpbmcvYm91bmRzLWluLWZsaXBwZWQtd3JpdGluZy1tb2RlLmh0bWw6IEFkZGVk LgorCiAyMDEyLTA1LTE3ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBbY2hyb21pdW1dIFBydW5lIHVubmVjZXNzYXJ5IGZhaWx1cmUgZXhwZWN0YXRpb25z LgpJbmRleDogTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvYm91bmRzLWluLWZsaXBwZWQtd3JpdGlu Zy1tb2RlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9jb21wb3NpdGlu Zy9ib3VuZHMtaW4tZmxpcHBlZC13cml0aW5nLW1vZGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvYm91bmRzLWluLWZsaXBwZWQtd3JpdGluZy1t b2RlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNyBAQAorKEdyYXBoaWNz TGF5ZXIKKyAgKGJvdW5kcyA4MDAuMDAgNjAwLjAwKQorICAoY2hpbGRyZW4gMQorICAgIChHcmFw aGljc0xheWVyCisgICAgICAoYm91bmRzIDgwMC4wMCA2MDAuMDApCisgICAgICAoY2hpbGRyZW4g MQorICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgIChwb3NpdGlvbiAxMDAuMDAgMTAw LjAwKQorICAgICAgICAgIChhbmNob3IgMC41MCAwLjc1KQorICAgICAgICAgIChib3VuZHMgMTAw LjAwIDIwMC4wMCkKKyAgICAgICAgICAoZHJhd3NDb250ZW50IDEpCisgICAgICAgICkKKyAgICAg ICkKKyAgICApCisgICkKKykKKwpJbmRleDogTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvYm91bmRz LWluLWZsaXBwZWQtd3JpdGluZy1tb2RlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Y29tcG9zaXRpbmcvYm91bmRzLWluLWZsaXBwZWQtd3JpdGluZy1tb2RlLmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9jb21wb3NpdGluZy9ib3VuZHMtaW4tZmxpcHBlZC13cml0aW5n LW1vZGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPGJvZHkgc3R5bGU9Im1h cmdpbjogMDsgcGFkZGluZzogMTAwcHg7Ij4KKyAgICA8ZGl2IHN0eWxlPSJ3aWR0aDogMTAwcHg7 IGhlaWdodDogMTAwcHg7IGJhY2tncm91bmQtY29sb3I6IHJlZDsiPjwvZGl2PgorICAgIDxkaXYg c3R5bGU9IndpZHRoOiAxMDBweDsgaGVpZ2h0OiAxMDBweDsgLXdlYmtpdC13cml0aW5nLW1vZGU6 IGhvcml6b250YWwtYnQ7IC13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGV6KDApIj4KKyAgICAg ICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1tYXJnaW4tYmVmb3JlOiAxMDBweDsgaGVpZ2h0OiAxMDBw eDsgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKyAgICA8cHJl IGlkPSJjb25zb2xlIj48L3ByZT4KKyAgICA8c2NyaXB0PgorICAgICAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CisgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29s ZSIpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKGxheW91dFRlc3RDb250cm9s bGVyLmxheWVyVHJlZUFzVGV4dCgpKSk7CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvYm9k eT4K