86030 2012-05-09 16:05:10 -0700 [Chromium] LayoutTestController should use ENABLE guards for some features 2012-05-09 17:14:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth eric johnme peter tkent webkit.review.bot oldest_to_newest 619958 0 abarth 2012-05-09 16:05:10 -0700 [Chromium] LayoutTestController should use ENABLE guards for some features 619960 1 141041 abarth 2012-05-09 16:05:56 -0700 Created attachment 141041 Patch 619965 2 141041 eric 2012-05-09 16:07:23 -0700 Comment on attachment 141041 Patch I didn't even know you could use ENABLE guards in DRT?!? 620071 3 141041 webkit.review.bot 2012-05-09 17:14:31 -0700 Comment on attachment 141041 Patch Clearing flags on attachment: 141041 Committed r116581: <http://trac.webkit.org/changeset/116581> 620073 4 webkit.review.bot 2012-05-09 17:14:36 -0700 All reviewed patches have been landed. Closing bug. 141041 2012-05-09 16:05:56 -0700 2012-05-09 17:14:31 -0700 Patch bug-86030-20120509160555.patch text/plain 7225 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNjU3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTA1LTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0Nocm9taXVtXSBMYXlvdXRUZXN0Q29udHJvbGxlciBzaG91bGQgdXNlIEVOQUJM RSBndWFyZHMgZm9yIHNvbWUgZmVhdHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg2MDMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlc2UgZmVhdHVyZXMgYXJlIGRpc2FibGVkIG9uIE9TKEFORFJP SUQpIGFuZCBzbyBzaG91bGRuJ3QgYmUgY29tcGlsZWQKKyAgICAgICAgd2hlbiB0aGUgZmVhdHVy ZSBpcyBvZmYuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0 Q29udHJvbGxlci5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6TGF5b3V0VGVz dENvbnRyb2xsZXIpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRl c3RDb250cm9sbGVyLmg6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcik6CisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmg6CisgICAgICAgIChUZXN0U2hl bGwpOgorCiAyMDEyLTA1LTA5ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFdoZW4gY3JlYXRpbmcgYSBuZXcgcGFnZSBkdXJpbmcgYSBuYXZpZ2F0aW9u LCBwcmltZSB0aGUgaW5pdGlhbCBkb2N1bWVudCB3aXRoIHRoZSBjb3JyZWN0IHJlZmVycmVyIHBv bGljeQpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRy b2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xh eW91dFRlc3RDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMTE2NTI1KQorKysgVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC05Myw4ICs5MywxMCBAQCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6TGF5b3V0VGVzdENvbnRy b2xsCiAgICAgLy8gbmFtZXMgdG8gdGhlaXIgbWV0aG9kcyB3aWxsIGJlIGRvbmUgYnkgY2FsbGlu ZyBiaW5kVG9KYXZhU2NyaXB0KCkgKGRlZmluZWQKICAgICAvLyBieSBDcHBCb3VuZENsYXNzLCB0 aGUgcGFyZW50IHRvIExheW91dFRlc3RDb250cm9sbGVyKS4KICAgICBiaW5kTWV0aG9kKCJhZGRG aWxlVG9QYXN0ZWJvYXJkT25EcmFnIiwgJkxheW91dFRlc3RDb250cm9sbGVyOjphZGRGaWxlVG9Q YXN0ZWJvYXJkT25EcmFnKTsKKyNpZiBFTkFCTEUoSU5QVVRfU1BFRUNIKQogICAgIGJpbmRNZXRo b2QoImFkZE1vY2tTcGVlY2hJbnB1dFJlc3VsdCIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6YWRk TW9ja1NwZWVjaElucHV0UmVzdWx0KTsKICAgICBiaW5kTWV0aG9kKCJzZXRNb2NrU3BlZWNoSW5w dXREdW1wUmVjdCIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0TW9ja1NwZWVjaElucHV0RHVt cFJlY3QpOworI2VuZGlmCiAgICAgYmluZE1ldGhvZCgiYWRkT3JpZ2luQWNjZXNzV2hpdGVsaXN0 RW50cnkiLCAmTGF5b3V0VGVzdENvbnRyb2xsZXI6OmFkZE9yaWdpbkFjY2Vzc1doaXRlbGlzdEVu dHJ5KTsKICAgICBiaW5kTWV0aG9kKCJhZGRVc2VyU2NyaXB0IiwgJkxheW91dFRlc3RDb250cm9s bGVyOjphZGRVc2VyU2NyaXB0KTsKICAgICBiaW5kTWV0aG9kKCJhZGRVc2VyU3R5bGVTaGVldCIs ICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6YWRkVXNlclN0eWxlU2hlZXQpOwpAQCAtMTMyLDcgKzEz NCw5IEBAIExheW91dFRlc3RDb250cm9sbGVyOjpMYXlvdXRUZXN0Q29udHJvbGwKICAgICBiaW5k TWV0aG9kKCJzZXRJc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW4iLCAmTGF5b3V0VGVzdENvbnRy b2xsZXI6OnNldElzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbik7CiAgICAgYmluZE1ldGhvZCgi ZXhlY0NvbW1hbmQiLCAmTGF5b3V0VGVzdENvbnRyb2xsZXI6OmV4ZWNDb21tYW5kKTsKICAgICBi aW5kTWV0aG9kKCJmb3JjZVJlZFNlbGVjdGlvbkNvbG9ycyIsICZMYXlvdXRUZXN0Q29udHJvbGxl cjo6Zm9yY2VSZWRTZWxlY3Rpb25Db2xvcnMpOworI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQog ICAgIGJpbmRNZXRob2QoImdyYW50RGVza3RvcE5vdGlmaWNhdGlvblBlcm1pc3Npb24iLCAmTGF5 b3V0VGVzdENvbnRyb2xsZXI6OmdyYW50RGVza3RvcE5vdGlmaWNhdGlvblBlcm1pc3Npb24pOwor I2VuZGlmCiAgICAgYmluZE1ldGhvZCgiZmluZFN0cmluZyIsICZMYXlvdXRUZXN0Q29udHJvbGxl cjo6ZmluZFN0cmluZyk7CiAgICAgYmluZE1ldGhvZCgiaXNDb21tYW5kRW5hYmxlZCIsICZMYXlv dXRUZXN0Q29udHJvbGxlcjo6aXNDb21tYW5kRW5hYmxlZCk7CiAgICAgYmluZE1ldGhvZCgiaGFz Q3VzdG9tUGFnZVNpemVTdHlsZSIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6aGFzQ3VzdG9tUGFn ZVNpemVTdHlsZSk7CkBAIC0yMTAsNyArMjE0LDkgQEAgTGF5b3V0VGVzdENvbnRyb2xsZXI6Okxh eW91dFRlc3RDb250cm9sbAogICAgIGJpbmRNZXRob2QoInNldFhTU0F1ZGl0b3JFbmFibGVkIiwg JkxheW91dFRlc3RDb250cm9sbGVyOjpzZXRYU1NBdWRpdG9yRW5hYmxlZCk7CiAgICAgYmluZE1l dGhvZCgic2V0QXN5bmNocm9ub3VzU3BlbGxDaGVja2luZ0VuYWJsZWQiLCAmTGF5b3V0VGVzdENv bnRyb2xsZXI6OnNldEFzeW5jaHJvbm91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKTsKICAgICBiaW5k TWV0aG9kKCJzaG93V2ViSW5zcGVjdG9yIiwgJkxheW91dFRlc3RDb250cm9sbGVyOjpzaG93V2Vi SW5zcGVjdG9yKTsKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKICAgICBiaW5kTWV0aG9kKCJz aW11bGF0ZURlc2t0b3BOb3RpZmljYXRpb25DbGljayIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6 c2ltdWxhdGVEZXNrdG9wTm90aWZpY2F0aW9uQ2xpY2spOworI2VuZGlmCiAgICAgYmluZE1ldGhv ZCgic3RhcnRTcGVlY2hJbnB1dCIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6c3RhcnRTcGVlY2hJ bnB1dCk7CiAgICAgYmluZE1ldGhvZCgic3VzcGVuZEFuaW1hdGlvbnMiLCAmTGF5b3V0VGVzdENv bnRyb2xsZXI6OnN1c3BlbmRBbmltYXRpb25zKTsKICAgICBiaW5kTWV0aG9kKCJ0ZXN0UmVwYWlu dCIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6dGVzdFJlcGFpbnQpOwpAQCAtMTE4Niw2ICsxMTky LDcgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6Y2FsbFNob3VsZENsbwogICAgIHJlc3Vs dC0+c2V0KG1fc2hlbGwtPndlYlZpZXcoKS0+ZGlzcGF0Y2hCZWZvcmVVbmxvYWRFdmVudCgpKTsK IH0KIAorI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6Z3JhbnREZXNrdG9wTm90aWZpY2F0aW9uUGVybWlzc2lvbihjb25zdCBDcHBBcmd1bWVudExp c3QmIGFyZ3VtZW50cywgQ3BwVmFyaWFudCogcmVzdWx0KQogewogICAgIGlmIChhcmd1bWVudHMu c2l6ZSgpICE9IDEgfHwgIWFyZ3VtZW50c1swXS5pc1N0cmluZygpKSB7CkBAIC0xMjExLDYgKzEy MTgsNyBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzaW11bGF0ZURlc2t0CiAjZW5kaWYK ICAgICAgICAgcmVzdWx0LT5zZXQoZmFsc2UpOwogfQorI2VuZGlmCiAKIHZvaWQgTGF5b3V0VGVz dENvbnRyb2xsZXI6OnNldERvbWFpblJlbGF4YXRpb25Gb3JiaWRkZW5Gb3JVUkxTY2hlbWUoY29u c3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3VsdCkKIHsKQEAg LTE5NjAsNiArMTk2OCw3IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmFib3J0TW9kYWwo Y28KICAgICByZXN1bHQtPnNldE51bGwoKTsKIH0KIAorI2lmIEVOQUJMRShJTlBVVF9TUEVFQ0gp CiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjphZGRNb2NrU3BlZWNoSW5wdXRSZXN1bHQoY29u c3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3VsdCkKIHsKICAg ICByZXN1bHQtPnNldE51bGwoKTsKQEAgLTE5NzksNiArMTk4OCw3IEBAIHZvaWQgTGF5b3V0VGVz dENvbnRyb2xsZXI6OnNldE1vY2tTcGVlY2gKICAgICBpZiAoTW9ja1dlYlNwZWVjaElucHV0Q29u dHJvbGxlciogY29udHJvbGxlciA9IG1fc2hlbGwtPndlYlZpZXdIb3N0KCktPnNwZWVjaElucHV0 Q29udHJvbGxlck1vY2soKSkKICAgICAgICAgY29udHJvbGxlci0+c2V0RHVtcFJlY3QoYXJndW1l bnRzWzBdLnZhbHVlLmJvb2xWYWx1ZSk7CiB9CisjZW5kaWYKIAogdm9pZCBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6c3RhcnRTcGVlY2hJbnB1dChjb25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50 cywgQ3BwVmFyaWFudCogcmVzdWx0KQogewpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCShyZXZpc2lvbiAxMTY1MjUp CisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5o CSh3b3JraW5nIGNvcHkpCkBAIC0yNDksMTAgKzI0OSwxMiBAQCBwdWJsaWM6CiAgICAgdm9pZCBz ZXRJY29uRGF0YWJhc2VFbmFibGVkKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYsIENwcFZhcmlhbnQq KTsKICAgICB2b2lkIGR1bXBTZWxlY3Rpb25SZWN0KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYsIENw cFZhcmlhbnQqKTsKIAorI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQogICAgIC8vIEdyYW50cyBw ZXJtaXNzaW9uIGZvciBkZXNrdG9wIG5vdGlmaWNhdGlvbnMgdG8gYW4gb3JpZ2luCiAgICAgdm9p ZCBncmFudERlc2t0b3BOb3RpZmljYXRpb25QZXJtaXNzaW9uKGNvbnN0IENwcEFyZ3VtZW50TGlz dCYsIENwcFZhcmlhbnQqKTsKICAgICAvLyBTaW11bGF0ZXMgYSBjbGljayBvbiBhIGRlc2t0b3Ag bm90aWZpY2F0aW9uLgogICAgIHZvaWQgc2ltdWxhdGVEZXNrdG9wTm90aWZpY2F0aW9uQ2xpY2so Y29uc3QgQ3BwQXJndW1lbnRMaXN0JiwgQ3BwVmFyaWFudCopOworI2VuZGlmCiAKICAgICB2b2lk IHNldERvbWFpblJlbGF4YXRpb25Gb3JiaWRkZW5Gb3JVUkxTY2hlbWUoY29uc3QgQ3BwQXJndW1l bnRMaXN0JiwgQ3BwVmFyaWFudCopOwogICAgIHZvaWQgc2V0RGVmZXJNYWluUmVzb3VyY2VEYXRh TG9hZChjb25zdCBDcHBBcmd1bWVudExpc3QmLCBDcHBWYXJpYW50Kik7CkBAIC0zNzQsOCArMzc2 LDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIGFib3J0TW9kYWwoY29uc3QgQ3BwQXJndW1lbnRMaXN0 JiwgQ3BwVmFyaWFudCopOwogCiAgICAgLy8gU3BlZWNoIGlucHV0IHJlbGF0ZWQgZnVuY3Rpb25z LgorI2lmIEVOQUJMRShJTlBVVF9TUEVFQ0gpCiAgICAgdm9pZCBhZGRNb2NrU3BlZWNoSW5wdXRS ZXN1bHQoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiwgQ3BwVmFyaWFudCopOwogICAgIHZvaWQgc2V0 TW9ja1NwZWVjaElucHV0RHVtcFJlY3QoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiwgQ3BwVmFyaWFu dCopOworI2VuZGlmCiAgICAgdm9pZCBzdGFydFNwZWVjaElucHV0KGNvbnN0IENwcEFyZ3VtZW50 TGlzdCYsIENwcFZhcmlhbnQqKTsKIAogICAgIHZvaWQgbGF5ZXJUcmVlQXNUZXh0KGNvbnN0IENw cEFyZ3VtZW50TGlzdCYgYXJncywgQ3BwVmFyaWFudCogcmVzdWx0KTsKSW5kZXg6IFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5oCShyZXZpc2lvbiAxMTY1MjUpCisrKyBU b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaAkod29ya2luZyBjb3B5KQpA QCAtOTUsNyArOTUsOSBAQCBwdWJsaWM6CiAgICAgRXZlbnRTZW5kZXIqIGV2ZW50U2VuZGVyKCkg Y29uc3QgeyByZXR1cm4gbV9ldmVudFNlbmRlci5nZXQoKTsgfQogICAgIEFjY2Vzc2liaWxpdHlD b250cm9sbGVyKiBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlcigpIGNvbnN0IHsgcmV0dXJuIG1fYWNj ZXNzaWJpbGl0eUNvbnRyb2xsZXIuZ2V0KCk7IH0KICAgICBHYW1lcGFkQ29udHJvbGxlciogZ2Ft ZXBhZENvbnRyb2xsZXIoKSBjb25zdCB7IHJldHVybiBtX2dhbWVwYWRDb250cm9sbGVyLmdldCgp OyB9CisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCiAgICAgTm90aWZpY2F0aW9uUHJlc2VudGVy KiBub3RpZmljYXRpb25QcmVzZW50ZXIoKSBjb25zdCB7IHJldHVybiBtX25vdGlmaWNhdGlvblBy ZXNlbnRlci5nZXQoKTsgfQorI2VuZGlmCiAgICAgVGVzdEV2ZW50UHJpbnRlciogcHJpbnRlcigp IGNvbnN0IHsgcmV0dXJuIG1fcHJpbnRlci5nZXQoKTsgfQogCiAgICAgV2ViUHJlZmVyZW5jZXMq IHByZWZlcmVuY2VzKCkgeyByZXR1cm4gJm1fcHJlZnM7IH0KQEAgLTIxNyw3ICsyMTksOSBAQCBw cml2YXRlOgogICAgIE93blB0cjxFdmVudFNlbmRlcj4gbV9ldmVudFNlbmRlcjsKICAgICBPd25Q dHI8TGF5b3V0VGVzdENvbnRyb2xsZXI+IG1fbGF5b3V0VGVzdENvbnRyb2xsZXI7CiAgICAgT3du UHRyPFRleHRJbnB1dENvbnRyb2xsZXI+IG1fdGV4dElucHV0Q29udHJvbGxlcjsKKyNpZiBFTkFC TEUoTk9USUZJQ0FUSU9OUykgfHwgRU5BQkxFKExFR0FDWV9OT1RJRklDQVRJT05TKQogICAgIE93 blB0cjxOb3RpZmljYXRpb25QcmVzZW50ZXI+IG1fbm90aWZpY2F0aW9uUHJlc2VudGVyOworI2Vu ZGlmCiAgICAgT3duUHRyPFdlYlZpZXdIb3N0PiBtX3dlYlZpZXdIb3N0OwogICAgIE93blB0cjxX ZWJLaXQ6OldlYlRocmVhZD4gbV93ZWJDb21wb3NpdG9yVGhyZWFkOwogCg==