86011 2012-05-09 13:26:54 -0700 CopiedSpace does not add pinned blocks back to the to-space filter 2012-05-09 15:49:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg ggaren oldest_to_newest 619781 0 mhahnenberg 2012-05-09 13:26:54 -0700 After a collection has finished, we go through the blocks in from-space and move any of them that are pinned into to-space. At the beginning of collection, we reset the to-space block filter that is used during conservative scanning and add back the blocks that are filled during the collection. However, we neglect to add back those blocks that are moved from from-space to to-space, which can cause the conservative scan to think that some pinned items are not actually in CopiedSpace. 619789 1 141007 mhahnenberg 2012-05-09 13:33:59 -0700 Created attachment 141007 Patch 619902 2 141007 ggaren 2012-05-09 15:18:09 -0700 Comment on attachment 141007 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141007&action=review r=me Please add Radar link > Source/JavaScriptCore/heap/CopiedSpace.cpp:186 > + // We don't add the block to the toSpaceSet because it was never removed. You should ASSERT this condition. 619911 3 mhahnenberg 2012-05-09 15:25:43 -0700 <rdar://problem/11417840> 619938 4 mhahnenberg 2012-05-09 15:49:52 -0700 Committed r116565: <http://trac.webkit.org/changeset/116565> 141007 2012-05-09 13:33:59 -0700 2012-05-09 15:18:09 -0700 Patch bug-86011-20120509133358.patch text/plain 2254 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 YzY2MDY2ZTI4OWUyMGEyM2Q0NWY5MDFhODJkNWMzNjNlMTI4YTIxLi43Y2NkNzdlYWI0NDM0MzQx ZTkxOWExMWNhMjlmNzAyNTM5OTI2M2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxMi0wNS0wOSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBw bGUuY29tPgorCisgICAgICAgIENvcGllZFNwYWNlIGRvZXMgbm90IGFkZCBwaW5uZWQgYmxvY2tz IGJhY2sgdG8gdGhlIHRvLXNwYWNlIGZpbHRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYwMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZnRlciBhIGNvbGxlY3Rpb24gaGFzIGZpbmlzaGVkLCB3ZSBn byB0aHJvdWdoIHRoZSBibG9ja3MgaW4gZnJvbS1zcGFjZSAKKyAgICAgICAgYW5kIG1vdmUgYW55 IG9mIHRoZW0gdGhhdCBhcmUgcGlubmVkIGludG8gdG8tc3BhY2UuIEF0IHRoZSBiZWdpbm5pbmcg b2YgCisgICAgICAgIGNvbGxlY3Rpb24sIHdlIHJlc2V0IHRoZSB0by1zcGFjZSBibG9jayBmaWx0 ZXIgdGhhdCBpcyB1c2VkIGR1cmluZyAKKyAgICAgICAgY29uc2VydmF0aXZlIHNjYW5uaW5nIGFu ZCBhZGQgYmFjayB0aGUgYmxvY2tzIHRoYXQgYXJlIGZpbGxlZCBkdXJpbmcgdGhlIAorICAgICAg ICBjb2xsZWN0aW9uLiBIb3dldmVyLCB3ZSBuZWdsZWN0IHRvIGFkZCBiYWNrIHRob3NlIGJsb2Nr cyB0aGF0IGFyZSBtb3ZlZCAKKyAgICAgICAgZnJvbSBmcm9tLXNwYWNlIHRvIHRvLXNwYWNlLCB3 aGljaCBjYW4gY2F1c2UgdGhlIGNvbnNlcnZhdGl2ZSBzY2FuIHRvIAorICAgICAgICB0aGluayB0 aGF0IHNvbWUgcGlubmVkIGl0ZW1zIGFyZSBub3QgYWN0dWFsbHkgaW4gQ29waWVkU3BhY2UuCisK KyAgICAgICAgKiBoZWFwL0NvcGllZFNwYWNlLmNwcDoKKyAgICAgICAgKEpTQzo6Q29waWVkU3Bh Y2U6OmRvbmVDb3B5aW5nKTogQWRkIHRoZSBwaW5uZWQgYmxvY2tzIGJhY2sgdG8gdGhlIAorICAg ICAgICB0by1zcGFjZSBmaWx0ZXIuIEFsc28gYWRkZWQgYSBjb21tZW50IGZvciBmdXR1cmUgcmVh ZGVycyB0aGF0IAorICAgICAgICBpbmRpY2F0ZXMgdGhhdCBpdCdzIG9rYXkgdGhhdCB3ZSBkb24n dCBhbHNvIGFkZCB0aGUgYmxvY2sgdG8gdGhlIAorICAgICAgICB0by1zcGFjZSBibG9jayBzZXQg c2luY2UgaXQgd2FzIG5ldmVyIHJlbW92ZWQuCisKIDIwMTItMDUtMDggIE1hcmsgSGFobmVuYmVy ZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBIZWFwIHNob3VsZCBub3QgY29u dGludWFsbHkgYWxsb2NhdGUgbmV3IHBhZ2VzIGluIHN0ZWFkeSBzdGF0ZQpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2UuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2UuY3BwCmluZGV4IDVlZmQwNDM4OTQ2ZTdiODg1M2Yw MmRlYzU4YzhmOTIyMGY1NjExYTguLmYzZTIzNmIzZmEyMmI5YmRiYTM1MTgyODM0OGY5MTI0Y2Yw MTYyM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZFNwYWNl LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRTcGFjZS5jcHAKQEAg LTE4Myw2ICsxODMsOCBAQCB2b2lkIENvcGllZFNwYWNlOjpkb25lQ29weWluZygpCiAgICAgICAg IENvcGllZEJsb2NrKiBibG9jayA9IHN0YXRpY19jYXN0PENvcGllZEJsb2NrKj4obV9mcm9tU3Bh Y2UtPnJlbW92ZUhlYWQoKSk7CiAgICAgICAgIGlmIChibG9jay0+bV9pc1Bpbm5lZCkgewogICAg ICAgICAgICAgYmxvY2stPm1faXNQaW5uZWQgPSBmYWxzZTsKKyAgICAgICAgICAgIC8vIFdlIGRv bid0IGFkZCB0aGUgYmxvY2sgdG8gdGhlIHRvU3BhY2VTZXQgYmVjYXVzZSBpdCB3YXMgbmV2ZXIg cmVtb3ZlZC4KKyAgICAgICAgICAgIG1fdG9TcGFjZUZpbHRlci5hZGQocmVpbnRlcnByZXRfY2Fz dDxCaXRzPihibG9jaykpOwogICAgICAgICAgICAgbV90b1NwYWNlLT5wdXNoKGJsb2NrKTsKICAg ICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9Cg==