86009 2012-05-09 12:45:02 -0700 Remove some isSVGFoo methods 2012-05-09 14:19:30 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis eric pdr webkit.review.bot zimmermann oldest_to_newest 619739 0 rwlbuis 2012-05-09 12:45:02 -0700 Stuff like isRounded() is not needed at all atm. 619750 1 141000 rwlbuis 2012-05-09 12:49:58 -0700 Created attachment 141000 Patch 619761 2 pdr 2012-05-09 13:06:30 -0700 I would give this a R+ if I could. 619770 3 141000 eric 2012-05-09 13:18:06 -0700 Comment on attachment 141000 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review > Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42 > - virtual bool isSVGEllipse() const { return true; } Is there one of these on teh base class as well? 619773 4 rwlbuis 2012-05-09 13:21:33 -0700 Hi Eric, Thanks for the review! (In reply to comment #3) > (From update of attachment 141000 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review > > > Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42 > > - virtual bool isSVGEllipse() const { return true; } > > Is there one of these on teh base class as well? Nope, there was a mention of isSVGRect in RenderObject.h but not isSVGEllipse, a sure sign that some of these flags got inconsistent. 619822 5 141000 webkit.review.bot 2012-05-09 14:19:25 -0700 Comment on attachment 141000 Patch Clearing flags on attachment: 141000 Committed r116557: <http://trac.webkit.org/changeset/116557> 619823 6 webkit.review.bot 2012-05-09 14:19:30 -0700 All reviewed patches have been landed. Closing bug. 141000 2012-05-09 12:49:58 -0700 2012-05-09 14:19:25 -0700 Patch bug-86009-20120509154956.patch text/plain 3333 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGYxNjlkMDk2YWQxM2Rh YzcyZTYzMGYyZDZhNzY3NjhkZDNlMjZkMy4uMDM1NTUyNmFjMzJiODRmZDA2ZGFjNTAzODk4NDAy NmNlN2UwMjAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTA5ICBSb2Ig QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNvbWUgaXNTVkdGb28gbWV0 aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYw MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVz ZSBhcmUgbm90IHVzZWQgYXQgdGhlIG1vbWVudCBhbmQgd2VyZSBwcm9iYWJseSBqdXN0IGNvcHkg YW5kIHBhc3RlZCBmcm9tCisgICAgICAgIGlzU1ZHRm9vIG1ldGhvZHMgaW4gUmVuZGVyT2JqZWN0 LmguCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6CisgICAgICAgICogcmVu ZGVyaW5nL3N2Zy9SZW5kZXJTVkdFbGxpcHNlLmg6CisgICAgICAgIChSZW5kZXJTVkdFbGxpcHNl KToKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1JlY3QuaDoKKyAgICAgICAgKFJl bmRlclNWR1JlY3QpOgorICAgICAgICAqIHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHU2hhcGUuaDoK KwogMjAxMi0wNS0wOSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2 ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFNpbXBsaWZ5IENTU1BhcnNlcjo6cGFyc2VT aW1wbGVMZW5ndGhWYWx1ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyT2JqZWN0LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgK aW5kZXggMzk1MDJlYzE0NjE3NzdkZWQ0ZDVkYTJmYzg0NWZjYjdlNjc0ZGM3OS4uNzg4YWJhZGFk MjFiZTllNjViYzVhZjM1Y2I3ZTM1NWZjNjk5ODcyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJPYmplY3QuaApAQCAtNDE3LDcgKzQxNyw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IGJvb2wgaXNTVkdHcmFkaWVudFN0b3AoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZp cnR1YWwgYm9vbCBpc1NWR0hpZGRlbkNvbnRhaW5lcigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CiAgICAgdmlydHVhbCBib29sIGlzU1ZHUGF0aCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0g ICAgdmlydHVhbCBib29sIGlzU1ZHUmVjdCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAg dmlydHVhbCBib29sIGlzU1ZHU2hhcGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZp cnR1YWwgYm9vbCBpc1NWR1RleHQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1 YWwgYm9vbCBpc1NWR1RleHRQYXRoKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHRWxsaXBzZS5oIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdFbGxpcHNlLmgKaW5kZXggNzYyOTVj Njg2NDQxMDc1MGYzNDJiNzNjMzQwY2Q4MGQ4Mzg0ODU4NC4uMzcyMGU5YTMxNmQyMThhZDQzOWUy OGMxMmZkZWVjODA4YzI1YmI3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9SZW5kZXJTVkdFbGxpcHNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2 Zy9SZW5kZXJTVkdFbGxpcHNlLmgKQEAgLTM5LDcgKzM5LDYgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgflJlbmRlclNWR0VsbGlwc2UoKTsKIAogcHJpdmF0ZToKLSAgICB2aXJ0dWFsIGJvb2wgaXNT VkdFbGxpcHNlKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgY29uc3QgY2hh ciogcmVuZGVyTmFtZSgpIGNvbnN0IHsgcmV0dXJuICJSZW5kZXJTVkdFbGxpcHNlIjsgfQogCiAg ICAgdmlydHVhbCB2b2lkIGNyZWF0ZVNoYXBlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1JlY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zdmcvUmVuZGVyU1ZHUmVjdC5oCmluZGV4IGFiNmViMjM0MzYwYmJmYmJlMzlkZTJiNjEzZDI5 MjI5M2Q1ZmMzNWYuLmJkMjE1MzhjMjA2NmMzNTlmNmQyMTBkMzI1OGY1NmRkM2FkNGY5ODAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVjdC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVjdC5oCkBAIC00MCw3 ICs0MCw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5SZW5kZXJTVkdSZWN0KCk7CiAKIHByaXZh dGU6Ci0gICAgdmlydHVhbCBib29sIGlzU1ZHUmVjdCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0K ICAgICB2aXJ0dWFsIGNvbnN0IGNoYXIqIHJlbmRlck5hbWUoKSBjb25zdCB7IHJldHVybiAiUmVu ZGVyU1ZHUmVjdCI7IH0KIAogICAgIHZpcnR1YWwgdm9pZCBjcmVhdGVTaGFwZSgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFwZS5oIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFwZS5oCmluZGV4IGFiOWIxY2I1 YWFjNDI2MGVmYTlmZjM0NTdhZDYzMzNlYmVhMWYyZTMuLjM4MTQxMjljNGZhMWRlNDM4MDIwMjA2 YjE2MmI3M2FjNDhkNGU0YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dmcvUmVuZGVyU1ZHU2hhcGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1Jl bmRlclNWR1NoYXBlLmgKQEAgLTEwOSw3ICsxMDksNiBAQCBwcml2YXRlOgogCiAgICAgdmlydHVh bCBib29sIGlzU1ZHU2hhcGUoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCBj b25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3QgeyByZXR1cm4gIlJlbmRlclNWR1NoYXBlIjsg fQotICAgIHZpcnR1YWwgYm9vbCBpc1JvdW5kZWRSZWN0KCkgeyByZXR1cm4gZmFsc2U7IH0KIAog ICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKTsKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoUGFpbnRJ bmZvJiwgY29uc3QgTGF5b3V0UG9pbnQmKTsK