86005 2012-05-09 10:54:14 -0700 [GTK] Missing field initializers for WKPageLoaderClient 2012-05-10 09:32:48 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 spena webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 619644 0 spena 2012-05-09 10:54:14 -0700 Building WK2 currently outputs the following warnings: ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp: In function ‘void attachLoaderClientToView(WebKitWebView*)’: ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:149:5: warning: missing initializer for member ‘WKPageLoaderClient::willGoToBackForwardListItem’ [-Wmissing-field-initializers] ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:149:5: warning: missing initializer for member ‘WKPageLoaderClient::interactionOccurredWhileProcessUnresponsive’ [-Wmissing-field-initializers] The attached patch initializes these members. 619652 1 140977 spena 2012-05-09 10:59:14 -0700 Created attachment 140977 Patch 619654 2 webkit.review.bot 2012-05-09 11:01:05 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 619664 3 140977 webkit.review.bot 2012-05-09 11:11:55 -0700 Comment on attachment 140977 Patch Rejecting attachment 140977 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12656723 619667 4 spena 2012-05-09 11:15:31 -0700 I'll check if I messed up the changelog, one sec. 619670 5 140983 spena 2012-05-09 11:18:51 -0700 Created attachment 140983 Patch 620631 6 140983 webkit.review.bot 2012-05-10 09:32:44 -0700 Comment on attachment 140983 Patch Clearing flags on attachment: 140983 Committed r116651: <http://trac.webkit.org/changeset/116651> 620632 7 webkit.review.bot 2012-05-10 09:32:48 -0700 All reviewed patches have been landed. Closing bug. 140977 2012-05-09 10:59:14 -0700 2012-05-09 11:18:43 -0700 Patch bug-86005-20120509195912.patch text/plain 1689 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTJiODJjOTY5ZDczM2Rj M2JkZjI4ZGY1MzlhMzRmOTJjOTYzMDBjNS4uNGMxNmE0YTgxYjg0ZmQxN2I5NWY5YzU3OTY4YmVl NmU5MjllYWQ1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTA5ICBTaW1v biBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNaXNzaW5nIGZpZWxk IGluaXRpYWxpemVycyBmb3IgV0tQYWdlTG9hZGVyQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjAwNQorCisgICAgICAgIEluaXRpYWxpemUg d2lsbEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtIGFuZAorICAgICAgICBpbnRlcmFjdGlvbk9jY3Vy cmVkV2hpbGVQcm9jZXNzVW5yZXNwb25zaXZlIGZpZWxkcyBvZgorICAgICAgICBXS1BhZ2VMb2Fk ZXJDbGllbnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGll bnQuY3BwOgorICAgICAgICAoYXR0YWNoTG9hZGVyQ2xpZW50VG9WaWV3KToKKwogMjAxMi0wNS0w OSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAg ICAgICBbUXRdIFRhcC10by16b29tIHpvb21zIHRvIHdyb25nIGFyZWEuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcApp bmRleCBjMjZkOGViZTk3ZmFlNjhhMWExNmM4ZTk0YjJjYjBkMWQ4OGQzMDAzLi45NDc2MjU1Yzg4 NDQyNTNkNzcwZmIxNWFiN2JhMmRlMTlkNGQzOWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAKQEAgLTE0NSw3 ICsxNDUsOSBAQCB2b2lkIGF0dGFjaExvYWRlckNsaWVudFRvVmlldyhXZWJLaXRXZWJWaWV3KiB3 ZWJWaWV3KQogICAgICAgICAwLCAvLyBzaG91bGRHb1RvQmFja0ZvcndhcmRMaXN0SXRlbQogICAg ICAgICAwLCAvLyBkaWRGYWlsVG9Jbml0aWFsaXplUGx1Z2luCiAgICAgICAgIDAsIC8vIGRpZERl dGVjdFhTU0ZvckZyYW1lCi0gICAgICAgIDAgLy8gZGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5 b3V0Rm9yRnJhbWUgCisgICAgICAgIDAsIC8vIGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91 dEZvckZyYW1lCisgICAgICAgIDAsIC8vIHdpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbQorICAg ICAgICAwIC8vIGludGVyYWN0aW9uT2NjdXJyZWRXaGlsZVByb2Nlc3NVbnJlc3BvbnNpdmUKICAg ICB9OwogICAgIFdLUGFnZVJlZiB3a1BhZ2UgPSB0b0FQSSh3ZWJraXRXZWJWaWV3QmFzZUdldFBh Z2UoV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2ViVmlldykpKTsKICAgICBXS1BhZ2VTZXRQYWdlTG9h ZGVyQ2xpZW50KHdrUGFnZSwgJndrTG9hZGVyQ2xpZW50KTsK 140983 2012-05-09 11:18:51 -0700 2012-05-10 09:32:43 -0700 Patch bug-86005-20120509201850.patch text/plain 1728 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTJiODJjOTY5ZDczM2Rj M2JkZjI4ZGY1MzlhMzRmOTJjOTYzMDBjNS4uNTFmYTlkNjlhOGZlMjVlY2Y0YWM3YzkyNTg2N2Uy MmM5ODg1YWRkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTA5ICBTaW1v biBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNaXNzaW5nIGZpZWxk IGluaXRpYWxpemVycyBmb3IgV0tQYWdlTG9hZGVyQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjAwNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluaXRpYWxpemUgd2lsbEdvVG9CYWNrRm9yd2Fy ZExpc3RJdGVtIGFuZAorICAgICAgICBpbnRlcmFjdGlvbk9jY3VycmVkV2hpbGVQcm9jZXNzVW5y ZXNwb25zaXZlIGZpZWxkcyBvZgorICAgICAgICBXS1BhZ2VMb2FkZXJDbGllbnQuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAo YXR0YWNoTG9hZGVyQ2xpZW50VG9WaWV3KToKKwogMjAxMi0wNS0wOSAgQWxsYW4gU2FuZGZlbGQg SmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIFRhcC10by16 b29tIHpvb21zIHRvIHdyb25nIGFyZWEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcAppbmRleCBjMjZkOGViZTk3ZmFl NjhhMWExNmM4ZTk0YjJjYjBkMWQ4OGQzMDAzLi45NDc2MjU1Yzg4NDQyNTNkNzcwZmIxNWFiN2Jh MmRlMTlkNGQzOWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAKQEAgLTE0NSw3ICsxNDUsOSBAQCB2b2lkIGF0 dGFjaExvYWRlckNsaWVudFRvVmlldyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgICAgICAw LCAvLyBzaG91bGRHb1RvQmFja0ZvcndhcmRMaXN0SXRlbQogICAgICAgICAwLCAvLyBkaWRGYWls VG9Jbml0aWFsaXplUGx1Z2luCiAgICAgICAgIDAsIC8vIGRpZERldGVjdFhTU0ZvckZyYW1lCi0g ICAgICAgIDAgLy8gZGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWUgCisgICAg ICAgIDAsIC8vIGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lCisgICAgICAg IDAsIC8vIHdpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbQorICAgICAgICAwIC8vIGludGVyYWN0 aW9uT2NjdXJyZWRXaGlsZVByb2Nlc3NVbnJlc3BvbnNpdmUKICAgICB9OwogICAgIFdLUGFnZVJl ZiB3a1BhZ2UgPSB0b0FQSSh3ZWJraXRXZWJWaWV3QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVX X0JBU0Uod2ViVmlldykpKTsKICAgICBXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KHdrUGFnZSwg JndrTG9hZGVyQ2xpZW50KTsK