85976 2012-05-09 03:40:59 -0700 [chromium] Exposes OrientationChangeEvent. 2012-05-09 10:58:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bulach bulach abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 619346 0 bulach 2012-05-09 03:40:59 -0700 [chromium] Exposes OrientationChangeEvent. 619350 1 140906 bulach 2012-05-09 03:46:47 -0700 Created attachment 140906 Patch 619353 2 webkit.review.bot 2012-05-09 03:49:59 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 619536 3 140906 abarth 2012-05-09 08:58:30 -0700 Comment on attachment 140906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140906&action=review > Source/WebKit/chromium/public/WebFrame.h:570 > + virtual void sendOrientationChangeEvent(int orientation) = 0; This comment from Frame.h was helpful to me. I wonder if we should include it here too: // Orientation is the interface orientation in degrees. Some examples are: // 0 is straight up; -90 is when the device is rotated 90 clockwise; // 90 is when rotated counter clockwise. 619580 4 140960 bulach 2012-05-09 09:34:31 -0700 Created attachment 140960 Patch 619581 5 140960 abarth 2012-05-09 09:35:00 -0700 Comment on attachment 140960 Patch Many thanks. 619582 6 140906 bulach 2012-05-09 09:35:02 -0700 Comment on attachment 140906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140906&action=review >> Source/WebKit/chromium/public/WebFrame.h:570 >> + virtual void sendOrientationChangeEvent(int orientation) = 0; > > This comment from Frame.h was helpful to me. I wonder if we should include it here too: > > // Orientation is the interface orientation in degrees. Some examples are: > // 0 is straight up; -90 is when the device is rotated 90 clockwise; > // 90 is when rotated counter clockwise. yeah, agreed it clarifies. added. 619650 7 140960 webkit.review.bot 2012-05-09 10:58:09 -0700 Comment on attachment 140960 Patch Clearing flags on attachment: 140960 Committed r116544: <http://trac.webkit.org/changeset/116544> 619651 8 webkit.review.bot 2012-05-09 10:58:14 -0700 All reviewed patches have been landed. Closing bug. 140906 2012-05-09 03:46:47 -0700 2012-05-09 09:35:02 -0700 Patch bug-85976-20120509114645.patch text/plain 3042 bulach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZWY3NTUzOTQzNTg1MDE0YjJmMGFlMjliZTc2 YmRmYWUzODg2OWNiYy4uY2I5MzZlZDY4ZGJiNTg5MmIxMzUyNjJiN2QwMmVhNDM1ZjkyMzM3NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wNS0wOSAg TWFyY3VzIEJ1bGFjaCAgPGJ1bGFjaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVt XSBFeHBvc2VzIE9yaWVudGF0aW9uQ2hhbmdlRXZlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgdXNlZCBieSB0aGUgYW5kcm9pZCBwb3J0 LCB3ZSBuZWVkIHRvIGV4cG9zZSB0aGUgZXhpc3RpbmcKKyAgICAgICAgV2ViQ29yZSBBUEkuCisK KyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKFdlYkZyYW1lKToKKyAgICAg ICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBs OjpzZW5kT3JpZW50YXRpb25DaGFuZ2VFdmVudCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAg ICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKyAgICAgICAgKFdlYkZyYW1lSW1wbCk6CisKIDIwMTIt MDUtMDkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gRGlzYWJsZSBXZWJWaWV3VGVzdC5UZXh0SW5wdXRUeXBlIGJlY2F1c2UgdGhlIHRlc3Qg aXMgaW5jb21wbGV0ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkZyYW1lLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCmlu ZGV4IGRhNzk1YWU4ZGU4Y2M1OTYzMWVhMTY0OTAzMWJiNjIzNzliOTliYWEuLmQyNTZjYWM2MDli YmYxZjYwZjQ3MmY3MmRkMTE1ODEwMzc5MTRhYTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViRnJhbWUuaApAQCAtNTY1LDYgKzU2NSw5IEBAIHB1YmxpYzoKICAgICAvLyBvZiBt YXRjaGVzIGZvdW5kIGR1cmluZyB0aGUgc2NvcGluZyBlZmZvcnQuCiAgICAgdmlydHVhbCB2b2lk IHJlc2V0TWF0Y2hDb3VudCgpID0gMDsKIAorICAgIC8vIE9yaWVudGF0aW9uQ2hhbmdlIGV2ZW50 IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorCisgICAgdmly dHVhbCB2b2lkIHNlbmRPcmllbnRhdGlvbkNoYW5nZUV2ZW50KGludCBvcmllbnRhdGlvbikgPSAw OwogCiAgICAgLy8gRXZlbnRzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJGcmFtZUltcGwuY3BwCmluZGV4IDNkNWFhNWE3NDQ0NjkwM2M2OTZlZGU1MTk5NGVhNjU5ODdj ZGYwZGUuLjVlMTVmNmM1OGQzZThiNzRhMWZlYjhiODc1ODU1M2JkYzViNWRlM2IgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtMTg2NSw2ICsxODY1 LDE0IEBAIHZvaWQgV2ViRnJhbWVJbXBsOjpoYW5kbGVJbnRlbnRGYWlsdXJlKGludCBpbnRlbnRJ ZGVudGlmaWVyLCBjb25zdCBXZWJTdHJpbmcmIHJlCiB7CiB9CiAKK3ZvaWQgV2ViRnJhbWVJbXBs OjpzZW5kT3JpZW50YXRpb25DaGFuZ2VFdmVudChpbnQgb3JpZW50YXRpb24pCit7CisjaWYgRU5B QkxFKE9SSUVOVEFUSU9OX0VWRU5UUykKKyAgICBpZiAobV9mcmFtZSkKKyAgICAgICAgbV9mcmFt ZS0+c2VuZE9yaWVudGF0aW9uQ2hhbmdlRXZlbnQob3JpZW50YXRpb24pOworI2VuZGlmCit9CisK IHZvaWQgV2ViRnJhbWVJbXBsOjphZGRFdmVudExpc3RlbmVyKGNvbnN0IFdlYlN0cmluZyYgZXZl bnRUeXBlLCBXZWJET01FdmVudExpc3RlbmVyKiBsaXN0ZW5lciwgYm9vbCB1c2VDYXB0dXJlKQog ewogICAgIERPTVdpbmRvdyogd2luZG93ID0gbV9mcmFtZS0+ZG9tV2luZG93KCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCmluZGV4IGMzYWNjMWFmYmNjMzhkNzEx NzExMDg2MGFkZmJiZmI3Y2JmOTc1YzkuLjViMDJiZWJjMmFiODE5NjBjNjMzMTZmZTAzMDE3YmIz MTE5MzkxZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCkBA IC0yMDgsNiArMjA4LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBoYW5kbGVJbnRlbnRS ZXN1bHQoaW50LCBjb25zdCBXZWJTdHJpbmcmKTsKICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlSW50 ZW50RmFpbHVyZShpbnQsIGNvbnN0IFdlYlN0cmluZyYpOwogCisgICAgdmlydHVhbCB2b2lkIHNl bmRPcmllbnRhdGlvbkNoYW5nZUV2ZW50KGludCBvcmllbnRhdGlvbik7CisKICAgICB2aXJ0dWFs IHZvaWQgYWRkRXZlbnRMaXN0ZW5lcihjb25zdCBXZWJTdHJpbmcmIGV2ZW50VHlwZSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXZWJET01FdmVudExpc3RlbmVyKiwgYm9vbCB1 c2VDYXB0dXJlKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlRXZlbnRMaXN0ZW5lcihjb25zdCBX ZWJTdHJpbmcmIGV2ZW50VHlwZSwK 140960 2012-05-09 09:34:31 -0700 2012-05-09 10:58:09 -0700 Patch bug-85976-20120509173429.patch text/plain 3253 bulach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZWY3NTUzOTQzNTg1MDE0YjJmMGFlMjliZTc2 YmRmYWUzODg2OWNiYy4uY2I5MzZlZDY4ZGJiNTg5MmIxMzUyNjJiN2QwMmVhNDM1ZjkyMzM3NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wNS0wOSAg TWFyY3VzIEJ1bGFjaCAgPGJ1bGFjaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVt XSBFeHBvc2VzIE9yaWVudGF0aW9uQ2hhbmdlRXZlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgdXNlZCBieSB0aGUgYW5kcm9pZCBwb3J0 LCB3ZSBuZWVkIHRvIGV4cG9zZSB0aGUgZXhpc3RpbmcKKyAgICAgICAgV2ViQ29yZSBBUEkuCisK KyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKFdlYkZyYW1lKToKKyAgICAg ICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBs OjpzZW5kT3JpZW50YXRpb25DaGFuZ2VFdmVudCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAg ICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKyAgICAgICAgKFdlYkZyYW1lSW1wbCk6CisKIDIwMTIt MDUtMDkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gRGlzYWJsZSBXZWJWaWV3VGVzdC5UZXh0SW5wdXRUeXBlIGJlY2F1c2UgdGhlIHRlc3Qg aXMgaW5jb21wbGV0ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkZyYW1lLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCmlu ZGV4IGRhNzk1YWU4ZGU4Y2M1OTYzMWVhMTY0OTAzMWJiNjIzNzliOTliYWEuLjFmYTA0OTYwOTY1 NWM0ZDdmNTc1ODZjOWVlMjExMmM1ZDY4OWNjMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViRnJhbWUuaApAQCAtNTY1LDYgKzU2NSwxMyBAQCBwdWJsaWM6CiAgICAgLy8gb2Yg bWF0Y2hlcyBmb3VuZCBkdXJpbmcgdGhlIHNjb3BpbmcgZWZmb3J0LgogICAgIHZpcnR1YWwgdm9p ZCByZXNldE1hdGNoQ291bnQoKSA9IDA7CiAKKyAgICAvLyBPcmllbnRhdGlvbkNoYW5nZSBldmVu dCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKworICAgIC8v IE9yaWVudGF0aW9uIGlzIHRoZSBpbnRlcmZhY2Ugb3JpZW50YXRpb24gaW4gZGVncmVlcy4KKyAg ICAvLyBTb21lIGV4YW1wbGVzIGFyZToKKyAgICAvLyAgMCBpcyBzdHJhaWdodCB1cDsgLTkwIGlz IHdoZW4gdGhlIGRldmljZSBpcyByb3RhdGVkIDkwIGNsb2Nrd2lzZTsKKyAgICAvLyAgOTAgaXMg d2hlbiByb3RhdGVkIGNvdW50ZXIgY2xvY2t3aXNlLgorICAgIHZpcnR1YWwgdm9pZCBzZW5kT3Jp ZW50YXRpb25DaGFuZ2VFdmVudChpbnQgb3JpZW50YXRpb24pID0gMDsKIAogICAgIC8vIEV2ZW50 cyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFt ZUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApp bmRleCAzZDVhYTVhNzQ0NDY5MDNjNjk2ZWRlNTE5OTRlYTY1OTg3Y2RmMGRlLi41ZTE1ZjZjNThk M2U4Yjc0YTFmZWI4Yjg3NTg1NTNiZGM1YjVkZTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTE4NjUsNiArMTg2NSwxNCBAQCB2b2lkIFdlYkZy YW1lSW1wbDo6aGFuZGxlSW50ZW50RmFpbHVyZShpbnQgaW50ZW50SWRlbnRpZmllciwgY29uc3Qg V2ViU3RyaW5nJiByZQogewogfQogCit2b2lkIFdlYkZyYW1lSW1wbDo6c2VuZE9yaWVudGF0aW9u Q2hhbmdlRXZlbnQoaW50IG9yaWVudGF0aW9uKQoreworI2lmIEVOQUJMRShPUklFTlRBVElPTl9F VkVOVFMpCisgICAgaWYgKG1fZnJhbWUpCisgICAgICAgIG1fZnJhbWUtPnNlbmRPcmllbnRhdGlv bkNoYW5nZUV2ZW50KG9yaWVudGF0aW9uKTsKKyNlbmRpZgorfQorCiB2b2lkIFdlYkZyYW1lSW1w bDo6YWRkRXZlbnRMaXN0ZW5lcihjb25zdCBXZWJTdHJpbmcmIGV2ZW50VHlwZSwgV2ViRE9NRXZl bnRMaXN0ZW5lciogbGlzdGVuZXIsIGJvb2wgdXNlQ2FwdHVyZSkKIHsKICAgICBET01XaW5kb3cq IHdpbmRvdyA9IG1fZnJhbWUtPmRvbVdpbmRvdygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuaAppbmRleCBjM2FjYzFhZmJjYzM4ZDcxMTcxMTA4NjBhZGZiYmZiN2Ni Zjk3NWM5Li41YjAyYmViYzJhYjgxOTYwYzYzMzE2ZmUwMzAxN2JiMzExOTM5MWZjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaApAQCAtMjA4LDYgKzIwOCw4IEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlSW50ZW50UmVzdWx0KGludCwgY29uc3Qg V2ViU3RyaW5nJik7CiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZUludGVudEZhaWx1cmUoaW50LCBj b25zdCBXZWJTdHJpbmcmKTsKIAorICAgIHZpcnR1YWwgdm9pZCBzZW5kT3JpZW50YXRpb25DaGFu Z2VFdmVudChpbnQgb3JpZW50YXRpb24pOworCiAgICAgdmlydHVhbCB2b2lkIGFkZEV2ZW50TGlz dGVuZXIoY29uc3QgV2ViU3RyaW5nJiBldmVudFR5cGUsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgV2ViRE9NRXZlbnRMaXN0ZW5lciosIGJvb2wgdXNlQ2FwdHVyZSk7CiAgICAg dmlydHVhbCB2b2lkIHJlbW92ZUV2ZW50TGlzdGVuZXIoY29uc3QgV2ViU3RyaW5nJiBldmVudFR5 cGUsCg==