85975 2012-05-09 03:28:02 -0700 Improve a warning message for a reftest having an unused expectation file. 2012-05-09 20:24:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hayato hayato abarth dpranke ojan rniwa webkit.review.bot oldest_to_newest 619343 0 hayato 2012-05-09 03:28:02 -0700 The current warning message is not intuitive. It might be better to update the message. 619344 1 140904 hayato 2012-05-09 03:31:07 -0700 Created attachment 140904 Improve a warning message. 619728 2 140904 dpranke 2012-05-09 12:28:24 -0700 Comment on attachment 140904 Improve a warning message. This might be bikeshedding, but "expectation file" == test_expectations.txt to me. I'd probably call it a "expected baseline" 619814 3 ojan 2012-05-09 14:03:11 -0700 (In reply to comment #2) > (From update of attachment 140904 [details]) > This might be bikeshedding, but "expectation file" == test_expectations.txt to me. I'd probably call it a "expected baseline" Not really true historically for WebKit though. baseline is a chromium-ism that we've leaked in, so now it's a mess where people use the terms interchangeably. 620152 4 hayato 2012-05-09 18:46:17 -0700 Thank you for comments, guys. Let me land this patch as is anyway. If term of 'expectation file' causes confusion, I'm happy to modify it later. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 140904 [details] [details]) > > This might be bikeshedding, but "expectation file" == test_expectations.txt to me. I'd probably call it a "expected baseline" > > Not really true historically for WebKit though. baseline is a chromium-ism that we've leaked in, so now it's a mess where people use the terms interchangeably. 620192 5 140904 webkit.review.bot 2012-05-09 20:24:00 -0700 Comment on attachment 140904 Improve a warning message. Clearing flags on attachment: 140904 Committed r116600: <http://trac.webkit.org/changeset/116600> 620193 6 webkit.review.bot 2012-05-09 20:24:05 -0700 All reviewed patches have been landed. Closing bug. 140904 2012-05-09 03:31:07 -0700 2012-05-09 20:24:00 -0700 Improve a warning message. bug-85975-20120509193106.patch text/plain 1804 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NDc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWU1ZmJmOTEyNDYyODllOWVkNmVmZGUxNTQ2YmRlMTE4 M2QzZjU5ZS4uYzBkOWFhYjAwYTJkMmRhNTIyOGYwZWJiMTM3NzQxNzYxNDFkMjM0NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA1LTA5ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAg ICAgICBJbXByb3ZlIGEgd2FybmluZyBtZXNzYWdlIGZvciBhIHJlZnRlc3QgaGF2aW5nIGFuIHVu dXNlZCBleHBlY3RhdGlvbiBmaWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODU5NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgY3VycmVudCB3YXJuaW5nIG1lc3NhZ2UgaXMgbm90IGludHVpdGl2 ZS4gSXQgbWlnaHQgYmUgYmV0dGVyIHRvIHVwZGF0ZSB0aGUgbWVzc2FnZQorICAgICAgICBzbyB0 aGF0IGl0IGVuY291cmFnZSB1c2VycyB0byByZW1vdmUgdW51c2VkIGV4cGVjdGF0aW9uIGZpbGVz LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMv c2luZ2xlX3Rlc3RfcnVubmVyLnB5OgorICAgICAgICAoU2luZ2xlVGVzdFJ1bm5lci5fX2luaXRf Xyk6CisKIDIwMTItMDUtMDggIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFtFRkxdW0RSVF0gSW1wbGVtZW50IFRleHRJbnB1dENvbnRyb2xsZXIuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9z aW5nbGVfdGVzdF9ydW5uZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHkKaW5kZXggM2Y1MTQxMGNmYmEyYjNj NTdjMWVkZmQ1NTk1MTk0NjFiMWE2YjY0ZS4uNTI5YWVhMjIyMjRiZDI0MGMwZmRmZDU0MmFiZjZk YmVjZmUwOTQ2MiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQpA QCAtNjcsNyArNjcsNyBAQCBjbGFzcyBTaW5nbGVUZXN0UnVubmVyOgogICAgICAgICAgICAgZm9y IHN1ZmZpeCBpbiAoJy50eHQnLCAnLnBuZycsICcud2F2Jyk6CiAgICAgICAgICAgICAgICAgZXhw ZWN0ZWRfZmlsZW5hbWUgPSBzZWxmLl9wb3J0LmV4cGVjdGVkX2ZpbGVuYW1lKHNlbGYuX3Rlc3Rf bmFtZSwgc3VmZml4KQogICAgICAgICAgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3Rz KGV4cGVjdGVkX2ZpbGVuYW1lKToKLSAgICAgICAgICAgICAgICAgICAgX2xvZy5lcnJvcignJXMg aXMgYm90aCBhIHJlZnRlc3QgYW5kIGhhcyBhbiBleHBlY3RlZCBvdXRwdXQgZmlsZSAlcy4nLAor ICAgICAgICAgICAgICAgICAgICBfbG9nLmVycm9yKCclcyBpcyBhIHJlZnRlc3QsIGJ1dCBoYXMg YW4gdW51c2VkIGV4cGVjdGF0aW9uIGZpbGUuIFBsZWFzZSByZW1vdmUgJXMuJywKICAgICAgICAg ICAgICAgICAgICAgICAgIHNlbGYuX3Rlc3RfbmFtZSwgZXhwZWN0ZWRfZmlsZW5hbWUpCiAKICAg ICBkZWYgX2V4cGVjdGVkX2RyaXZlcl9vdXRwdXQoc2VsZik6Cg==