85971 2012-05-09 02:53:55 -0700 [EFL] EFL's DumpRenderTree does not print didReceiveTitle messages 2012-05-21 20:46:27 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 619317 0 cdumez 2012-05-09 02:53:55 -0700 EFL's DumpRenderTree does not print didReceiveTitle messages which are expected by the following tests: http/tests/loading/post-in-iframe-with-back-navigation.html http/tests/loading/redirect-with-no-location-crash.html 619321 1 140896 cdumez 2012-05-09 02:59:17 -0700 Created attachment 140896 Patch 622941 2 cdumez 2012-05-14 07:02:00 -0700 Could I get informal review on this one? 622948 3 140896 rakuco 2012-05-14 07:07:35 -0700 Comment on attachment 140896 Patch Makes sense to me. 623522 4 140896 gyuyoung.kim 2012-05-14 18:00:14 -0700 Comment on attachment 140896 Patch Looks fine to me as well as kubo. 629905 5 140896 webkit.review.bot 2012-05-21 20:46:19 -0700 Comment on attachment 140896 Patch Clearing flags on attachment: 140896 Committed r117894: <http://trac.webkit.org/changeset/117894> 629906 6 webkit.review.bot 2012-05-21 20:46:27 -0700 All reviewed patches have been landed. Closing bug. 140896 2012-05-09 02:59:17 -0700 2012-05-21 20:46:19 -0700 Patch 85971_didReceiveTitle.patch text/plain 6048 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwYmI5ZjRiLi4wZjcxNjBmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUt MDkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXSBFRkwncyBEdW1wUmVuZGVyVHJlZSBkb2VzIG5vdCBwcmludCBkaWRSZWNlaXZl VGl0bGUgbWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg1OTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVW5za2lwIGh0dHAvdGVzdHMvbG9hZGluZy9yZWRpcmVjdC13aXRoLW5vLWxvY2F0aW9u LWNyYXNoLmh0bWwgbm93CisgICAgICAgIHRoYXQgRUZMJ3MgRHVtcFJlbmRlclRyZWUgcHJpbnRz IG91dCB0aGUgZXhwZWN0ZWQgZGlkUmVjZWl2ZVRpdGxlCisgICAgICAgIG1lc3NhZ2VzLgorCisg ICAgICAgICogcGxhdGZvcm0vZWZsL1NraXBwZWQ6CisKIDIwMTItMDUtMDkgIEtlbnQgVGFtdXJh ICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVGVzdCBleHBlY3Rh dGlvbiB1cGRhdGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBl ZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmluZGV4IDBmNTg5N2MuLmI2NDNj ODEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC04MDksNyArODA5LDYgQEAgaHR0cC90 ZXN0cy9oaXN0b3J5L2JhY2std2l0aC1mcmFnbWVudC1jaGFuZ2UucGhwCiAjIEZhaWxpbmcgaHR0 cCB0ZXN0cyAodmlhIEdUSyspCiBodHRwL3Rlc3RzL2xvYWRpbmcvYmFkLXNjaGVtZS1zdWJmcmFt ZS5odG1sCiBodHRwL3Rlc3RzL2xvYWRpbmcvYmFkLXNlcnZlci1zdWJmcmFtZS5odG1sCi1odHRw L3Rlc3RzL2xvYWRpbmcvcmVkaXJlY3Qtd2l0aC1uby1sb2NhdGlvbi1jcmFzaC5odG1sCiBodHRw L3Rlc3RzL2xvYWRpbmcvdGV4dC1jb250ZW50LXR5cGUtd2l0aC1iaW5hcnktZXh0ZW5zaW9uLmh0 bWwKIGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcGxheS1zdGFsbC1zZWVrLmh0bWwKIGh0dHAvdGVz dHMvbWVkaWEvdmlkZW8tcGxheS1zdGFsbC5odG1sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjRhYWFmYy4uMWViODcyYiAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisy MDEyLTA1LTA5ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+ CisKKyAgICAgICAgW0VGTF0gRUZMJ3MgRHVtcFJlbmRlclRyZWUgZG9lcyBub3QgcHJpbnQgZGlk UmVjZWl2ZVRpdGxlIG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NTk3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIExpc3RlbiBmb3IgdGhlICJ0aXRsZSxjaGFuZ2VkIiBzaWduYWwgb24gdGhl IGZyYW1lcyBpbnN0ZWFkIG9mIHRoZQorICAgICAgICB2aWV3IHNvIHRoYXQgd2UgZ2V0IG5vdGlm aWVkIGZvciBvdGhlciBmcmFtZSB0aGFuIHRoZSBtYWluIG9uZS4KKyAgICAgICAgUHJpbnQgb3V0 IHRoZSBkaWRSZWNlaXZlVGl0bGUgbWVzc2FnZXMgd2hpY2ggYXJlIGV4cGVjdGVkIGlmCisgICAg ICAgIExheW91dFRlc3RDb250cm9sbGVyJ3MgZHVtcEZyYW1lTG9hZENhbGxiYWNrcygpIHJldHVy bnMgdHJ1ZS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNo cm9tZS5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6Y3JlYXRlVmlldyk6Cisg ICAgICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6b25GcmFtZVRpdGxlQ2hhbmdlZCk6CisgICAg ICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6b25GcmFtZUNyZWF0ZWQpOgorICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5oOgorICAgICAgICAoRHVtcFJl bmRlclRyZWVDaHJvbWUpOgorCiAyMDEyLTA1LTA5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs ZS5jb20+CiAKICAgICAgICAgTWFkZSBidWlsZC13ZWJraXQgY29weSBXZWJLaXRMaWJyYXJpZXMg dG8gdGhlIHJpZ2h0IGxvY2F0aW9uIGFnYWluIGFmdGVyIHIxMTYyNTcKZGlmZiAtLWdpdCBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCmluZGV4IGJmYWVmNWUu LjdjYTZhNzkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVy VHJlZUNocm9tZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJU cmVlQ2hyb21lLmNwcApAQCAtOTUsNyArOTUsNiBAQCBFdmFzX09iamVjdCogRHVtcFJlbmRlclRy ZWVDaHJvbWU6OmNyZWF0ZVZpZXcoKSBjb25zdAogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxi YWNrX2FkZCh2aWV3LCAibG9hZCxyZXNvdXJjZSxmYWlsZWQiLCBvblJlc291cmNlTG9hZEZhaWxl ZCwgMCk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKHZpZXcsICJsb2FkLHJl c291cmNlLGZpbmlzaGVkIiwgb25SZXNvdXJjZUxvYWRGaW5pc2hlZCwgMCk7CiAgICAgZXZhc19v YmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKHZpZXcsICJsb2FkLHN0YXJ0ZWQiLCBvbkxvYWRTdGFy dGVkLCAwKTsKLSAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQodmlldywgInRpdGxl LGNoYW5nZWQiLCBvblRpdGxlQ2hhbmdlZCwgMCk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2Fs bGJhY2tfYWRkKHZpZXcsICJ3aW5kb3csb2JqZWN0LGNsZWFyZWQiLCBvbldpbmRvd09iamVjdENs ZWFyZWQsIG1fZ2NDb250cm9sbGVyLmdldCgpKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxs YmFja19hZGQodmlldywgInN0YXR1c2Jhcix0ZXh0LHNldCIsIG9uU3RhdHVzYmFyVGV4dFNldCwg MCk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKHZpZXcsICJsb2FkLGRvY3Vt ZW50LGZpbmlzaGVkIiwgb25Eb2N1bWVudExvYWRGaW5pc2hlZCwgMCk7CkBAIC0xMTUsNiArMTE0 LDcgQEAgRXZhc19PYmplY3QqIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpjcmVhdGVWaWV3KCkgY29u c3QKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQobWFpbkZyYW1lLCAicmVkaXJl Y3QsY2FuY2VsbGVkIiwgb25GcmFtZVJlZGlyZWN0Q2FuY2VsbGVkLCAwKTsKICAgICBldmFzX29i amVjdF9zbWFydF9jYWxsYmFja19hZGQobWFpbkZyYW1lLCAicmVkaXJlY3QsbG9hZCxwcm92aXNp b25hbCIsIG9uRnJhbWVSZWRpcmVjdEZvclByb3Zpc2lvbmFsTG9hZCwgMCk7CiAgICAgZXZhc19v YmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKG1haW5GcmFtZSwgInJlZGlyZWN0LHJlcXVlc3RlZCIs IG9uRnJhbWVSZWRpcmVjdFJlcXVlc3RlZCwgMCk7CisgICAgZXZhc19vYmplY3Rfc21hcnRfY2Fs bGJhY2tfYWRkKG1haW5GcmFtZSwgInRpdGxlLGNoYW5nZWQiLCBvbkZyYW1lVGl0bGVDaGFuZ2Vk LCAwKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQobWFpbkZyYW1lLCAieHNz LGRldGVjdGVkIiwgb25EaWREZXRlY3RYU1MsIDApOwogCiAgICAgcmV0dXJuIHZpZXc7CkBAIC00 MTksMTMgKzQxOSwxNyBAQCB2b2lkIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpvblN0YXR1c2JhclRl eHRTZXQodm9pZCosIEV2YXNfT2JqZWN0Kiwgdm9pZCogZXZlbnRJbgogICAgIHByaW50ZigiVUkg REVMRUdBVEUgU1RBVFVTIENBTExCQUNLOiBzZXRTdGF0dXNUZXh0OiVzXG4iLCBzdGF0dXNiYXJU ZXh0KTsKIH0KIAotdm9pZCBEdW1wUmVuZGVyVHJlZUNocm9tZTo6b25UaXRsZUNoYW5nZWQodm9p ZCosIEV2YXNfT2JqZWN0Kiwgdm9pZCogZXZlbnRJbmZvKQordm9pZCBEdW1wUmVuZGVyVHJlZUNo cm9tZTo6b25GcmFtZVRpdGxlQ2hhbmdlZCh2b2lkKiwgRXZhc19PYmplY3QqIGZyYW1lLCB2b2lk KiBldmVudEluZm8pCiB7Ci0gICAgaWYgKCFnTGF5b3V0VGVzdENvbnRyb2xsZXItPmR1bXBUaXRs ZUNoYW5nZXMoKSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgY29uc3QgY2hhciogdGl0bGVUZXh0 ID0gc3RhdGljX2Nhc3Q8Y29uc3QgY2hhcio+KGV2ZW50SW5mbyk7Ci0gICAgcHJpbnRmKCJUSVRM RSBDSEFOR0VEOiAlc1xuIiwgdGl0bGVUZXh0KTsKKworICAgIGlmICghZG9uZSAmJiBnTGF5b3V0 VGVzdENvbnRyb2xsZXItPmR1bXBGcmFtZUxvYWRDYWxsYmFja3MoKSkgeworICAgICAgICBjb25z dCBTdHJpbmcgZnJhbWVOYW1lKER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c3VpdGFibGVEUlRG cmFtZU5hbWUoZnJhbWUpKTsKKyAgICAgICAgcHJpbnRmKCIlcyAtIGRpZFJlY2VpdmVUaXRsZTog JXNcbiIsIGZyYW1lTmFtZS51dGY4KCkuZGF0YSgpLCB0aXRsZVRleHQpOworICAgIH0KKworICAg IGlmICghZG9uZSAmJiBnTGF5b3V0VGVzdENvbnRyb2xsZXItPmR1bXBUaXRsZUNoYW5nZXMoKSkK KyAgICAgICAgcHJpbnRmKCJUSVRMRSBDSEFOR0VEOiAlc1xuIiwgdGl0bGVUZXh0KTsKIH0KIAog dm9pZCBEdW1wUmVuZGVyVHJlZUNocm9tZTo6b25Eb2N1bWVudExvYWRGaW5pc2hlZCh2b2lkKiwg RXZhc19PYmplY3QqLCB2b2lkKiBldmVudEluZm8pCkBAIC01MTQsNiArNTE4LDcgQEAgdm9pZCBE dW1wUmVuZGVyVHJlZUNocm9tZTo6b25GcmFtZUNyZWF0ZWQodm9pZCosIEV2YXNfT2JqZWN0Kiwg dm9pZCogZXZlbnRJbmZvKQogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChmcmFt ZSwgInJlZGlyZWN0LGNhbmNlbGxlZCIsIG9uRnJhbWVSZWRpcmVjdENhbmNlbGxlZCwgMCk7CiAg ICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGZyYW1lLCAicmVkaXJlY3QsbG9hZCxw cm92aXNpb25hbCIsIG9uRnJhbWVSZWRpcmVjdEZvclByb3Zpc2lvbmFsTG9hZCwgMCk7CiAgICAg ZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGZyYW1lLCAicmVkaXJlY3QscmVxdWVzdGVk Iiwgb25GcmFtZVJlZGlyZWN0UmVxdWVzdGVkLCAwKTsKKyAgICBldmFzX29iamVjdF9zbWFydF9j YWxsYmFja19hZGQoZnJhbWUsICJ0aXRsZSxjaGFuZ2VkIiwgb25GcmFtZVRpdGxlQ2hhbmdlZCwg MCk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGZyYW1lLCAieHNzLGRldGVj dGVkIiwgb25EaWREZXRlY3RYU1MsIDApOwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuaCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5oCmluZGV4IDNkNWY1YTMuLjFhZDBmMGIgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5oCisr KyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5oCkBAIC03 Nyw3ICs3Nyw3IEBAIHByaXZhdGU6CiAKICAgICBzdGF0aWMgdm9pZCBvblN0YXR1c2JhclRleHRT ZXQodm9pZCosIEV2YXNfT2JqZWN0Kiwgdm9pZCopOwogCi0gICAgc3RhdGljIHZvaWQgb25UaXRs ZUNoYW5nZWQodm9pZCosIEV2YXNfT2JqZWN0Kiwgdm9pZCopOworICAgIHN0YXRpYyB2b2lkIG9u RnJhbWVUaXRsZUNoYW5nZWQodm9pZCosIEV2YXNfT2JqZWN0Kiwgdm9pZCopOwogCiAgICAgc3Rh dGljIHZvaWQgb25Eb2N1bWVudExvYWRGaW5pc2hlZCh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lk Kik7CiAK