85955 2012-05-08 22:33:33 -0700 Coding style issues present in RenderFrameSet.cpp 2012-05-08 23:13:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mario mario eric webkit.review.bot oldest_to_newest 619169 0 mario 2012-05-08 22:33:33 -0700 There are some coding style issues here that might be interesting to fix: $ check-webkit-style Source/WebCore/rendering/RenderFrameSet.cpp Source/WebCore/rendering/RenderFrameSet.cpp:184: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderFrameSet.cpp:186: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderFrameSet.cpp:349: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/WebCore/rendering/RenderFrameSet.cpp:687: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 4 in 1 files 619182 1 140865 mario 2012-05-08 22:46:32 -0700 Created attachment 140865 Patch 619184 2 140865 eric 2012-05-08 22:52:24 -0700 Comment on attachment 140865 Patch OK. I think there are mixed feelings about such clean-up only patches. 619186 3 mario 2012-05-08 22:56:34 -0700 (In reply to comment #2) > (From update of attachment 140865 [details]) > OK. I think there are mixed feelings about such clean-up only patches. Yeah, I understand. Just trying to showcase how the workflow for working with bugzilla is to some people. Thanks for the fast response anyway! 619187 4 140865 mario 2012-05-08 22:57:46 -0700 Comment on attachment 140865 Patch I will prefer to do it myself for better showcasing. 619190 5 mario 2012-05-08 23:13:26 -0700 Committed r116496: <http://trac.webkit.org/changeset/116496> 140865 2012-05-08 22:46:32 -0700 2012-05-08 22:57:46 -0700 Patch bug-85955-20120509144630.patch text/plain 3005 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjdlMjEyYjhjNjUxMDdh YTI0ZTUxN2IwNGYyNGM5ZDkyODg0YTU1ZC4uNmJhMjBhMDA1MDc5YjIyNjA1ZjlhNWRiZWZjZmU1 NTU0YzZjYTZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTA4ICBNYXJp byBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBDb2Rpbmcg c3R5bGUgaXNzdWVzIHByZXNlbnQgaW4gUmVuZGVyRnJhbWVTZXQuY3BwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTk1NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEp1c3QgZml4ZWQgdGhvc2UgY29kaW5n IHN0eWxlIGlzc3Vlcy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGcmFtZVNldC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGcmFtZVNldDo6R3JpZEF4aXM6OnJlc2l6ZSk6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJGcmFtZVNldDo6bGF5T3V0QXhpcyk6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJGcmFtZVNldDo6Y29udGludWVSZXNpemluZyk6CisKIDIwMTItMDUtMDUg IFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTYyMjEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZyYW1lU2V0LmNwcAppbmRleCBlMDJjMDY2ODk5MGI1Mjk4YWI1MGRmOWQyMGY0ZTI5 NmY4MTllZTI1Li5hYzQ0OWEyNDBjNmQ4YjBkNjg1YjIxNmI2Zjk2MjZkZmU3ZDE2OTdmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGcmFtZVNldC5jcHAKQEAgLTE4MSw5ICsx ODEsOSBAQCB2b2lkIFJlbmRlckZyYW1lU2V0OjpHcmlkQXhpczo6cmVzaXplKGludCBzaXplKQog ICAgIG1fZGVsdGFzLnJlc2l6ZShzaXplKTsKICAgICBtX2RlbHRhcy5maWxsKDApOwogICAgIAot ICAgIC8vIFRvIHRyYWNrIGVkZ2VzIGZvciByZXNpemFiaWxpdHkgYW5kIGJvcmRlcnMsIHdlIG5l ZWQgdG8gYmUgKHNpemUgKyAxKS4gIFRoaXMgaXMgYmVjYXVzZSBhIHBhcmVudCBmcmFtZXNldAor ICAgIC8vIFRvIHRyYWNrIGVkZ2VzIGZvciByZXNpemFiaWxpdHkgYW5kIGJvcmRlcnMsIHdlIG5l ZWQgdG8gYmUgKHNpemUgKyAxKS4gVGhpcyBpcyBiZWNhdXNlIGEgcGFyZW50IGZyYW1lc2V0CiAg ICAgLy8gbWF5IGFzayB1cyBmb3IgaW5mb3JtYXRpb24gYWJvdXQgb3VyIGxlZnQvdG9wL3JpZ2h0 L2JvdHRvbSBlZGdlcyBpbiBvcmRlciB0byBtYWtlIGl0cyBvd24gZGVjaXNpb25zIGFib3V0Ci0g ICAgLy8gd2hhdCB0byBkby4gIFdlIGFyZSBjYXBhYmxlIG9mIHRhaW50aW5nIHRoYXQgcGFyZW50 IGZyYW1lc2V0J3MgYm9yZGVycywgc28gd2UgaGF2ZSB0byBjYWNoZSB0aGlzIGluZm8uCisgICAg Ly8gd2hhdCB0byBkby4gV2UgYXJlIGNhcGFibGUgb2YgdGFpbnRpbmcgdGhhdCBwYXJlbnQgZnJh bWVzZXQncyBib3JkZXJzLCBzbyB3ZSBoYXZlIHRvIGNhY2hlIHRoaXMgaW5mby4KICAgICBtX3By ZXZlbnRSZXNpemUucmVzaXplKHNpemUgKyAxKTsKICAgICBtX2FsbG93Qm9yZGVyLnJlc2l6ZShz aXplICsgMSk7CiB9CkBAIC0zNDIsMTEgKzM0MiwxMCBAQCB2b2lkIFJlbmRlckZyYW1lU2V0Ojps YXlPdXRBeGlzKEdyaWRBeGlzJiBheGlzLCBjb25zdCBMZW5ndGgqIGdyaWQsIGludCBhdmFpbGFi bAogICAgICAgICAgICAgICAgIHJlbWFpbmluZ0xlbiAtPSBjaGFuZ2VQZXJjZW50OwogICAgICAg ICAgICAgfQogICAgICAgICB9Ci0gICAgfSAKLSAgICAKLSAgICAvLyBJZiB3ZSBkb24ndCBoYXZl IGFueSBwZXJjZW50YWdlIGNvbHVtbnMvcm93cyB3ZSBvbmx5IGhhdmUgZml4ZWQgY29sdW1ucy4g U3ByZWFkCi0gICAgLy8gdGhlIHJlbWFpbmRlciBlcXVhbGx5IG92ZXIgYWxsIGZpeGVkIGNvbHVt bnMvcm93cy4KLSAgICBlbHNlIGlmIChyZW1haW5pbmdMZW4gJiYgY291bnRGaXhlZCkgeworICAg IH0gZWxzZSBpZiAocmVtYWluaW5nTGVuICYmIGNvdW50Rml4ZWQpIHsKKyAgICAgICAgLy8gSWYg d2UgZG9uJ3QgaGF2ZSBhbnkgcGVyY2VudGFnZSBjb2x1bW5zL3Jvd3Mgd2Ugb25seSBoYXZlCisg ICAgICAgIC8vIGZpeGVkIGNvbHVtbnMuIFNwcmVhZCB0aGUgcmVtYWluZGVyIGVxdWFsbHkgb3Zl ciBhbGwgZml4ZWQKKyAgICAgICAgLy8gY29sdW1ucy9yb3dzLgogICAgICAgICBpbnQgcmVtYWlu aW5nRml4ZWQgPSByZW1haW5pbmdMZW47CiAgICAgICAgIGludCBjaGFuZ2VGaXhlZCA9IDA7CiAg ICAgICAgIApAQCAtNjg0LDcgKzY4Myw3IEBAIHZvaWQgUmVuZGVyRnJhbWVTZXQ6OmNvbnRpbnVl UmVzaXppbmcoR3JpZEF4aXMmIGF4aXMsIGludCBwb3NpdGlvbikKICAgICAgICAgcmV0dXJuOwog ICAgIGludCBjdXJyZW50U3BsaXRQb3NpdGlvbiA9IHNwbGl0UG9zaXRpb24oYXhpcywgYXhpcy5t X3NwbGl0QmVpbmdSZXNpemVkKTsKICAgICBpbnQgZGVsdGEgPSAocG9zaXRpb24gLSBjdXJyZW50 U3BsaXRQb3NpdGlvbikgLSBheGlzLm1fc3BsaXRSZXNpemVPZmZzZXQ7Ci0gICAgaWYgKGRlbHRh ID09IDApCisgICAgaWYgKCFkZWx0YSkKICAgICAgICAgcmV0dXJuOwogICAgIGF4aXMubV9kZWx0 YXNbYXhpcy5tX3NwbGl0QmVpbmdSZXNpemVkIC0gMV0gKz0gZGVsdGE7CiAgICAgYXhpcy5tX2Rl bHRhc1theGlzLm1fc3BsaXRCZWluZ1Jlc2l6ZWRdIC09IGRlbHRhOwo=