85931 2012-05-08 16:46:05 -0700 [GTK] don't use soup_session_pause_message in webkitdownload 2012-05-09 08:22:41 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danw webkit-unassigned webkit.review.bot oldest_to_newest 618957 0 danw 2012-05-08 16:46:05 -0700 related to bug 85159; libsoup master doesn't like it when you mix soup_session_pause_message() and SoupRequest. I am not sure that this patch is totally right, since epiphany doesn't seem to ever show a dialog here, so you wouldn't really be able to tell if it was paused or not. It does make the warnings go away though... It seems like this is something that there ought to be a test case for ("when following a link that should cause a download, the download gets paused until the higher levels decide what to do with it"), but I think that would require new DRT hooks? 618959 1 140815 danw 2012-05-08 16:48:58 -0700 Created attachment 140815 patch Hm... prepare-ChangeLog didn't add the "No new tests. (OOPS!)" line... I guess we get a pass because it's platform-specific code? Still, a test would be nice. 618963 2 140815 mrobinson 2012-05-08 16:51:12 -0700 Comment on attachment 140815 patch Looks good to me. setDefersLoading is tested by the layout tests, but an option if you want to add a test is to add a GTK+ API unit test. 619385 3 140815 danw 2012-05-09 04:54:57 -0700 Comment on attachment 140815 patch ok, actually testmimehandling was already broken against libsoup master without this patch, and now works again with this patch 619504 4 140815 webkit.review.bot 2012-05-09 08:22:37 -0700 Comment on attachment 140815 patch Clearing flags on attachment: 140815 Committed r116525: <http://trac.webkit.org/changeset/116525> 619505 5 webkit.review.bot 2012-05-09 08:22:41 -0700 All reviewed patches have been landed. Closing bug. 140815 2012-05-08 16:48:58 -0700 2012-05-09 08:22:37 -0700 patch 0001-GTK-don-t-use-soup_session_pause_message-in-webkitdo.patch text/plain 2553 danw RnJvbSBiYjA4YWMxOWM5MWI1YWI4YzM3Mjk3OWMwOGMxMjJhOTczYjAyMTlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW4gV2luc2hpcCA8ZGFud0Bnbm9tZS5vcmc+CkRhdGU6IFR1 ZSwgOCBNYXkgMjAxMiAxOTo0Njo1MSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtHVEtdIGRvbid0 IHVzZSBzb3VwX3Nlc3Npb25fcGF1c2VfbWVzc2FnZSBpbiB3ZWJraXRkb3dubG9hZAoKLS0tCiBT b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysr KysrKwogU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcCB8ICAgMTAg KystLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBjNzM4MzVmLi5kYzg5ZTFhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDUtMDggIERhbiBXaW5zaGlwICA8ZGFud0Bnbm9t ZS5vcmc+CisKKyAgICAgICAgW0dUS10gZG9uJ3QgdXNlIHNvdXBfc2Vzc2lvbl9wYXVzZV9tZXNz YWdlIGluIHdlYmtpdGRvd25sb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NTkzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcDoKKyAgICAgICAgKHdlYmtp dF9kb3dubG9hZF9uZXdfd2l0aF9oYW5kbGUpOgorICAgICAgICAod2Via2l0X2Rvd25sb2FkX3N0 YXJ0KToKKwogMjAxMi0wNC0xOCAgSm9uIEhvbmV5Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29t PgogCiAgICAgICAgIEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaFdpbGxTZW5kU3VibWl0RXZl bnQoKSBzaG91bGQgYmUgZ2l2ZW4gbW9yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJr aXRkb3dubG9hZC5jcHAKaW5kZXggODcxZGIyYy4uZTY5OGVkNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwCkBAIC00MjEsMTQgKzQyMSwxMSBAQCBXZWJL aXREb3dubG9hZCogd2Via2l0X2Rvd25sb2FkX25ld193aXRoX2hhbmRsZShXZWJLaXROZXR3b3Jr UmVxdWVzdCogcmVxdWVzdCwgVwogewogICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKHJlcXVlc3Qs IE5VTEwpOwogCi0gICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCogZCA9IGhhbmRsZS0+Z2V0SW50 ZXJuYWwoKTsKLSAgICBpZiAoZC0+bV9zb3VwTWVzc2FnZSkKLSAgICAgICAgc291cF9zZXNzaW9u X3BhdXNlX21lc3NhZ2Uod2Via2l0X2dldF9kZWZhdWx0X3Nlc3Npb24oKSwgZC0+bV9zb3VwTWVz c2FnZS5nZXQoKSk7Ci0KICAgICBXZWJLaXREb3dubG9hZCogZG93bmxvYWQgPSBXRUJLSVRfRE9X TkxPQUQoZ19vYmplY3RfbmV3KFdFQktJVF9UWVBFX0RPV05MT0FELCAibmV0d29yay1yZXF1ZXN0 IiwgcmVxdWVzdCwgTlVMTCkpOwogICAgIFdlYktpdERvd25sb2FkUHJpdmF0ZSogcHJpdiA9IGRv d25sb2FkLT5wcml2OwogCiAgICAgaGFuZGxlLT5yZWYoKTsKKyAgICBoYW5kbGUtPnNldERlZmVy c0xvYWRpbmcodHJ1ZSk7CiAgICAgcHJpdi0+cmVzb3VyY2VIYW5kbGUgPSBoYW5kbGU7CiAKICAg ICB3ZWJraXRfZG93bmxvYWRfc2V0X3Jlc3BvbnNlKGRvd25sb2FkLCByZXNwb25zZSk7CkBAIC01 MTMsMTAgKzUxMCw3IEBAIHZvaWQgd2Via2l0X2Rvd25sb2FkX3N0YXJ0KFdlYktpdERvd25sb2Fk KiBkb3dubG9hZCkKICAgICAgICAgcHJpdi0+cmVzb3VyY2VIYW5kbGUgPSBSZXNvdXJjZUhhbmRs ZTo6Y3JlYXRlKC8qIE51bGwgTmV0d29ya2luZ0NvbnRleHQgKi8gTlVMTCwgY29yZShwcml2LT5u ZXR3b3JrUmVxdWVzdCksIHByaXYtPmRvd25sb2FkQ2xpZW50LCBmYWxzZSwgZmFsc2UpOwogICAg IGVsc2UgewogICAgICAgICBwcml2LT5yZXNvdXJjZUhhbmRsZS0+c2V0Q2xpZW50KHByaXYtPmRv d25sb2FkQ2xpZW50KTsKLQotICAgICAgICBSZXNvdXJjZUhhbmRsZUludGVybmFsKiBkID0gcHJp di0+cmVzb3VyY2VIYW5kbGUtPmdldEludGVybmFsKCk7Ci0gICAgICAgIGlmIChkLT5tX3NvdXBN ZXNzYWdlKQotICAgICAgICAgICAgc291cF9zZXNzaW9uX3VucGF1c2VfbWVzc2FnZSh3ZWJraXRf Z2V0X2RlZmF1bHRfc2Vzc2lvbigpLCBkLT5tX3NvdXBNZXNzYWdlLmdldCgpKTsKKyAgICAgICAg cHJpdi0+cmVzb3VyY2VIYW5kbGUtPnNldERlZmVyc0xvYWRpbmcoZmFsc2UpOwogICAgIH0KIAog ICAgIHByaXYtPnRpbWVyID0gZ190aW1lcl9uZXcoKTsKLS0gCjEuNy4xMAoK