85915 2012-05-08 14:18:48 -0700 Rename offsetTopLeft in RenderBoxModelObject to something better 2012-05-30 13:31:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shezbaig.wk shezbaig.wk darin eric jchaffraix webkit.review.bot oldest_to_newest 618795 0 shezbaig.wk 2012-05-08 14:18:48 -0700 (from bug 34875, comment 21) I'm open to suggestions 618877 1 darin 2012-05-08 15:36:50 -0700 Here’s the recipe for coming up with a good name: Write out a sentence or sentences describing what the function does or when it should be called. Then you can often select the name from the words in those sentences. 620599 2 141176 shezbaig.wk 2012-05-10 08:23:26 -0700 Created attachment 141176 Patch 637272 3 141176 jchaffraix 2012-05-30 08:42:14 -0700 Comment on attachment 141176 Patch Darin ping! This patch has been around for some time. The naming is fine by me, but I wasn't the one requesting this change. If there is no update, I am going to r+ it as a such a simple renaming shouldn't be waiting on reviewers. 637558 4 141176 darin 2012-05-30 12:47:46 -0700 Comment on attachment 141176 Patch Name is kinda long, but I think it’s an improvement. 637622 5 141176 webkit.review.bot 2012-05-30 13:31:07 -0700 Comment on attachment 141176 Patch Clearing flags on attachment: 141176 Committed r118961: <http://trac.webkit.org/changeset/118961> 637623 6 webkit.review.bot 2012-05-30 13:31:12 -0700 All reviewed patches have been landed. Closing bug. 141176 2012-05-10 08:23:26 -0700 2012-05-30 13:31:07 -0700 Patch bug-85915-20120510112427.patch text/plain 6050 shezbaig.wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIwNTFkNjQ1ZDdkOTYy MDQ4MmU4Njc2MmQxMmY0YzgxYmRiYTFiNC4uYTZhYTk2YWVjNTQ4YWIxYjNkNDNmYWY0YzAxMjQ2 ZTc1NzgwODIxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTA1LTEwICBTaGV6 YW4gQmFpZyAgPHNoZXpiYWlnLndrQGdtYWlsLmNvbT4KKworICAgICAgICBSZW5hbWUgb2Zmc2V0 VG9wTGVmdCBpbiBSZW5kZXJCb3hNb2RlbE9iamVjdCB0byBzb21ldGhpbmcgYmV0dGVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTkxNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZWQgb2Zmc2V0 VG9wTGVmdCBpbiBSZW5kZXJCb3hNb2RlbE9iamVjdCB0bworICAgICAgICBhZGp1c3RlZFBvc2l0 aW9uUmVsYXRpdmVUb09mZnNldFBhcmVudCwgYmVjYXVzZSBpdCByZXR1cm5zIHRoZSBnaXZlbgor ICAgICAgICBzdGFydFBvaW50IGFmdGVyIGFkanVzdGluZyBpdCB0byBiZSByZWxhdGl2ZSB0byB0 aGUgdG9wLWxlZnQgY29ybmVyIG9mCisgICAgICAgIHRoZSBvZmZzZXRQYXJlbnQuICBUaGUgZGVm aW5pdGlvbiBvZiBvZmZzZXRQYXJlbnQgaXRzZWxmIGlzIG5vbi10cml2aWFsCisgICAgICAgIGFu ZCBpcyBkb2N1bWVudGVkIHdpdGhpbiB0aGUgYm9keSBvZiBSZW5kZXJPYmplY3Q6Om9mZnNldFBh cmVudCwKKyAgICAgICAgdGhlcmVmb3JlIEkgZGVjaWRlZCB0byByZXVzZSB0aGlzIHRlcm0sIGFz LWlzLCBpbiB0aGUgbmFtZSBvZiB0aGlzCisgICAgICAgIGZ1bmN0aW9uLgorCisgICAgICAgIE5v IG5ldyB0ZXN0czsgbm8gZnVuY3Rpb25hbCBvciB2aXNpYmxlIGNoYW5nZXMuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6 b2Zmc2V0TGVmdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6Om9mZnNldFRvcCk6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckJveE1vZGVsT2JqZWN0OjphZGp1c3RlZFBvc2l0aW9uUmVsYXRpdmVUb09m ZnNldFBhcmVudCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6b2Zm c2V0TGVmdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6b2Zmc2V0 VG9wKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuaDoKKyAgICAg ICAgKFJlbmRlckJveE1vZGVsT2JqZWN0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW5s aW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlcklubGluZTo6b2Zmc2V0TGVmdCk6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJJbmxpbmU6Om9mZnNldFRvcCk6CisKIDIwMTItMDUtMTAg IEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAg W1F0XSBBdm9pZCBzdHJpbmcgY29udmVyc2lvbnMgdG8gY29uc3RydWN0IGEgUVVybCB3aGVuIHVz aW5nIFF0NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggMTk5ZGVi NmIyMzJlYWNiNjVmMDY0NGM4ZGU3YzZiMjBkN2ZmNDU2NC4uNGRhNTAyZjJjMmI0YjEyN2MwN2M5 M2QxMjcxZDcxMjZjYWVjOTFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5j cHAKQEAgLTM5MDksMTIgKzM5MDksMTIgQEAgTGF5b3V0UmVjdCBSZW5kZXJCb3g6OmxheW91dE92 ZXJmbG93UmVjdEZvclByb3BhZ2F0aW9uKFJlbmRlclN0eWxlKiBwYXJlbnRTdHlsZSkKIAogTGF5 b3V0VW5pdCBSZW5kZXJCb3g6Om9mZnNldExlZnQoKSBjb25zdAogewotICAgIHJldHVybiBvZmZz ZXRUb3BMZWZ0KHRvcExlZnRMb2NhdGlvbigpKS54KCk7CisgICAgcmV0dXJuIGFkanVzdGVkUG9z aXRpb25SZWxhdGl2ZVRvT2Zmc2V0UGFyZW50KHRvcExlZnRMb2NhdGlvbigpKS54KCk7CiB9CiAK IExheW91dFVuaXQgUmVuZGVyQm94OjpvZmZzZXRUb3AoKSBjb25zdAogewotICAgIHJldHVybiBv ZmZzZXRUb3BMZWZ0KHRvcExlZnRMb2NhdGlvbigpKS55KCk7CisgICAgcmV0dXJuIGFkanVzdGVk UG9zaXRpb25SZWxhdGl2ZVRvT2Zmc2V0UGFyZW50KHRvcExlZnRMb2NhdGlvbigpKS55KCk7CiB9 CiAKIExheW91dFBvaW50IFJlbmRlckJveDo6ZmxpcEZvcldyaXRpbmdNb2RlRm9yQ2hpbGQoY29u c3QgUmVuZGVyQm94KiBjaGlsZCwgY29uc3QgTGF5b3V0UG9pbnQmIHBvaW50KSBjb25zdApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKaW5k ZXggZmNjYTFiM2Q1MWI4ZjU1YjE5MjkzNmJkMTk3ZjQwMDA4MGJhNjM2OS4uNzgwY2MyYWQxMmI2 OWRkZjVmY2YwOWU3MTEyOGRjOGVhMDYxMGUwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCkBAIC01MjYsNyArNTI2LDcgQEAgTGF5 b3V0VW5pdCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6cmVsYXRpdmVQb3NpdGlvbk9mZnNldFkoKSBj b25zdAogICAgIHJldHVybiBvZmZzZXQ7CiB9CiAKLUxheW91dFBvaW50IFJlbmRlckJveE1vZGVs T2JqZWN0OjpvZmZzZXRUb3BMZWZ0KGNvbnN0IExheW91dFBvaW50JiBzdGFydFBvaW50KSBjb25z dAorTGF5b3V0UG9pbnQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmFkanVzdGVkUG9zaXRpb25SZWxh dGl2ZVRvT2Zmc2V0UGFyZW50KGNvbnN0IExheW91dFBvaW50JiBzdGFydFBvaW50KSBjb25zdAog ewogICAgIC8vIElmIHRoZSBlbGVtZW50IGlzIHRoZSBIVE1MIGJvZHkgZWxlbWVudCBvciBkb2Vz IG5vdCBoYXZlIGFuIGFzc29jaWF0ZWQgYm94CiAgICAgLy8gcmV0dXJuIDAgYW5kIHN0b3AgdGhp cyBhbGdvcml0aG0uCkBAIC01NjQsMTUgKzU2NCwxNSBAQCBMYXlvdXRQb2ludCBSZW5kZXJCb3hN b2RlbE9iamVjdDo6b2Zmc2V0VG9wTGVmdChjb25zdCBMYXlvdXRQb2ludCYgc3RhcnRQb2ludCkg YwogTGF5b3V0VW5pdCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6b2Zmc2V0TGVmdCgpIGNvbnN0CiB7 CiAgICAgLy8gTm90ZSB0aGF0IFJlbmRlcklubGluZSBhbmQgUmVuZGVyQm94IG92ZXJyaWRlIHRo aXMgdG8gcGFzcyBhIGRpZmZlcmVudAotICAgIC8vIHN0YXJ0UG9pbnQgdG8gb2Zmc2V0VG9wTGVm dC4KLSAgICByZXR1cm4gb2Zmc2V0VG9wTGVmdChMYXlvdXRQb2ludCgpKS54KCk7CisgICAgLy8g c3RhcnRQb2ludCB0byBhZGp1c3RlZFBvc2l0aW9uUmVsYXRpdmVUb09mZnNldFBhcmVudC4KKyAg ICByZXR1cm4gYWRqdXN0ZWRQb3NpdGlvblJlbGF0aXZlVG9PZmZzZXRQYXJlbnQoTGF5b3V0UG9p bnQoKSkueCgpOwogfQogCiBMYXlvdXRVbml0IFJlbmRlckJveE1vZGVsT2JqZWN0OjpvZmZzZXRU b3AoKSBjb25zdAogewogICAgIC8vIE5vdGUgdGhhdCBSZW5kZXJJbmxpbmUgYW5kIFJlbmRlckJv eCBvdmVycmlkZSB0aGlzIHRvIHBhc3MgYSBkaWZmZXJlbnQKLSAgICAvLyBzdGFydFBvaW50IHRv IG9mZnNldFRvcExlZnQuCi0gICAgcmV0dXJuIG9mZnNldFRvcExlZnQoTGF5b3V0UG9pbnQoKSku eSgpOworICAgIC8vIHN0YXJ0UG9pbnQgdG8gYWRqdXN0ZWRQb3NpdGlvblJlbGF0aXZlVG9PZmZz ZXRQYXJlbnQuCisgICAgcmV0dXJuIGFkanVzdGVkUG9zaXRpb25SZWxhdGl2ZVRvT2Zmc2V0UGFy ZW50KExheW91dFBvaW50KCkpLnkoKTsKIH0KIAogaW50IFJlbmRlckJveE1vZGVsT2JqZWN0Ojpw aXhlbFNuYXBwZWRPZmZzZXRXaWR0aCgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCmluZGV4IDZjODhmMGZiZmUzYWQ5NDUwNzVhMzE1 MmFjZTQ0ZDI1MjA4NTkzMjkuLmZlYWY3NTE1Y2ZmMGQ4OGI5OTVhMzg2MjZkMGJlMDk2YzcyMGNj YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9i amVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVj dC5oCkBAIC0yMjcsNyArMjI3LDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBJbnRTaXplIG1fdGls ZVNpemU7CiAgICAgfTsKIAotICAgIExheW91dFBvaW50IG9mZnNldFRvcExlZnQoY29uc3QgTGF5 b3V0UG9pbnQmKSBjb25zdDsKKyAgICBMYXlvdXRQb2ludCBhZGp1c3RlZFBvc2l0aW9uUmVsYXRp dmVUb09mZnNldFBhcmVudChjb25zdCBMYXlvdXRQb2ludCYpIGNvbnN0OwogCiAgICAgdm9pZCBj YWxjdWxhdGVCYWNrZ3JvdW5kSW1hZ2VHZW9tZXRyeShjb25zdCBGaWxsTGF5ZXIqLCBjb25zdCBM YXlvdXRSZWN0JiBwYWludFJlY3QsIEJhY2tncm91bmRJbWFnZUdlb21ldHJ5Jik7CiAgICAgdm9p ZCBnZXRCb3JkZXJFZGdlSW5mbyhjbGFzcyBCb3JkZXJFZGdlW10sIGNvbnN0IFJlbmRlclN0eWxl KiwgYm9vbCBpbmNsdWRlTG9naWNhbExlZnRFZGdlID0gdHJ1ZSwgYm9vbCBpbmNsdWRlTG9naWNh bFJpZ2h0RWRnZSA9IHRydWUpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlcklubGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy SW5saW5lLmNwcAppbmRleCA1YzkzMzYxMDRhNzRkZTAwZTJkYjhkYzBlOTkyZjgyYzA1NTIyM2M0 Li5hNmZkYzllZjFmMmFkYTgzZThiOTY3MjNkODk2ZWUzMzRhNTNlMzk4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcApAQCAtNjgxLDcgKzY4MSw3IEBAIExheW91 dFVuaXQgUmVuZGVySW5saW5lOjpvZmZzZXRMZWZ0KCkgY29uc3QKICAgICBMYXlvdXRQb2ludCB0 b3BMZWZ0OwogICAgIGlmIChJbmxpbmVCb3gqIGZpcnN0Qm94ID0gZmlyc3RMaW5lQm94SW5jbHVk aW5nQ3VsbGluZygpKQogICAgICAgICB0b3BMZWZ0ID0gZmxvb3JlZExheW91dFBvaW50KGZpcnN0 Qm94LT50b3BMZWZ0KCkpOwotICAgIHJldHVybiBvZmZzZXRUb3BMZWZ0KHRvcExlZnQpLngoKTsK KyAgICByZXR1cm4gYWRqdXN0ZWRQb3NpdGlvblJlbGF0aXZlVG9PZmZzZXRQYXJlbnQodG9wTGVm dCkueCgpOwogfQogCiBMYXlvdXRVbml0IFJlbmRlcklubGluZTo6b2Zmc2V0VG9wKCkgY29uc3QK QEAgLTY4OSw3ICs2ODksNyBAQCBMYXlvdXRVbml0IFJlbmRlcklubGluZTo6b2Zmc2V0VG9wKCkg Y29uc3QKICAgICBMYXlvdXRQb2ludCB0b3BMZWZ0OwogICAgIGlmIChJbmxpbmVCb3gqIGZpcnN0 Qm94ID0gZmlyc3RMaW5lQm94SW5jbHVkaW5nQ3VsbGluZygpKQogICAgICAgICB0b3BMZWZ0ID0g Zmxvb3JlZExheW91dFBvaW50KGZpcnN0Qm94LT50b3BMZWZ0KCkpOwotICAgIHJldHVybiBvZmZz ZXRUb3BMZWZ0KHRvcExlZnQpLnkoKTsKKyAgICByZXR1cm4gYWRqdXN0ZWRQb3NpdGlvblJlbGF0 aXZlVG9PZmZzZXRQYXJlbnQodG9wTGVmdCkueSgpOwogfQogCiBzdGF0aWMgTGF5b3V0VW5pdCBj b21wdXRlTWFyZ2luKGNvbnN0IFJlbmRlcklubGluZSogcmVuZGVyZXIsIGNvbnN0IExlbmd0aCYg bWFyZ2luKQo=