85906 2012-05-08 12:15:55 -0700 [Qt][WK2] Remove delayed loadDidSucceed() signaling and m_deferedUrlToLoad from QQuickWebViewPrivate 2012-05-09 01:41:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan abecsi hausmann menard vestbo webkit.review.bot zoltan oldest_to_newest 618704 0 zalan 2012-05-08 12:15:55 -0700 No need to delay loading related activities, after http://trac.webkit.org/changeset/113172 , when WebView started being inherited from Flickable. copied the discussion from here https://bugs.webkit.org/show_bug.cgi?id=84527#c3 "> (case 3, loadDidSucceed() implements some deferred loading success dispatching due to the delayed interaction engine construction. I looked at the original patch (bug 77111) and don't see any reasoning why success() is special in that case, and for example failed() is not. Commit log also states that page is suspended while I don't think it is, it's just that the suspend flag is turned on by default, so not sure why success() is treated differently here, unless I miss something, which could very well be the case. If this delaying logic could be omitted, we would end up even less d_func() calls in QtWebPageLoadClient(), provided that's the preferred direction.) This delay was needed before the WebView became a subclass of Flickable because the instantiation of the internal Flickable happened in onComponentComplete and we needed to defer the emission of the success signal after the construction finished to prevent crashes in API tests, since almost all the unit tests depend on loadSuccess. This delay can be omitted since WebView is a direct subclass of Flickable now." 618715 1 140766 zalan 2012-05-08 12:31:12 -0700 Created attachment 140766 Patch 619269 2 140766 webkit.review.bot 2012-05-09 01:41:30 -0700 Comment on attachment 140766 Patch Clearing flags on attachment: 140766 Committed r116505: <http://trac.webkit.org/changeset/116505> 619270 3 webkit.review.bot 2012-05-09 01:41:35 -0700 All reviewed patches have been landed. Closing bug. 140766 2012-05-08 12:31:12 -0700 2012-05-09 01:41:29 -0700 Patch bug-85906-20120508213110.patch text/plain 5071 zalan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjQ0NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA1LTA4ICBaYWxhbiBC dWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gUmVtb3ZlIGRl bGF5ZWQgbG9hZERpZFN1Y2NlZWQoKSBzaWduYWxpbmcgYW5kIG1fZGVmZXJlZFVybFRvTG9hZCBm cm9tIFFRdWlja1dlYlZpZXdQcml2YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NTkwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERlZmVycmVkIGxvYWRpbmcgYWN0aXZpZXMgd2VyZSBpbnRyb2R1Y2Vk IHRvIHdvcmsgYXJvdW5kIHRoZSBkZWxheWVkIEZsaWNrYWJsZSBjb25zdHJ1Y3Rpb24KKyAgICAg ICAgYXQgb25Db21wb25lbnRDb21wbGV0ZSgpLiBRUXVpY2tXZWJWaWV3IGluaGVyaXRzIGZyb20g UVF1aWNrRmxpY2thYmxlIG5vdywKKyAgICAgICAgc28gbm8gbmVlZCBmb3IgdGhlIHdvcmthcm91 bmQgYW55bW9yZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5j cHA6CisgICAgICAgIChRUXVpY2tXZWJWaWV3RmxpY2thYmxlUHJpdmF0ZTo6UVF1aWNrV2ViVmll d0ZsaWNrYWJsZVByaXZhdGUpOgorICAgICAgICAoUVF1aWNrV2ViVmlld0ZsaWNrYWJsZVByaXZh dGU6Om9uQ29tcG9uZW50Q29tcGxldGUpOgorICAgICAgICAoUVF1aWNrV2ViVmlldzo6c2V0VXJs KToKKyAgICAgICAgKFFRdWlja1dlYlZpZXc6OmNvbXBvbmVudENvbXBsZXRlKToKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmg6CisgICAgICAgIChRUXVpY2tX ZWJWaWV3UHJpdmF0ZTo6b25Db21wb25lbnRDb21wbGV0ZSk6CisgICAgICAgIChRUXVpY2tXZWJW aWV3UHJpdmF0ZSk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3RmxpY2thYmxlUHJpdmF0ZSk6CisK IDIwMTItMDUtMDggIEplc3VzIFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVu Ym9zc2Eub3JnPgogCiAgICAgICAgIFtXSzJdIEludGVncmF0ZSBQYWdlIFZpc2liaWxpdHkgc3Rh dGUgY2hhbmdlIGFuZCBXSzIgU3VzcGVuZC9SZXN1bWUgQVBJCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAJKHJldmlzaW9uIDEx NjQzNCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTM0MSwxNCArMzQxLDYgQEAgdm9pZCBRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6bG9hZERpZFN1Y2NlZQogICAgIGVtaXQgcS0+bG9hZGluZ0NoYW5nZWQoJmxvYWRS ZXF1ZXN0KTsKIH0KIAotdm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6b25Db21wb25lbnRDb21w bGV0ZSgpCi17Ci0gICAgaWYgKG1fZGVmZXJlZFVybFRvTG9hZC5pc0VtcHR5KCkpCi0gICAgICAg IHJldHVybjsKLQotICAgIHFfcHRyLT5zZXRVcmwobV9kZWZlcmVkVXJsVG9Mb2FkKTsKLX0KLQog dm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6c2V0TmVlZHNEaXNwbGF5KCkKIHsKICAgICBRX1Eo UVF1aWNrV2ViVmlldyk7CkBAIC03MjksNyArNzIxLDYgQEAgdm9pZCBRUXVpY2tXZWJWaWV3TGVn YWN5UHJpdmF0ZTo6c2V0Wm9vbQogUVF1aWNrV2ViVmlld0ZsaWNrYWJsZVByaXZhdGU6OlFRdWlj a1dlYlZpZXdGbGlja2FibGVQcml2YXRlKFFRdWlja1dlYlZpZXcqIHZpZXdwb3J0KQogICAgIDog UVF1aWNrV2ViVmlld1ByaXZhdGUodmlld3BvcnQpCiAgICAgLCBwYWdlSXNTdXNwZW5kZWQodHJ1 ZSkKLSAgICAsIGxvYWRTdWNjZXNzRGlzcGF0Y2hJc1BlbmRpbmcoZmFsc2UpCiB7CiAgICAgLy8g RGlzYWJsZSBtb3VzZSBldmVudHMgb24gdGhlIGZsaWNrYWJsZSB3ZWIgdmlldyBzbyB3ZSBkbyBu b3QKICAgICAvLyBzZWxlY3QgdGV4dCBkdXJpbmcgcGFuIGdlc3R1cmVzIG9uIHBsYXRmb3JtcyB3 aGljaCBzZW5kIGJvdGgKQEAgLTc5MiwyMyArNzgzLDggQEAgdm9pZCBRUXVpY2tXZWJWaWV3Rmxp Y2thYmxlUHJpdmF0ZTo6b25DbwogCiAgICAgX3FfcmVzdW1lKCk7CiAKLSAgICBpZiAobG9hZFN1 Y2Nlc3NEaXNwYXRjaElzUGVuZGluZykgewotICAgICAgICBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6 bG9hZERpZFN1Y2NlZWQoKTsKLSAgICAgICAgbG9hZFN1Y2Nlc3NEaXNwYXRjaElzUGVuZGluZyA9 IGZhbHNlOwotICAgIH0KLQogICAgIC8vIFRyaWdnZXIgc2V0dGluZyBvZiBjb3JyZWN0IHZpc2li aWxpdHkgZmxhZ3MgYWZ0ZXIgZXZlcnl0aGluZyB3YXMgYWxsb2NhdGVkIGFuZCBpbml0aWFsaXpl ZC4KICAgICBfcV9vblZpc2libGVDaGFuZ2VkKCk7Ci0KLSAgICBRUXVpY2tXZWJWaWV3UHJpdmF0 ZTo6b25Db21wb25lbnRDb21wbGV0ZSgpOwotfQotCi12b2lkIFFRdWlja1dlYlZpZXdGbGlja2Fi bGVQcml2YXRlOjpsb2FkRGlkU3VjY2VlZCgpCi17Ci0gICAgaWYgKGludGVyYWN0aW9uRW5naW5l KQotICAgICAgICBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6bG9hZERpZFN1Y2NlZWQoKTsKLSAgICBl bHNlCi0gICAgICAgIGxvYWRTdWNjZXNzRGlzcGF0Y2hJc1BlbmRpbmcgPSB0cnVlOwogfQogCiB2 b2lkIFFRdWlja1dlYlZpZXdGbGlja2FibGVQcml2YXRlOjpsb2FkRGlkQ29tbWl0KCkKQEAgLTE0 NTcsMTEgKzE0MzMsNiBAQCB2b2lkIFFRdWlja1dlYlZpZXc6OnNldFVybChjb25zdCBRVXJsJiB1 CiAgICAgaWYgKHVybC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICghaXND b21wb25lbnRDb21wbGV0ZSgpKSB7Ci0gICAgICAgIGQtPm1fZGVmZXJlZFVybFRvTG9hZCA9IHVy bDsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIGQtPndlYlBhZ2VQcm94eS0+bG9hZFVS TCh1cmwudG9TdHJpbmcoKSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgJKHJldmlzaW9uIDExNjQzNCkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaAkod29y a2luZyBjb3B5KQpAQCAtNjcsNiArNjcsOCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQg aW5pdGlhbGl6ZShXS0NvbnRleHRSZWYgY29udGV4dFJlZiA9IDAsIFdLUGFnZUdyb3VwUmVmIHBh Z2VHcm91cFJlZiA9IDApOwogCisgICAgdmlydHVhbCB2b2lkIG9uQ29tcG9uZW50Q29tcGxldGUo KSB7IH0KKwogICAgIHZpcnR1YWwgdm9pZCBlbmFibGVNb3VzZUV2ZW50cygpIHsgfQogICAgIHZp cnR1YWwgdm9pZCBkaXNhYmxlTW91c2VFdmVudHMoKSB7IH0KIApAQCAtNzQsNyArNzYsNiBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUNvbnRlbnRzU2l6ZShjb25zdCBRU2l6ZUYm KSB7IH0KIAogICAgIHZpcnR1YWwgdm9pZCBsb2FkRGlkU3VjY2VlZCgpOwotICAgIHZpcnR1YWwg dm9pZCBvbkNvbXBvbmVudENvbXBsZXRlKCk7CiAgICAgdmlydHVhbCB2b2lkIGxvYWREaWRDb21t aXQoKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGlkRmluaXNoRmlyc3ROb25FbXB0eUxheW91dCgp IHsgfQogICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VWaWV3cG9ydFByb3BlcnRpZXMoY29uc3Qg V2ViQ29yZTo6Vmlld3BvcnRBdHRyaWJ1dGVzJiBhdHRyKSB7IH0KQEAgLTE5Miw3ICsxOTMsNiBA QCBwcm90ZWN0ZWQ6CiAgICAgYm9vbCBtX3JlbmRlclRvT2Zmc2NyZWVuQnVmZmVyOwogICAgIGJv b2wgbV9kaWFsb2dBY3RpdmU7CiAgICAgUVVybCBtX2ljb25VUkw7Ci0gICAgUVVybCBtX2RlZmVy ZWRVcmxUb0xvYWQ7CiB9OwogCiBjbGFzcyBRUXVpY2tXZWJWaWV3TGVnYWN5UHJpdmF0ZSA6IHB1 YmxpYyBRUXVpY2tXZWJWaWV3UHJpdmF0ZSB7CkBAIC0yMTYsMTEgKzIxNiwxMSBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB+UVF1aWNrV2ViVmlld0ZsaWNrYWJsZVByaXZhdGUoKTsKICAgICB2aXJ0 dWFsIHZvaWQgaW5pdGlhbGl6ZShXS0NvbnRleHRSZWYgY29udGV4dFJlZiA9IDAsIFdLUGFnZUdy b3VwUmVmIHBhZ2VHcm91cFJlZiA9IDApOwogCisgICAgdmlydHVhbCB2b2lkIG9uQ29tcG9uZW50 Q29tcGxldGUoKTsKKwogICAgIHZpcnR1YWwgUVBvaW50RiBwYWdlSXRlbVBvcygpOwogICAgIHZp cnR1YWwgdm9pZCB1cGRhdGVDb250ZW50c1NpemUoY29uc3QgUVNpemVGJik7CiAKLSAgICB2aXJ0 dWFsIHZvaWQgbG9hZERpZFN1Y2NlZWQoKTsKLSAgICB2aXJ0dWFsIHZvaWQgb25Db21wb25lbnRD b21wbGV0ZSgpOwogICAgIHZpcnR1YWwgdm9pZCBsb2FkRGlkQ29tbWl0KCk7CiAgICAgdmlydHVh bCB2b2lkIGRpZEZpbmlzaEZpcnN0Tm9uRW1wdHlMYXlvdXQoKTsKICAgICB2aXJ0dWFsIHZvaWQg ZGlkQ2hhbmdlVmlld3BvcnRQcm9wZXJ0aWVzKGNvbnN0IFdlYkNvcmU6OlZpZXdwb3J0QXR0cmli dXRlcyYpOwpAQCAtMjM3LDcgKzIzNyw2IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgUVNjb3Bl ZFBvaW50ZXI8V2ViS2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU+IGludGVyYWN0aW9u RW5naW5lOwogICAgIGJvb2wgcGFnZUlzU3VzcGVuZGVkOwotICAgIGJvb2wgbG9hZFN1Y2Nlc3NE aXNwYXRjaElzUGVuZGluZzsKIH07CiAKICNlbmRpZiAvLyBxcXVpY2t3ZWJ2aWV3X3BfcF9oCg==