85904 2012-05-08 12:08:22 -0700 REGRESSION(r116440): Broke the Chromium Android bot (Requested by beverloo on #webkit). 2012-05-08 12:25:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85897 1 webkit.review.bot webkit.review.bot abarth peter tony oldest_to_newest 618690 0 webkit.review.bot 2012-05-08 12:08:22 -0700 http://trac.webkit.org/changeset/116440 broke the build: Broke the Chromium Android bot (Requested by beverloo on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 618692 1 140760 webkit.review.bot 2012-05-08 12:09:00 -0700 Created attachment 140760 ROLLOUT of r116440 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 618697 2 peter 2012-05-08 12:12:17 -0700 This has a whole dependency chain of unupstreamed code; changes to ICU are necessary, but these are in a separate repository and then break the build with other errors. This will require some more investigation as to what exactly is necessary to get this working. Previously ICU wasn't build for host, as ImageDiff didn't depend on it. Since this is a Chromium-only binary it may be an option to remove the dependency on WTF altogether; usage seems to be limited. I can take on 85897 early next week. Setting CQ+. 618712 3 140760 webkit.review.bot 2012-05-08 12:25:52 -0700 Comment on attachment 140760 ROLLOUT of r116440 Clearing flags on attachment: 140760 Committed r116448: <http://trac.webkit.org/changeset/116448> 618713 4 webkit.review.bot 2012-05-08 12:25:57 -0700 All reviewed patches have been landed. Closing bug. 140760 2012-05-08 12:09:00 -0700 2012-05-08 12:25:52 -0700 ROLLOUT of r116440 bug-85904-20120508191252.patch text/plain 1728 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ0NDk0NTgxNDdkZWNkODQ2NjkyZmJl M2Y5ZDg2NDBlMDlhZGM2OWMuLmM5ODZhODFhMjliNmYzYTQ0YjgzODRkNTljODc3Mjk1OTdlNDI0 YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDUtMDggIFNoZXJpZmYgQm90ICA8d2Via2l0 LnJldmlldy5ib3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHIxMTY0NDAuCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzExNjQ0 MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU5MDQK KworICAgICAgICBCcm9rZSB0aGUgQ2hyb21pdW0gQW5kcm9pZCBib3QgKFJlcXVlc3RlZCBieSBi ZXZlcmxvbyBvbgorICAgICAgICAjd2Via2l0KS4KKworICAgICAgICAqIFdURi5neXAvV1RGLmd5 cDoKKwogMjAxMi0wNS0wOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFtDaHJvbWl1bV0gT1MoQU5EUk9JRCkgSW1hZ2VEaWZmIHJlcXVpcmVzIHVzIHRvIGJ1aWxk IFdURiBmb3IgYm90aCBob3N0IGFuZCB0YXJnZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvV1RG Lmd5cC9XVEYuZ3lwIGIvU291cmNlL1dURi9XVEYuZ3lwL1dURi5neXAKaW5kZXggYTE3MDViYWI0 MTA3ZWIyOTljMGI1MWE3YmY1OTM3OTRmNmFiNzM1MS4uNjc2N2RmNjU3ZjNlNzRhNGQyNDU1NTE1 ZDE1MTgwYjU2Y2I5ODY3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9XVEYuZ3lwL1dURi5neXAK KysrIGIvU291cmNlL1dURi9XVEYuZ3lwL1dURi5neXAKQEAgLTkzLDE0ICs5Myw3IEBACiAgICAg ICAgICAgICBdLAogICAgICAgICAgIH1dLAogICAgICAgICBdLAotICAgICAgfSwKLSAgICAgICdj b25kaXRpb25zJzogWwotICAgICAgICBbJ09TPT0iYW5kcm9pZCIgYW5kIGFuZHJvaWRfYnVpbGRf dHlwZT09MCcsIHsKLSAgICAgICAgICAjIEFuZHJvaWQgYnVpbGRzIEltYWdlRGlmZiBmb3IgaG9z dCwgd2hpY2ggaGFzIGEgZGVwZW5kZW5jeSBvbiB3dGYuCi0gICAgICAgICAgIyBUaGF0IG1lYW5z IHdlIG5lZWQgdG8gYnVpbGQgdGhpcyB0YXJnZXQgZm9yIGJvdGggaG9zdCBhbmQgdGFyZ2V0Lgot ICAgICAgICAgICd0b29sc2V0cyc6IFsnaG9zdCcsICd0YXJnZXQnXSwKLSAgICAgICAgfV0sCi0g ICAgICBdCisgICAgICB9CiAgICAgfSwKICAgICB7CiAgICAgICAndGFyZ2V0X25hbWUnOiAnd3Rm JywKQEAgLTE4OSwxMSArMTgyLDYgQEAKICAgICAgICAgICAgIH1dLAogICAgICAgICAgIF0sCiAg ICAgICAgIH1dLAotICAgICAgICBbJ09TPT0iYW5kcm9pZCIgYW5kIGFuZHJvaWRfYnVpbGRfdHlw ZT09MCcsIHsKLSAgICAgICAgICAjIEFuZHJvaWQgYnVpbGRzIEltYWdlRGlmZiBmb3IgaG9zdCwg d2hpY2ggaGFzIGEgZGVwZW5kZW5jeSBvbiB3dGYuCi0gICAgICAgICAgIyBUaGF0IG1lYW5zIHdl IG5lZWQgdG8gYnVpbGQgdGhpcyB0YXJnZXQgZm9yIGJvdGggaG9zdCBhbmQgdGFyZ2V0LgotICAg ICAgICAgICd0b29sc2V0cyc6IFsnaG9zdCcsICd0YXJnZXQnXSwKLSAgICAgICAgfV0sCiAgICAg ICBdLAogICAgIH0sCiAgIF0K